@@ -63,7 +63,7 @@ discard block |
||
63 | 63 | // @codeCoverageIgnoreStart |
64 | 64 | if (!function_exists('phpbb_get_user_avatar')) |
65 | 65 | { |
66 | - include($phpbb_root_path . 'includes/functions_display.' . $php_ext); |
|
66 | + include($phpbb_root_path.'includes/functions_display.'.$php_ext); |
|
67 | 67 | } |
68 | 68 | // @codeCoverageIgnoreEnd |
69 | 69 | } |
@@ -101,8 +101,8 @@ discard block |
||
101 | 101 | */ |
102 | 102 | protected function member_posts(array $row) |
103 | 103 | { |
104 | - $u_posts = append_sid($this->phpbb_root_path . 'search.' . $this->php_ext, "author_id={$row['user_id']}&sr=posts" . $this->explain_range); |
|
105 | - $user_posts = '<a href="' . $u_posts . '">' . $row['user_posts'] . '</a>'; |
|
104 | + $u_posts = append_sid($this->phpbb_root_path.'search.'.$this->php_ext, "author_id={$row['user_id']}&sr=posts".$this->explain_range); |
|
105 | + $user_posts = '<a href="'.$u_posts.'">'.$row['user_posts'].'</a>'; |
|
106 | 106 | |
107 | 107 | return array( |
108 | 108 | 'USERNAME' => get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']), |
@@ -170,7 +170,7 @@ discard block |
||
170 | 170 | 'WHERE' => $this->db->sql_in_set('u.user_type', array(USER_NORMAL, USER_FOUNDER)), |
171 | 171 | ); |
172 | 172 | |
173 | - $sql_method = 'set_' . $this->settings['query_type'] . '_sql'; |
|
173 | + $sql_method = 'set_'.$this->settings['query_type'].'_sql'; |
|
174 | 174 | call_user_func_array(array($this, $sql_method), array(&$sql_ary)); |
175 | 175 | |
176 | 176 | $this->set_range_sql($sql_ary); |
@@ -184,7 +184,7 @@ discard block |
||
184 | 184 | protected function set_visits_sql(array &$sql_ary) |
185 | 185 | { |
186 | 186 | $sql_ary['SELECT'] .= ', u.user_lastvisit as member_date'; |
187 | - $sql_ary['WHERE'] .= ' AND u.user_lastvisit <> 0 AND u.user_id <> ' . (int) $this->user->data['user_id']; |
|
187 | + $sql_ary['WHERE'] .= ' AND u.user_lastvisit <> 0 AND u.user_id <> '.(int) $this->user->data['user_id']; |
|
188 | 188 | $sql_ary['ORDER_BY'] = 'u.user_lastvisit DESC'; |
189 | 189 | |
190 | 190 | $this->sql_date_field = 'user_lastvisit'; |
@@ -200,7 +200,7 @@ discard block |
||
200 | 200 | $this->info_header = ''; |
201 | 201 | $this->view_mode = 'member_bots'; |
202 | 202 | |
203 | - $sql_ary['WHERE'] = 'u.user_type = ' . USER_IGNORE; |
|
203 | + $sql_ary['WHERE'] = 'u.user_type = '.USER_IGNORE; |
|
204 | 204 | } |
205 | 205 | |
206 | 206 | /** |
@@ -209,7 +209,7 @@ discard block |
||
209 | 209 | protected function set_tenured_sql(array &$sql_ary) |
210 | 210 | { |
211 | 211 | $sql_ary['SELECT'] .= ', u.user_regdate as member_date'; |
212 | - $sql_ary['ORDER_BY'] = 'u.user_regdate ' . (($this->settings['query_type'] == 'tenured') ? 'ASC' : 'DESC'); |
|
212 | + $sql_ary['ORDER_BY'] = 'u.user_regdate '.(($this->settings['query_type'] == 'tenured') ? 'ASC' : 'DESC'); |
|
213 | 213 | |
214 | 214 | $this->sql_date_field = 'u.user_regdate'; |
215 | 215 | $this->settings['date_range'] = ''; |
@@ -232,7 +232,7 @@ discard block |
||
232 | 232 | $sql_ary['SELECT'] .= ', COUNT(p.post_id) as user_posts'; |
233 | 233 | $sql_ary['FROM'] += array(TOPICS_TABLE => 't'); |
234 | 234 | $sql_ary['FROM'] += array(POSTS_TABLE => 'p'); |
235 | - $sql_ary['WHERE'] .= ' AND ' . time() . ' > t.topic_time AND t.topic_id = p.topic_id AND p.post_visibility = ' . ITEM_APPROVED . ' AND p.poster_id = u.user_id'; |
|
235 | + $sql_ary['WHERE'] .= ' AND '.time().' > t.topic_time AND t.topic_id = p.topic_id AND p.post_visibility = '.ITEM_APPROVED.' AND p.poster_id = u.user_id'; |
|
236 | 236 | $sql_ary['GROUP_BY'] = 'u.user_id'; |
237 | 237 | $sql_ary['ORDER_BY'] = 'user_posts DESC, u.username ASC'; |
238 | 238 | |
@@ -249,7 +249,7 @@ discard block |
||
249 | 249 | if ($this->settings['date_range'] && $this->sql_date_field) |
250 | 250 | { |
251 | 251 | $range = $this->date_range->get($this->settings['date_range']); |
252 | - $this->explain_range = '&date=' . $range['date']; |
|
252 | + $this->explain_range = '&date='.$range['date']; |
|
253 | 253 | |
254 | 254 | $sql_ary['WHERE'] .= " AND {$this->sql_date_field} BETWEEN {$range['start']} AND {$range['stop']}"; |
255 | 255 | } |
@@ -144,8 +144,7 @@ |
||
144 | 144 | { |
145 | 145 | $content = $this->translator->lang('BLOCK_NO_DATA'); |
146 | 146 | $returned_data['status'] = 0; |
147 | - } |
|
148 | - else |
|
147 | + } else |
|
149 | 148 | { |
150 | 149 | $content = $returned_data['content']; |
151 | 150 | } |
@@ -118,8 +118,7 @@ |
||
118 | 118 | if (!$has_blocks && !$this->route_is_customized($entity->to_array())) |
119 | 119 | { |
120 | 120 | $this->route_mapper->delete($entity); |
121 | - } |
|
122 | - else |
|
121 | + } else |
|
123 | 122 | { |
124 | 123 | $entity->set_has_blocks($has_blocks); |
125 | 124 | $this->route_mapper->save($entity); |
@@ -154,8 +154,7 @@ |
||
154 | 154 | if (!empty($returned_data['content'])) |
155 | 155 | { |
156 | 156 | $content = $returned_data['content']; |
157 | - } |
|
158 | - else if ($edit_mode) |
|
157 | + } else if ($edit_mode) |
|
159 | 158 | { |
160 | 159 | $returned_data['status'] = 0; |
161 | 160 | $content = $this->translator->lang('BLOCK_NO_DATA'); |
@@ -96,13 +96,13 @@ discard block |
||
96 | 96 | public function set_javascript_data($route, $style_id) |
97 | 97 | { |
98 | 98 | $board_url = generate_board_url(); |
99 | - $ajax_url = $board_url . ((!$this->config['enable_mod_rewrite']) ? '/app.' . $this->php_ext : ''); |
|
99 | + $ajax_url = $board_url.((!$this->config['enable_mod_rewrite']) ? '/app.'.$this->php_ext : ''); |
|
100 | 100 | |
101 | 101 | $is_default_route = $u_default_route = false; |
102 | 102 | if ($this->config['sitemaker_default_layout']) |
103 | 103 | { |
104 | 104 | $is_default_route = ($this->config['sitemaker_default_layout'] === $route) ? true : false; |
105 | - $u_default_route .= $board_url . '/' . $this->config['sitemaker_default_layout']; |
|
105 | + $u_default_route .= $board_url.'/'.$this->config['sitemaker_default_layout']; |
|
106 | 106 | $u_default_route = reapply_sid($u_default_route); |
107 | 107 | } |
108 | 108 | |
@@ -150,7 +150,7 @@ discard block |
||
150 | 150 | list($controller_service, $controller_method) = explode(':', $controller); |
151 | 151 | $controller_params = $symfony_request->attributes->get('_route_params'); |
152 | 152 | $controller_object = $this->phpbb_container->get($controller_service); |
153 | - $controller_class = get_class($controller_object); |
|
153 | + $controller_class = get_class($controller_object); |
|
154 | 154 | |
155 | 155 | $r = new \ReflectionMethod($controller_class, $controller_method); |
156 | 156 | $class_params = $r->getParameters(); |
@@ -163,7 +163,7 @@ discard block |
||
163 | 163 | 'CONTROLLER_METHOD' => $controller_method, |
164 | 164 | 'CONTROLLER_PARAMS' => $controller_arguments, |
165 | 165 | 'S_IS_STARTPAGE' => $this->is_startpage($controller_service, $controller_arguments), |
166 | - 'UA_EXTENSION' => $namespace . '/' . $extension, |
|
166 | + 'UA_EXTENSION' => $namespace.'/'.$extension, |
|
167 | 167 | )); |
168 | 168 | } |
169 | 169 | } |
@@ -198,11 +198,11 @@ discard block |
||
198 | 198 | { |
199 | 199 | $routes_ary = $this->get_routes(); |
200 | 200 | |
201 | - $options = '<option value="">' . $this->translator->lang('SELECT') . '</option>'; |
|
201 | + $options = '<option value="">'.$this->translator->lang('SELECT').'</option>'; |
|
202 | 202 | foreach ($routes_ary as $route) |
203 | 203 | { |
204 | 204 | $selected = ($route == $current_route) ? ' selected="selected"' : ''; |
205 | - $options .= '<option value="' . $route . '"' . $selected . '>' . $route . '</option>'; |
|
205 | + $options .= '<option value="'.$route.'"'.$selected.'>'.$route.'</option>'; |
|
206 | 206 | } |
207 | 207 | |
208 | 208 | return $options; |
@@ -219,7 +219,7 @@ discard block |
||
219 | 219 | $options = ''; |
220 | 220 | foreach ($ex_positions as $position) |
221 | 221 | { |
222 | - $options .= '<option value="' . $position . '" selected="selected">' . $position . '</option>'; |
|
222 | + $options .= '<option value="'.$position.'" selected="selected">'.$position.'</option>'; |
|
223 | 223 | } |
224 | 224 | |
225 | 225 | return $options; |
@@ -83,7 +83,7 @@ discard block |
||
83 | 83 | |
84 | 84 | if (sizeof($query_ids)) |
85 | 85 | { |
86 | - $sql_where .= (($sql_where) ? ' AND ' : '') . $this->db->sql_in_set('user_id', $query_ids); |
|
86 | + $sql_where .= (($sql_where) ? ' AND ' : '').$this->db->sql_in_set('user_id', $query_ids); |
|
87 | 87 | $this->query($sql_where); |
88 | 88 | } |
89 | 89 | |
@@ -160,8 +160,8 @@ discard block |
||
160 | 160 | public function get_profile_fields() |
161 | 161 | { |
162 | 162 | $sql = 'SELECT l.lang_name, f.field_ident |
163 | - FROM ' . PROFILE_LANG_TABLE . ' l, ' . PROFILE_FIELDS_TABLE . ' f |
|
164 | - WHERE l.lang_id = ' . $this->user->get_iso_lang_id() . ' |
|
163 | + FROM ' . PROFILE_LANG_TABLE.' l, '.PROFILE_FIELDS_TABLE.' f |
|
164 | + WHERE l.lang_id = ' . $this->user->get_iso_lang_id().' |
|
165 | 165 | AND f.field_active = 1 |
166 | 166 | AND f.field_no_view = 0 |
167 | 167 | AND f.field_hide = 0 |
@@ -219,7 +219,7 @@ discard block |
||
219 | 219 | */ |
220 | 220 | protected function get_search_url($user_id) |
221 | 221 | { |
222 | - return ($this->auth->acl_get('u_search')) ? append_sid($this->phpbb_root_path . 'search.' . $this->php_ext, "author_id=$user_id&sr=posts") : ''; |
|
222 | + return ($this->auth->acl_get('u_search')) ? append_sid($this->phpbb_root_path.'search.'.$this->php_ext, "author_id=$user_id&sr=posts") : ''; |
|
223 | 223 | } |
224 | 224 | |
225 | 225 | /** |
@@ -230,7 +230,7 @@ discard block |
||
230 | 230 | { |
231 | 231 | if (!function_exists('phpbb_get_user_rank')) |
232 | 232 | { |
233 | - include($this->phpbb_root_path . 'includes/functions_display.' . $this->php_ext); |
|
233 | + include($this->phpbb_root_path.'includes/functions_display.'.$this->php_ext); |
|
234 | 234 | } |
235 | 235 | |
236 | 236 | $user_rank_data = phpbb_get_user_rank($row, $row['user_posts']); |
@@ -304,8 +304,8 @@ discard block |
||
304 | 304 | protected function get_sql_statement($sql_where = '', $order_by = '') |
305 | 305 | { |
306 | 306 | return 'SELECT user_id, username, user_type, user_colour, user_avatar, user_avatar_type, user_avatar_height, user_avatar_width, user_regdate, user_lastvisit, user_birthday, user_posts, user_rank, user_email, user_allow_viewemail, user_allow_pm, user_jabber, user_inactive_reason |
307 | - FROM ' . USERS_TABLE . |
|
308 | - (($sql_where) ? ' WHERE ' . $sql_where : '') . |
|
309 | - (($order_by) ? ' ORDER BY ' . $order_by : ''); |
|
307 | + FROM ' . USERS_TABLE. |
|
308 | + (($sql_where) ? ' WHERE '.$sql_where : ''). |
|
309 | + (($order_by) ? ' ORDER BY '.$order_by : ''); |
|
310 | 310 | } |
311 | 311 | } |
@@ -288,8 +288,7 @@ |
||
288 | 288 | 'NAME' => $field_data['PROFILE_FIELD_NAME'], |
289 | 289 | 'U_CONTACT' => $field_data['PROFILE_FIELD_CONTACT'], |
290 | 290 | ); |
291 | - } |
|
292 | - else |
|
291 | + } else |
|
293 | 292 | { |
294 | 293 | $this->user_cache[$user_id]['profile_fields'][$field] = $field_data; |
295 | 294 | } |
@@ -22,7 +22,7 @@ discard block |
||
22 | 22 | // @codeCoverageIgnoreStart |
23 | 23 | if (!function_exists('make_forum_select')) |
24 | 24 | { |
25 | - include($phpbb_root_path . 'includes/functions_admin.' . $php_ext); |
|
25 | + include($phpbb_root_path.'includes/functions_admin.'.$php_ext); |
|
26 | 26 | } |
27 | 27 | // @codeCoverageIgnoreEnd |
28 | 28 | } |
@@ -43,7 +43,7 @@ discard block |
||
43 | 43 | $forum_options = array('' => 'ALL_FORUMS'); |
44 | 44 | foreach ($forumlist as $row) |
45 | 45 | { |
46 | - $forum_options[$row['forum_id']] = $row['padding'] . $row['forum_name']; |
|
46 | + $forum_options[$row['forum_id']] = $row['padding'].$row['forum_name']; |
|
47 | 47 | } |
48 | 48 | |
49 | 49 | return $forum_options; |
@@ -89,7 +89,7 @@ |
||
89 | 89 | $this->store['topic'][$row['topic_id']] = $row; |
90 | 90 | |
91 | 91 | $this->store['tracking'][$row['forum_id']]['topic_list'][] = $row['topic_id']; |
92 | - $this->store['tracking'][$row['forum_id']]['mark_time'] =& $row['forum_mark_time']; |
|
92 | + $this->store['tracking'][$row['forum_id']]['mark_time'] = & $row['forum_mark_time']; |
|
93 | 93 | $this->store['post_ids']['first'][] = $row['topic_first_post_id']; |
94 | 94 | $this->store['post_ids']['last'][] = $row['topic_last_post_id']; |
95 | 95 | $this->store['poster_ids'][] = $row['topic_poster']; |
@@ -235,8 +235,7 @@ |
||
235 | 235 | if (sizeof($post_ids)) |
236 | 236 | { |
237 | 237 | return $this->db->sql_in_set('p.post_id', array_map('intval', $post_ids)); |
238 | - } |
|
239 | - else if (sizeof($this->store['topic'])) |
|
238 | + } else if (sizeof($this->store['topic'])) |
|
240 | 239 | { |
241 | 240 | $this->_limit_posts_by_topic($sql_where, $topic_first_or_last_post); |
242 | 241 | } |
@@ -64,7 +64,7 @@ |
||
64 | 64 | { |
65 | 65 | if (!class_exists('acp_forums')) |
66 | 66 | { |
67 | - include($this->phpbb_root_path . 'includes/acp/acp_forums.' . $this->php_ext); |
|
67 | + include($this->phpbb_root_path.'includes/acp/acp_forums.'.$this->php_ext); |
|
68 | 68 | } |
69 | 69 | |
70 | 70 | $this->translator->add_lang('acp/forums'); |