Inspection of "Test forum topics block" - blitze/phpBB-ext-sitemaker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2c87b2...a93112 )

by Daniel

created 2015-12-02 02:11 UTC

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\services\menus\action;
 

Please login to merge, or discard this patch.

services/menus/action/load_items.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\services\menus\action;
 

Please login to merge, or discard this patch.

services/menus/action/add_item.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\services\menus\action;
 

Please login to merge, or discard this patch.

services/menus/action/base_action.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\services\menus\action;
 

Please login to merge, or discard this patch.

services/menus/action/add_bulk.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\services\menus\action;
 

Please login to merge, or discard this patch.

services/menus/action/action_interface.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\services\menus\action;
 

Please login to merge, or discard this patch.

services/menus/display.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\services\menus;
 

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -47,7 +47,7 @@  discard block
 block discarded – undo
 	/**
 	 *
 	 */
-	public function display_list(array $data, \phpbb\template\twig\twig &$template, $handle = 'tree')
+	public function display_list(array $data, \phpbb\template\twig\twig & $template, $handle = 'tree')
 	{
 		$data = array_values($data);
 
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
 			}
 
 			$is_current_item = $this->is_current_item($row, $current_data['item_id']);
-			$this_depth	= $this->parental_depth[$row['parent_id']] + 1;
+			$this_depth = $this->parental_depth[$row['parent_id']] + 1;
 
 			$this->set_parental_depth($row, $this_depth, $current_data, $is_current_item);
 
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
 				continue;
 			}
 
-			$tpl_data	= array(
+			$tpl_data = array(
 				'S_PREV_DEPTH'	=> $prev_depth,
 				'S_THIS_DEPTH'	=> $this_depth,
 				'S_NUM_KIDS'	=> $this->count_descendants($row),
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
 		}
 	}
 
-	protected function close_open_tags(\phpbb\template\twig\twig &$template, $handle, $repeat)
+	protected function close_open_tags(\phpbb\template\twig\twig & $template, $handle, $repeat)
 	{
 		for ($i = 0; $i < $repeat; $i++)
 		{

Please login to merge, or discard this patch.

services/menus/nestedset.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,23 +1,23 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\services\menus;
 
 class nestedset extends \blitze\sitemaker\services\tree\builder
 {
 	/**
-	* Construct
-	*
-	* @param \phpbb\db\driver\driver_interface	$db				Database connection
-	* @param \phpbb\lock\db						$lock			Lock class used to lock the table when moving forums around
-	* @param string								$table_name		Table name
-	*/
+	 * Construct
+	 *
+	 * @param \phpbb\db\driver\driver_interface	$db				Database connection
+	 * @param \phpbb\lock\db						$lock			Lock class used to lock the table when moving forums around
+	 * @param string								$table_name		Table name
+	 */
 	public function __construct(\phpbb\db\driver\driver_interface $db, \phpbb\lock\db $lock, $table_name)
 	{
 		parent::__construct(

Please login to merge, or discard this patch.

services/menus/action_handler.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\services\menus;
 

Please login to merge, or discard this patch.

		@@ -47,7 +47,7 @@ discard block
		block discarded – undo
47	47	/**
48	48	*
49	49	*/
50		- public function display_list(array $data, \phpbb\template\twig\twig &$template, $handle = 'tree')
	50	+ public function display_list(array $data, \phpbb\template\twig\twig & $template, $handle = 'tree')
51	51	{
52	52	$data = array_values($data);
53	53
		@@ -67,7 +67,7 @@ discard block
		block discarded – undo
67	67	}
68	68
69	69	$is_current_item = $this->is_current_item($row, $current_data['item_id']);
70		- $this_depth = $this->parental_depth[$row['parent_id']] + 1;
	70	+ $this_depth = $this->parental_depth[$row['parent_id']] + 1;
71	71
72	72	$this->set_parental_depth($row, $this_depth, $current_data, $is_current_item);
73	73
		@@ -76,7 +76,7 @@ discard block
		block discarded – undo
76	76	continue;
77	77	}
78	78
79		- $tpl_data = array(
	79	+ $tpl_data = array(
80	80	'S_PREV_DEPTH' => $prev_depth,
81	81	'S_THIS_DEPTH' => $this_depth,
82	82	'S_NUM_KIDS' => $this->count_descendants($row),
		@@ -130,7 +130,7 @@ discard block
		block discarded – undo
130	130	}
131	131	}
132	132
133		- protected function close_open_tags(\phpbb\template\twig\twig &$template, $handle, $repeat)
	133	+ protected function close_open_tags(\phpbb\template\twig\twig & $template, $handle, $repeat)
134	134	{
135	135	for ($i = 0; $i < $repeat; $i++)
136	136	{

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- *
4		- * @package sitemaker
5		- * @copyright (c) 2013 Daniel A. (blitze)
6		- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
7		- *
8		- */
	3	+ *
	4	+ * @package sitemaker
	5	+ * @copyright (c) 2013 Daniel A. (blitze)
	6	+ * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
	7	+ *
	8	+ */
9	9
10	10	namespace blitze\sitemaker\services\menus\action;
11	11

		@@ -1,23 +1,23 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- *
4		- * @package sitemaker
5		- * @copyright (c) 2013 Daniel A. (blitze)
6		- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
7		- *
8		- */
	3	+ *
	4	+ * @package sitemaker
	5	+ * @copyright (c) 2013 Daniel A. (blitze)
	6	+ * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
	7	+ *
	8	+ */
9	9
10	10	namespace blitze\sitemaker\services\menus;
11	11
12	12	class nestedset extends \blitze\sitemaker\services\tree\builder
13	13	{
14	14	/**
15		- * Construct
16		- *
17		- * @param \phpbb\db\driver\driver_interface $db Database connection
18		- * @param \phpbb\lock\db $lock Lock class used to lock the table when moving forums around
19		- * @param string $table_name Table name
20		- */
	15	+ * Construct
	16	+ *
	17	+ * @param \phpbb\db\driver\driver_interface $db Database connection
	18	+ * @param \phpbb\lock\db $lock Lock class used to lock the table when moving forums around
	19	+ * @param string $table_name Table name
	20	+ */
21	21	public function __construct(\phpbb\db\driver\driver_interface $db, \phpbb\lock\db $lock, $table_name)
22	22	{
23	23	parent::__construct(

blitze / phpBB-ext-sitemaker

Push — master ( 2c87b2...a93112 )

Category

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch