blitze / phpBB-ext-sitemaker

services/poll.php

Braces +1 added lines, -2 removed lines

@@ -303,8 +303,7 @@
 				$cur_voted_id[] = $row['poll_option_id'];
 			}
 			$this->db->sql_freeresult($result);
-		}
-		else
+		} else
 		{
 			// Cookie based guest tracking ... I don't like this but hum ho
 			// it's oft requested. This relies on "nice" users who don't feel

Spacing +8 added lines, -8 removed lines

@@ -68,7 +68,7 @@ 
 	 * @param array $topic_data
 	 * @param \phpbb\template\twig\twig $template
 	 */
-	public function build(array $topic_data, \phpbb\template\twig\twig &$template)
+	public function build(array $topic_data, \phpbb\template\twig\twig & $template)
 	{
 		$this->translator->add_lang('viewtopic');
 
@@ -100,7 +100,7 @@ 
 			'S_POLL_ACTION'		=> $viewtopic_url,
 			'S_FORM_TOKEN'		=> $this->sitemaker->get_form_key('posting'),
 
-			'U_VIEW_RESULTS'	=> $viewtopic_url . '&view=viewpoll',
+			'U_VIEW_RESULTS'	=> $viewtopic_url.'&view=viewpoll',
 		));
 	}
 
@@ -171,7 +171,7 @@ 
 		$post_id = (int) $topic_data['topic_first_post_id'];
 
 		$sql = 'SELECT o.*, p.bbcode_bitfield, p.bbcode_uid
-			FROM ' . POLL_OPTIONS_TABLE . ' o, ' . POSTS_TABLE . " p
+			FROM ' . POLL_OPTIONS_TABLE.' o, '.POSTS_TABLE." p
 			WHERE o.topic_id = $topic_id
 				AND p.post_id = $post_id
 				AND p.topic_id = o.topic_id
@@ -216,7 +216,7 @@ 
 	 * @param int $poll_most
 	 * @param \phpbb\template\twig\twig $template
 	 */
-	private function build_poll_options(array $cur_voted_id, array $poll_info, $poll_total, $poll_most, \phpbb\template\twig\twig &$template)
+	private function build_poll_options(array $cur_voted_id, array $poll_info, $poll_total, $poll_most, \phpbb\template\twig\twig & $template)
 	{
 		foreach ($poll_info as $poll_option)
 		{
@@ -247,8 +247,8 @@ 
 		if ($this->user->data['is_registered'])
 		{
 			$sql = 'SELECT poll_option_id
-			FROM ' . POLL_VOTES_TABLE . '
-			WHERE topic_id = ' . (int) $topic_id . '
+			FROM ' . POLL_VOTES_TABLE.'
+			WHERE topic_id = ' . (int) $topic_id.'
 				AND vote_user_id = ' . (int) $this->user->data['user_id'];
 			$result = $this->db->sql_query($sql);
 
@@ -263,9 +263,9 @@ 
 			// Cookie based guest tracking ... I don't like this but hum ho
 			// it's oft requested. This relies on "nice" users who don't feel
 			// the need to delete cookies to mess with results.
-			if ($this->request->is_set($this->config['cookie_name'] . '_poll_' . $topic_id, \phpbb\request\request_interface::COOKIE))
+			if ($this->request->is_set($this->config['cookie_name'].'_poll_'.$topic_id, \phpbb\request\request_interface::COOKIE))
 			{
-				$cur_voted_id = explode(',', $this->request->variable($this->config['cookie_name'] . '_poll_' . $topic_id, '', true, \phpbb\request\request_interface::COOKIE));
+				$cur_voted_id = explode(',', $this->request->variable($this->config['cookie_name'].'_poll_'.$topic_id, '', true, \phpbb\request\request_interface::COOKIE));
 				$cur_voted_id = array_map('intval', $cur_voted_id);
 			}
 		}

services/groups.php

Spacing +6 added lines, -6 removed lines

@@ -40,7 +40,7 @@ 
 	public function get_users_groups()
 	{
 		$sql = 'SELECT group_id
-			FROM ' . USER_GROUP_TABLE . '
+			FROM ' . USER_GROUP_TABLE.'
 			WHERE user_id = ' . (int) $this->user->data['user_id'];
 		$result = $this->db->sql_query($sql);
 
@@ -83,13 +83,13 @@ 
 		$sql = $this->_get_group_sql($mode);
 		$result = $this->db->sql_query($sql);
 
-		$options = '<option value="0">' . $this->translator->lang('ALL_GROUPS') . '</option>';
+		$options = '<option value="0">'.$this->translator->lang('ALL_GROUPS').'</option>';
 		while ($row = $this->db->sql_fetchrow($result))
 		{
 			$group_name = $this->_get_group_name($row);
 			$group_class = $this->_get_group_class($row['group_type']);
 			$selected_option = $this->_get_selected_option($row['group_id'], $selected);
-			$options .= '<option' . $group_class . ' value="' . $row['group_id'] . '"' . $selected_option . '>' . $group_name . '</option>';
+			$options .= '<option'.$group_class.' value="'.$row['group_id'].'"'.$selected_option.'>'.$group_name.'</option>';
 		}
 		$this->db->sql_freeresult($result);
 
@@ -103,8 +103,8 @@ 
 	private function _get_group_sql($mode)
 	{
 		return 'SELECT group_id, group_name, group_type
-			FROM ' . GROUPS_TABLE .
-			(($mode === 'special') ? ' WHERE group_type = ' . GROUP_SPECIAL : '') . '
+			FROM ' . GROUPS_TABLE.
+			(($mode === 'special') ? ' WHERE group_type = '.GROUP_SPECIAL : '').'
 			ORDER BY group_type DESC, group_name ASC';
 	}
 
@@ -114,7 +114,7 @@ 
 	 */
 	private function _get_group_name(array $row)
 	{
-		return ($row['group_type'] == GROUP_SPECIAL) ? $this->translator->lang('G_' . $row['group_name']) : ucfirst($row['group_name']);
+		return ($row['group_type'] == GROUP_SPECIAL) ? $this->translator->lang('G_'.$row['group_name']) : ucfirst($row['group_name']);
 	}
 
 	/**

services/members.php

Spacing +9 added lines, -9 removed lines

@@ -63,7 +63,7 @@ 
 		// @codeCoverageIgnoreStart
 		if (!function_exists('phpbb_get_user_avatar'))
 		{
-			include($phpbb_root_path . 'includes/functions_display.' . $php_ext);
+			include($phpbb_root_path.'includes/functions_display.'.$php_ext);
 		}
 		// @codeCoverageIgnoreEnd
 	}
@@ -101,8 +101,8 @@ 
 	 */
 	protected function member_posts(array $row)
 	{
-		$u_posts = append_sid($this->phpbb_root_path . 'search.' . $this->php_ext, "author_id={$row['user_id']}&sr=posts" . $this->explain_range);
-		$user_posts = '<a href="' . $u_posts . '">' . $row['user_posts'] . '</a>';
+		$u_posts = append_sid($this->phpbb_root_path.'search.'.$this->php_ext, "author_id={$row['user_id']}&amp;sr=posts".$this->explain_range);
+		$user_posts = '<a href="'.$u_posts.'">'.$row['user_posts'].'</a>';
 
 		return array(
 			'USERNAME'		=> get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),
@@ -170,7 +170,7 @@ 
 			'WHERE'			=> $this->db->sql_in_set('u.user_type', array(USER_NORMAL, USER_FOUNDER)),
 		);
 
-		$sql_method = 'set_' . $this->settings['query_type'] . '_sql';
+		$sql_method = 'set_'.$this->settings['query_type'].'_sql';
 		call_user_func_array(array($this, $sql_method), array(&$sql_ary));
 
 		$this->set_range_sql($sql_ary);
@@ -184,7 +184,7 @@ 
 	protected function set_visits_sql(array &$sql_ary)
 	{
 		$sql_ary['SELECT'] .= ', u.user_lastvisit as member_date';
-		$sql_ary['WHERE'] .= ' AND u.user_lastvisit <> 0 AND u.user_id <> ' . (int) $this->user->data['user_id'];
+		$sql_ary['WHERE'] .= ' AND u.user_lastvisit <> 0 AND u.user_id <> '.(int) $this->user->data['user_id'];
 		$sql_ary['ORDER_BY'] = 'u.user_lastvisit DESC';
 
 		$this->sql_date_field = 'user_lastvisit';
@@ -200,7 +200,7 @@ 
 		$this->info_header = '';
 		$this->view_mode = 'member_bots';
 
-		$sql_ary['WHERE'] = 'u.user_type = ' . USER_IGNORE;
+		$sql_ary['WHERE'] = 'u.user_type = '.USER_IGNORE;
 	}
 
 	/**
@@ -209,7 +209,7 @@ 
 	protected function set_tenured_sql(array &$sql_ary)
 	{
 		$sql_ary['SELECT'] .= ', u.user_regdate as member_date';
-		$sql_ary['ORDER_BY'] = 'u.user_regdate ' . (($this->settings['query_type'] == 'tenured') ? 'ASC' : 'DESC');
+		$sql_ary['ORDER_BY'] = 'u.user_regdate '.(($this->settings['query_type'] == 'tenured') ? 'ASC' : 'DESC');
 
 		$this->sql_date_field = 'u.user_regdate';
 		$this->settings['date_range'] = '';
@@ -232,7 +232,7 @@ 
 		$sql_ary['SELECT'] .= ', COUNT(p.post_id) as user_posts';
 		$sql_ary['FROM'] += array(TOPICS_TABLE => 't');
 		$sql_ary['FROM'] += array(POSTS_TABLE => 'p');
-		$sql_ary['WHERE'] .= ' AND ' . time() . ' > t.topic_time AND t.topic_id = p.topic_id AND p.post_visibility = ' . ITEM_APPROVED . ' AND p.poster_id = u.user_id';
+		$sql_ary['WHERE'] .= ' AND '.time().' > t.topic_time AND t.topic_id = p.topic_id AND p.post_visibility = '.ITEM_APPROVED.' AND p.poster_id = u.user_id';
 		$sql_ary['GROUP_BY'] = 'u.user_id';
 		$sql_ary['ORDER_BY'] = 'user_posts DESC, u.username ASC';
 
@@ -249,7 +249,7 @@ 
 		if ($this->settings['date_range'] && $this->sql_date_field)
 		{
 			$range = $this->date_range->get($this->settings['date_range']);
-			$this->explain_range = '&amp;date=' . $range['date'];
+			$this->explain_range = '&amp;date='.$range['date'];
 
 			$sql_ary['WHERE'] .= " AND {$this->sql_date_field} BETWEEN {$range['start']} AND {$range['stop']}";
 		}

services/blocks/action/base_action.php

Braces +1 added lines, -2 removed lines

@@ -144,8 +144,7 @@
 		{
 			$content = $this->translator->lang('BLOCK_NO_DATA');
 			$returned_data['status'] = 0;
-		}
-		else
+		} else
 		{
 			$content = $returned_data['content'];
 		}

services/blocks/action/save_blocks.php

Braces +1 added lines, -2 removed lines

@@ -118,8 +118,7 @@
 		if (!$has_blocks && !$this->route_is_customized($entity->to_array()))
 		{
 			$this->route_mapper->delete($entity);
-		}
-		else
+		} else
 		{
 			$entity->set_has_blocks($has_blocks);
 			$this->route_mapper->save($entity);

services/blocks/action/add_block.php

Spacing +2 added lines, -2 removed lines

@@ -17,8 +17,8 @@
 	 */
 	public function execute($style_id)
 	{
-		$name	= $this->request->variable('block', '');
-		$route	= $this->request->variable('route', '');
+		$name = $this->request->variable('block', '');
+		$route = $this->request->variable('route', '');
 
 		if (($block_instance = $this->block_factory->get_block($name)) === null)
 		{

services/blocks/blocks.php

Braces +1 added lines, -2 removed lines

@@ -154,8 +154,7 @@
 		if (!empty($returned_data['content']))
 		{
 			$content = $returned_data['content'];
-		}
-		else if ($edit_mode)
+		} else if ($edit_mode)
 		{
 			$returned_data['status'] = 0;
 			$content = $this->translator->lang('BLOCK_NO_DATA');

Doc Comments +1 added lines, -1 removed lines

@@ -144,7 +144,7 @@
 	 * @param string $position
 	 * @param array $blocks
 	 * @param array $ex_positions
-	 * @param array $users_groups
+	 * @param integer[] $users_groups
 	 * @param array $display_modes
 	 * @param bool $edit_mode
 	 * @return array[]

services/blocks/display.php

Spacing +3 added lines, -3 removed lines

@@ -71,7 +71,7 @@ 
 		{
 			$edit_mode = $this->toggle_edit_mode();
 			$style_id = $this->get_style_id();
-			$current_route = ltrim($this->user->page['page_dir'] . '/' . $this->user->page['page_name'], './');
+			$current_route = ltrim($this->user->page['page_dir'].'/'.$this->user->page['page_name'], './');
 
 			$this->show_sitemaker($current_route, $this->user->page['page_dir'], $style_id, $edit_mode);
 		}
@@ -107,7 +107,7 @@ 
 	 */
 	protected function toggle_edit_mode()
 	{
-		$edit_mode = $this->request->variable($this->config['cookie_name'] . '_sm_edit_mode', false, false, \phpbb\request\request_interface::COOKIE);
+		$edit_mode = $this->request->variable($this->config['cookie_name'].'_sm_edit_mode', false, false, \phpbb\request\request_interface::COOKIE);
 
 		if ($this->request->is_set('edit_mode'))
 		{
@@ -163,7 +163,7 @@ 
 				);
 			}
 
-			$u_edit_mode = append_sid(generate_board_url() . '/' . ltrim(rtrim(build_url(array('edit_mode', 'sid', 'style')), '?'), './../'), 'edit_mode=' . (int) !$edit_mode);
+			$u_edit_mode = append_sid(generate_board_url().'/'.ltrim(rtrim(build_url(array('edit_mode', 'sid', 'style')), '?'), './../'), 'edit_mode='.(int) !$edit_mode);
 		}
 		else
 		{

Braces +3 added lines, -6 removed lines

@@ -86,8 +86,7 @@ 
 		if ($this->request->is_set('style'))
 		{
 			return $this->request->variable('style', 0);
-		}
-		else
+		} else
 		{
 			return (!$this->config['override_user_style']) ? $this->user->data['user_style'] : $this->config['default_style'];
 		}
@@ -131,8 +130,7 @@ 
 				self::SHOW_ON_PARENT_ROUTE_ONLY	=> true,
 				self::SHOW_ON_CHILD_ROUTE_ONLY	=> false,
 			);
-		}
-		else
+		} else
 		{
 			$modes = array(
 				self::SHOW_ON_ALL_ROUTES		=> true,
@@ -164,8 +162,7 @@ 
 			}
 
 			$u_edit_mode = append_sid(generate_board_url() . '/' . ltrim(rtrim(build_url(array('edit_mode', 'sid', 'style')), '?'), './../'), 'edit_mode=' . (int) !$edit_mode);
-		}
-		else
+		} else
 		{
 			$edit_mode = false;
 		}

services/url_checker.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 		$status = array();
 		$headers = $this->get_headers($url, $curl);
 
-		preg_match('/HTTP\/.* ([0-9]+) .*/', $headers , $status);
+		preg_match('/HTTP\/.* ([0-9]+) .*/', $headers, $status);
 
 		return ($status[1] == 200) ? true : false;
 	}

Braces +1 added lines, -2 removed lines

@@ -41,8 +41,7 @@
 		if (extension_loaded('curl') && $curl)
 		{
 			$headers = $this->curl_header($url);
-		}
-		else
+		} else
 		{
 			$headers = get_headers($url);
 			$headers = $headers[0];