| Total Complexity | 41 |
| Total Lines | 382 |
| Duplicated Lines | 0 % |
| Changes | 6 | ||
| Bugs | 0 | Features | 1 |
Complex classes like query_builder often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use query_builder, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class query_builder |
||
| 14 | { |
||
| 15 | /** @var \phpbb\auth\auth */ |
||
| 16 | protected $auth; |
||
| 17 | |||
| 18 | /** @var \phpbb\config\config */ |
||
| 19 | protected $config; |
||
| 20 | |||
| 21 | /** @var \phpbb\content_visibility */ |
||
| 22 | protected $content_visibility; |
||
| 23 | |||
| 24 | /** @var \phpbb\db\driver\driver_interface */ |
||
| 25 | protected $db; |
||
| 26 | |||
| 27 | /** @var \phpbb\user */ |
||
| 28 | protected $user; |
||
| 29 | |||
| 30 | /** @var array */ |
||
| 31 | protected $store; |
||
| 32 | |||
| 33 | /** @var array */ |
||
| 34 | protected $ex_fid_ary; |
||
| 35 | |||
| 36 | /** @var integer */ |
||
| 37 | protected $cache_time; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * Constructor |
||
| 41 | * |
||
| 42 | * @param \phpbb\auth\auth $auth Auth object |
||
| 43 | * @param \phpbb\config\config $config Config object |
||
| 44 | * @param \phpbb\content_visibility $content_visibility Content visibility |
||
| 45 | * @param \phpbb\db\driver\driver_interface $db Database connection |
||
| 46 | * @param \phpbb\user $user User object |
||
| 47 | * @param integer $cache_time Cache results for 3 hours by default |
||
| 48 | */ |
||
| 49 | public function __construct(\phpbb\auth\auth $auth, \phpbb\config\config $config, \phpbb\content_visibility $content_visibility, \phpbb\db\driver\driver_interface $db, \phpbb\user $user, $cache_time) |
||
| 50 | { |
||
| 51 | $this->auth = $auth; |
||
| 52 | $this->config = $config; |
||
| 53 | $this->content_visibility = $content_visibility; |
||
| 54 | $this->db = $db; |
||
| 55 | $this->user = $user; |
||
| 56 | $this->cache_time = $cache_time; |
||
| 57 | |||
| 58 | $this->ex_fid_ary = array_unique(array_keys($this->auth->acl_getf('!f_read', true))); |
||
| 59 | } |
||
| 60 | |||
| 61 | /** |
||
| 62 | * Begin query |
||
| 63 | * |
||
| 64 | * @param bool $track_topics |
||
| 65 | * @param bool $get_forum_data |
||
| 66 | * @return $this |
||
| 67 | */ |
||
| 68 | public function query($track_topics = true, $get_forum_data = true) |
||
| 69 | { |
||
| 70 | $this->_reset(); |
||
| 71 | |||
| 72 | $this->store['sql_array'] = array_fill_keys(array('SELECT', 'FROM', 'LEFT_JOIN', 'WHERE'), array()); |
||
| 73 | |||
| 74 | if ($get_forum_data) |
||
| 75 | { |
||
| 76 | $this->store['sql_array']['SELECT'][] = 'f.*'; |
||
| 77 | $this->store['sql_array']['FROM'][FORUMS_TABLE] = 'f'; |
||
| 78 | } |
||
| 79 | |||
| 80 | $this->store['sql_array']['SELECT'][] = 't.*'; |
||
| 81 | |||
| 82 | if ($track_topics) |
||
| 83 | { |
||
| 84 | $this->fetch_tracking_info(); |
||
| 85 | } |
||
| 86 | |||
| 87 | return $this; |
||
| 88 | } |
||
| 89 | |||
| 90 | /** |
||
| 91 | * Fetch Forum by id(s) |
||
| 92 | * |
||
| 93 | * @param int|array $forum_id |
||
| 94 | * @return $this |
||
| 95 | */ |
||
| 96 | public function fetch_forum($forum_id) |
||
| 97 | { |
||
| 98 | $this->_fetch($forum_id, (isset($this->store['sql_array']['FROM'][FORUMS_TABLE])) ? 'f.forum_id' : 't.forum_Id'); |
||
| 99 | |||
| 100 | return $this; |
||
| 101 | } |
||
| 102 | |||
| 103 | /** |
||
| 104 | * Fetch Topic by id(s) |
||
| 105 | * |
||
| 106 | * @param mixed $topic_id Limit by topic id: single id or array of topic ids |
||
| 107 | * @return $this |
||
| 108 | */ |
||
| 109 | public function fetch_topic($topic_id) |
||
| 110 | { |
||
| 111 | $this->_fetch($topic_id, 't.topic_id'); |
||
| 112 | |||
| 113 | return $this; |
||
| 114 | } |
||
| 115 | |||
| 116 | /** |
||
| 117 | * Fetch Topic by Poster id(s) |
||
| 118 | * |
||
| 119 | * @param mixed $user_id User id of topic poster: single id or array of user ids |
||
| 120 | * @return $this |
||
| 121 | */ |
||
| 122 | public function fetch_topic_poster($user_id) |
||
| 123 | { |
||
| 124 | $this->_fetch($user_id, 't.topic_poster'); |
||
| 125 | |||
| 126 | return $this; |
||
| 127 | } |
||
| 128 | |||
| 129 | /** |
||
| 130 | * Fetch by Topic Type |
||
| 131 | * |
||
| 132 | * @param array $topic_type |
||
| 133 | * @return $this |
||
| 134 | */ |
||
| 135 | public function fetch_topic_type(array $topic_type) |
||
| 136 | { |
||
| 137 | if (sizeof($topic_type)) |
||
| 138 | { |
||
| 139 | $this->store['sql_array']['WHERE'][] = $this->db->sql_in_set('t.topic_type', $topic_type); |
||
| 140 | } |
||
| 141 | |||
| 142 | return $this; |
||
| 143 | } |
||
| 144 | |||
| 145 | /** |
||
| 146 | * Fetch Topic Watch info |
||
| 147 | * |
||
| 148 | * @param $type |
||
| 149 | * @return $this |
||
| 150 | */ |
||
| 151 | public function fetch_watch_status($type = 'topic') |
||
| 152 | { |
||
| 153 | if ($this->user->data['is_registered']) |
||
| 154 | { |
||
| 155 | $keys = array( |
||
| 156 | 'forum' => array( |
||
| 157 | 'table' => FORUMS_WATCH_TABLE, |
||
| 158 | 'cond' => 'ws.forum_id = f.forum_id', |
||
| 159 | ), |
||
| 160 | 'topic' => array( |
||
| 161 | 'table' => TOPICS_WATCH_TABLE, |
||
| 162 | 'cond' => 'ws.topic_id = t.topic_id', |
||
| 163 | ), |
||
| 164 | ); |
||
| 165 | |||
| 166 | $this->store['sql_array']['SELECT'][] = 'ws.notify_status'; |
||
| 167 | $this->store['sql_array']['LEFT_JOIN'][] = array( |
||
| 168 | 'FROM' => array($keys[$type]['table'] => 'ws'), |
||
| 169 | 'ON' => $keys[$type]['cond'] . ' AND ws.user_id = ' . (int) $this->user->data['user_id'], |
||
| 170 | ); |
||
| 171 | } |
||
| 172 | |||
| 173 | return $this; |
||
| 174 | } |
||
| 175 | |||
| 176 | /** |
||
| 177 | * Fetch Topic Bookmark Info |
||
| 178 | * |
||
| 179 | * @return $this |
||
| 180 | */ |
||
| 181 | public function fetch_bookmark_status() |
||
| 182 | { |
||
| 183 | if ($this->user->data['is_registered'] && $this->config['allow_bookmarks']) |
||
| 184 | { |
||
| 185 | $this->store['sql_array']['SELECT'][] = 'bm.topic_id as bookmarked'; |
||
| 186 | $this->store['sql_array']['LEFT_JOIN'][] = array( |
||
| 187 | 'FROM' => array(BOOKMARKS_TABLE => 'bm'), |
||
| 188 | 'ON' => 'bm.user_id = ' . (int) $this->user->data['user_id'] . ' AND t.topic_id = bm.topic_id' |
||
| 189 | ); |
||
| 190 | } |
||
| 191 | |||
| 192 | return $this; |
||
| 193 | } |
||
| 194 | |||
| 195 | /** |
||
| 196 | * Fetch Topic Tracking Info |
||
| 197 | * |
||
| 198 | * @return $this |
||
| 199 | */ |
||
| 200 | public function fetch_tracking_info() |
||
| 201 | { |
||
| 202 | if ($this->user->data['is_registered'] && $this->config['load_db_lastread']) |
||
| 203 | { |
||
| 204 | $this->cache_time = 0; |
||
| 205 | |||
| 206 | $this->store['sql_array']['SELECT'][] = 'tt.mark_time, ft.mark_time as forum_mark_time'; |
||
| 207 | $this->store['sql_array']['LEFT_JOIN'][] = array( |
||
| 208 | 'FROM' => array(TOPICS_TRACK_TABLE => 'tt'), |
||
| 209 | 'ON' => 'tt.user_id = ' . (int) $this->user->data['user_id'] . ' AND t.topic_id = tt.topic_id' |
||
| 210 | ); |
||
| 211 | |||
| 212 | $this->store['sql_array']['LEFT_JOIN'][] = array( |
||
| 213 | 'FROM' => array(FORUMS_TRACK_TABLE => 'ft'), |
||
| 214 | 'ON' => 'ft.user_id = ' . (int) $this->user->data['user_id'] . ' AND t.forum_id = ft.forum_id' |
||
| 215 | ); |
||
| 216 | } |
||
| 217 | |||
| 218 | return $this; |
||
| 219 | } |
||
| 220 | |||
| 221 | /** |
||
| 222 | * Fetch Topics posted Info |
||
| 223 | * |
||
| 224 | * @return $this |
||
| 225 | */ |
||
| 226 | public function fetch_db_track() |
||
| 227 | { |
||
| 228 | if ($this->user->data['is_registered'] && $this->config['load_db_track']) |
||
| 229 | { |
||
| 230 | $this->store['sql_array']['SELECT'][] = 'tp.topic_posted'; |
||
| 231 | $this->store['sql_array']['LEFT_JOIN'][] = array('FROM' => array(TOPICS_POSTED_TABLE => 'tp'), 'ON' => 'tp.topic_id = t.topic_id AND tp.user_id = ' . $this->user->data['user_id']); |
||
| 232 | } |
||
| 233 | |||
| 234 | return $this; |
||
| 235 | } |
||
| 236 | |||
| 237 | /** |
||
| 238 | * Fetch by Date Range |
||
| 239 | * |
||
| 240 | * @param int $unix_start_time |
||
| 241 | * @param int $unix_stop_time |
||
| 242 | * @param string $mode topic|post |
||
| 243 | * @return $this |
||
| 244 | */ |
||
| 245 | public function fetch_date_range($unix_start_time, $unix_stop_time, $mode = 'topic') |
||
| 246 | { |
||
| 247 | if ($unix_start_time && $unix_stop_time) |
||
| 248 | { |
||
| 249 | $this->store['sql_array']['WHERE'][] = (($mode == 'topic') ? 't.topic_time' : 'p.post_time') . " BETWEEN $unix_start_time AND $unix_stop_time"; |
||
| 250 | } |
||
| 251 | |||
| 252 | return $this; |
||
| 253 | } |
||
| 254 | |||
| 255 | /** |
||
| 256 | * Fetch by Custom Query |
||
| 257 | * |
||
| 258 | * @param array $sql_array Array of elements to merge into query |
||
| 259 | * array( |
||
| 260 | * 'SELECT' => array('p.*'), |
||
| 261 | * 'WHERE' => array('p.post_id = 2'), |
||
| 262 | * ) |
||
| 263 | * @param array $overwrite_keys Array of query keys to overwrite with yours instead of merging |
||
| 264 | * e.g array('SELECT') will overwrite the 'SELECT' key with whatever is provided in $sql_array |
||
| 265 | * @return $this |
||
| 266 | */ |
||
| 267 | public function fetch_custom(array $sql_array, $overwrite_keys = array()) |
||
| 268 | { |
||
| 269 | $this->store['sql_array'] = array_merge_recursive($this->store['sql_array'], $sql_array); |
||
| 270 | |||
| 271 | foreach ($overwrite_keys as $key) |
||
| 272 | { |
||
| 273 | $this->store['sql_array'][$key] = $sql_array[$key]; |
||
| 274 | } |
||
| 275 | |||
| 276 | return $this; |
||
| 277 | } |
||
| 278 | |||
| 279 | /** |
||
| 280 | * Set Sorting Order |
||
| 281 | * |
||
| 282 | * @param string $sort_key The sorting key e.g. t.topic_time |
||
| 283 | * @param string $sort_dir Sort direction: ASC/DESC |
||
| 284 | * @return $this |
||
| 285 | */ |
||
| 286 | public function set_sorting($sort_key, $sort_dir = 'DESC') |
||
| 287 | { |
||
| 288 | $this->store['sql_array']['ORDER_BY'] = $sort_key . ' ' . $sort_dir; |
||
| 289 | |||
| 290 | return $this; |
||
| 291 | } |
||
| 292 | |||
| 293 | /** |
||
| 294 | * Build the query |
||
| 295 | * |
||
| 296 | * @param bool|true $check_visibility Should we only return data from forums the user is allowed to see? |
||
| 297 | * @param bool|true $enable_caching Should the query be cached where possible? |
||
| 298 | * @param bool|true $exclude_hidden_forums Leave out hidden forums? |
||
| 299 | * @return $this |
||
| 300 | */ |
||
| 301 | public function build($check_visibility = true, $enable_caching = true, $exclude_hidden_forums = true) |
||
| 302 | { |
||
| 303 | $this->_set_cache_time($enable_caching); |
||
| 304 | $this->_set_topic_visibility($check_visibility); |
||
| 305 | $this->_set_forum_table($exclude_hidden_forums); |
||
| 306 | |||
| 307 | // Topics table need to be the last in the chain |
||
| 308 | $this->store['sql_array']['FROM'][TOPICS_TABLE] = 't'; |
||
| 309 | $this->store['sql_array']['WHERE'][] = 't.topic_moved_id = 0'; |
||
| 310 | |||
| 311 | $this->store['sql_array']['SELECT'] = join(', ', array_filter($this->store['sql_array']['SELECT'])); |
||
| 312 | $this->store['sql_array']['WHERE'] = join(' AND ', array_filter($this->store['sql_array']['WHERE'])); |
||
| 313 | |||
| 314 | return $this; |
||
| 315 | } |
||
| 316 | |||
| 317 | /** |
||
| 318 | * Get the query array |
||
| 319 | * |
||
| 320 | * @return array The sql array that can be used with sql_build_query |
||
| 321 | */ |
||
| 322 | public function get_sql_array() |
||
| 323 | { |
||
| 324 | return $this->store['sql_array']; |
||
| 325 | } |
||
| 326 | |||
| 327 | /** |
||
| 328 | * @param bool $enable_caching |
||
| 329 | * @return void |
||
| 330 | */ |
||
| 331 | protected function _set_cache_time($enable_caching) |
||
| 332 | { |
||
| 333 | if ($enable_caching === false) |
||
| 334 | { |
||
| 335 | $this->cache_time = 0; |
||
| 336 | } |
||
| 337 | } |
||
| 338 | |||
| 339 | /** |
||
| 340 | * @param int|array $column_id |
||
| 341 | * @param string $column |
||
| 342 | * @return void |
||
| 343 | */ |
||
| 344 | private function _fetch($column_id, $column) |
||
| 345 | { |
||
| 346 | if (!empty($column_id)) |
||
| 347 | { |
||
| 348 | $this->store['sql_array']['WHERE'][] = (is_array($column_id)) ? $this->db->sql_in_set($column, $column_id) : $column . ' = ' . (int) $column_id; |
||
| 349 | } |
||
| 350 | } |
||
| 351 | |||
| 352 | /** |
||
| 353 | * @param bool $check_visibility |
||
| 354 | * @return void |
||
| 355 | */ |
||
| 356 | private function _set_topic_visibility($check_visibility) |
||
| 357 | { |
||
| 358 | if ($check_visibility) |
||
| 359 | { |
||
| 360 | $this->store['sql_array']['WHERE'][] = $this->content_visibility->get_global_visibility_sql('topic', array_map('intval', $this->ex_fid_ary), 't.'); |
||
| 361 | } |
||
| 362 | } |
||
| 363 | |||
| 364 | /** |
||
| 365 | * @param bool $exclude_hidden_forums |
||
| 366 | * @return void |
||
| 367 | */ |
||
| 368 | private function _set_forum_table($exclude_hidden_forums) |
||
| 379 | } |
||
| 380 | } |
||
| 381 | |||
| 382 | /** |
||
| 383 | * Reset data |
||
| 384 | * @return void |
||
| 385 | */ |
||
| 386 | private function _reset() |
||
| 387 | { |
||
| 388 | $this->store = array( |
||
| 395 | ); |
||
| 396 | } |
||
| 397 | } |
||
| 398 |