Completed
Pull Request — master (#26)
by Daniel
13:38 queued 11:04
created
blocks/forum_topics.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 	{
109 109
 		$this->set_display_fields();
110 110
 
111
-		$view = 'S_' . strtoupper($this->settings['template']);
111
+		$view = 'S_'.strtoupper($this->settings['template']);
112 112
 		$post_data = $this->get_post_data($topic_data);
113 113
 		$topic_data = array_values($topic_data);
114 114
 
@@ -156,10 +156,10 @@  discard block
 block discarded – undo
156 156
 				'VIEWS'				=> (int) $row['topic_views'],
157 157
 				'S_UNREAD_TOPIC'	=> $this->is_unread_topic($forum_id, $topic_id, $row['topic_last_post_time']),
158 158
 
159
-				'U_VIEWTOPIC'		=> append_sid($this->phpbb_root_path . 'viewtopic.' . $this->php_ext, "f=$forum_id&t=$topic_id"),
160
-				'U_VIEWFORUM'		=> append_sid($this->phpbb_root_path . 'viewforum.' . $this->php_ext, "f=$forum_id"),
161
-				'U_NEW_POST'		=> append_sid($this->phpbb_root_path . 'viewtopic.' . $this->php_ext, "f=$forum_id&t=$topic_id&view=unread") . '#unread',
162
-				'U_LAST_POST'		=> append_sid($this->phpbb_root_path . 'viewtopic.' . $this->php_ext, "f=$forum_id&t=$topic_id&p=" . $row['topic_last_post_id']) . '#p' . $row['topic_last_post_id'],
159
+				'U_VIEWTOPIC'		=> append_sid($this->phpbb_root_path.'viewtopic.'.$this->php_ext, "f=$forum_id&t=$topic_id"),
160
+				'U_VIEWFORUM'		=> append_sid($this->phpbb_root_path.'viewforum.'.$this->php_ext, "f=$forum_id"),
161
+				'U_NEW_POST'		=> append_sid($this->phpbb_root_path.'viewtopic.'.$this->php_ext, "f=$forum_id&t=$topic_id&view=unread").'#unread',
162
+				'U_LAST_POST'		=> append_sid($this->phpbb_root_path.'viewtopic.'.$this->php_ext, "f=$forum_id&t=$topic_id&p=".$row['topic_last_post_id']).'#p'.$row['topic_last_post_id'],
163 163
 			));
164 164
 			unset($topic_data[$i], $post_data[$topic_id]);
165 165
 		}
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -257,8 +257,7 @@  discard block
 block discarded – undo
257 257
 		if ($this->settings['context'] && $this->settings['preview_chars'])
258 258
 		{
259 259
 			$post_data = $this->forum_data->get_post_data($this->settings['context']);
260
-		}
261
-		else
260
+		} else
262 261
 		{
263 262
 			$post_data = array_fill_keys(array_keys($topic_data), array(array('post_text' => '', 'bbcode_uid' => '', 'bbcode_bitfield' => '')));
264 263
 		}
@@ -277,8 +276,7 @@  discard block
 block discarded – undo
277 276
 			$this->fields['user_id'] = 'topic_last_poster_id';
278 277
 
279 278
 			$this->ptemplate->assign_var('L_POST_BY_AUTHOR', $this->translator->lang('LAST_POST_BY_AUTHOR'));
280
-		}
281
-		else
279
+		} else
282 280
 		{
283 281
 			$this->fields['time'] = 'topic_time';
284 282
 			$this->fields['user_id'] = 'topic_poster';
Please login to merge, or discard this patch.
blocks/stats.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,9 +45,9 @@
 block discarded – undo
45 45
 	public function display(array $settings, $edit_mode = false)
46 46
 	{
47 47
 		$content = '';
48
-		$content .= $this->translator->lang('TOTAL_POSTS_COUNT', (int) $this->config['num_posts']) . '<br />';
49
-		$content .= $this->translator->lang('TOTAL_TOPICS', (int) $this->config['num_topics']) . '<br />';
50
-		$content .= $this->translator->lang('TOTAL_USERS', (int) $this->config['num_users']) . '<br />';
48
+		$content .= $this->translator->lang('TOTAL_POSTS_COUNT', (int) $this->config['num_posts']).'<br />';
49
+		$content .= $this->translator->lang('TOTAL_TOPICS', (int) $this->config['num_topics']).'<br />';
50
+		$content .= $this->translator->lang('TOTAL_USERS', (int) $this->config['num_users']).'<br />';
51 51
 		$content .= $this->translator->lang('NEWEST_USER', get_username_string('full', $this->config['newest_user_id'], $this->config['newest_username'], $this->config['newest_user_colour']));
52 52
 
53 53
 		$this->template->assign_var('NEWEST_USER', false);
Please login to merge, or discard this patch.
exception/base.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -96,10 +96,10 @@
 block discarded – undo
96 96
 		foreach ($this->message_full as &$message)
97 97
 		{
98 98
 			// Attempt to translate each portion
99
-			$translated_message = $translator->lang('EXCEPTION_' . $message);
99
+			$translated_message = $translator->lang('EXCEPTION_'.$message);
100 100
 
101 101
 			// Check if translating did anything
102
-			if ($translated_message !== 'EXCEPTION_' . $message)
102
+			if ($translated_message !== 'EXCEPTION_'.$message)
103 103
 			{
104 104
 				// It did, so replace message with the translated version
105 105
 				$message = $translated_message;
Please login to merge, or discard this patch.
services/groups.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 	public function get_users_groups()
41 41
 	{
42 42
 		$sql = 'SELECT group_id
43
-			FROM ' . USER_GROUP_TABLE . '
43
+			FROM ' . USER_GROUP_TABLE.'
44 44
 			WHERE user_id = ' . (int) $this->user->data['user_id'];
45 45
 		$result = $this->db->sql_query($sql);
46 46
 
@@ -83,13 +83,13 @@  discard block
 block discarded – undo
83 83
 		$sql = $this->_get_group_sql($mode);
84 84
 		$result = $this->db->sql_query($sql);
85 85
 
86
-		$options = '<option value="0">' . $this->translator->lang('ALL_GROUPS') . '</option>';
86
+		$options = '<option value="0">'.$this->translator->lang('ALL_GROUPS').'</option>';
87 87
 		while ($row = $this->db->sql_fetchrow($result))
88 88
 		{
89 89
 			$group_name = $this->_get_group_name($row);
90 90
 			$group_class = $this->_get_group_class($row['group_type']);
91 91
 			$selected_option = $this->_get_selected_option($row['group_id'], $selected);
92
-			$options .= '<option' . $group_class . ' value="' . $row['group_id'] . '"' . $selected_option . '>' . $group_name . '</option>';
92
+			$options .= '<option'.$group_class.' value="'.$row['group_id'].'"'.$selected_option.'>'.$group_name.'</option>';
93 93
 		}
94 94
 		$this->db->sql_freeresult($result);
95 95
 
@@ -103,8 +103,8 @@  discard block
 block discarded – undo
103 103
 	private function _get_group_sql($mode)
104 104
 	{
105 105
 		return 'SELECT group_id, group_name, group_type
106
-			FROM ' . GROUPS_TABLE .
107
-			(($mode === 'special') ? ' WHERE group_type = ' . GROUP_SPECIAL : '') . '
106
+			FROM ' . GROUPS_TABLE.
107
+			(($mode === 'special') ? ' WHERE group_type = '.GROUP_SPECIAL : '').'
108 108
 			ORDER BY group_type DESC, group_name ASC';
109 109
 	}
110 110
 
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 	 */
115 115
 	private function _get_group_name(array $row)
116 116
 	{
117
-		return ($row['group_type'] == GROUP_SPECIAL) ? $this->translator->lang('G_' . $row['group_name']) : ucfirst($row['group_name']);
117
+		return ($row['group_type'] == GROUP_SPECIAL) ? $this->translator->lang('G_'.$row['group_name']) : ucfirst($row['group_name']);
118 118
 	}
119 119
 
120 120
 	/**
Please login to merge, or discard this patch.
services/members.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 		// @codeCoverageIgnoreStart
64 64
 		if (!function_exists('phpbb_get_user_avatar'))
65 65
 		{
66
-			include($phpbb_root_path . 'includes/functions_display.' . $php_ext);
66
+			include($phpbb_root_path.'includes/functions_display.'.$php_ext);
67 67
 		}
68 68
 		// @codeCoverageIgnoreEnd
69 69
 	}
@@ -101,8 +101,8 @@  discard block
 block discarded – undo
101 101
 	 */
102 102
 	protected function member_posts(array $row)
103 103
 	{
104
-		$u_posts = append_sid($this->phpbb_root_path . 'search.' . $this->php_ext, "author_id={$row['user_id']}&amp;sr=posts" . $this->explain_range);
105
-		$user_posts = '<a href="' . $u_posts . '">' . $row['user_posts'] . '</a>';
104
+		$u_posts = append_sid($this->phpbb_root_path.'search.'.$this->php_ext, "author_id={$row['user_id']}&amp;sr=posts".$this->explain_range);
105
+		$user_posts = '<a href="'.$u_posts.'">'.$row['user_posts'].'</a>';
106 106
 
107 107
 		return array(
108 108
 			'USERNAME'		=> get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 			'WHERE'			=> $this->db->sql_in_set('u.user_type', array(USER_NORMAL, USER_FOUNDER)),
171 171
 		);
172 172
 
173
-		$sql_method = 'set_' . $this->settings['query_type'] . '_sql';
173
+		$sql_method = 'set_'.$this->settings['query_type'].'_sql';
174 174
 		call_user_func_array(array($this, $sql_method), array(&$sql_ary));
175 175
 
176 176
 		$this->set_range_sql($sql_ary);
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 	protected function set_visits_sql(array &$sql_ary)
185 185
 	{
186 186
 		$sql_ary['SELECT'] .= ', u.user_lastvisit as member_date';
187
-		$sql_ary['WHERE'] .= ' AND u.user_lastvisit <> 0 AND u.user_id <> ' . (int) $this->user->data['user_id'];
187
+		$sql_ary['WHERE'] .= ' AND u.user_lastvisit <> 0 AND u.user_id <> '.(int) $this->user->data['user_id'];
188 188
 		$sql_ary['ORDER_BY'] = 'u.user_lastvisit DESC';
189 189
 
190 190
 		$this->sql_date_field = 'user_lastvisit';
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
 		$this->info_header = '';
201 201
 		$this->view_mode = 'member_bots';
202 202
 
203
-		$sql_ary['WHERE'] = 'u.user_type = ' . USER_IGNORE;
203
+		$sql_ary['WHERE'] = 'u.user_type = '.USER_IGNORE;
204 204
 	}
205 205
 
206 206
 	/**
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
 	protected function set_tenured_sql(array &$sql_ary)
210 210
 	{
211 211
 		$sql_ary['SELECT'] .= ', u.user_regdate as member_date';
212
-		$sql_ary['ORDER_BY'] = 'u.user_regdate ' . (($this->settings['query_type'] == 'tenured') ? 'ASC' : 'DESC');
212
+		$sql_ary['ORDER_BY'] = 'u.user_regdate '.(($this->settings['query_type'] == 'tenured') ? 'ASC' : 'DESC');
213 213
 
214 214
 		$this->sql_date_field = 'u.user_regdate';
215 215
 		$this->settings['date_range'] = '';
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
 		$sql_ary['SELECT'] .= ', COUNT(p.post_id) as user_posts';
233 233
 		$sql_ary['FROM'] += array(TOPICS_TABLE => 't');
234 234
 		$sql_ary['FROM'] += array(POSTS_TABLE => 'p');
235
-		$sql_ary['WHERE'] .= ' AND ' . time() . ' > t.topic_time AND t.topic_id = p.topic_id AND p.post_visibility = ' . ITEM_APPROVED . ' AND p.poster_id = u.user_id';
235
+		$sql_ary['WHERE'] .= ' AND '.time().' > t.topic_time AND t.topic_id = p.topic_id AND p.post_visibility = '.ITEM_APPROVED.' AND p.poster_id = u.user_id';
236 236
 		$sql_ary['GROUP_BY'] = 'u.user_id';
237 237
 		$sql_ary['ORDER_BY'] = 'user_posts DESC, u.username ASC';
238 238
 
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
 		if ($this->settings['date_range'] && $this->sql_date_field)
250 250
 		{
251 251
 			$range = $this->date_range->get($this->settings['date_range']);
252
-			$this->explain_range = '&amp;date=' . $range['date'];
252
+			$this->explain_range = '&amp;date='.$range['date'];
253 253
 
254 254
 			$sql_ary['WHERE'] .= " AND {$this->sql_date_field} BETWEEN {$range['start']} AND {$range['stop']}";
255 255
 		}
Please login to merge, or discard this patch.
services/blocks/action/base_action.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -144,8 +144,7 @@
 block discarded – undo
144 144
 		{
145 145
 			$content = $this->translator->lang('BLOCK_NO_DATA');
146 146
 			$returned_data['status'] = 0;
147
-		}
148
-		else
147
+		} else
149 148
 		{
150 149
 			$content = $returned_data['content'];
151 150
 		}
Please login to merge, or discard this patch.
services/blocks/action/save_blocks.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -118,8 +118,7 @@
 block discarded – undo
118 118
 		if (!$has_blocks && !$this->route_is_customized($entity->to_array()))
119 119
 		{
120 120
 			$this->route_mapper->delete($entity);
121
-		}
122
-		else
121
+		} else
123 122
 		{
124 123
 			$entity->set_has_blocks($has_blocks);
125 124
 			$this->route_mapper->save($entity);
Please login to merge, or discard this patch.
services/blocks/blocks.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -154,8 +154,7 @@
 block discarded – undo
154 154
 		if (!empty($returned_data['content']))
155 155
 		{
156 156
 			$content = $returned_data['content'];
157
-		}
158
-		else if ($edit_mode)
157
+		} else if ($edit_mode)
159 158
 		{
160 159
 			$returned_data['status'] = 0;
161 160
 			$content = $this->translator->lang('BLOCK_NO_DATA');
Please login to merge, or discard this patch.
services/blocks/admin_bar.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -96,13 +96,13 @@  discard block
 block discarded – undo
96 96
 	public function set_javascript_data($route, $style_id)
97 97
 	{
98 98
 		$board_url = generate_board_url();
99
-		$ajax_url = $board_url . ((!$this->config['enable_mod_rewrite']) ? '/app.' . $this->php_ext : '');
99
+		$ajax_url = $board_url.((!$this->config['enable_mod_rewrite']) ? '/app.'.$this->php_ext : '');
100 100
 
101 101
 		$is_default_route = $u_default_route = false;
102 102
 		if ($this->config['sitemaker_default_layout'])
103 103
 		{
104 104
 			$is_default_route = ($this->config['sitemaker_default_layout'] === $route) ? true : false;
105
-			$u_default_route .= $board_url . '/' . $this->config['sitemaker_default_layout'];
105
+			$u_default_route .= $board_url.'/'.$this->config['sitemaker_default_layout'];
106 106
 			$u_default_route = reapply_sid($u_default_route);
107 107
 		}
108 108
 
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 			list($controller_service, $controller_method) = explode(':', $controller);
151 151
 			$controller_params	= $symfony_request->attributes->get('_route_params');
152 152
 			$controller_object	= $this->phpbb_container->get($controller_service);
153
-			$controller_class	= get_class($controller_object);
153
+			$controller_class = get_class($controller_object);
154 154
 
155 155
 			$r = new \ReflectionMethod($controller_class, $controller_method);
156 156
 			$class_params = $r->getParameters();
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 				'CONTROLLER_METHOD'	=> $controller_method,
164 164
 				'CONTROLLER_PARAMS'	=> $controller_arguments,
165 165
 				'S_IS_STARTPAGE'	=> $this->is_startpage($controller_service, $controller_arguments),
166
-				'UA_EXTENSION'		=> $namespace . '/' . $extension,
166
+				'UA_EXTENSION'		=> $namespace.'/'.$extension,
167 167
 			));
168 168
 		}
169 169
 	}
@@ -198,11 +198,11 @@  discard block
 block discarded – undo
198 198
 	{
199 199
 		$routes_ary = $this->get_routes();
200 200
 
201
-		$options = '<option value="">' . $this->translator->lang('SELECT') . '</option>';
201
+		$options = '<option value="">'.$this->translator->lang('SELECT').'</option>';
202 202
 		foreach ($routes_ary as $route)
203 203
 		{
204 204
 			$selected = ($route == $current_route) ? ' selected="selected"' : '';
205
-			$options .= '<option value="' . $route . '"' . $selected . '>' . $route . '</option>';
205
+			$options .= '<option value="'.$route.'"'.$selected.'>'.$route.'</option>';
206 206
 		}
207 207
 
208 208
 		return $options;
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 		$options = '';
220 220
 		foreach ($ex_positions as $position)
221 221
 		{
222
-			$options .= '<option value="' . $position . '" selected="selected">' . $position . '</option>';
222
+			$options .= '<option value="'.$position.'" selected="selected">'.$position.'</option>';
223 223
 		}
224 224
 
225 225
 		return $options;
Please login to merge, or discard this patch.