Completed
Pull Request — master (#26)
by Daniel
16:46 queued 14:37
created
services/menus/display.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 	 * @param string $handle
71 71
 	 * @return void
72 72
 	 */
73
-	public function display_navlist(array $data, \phpbb\template\twig\twig &$template, $handle = 'tree')
73
+	public function display_navlist(array $data, \phpbb\template\twig\twig & $template, $handle = 'tree')
74 74
 	{
75 75
 		$this->set_current_item($data);
76 76
 		$this->prepare_items($data['items']);
@@ -85,10 +85,10 @@  discard block
 block discarded – undo
85 85
 				$row['num_kids'] = $this->count_descendants($row);
86 86
 
87 87
 				$template->assign_block_vars($handle, array_change_key_case($row, CASE_UPPER));
88
-				$this->close_open_tags($template, $handle . '.close', abs($prev_depth - $this_depth));
88
+				$this->close_open_tags($template, $handle.'.close', abs($prev_depth - $this_depth));
89 89
 			}
90 90
 
91
-			$this->close_open_tags($template, 'close_' . $handle, ($this_depth - $this->min_depth));
91
+			$this->close_open_tags($template, 'close_'.$handle, ($this_depth - $this->min_depth));
92 92
 		}
93 93
 	}
94 94
 
@@ -156,12 +156,12 @@  discard block
 block discarded – undo
156 156
 	 */
157 157
 	protected function get_current_path()
158 158
 	{
159
-		$curr_page = '/' . ltrim($this->user->page['page_dir'] . '/' . $this->user->page['page_name'], './');
159
+		$curr_page = '/'.ltrim($this->user->page['page_dir'].'/'.$this->user->page['page_name'], './');
160 160
 		$curr_parts = explode('&', $this->user->page['query_string']);
161 161
 
162 162
 		sort($curr_parts);
163 163
 
164
-		return $curr_page . '?' . join('&', $curr_parts);
164
+		return $curr_page.'?'.join('&', $curr_parts);
165 165
 	}
166 166
 
167 167
 	/**
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 
204 204
 			$is_current_item = $this->is_current_item($row);
205 205
 			$is_parent = $this->is_parent_of_current_item($row);
206
-			$this_depth	= $this->parental_depth[$row['parent_id']] + 1;
206
+			$this_depth = $this->parental_depth[$row['parent_id']] + 1;
207 207
 			$leaf = $this->get_leaf_node($row, $is_current_item, $is_parent);
208 208
 
209 209
 			$this->parental_depth[$row[$this->pk]] = $this_depth;
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
 	 * @param int $repeat
285 285
 	 * @return void
286 286
 	 */
287
-	protected function close_open_tags(\phpbb\template\twig\twig &$template, $handle, $repeat)
287
+	protected function close_open_tags(\phpbb\template\twig\twig & $template, $handle, $repeat)
288 288
 	{
289 289
 		for ($i = 0; $i < $repeat; $i++)
290 290
 		{
Please login to merge, or discard this patch.
blocks/whois.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,6 +105,6 @@
 block discarded – undo
105 105
 	 */
106 106
 	private function get_viewonline_url()
107 107
 	{
108
-		return ($this->auth->acl_gets('u_viewprofile', 'a_user', 'a_useradd', 'a_userdel')) ? append_sid("{$this->phpbb_root_path}viewonline." . $this->php_ext) : '';
108
+		return ($this->auth->acl_gets('u_viewprofile', 'a_user', 'a_useradd', 'a_userdel')) ? append_sid("{$this->phpbb_root_path}viewonline.".$this->php_ext) : '';
109 109
 	}
110 110
 }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,8 +69,7 @@
 block discarded – undo
69 69
 		if ($data['TOTAL_USERS_ONLINE'])
70 70
 		{
71 71
 			list($l_online_users, $online_userlist, $l_online_record) = array_values($data);
72
-		}
73
-		else
72
+		} else
74 73
 		{
75 74
 			$item_id = 0;
76 75
 			$item = 'forum';
Please login to merge, or discard this patch.
services/filemanager/setup.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,6 +59,6 @@
 block discarded – undo
59 59
 	 */
60 60
 	public function get_access_key()
61 61
 	{
62
-		return sha1($this->user->data['user_form_salt'] . 'filemanager');
62
+		return sha1($this->user->data['user_form_salt'].'filemanager');
63 63
 	}
64 64
 }
Please login to merge, or discard this patch.
services/forum/query_builder.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 			$this->store['sql_array']['SELECT'][] = 'ws.notify_status';
166 166
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
167 167
 				'FROM'	=> array($keys[$type]['table'] => 'ws'),
168
-				'ON'	=> $keys[$type]['cond'] . ' AND ws.user_id = ' . (int) $this->user->data['user_id'],
168
+				'ON'	=> $keys[$type]['cond'].' AND ws.user_id = '.(int) $this->user->data['user_id'],
169 169
 			);
170 170
 		}
171 171
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 			$this->store['sql_array']['SELECT'][] = 'bm.topic_id as bookmarked';
185 185
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
186 186
 				'FROM'	=> array(BOOKMARKS_TABLE => 'bm'),
187
-				'ON'	=> 'bm.user_id = ' . (int) $this->user->data['user_id'] . ' AND t.topic_id = bm.topic_id'
187
+				'ON'	=> 'bm.user_id = '.(int) $this->user->data['user_id'].' AND t.topic_id = bm.topic_id'
188 188
 			);
189 189
 		}
190 190
 
@@ -205,12 +205,12 @@  discard block
 block discarded – undo
205 205
 			$this->store['sql_array']['SELECT'][] = 'tt.mark_time, ft.mark_time as forum_mark_time';
206 206
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
207 207
 				'FROM'	=> array(TOPICS_TRACK_TABLE => 'tt'),
208
-				'ON'	=> 'tt.user_id = ' . (int) $this->user->data['user_id'] . ' AND t.topic_id = tt.topic_id'
208
+				'ON'	=> 'tt.user_id = '.(int) $this->user->data['user_id'].' AND t.topic_id = tt.topic_id'
209 209
 			);
210 210
 
211 211
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
212 212
 				'FROM'	=> array(FORUMS_TRACK_TABLE => 'ft'),
213
-				'ON'	=> 'ft.user_id = ' . (int) $this->user->data['user_id'] . ' AND t.forum_id = ft.forum_id'
213
+				'ON'	=> 'ft.user_id = '.(int) $this->user->data['user_id'].' AND t.forum_id = ft.forum_id'
214 214
 			);
215 215
 		}
216 216
 
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
 	{
230 230
 		if ($unix_start_time && $unix_stop_time)
231 231
 		{
232
-			$this->store['sql_array']['WHERE'][] = (($mode == 'topic') ? 't.topic_time' : 'p.post_time') . " BETWEEN $unix_start_time AND $unix_stop_time";
232
+			$this->store['sql_array']['WHERE'][] = (($mode == 'topic') ? 't.topic_time' : 'p.post_time')." BETWEEN $unix_start_time AND $unix_stop_time";
233 233
 		}
234 234
 
235 235
 		return $this;
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 	 */
269 269
 	public function set_sorting($sort_key, $sort_dir = 'DESC')
270 270
 	{
271
-		$this->store['sql_array']['ORDER_BY'] = $sort_key . ' ' . $sort_dir;
271
+		$this->store['sql_array']['ORDER_BY'] = $sort_key.' '.$sort_dir;
272 272
 
273 273
 		return $this;
274 274
 	}
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
 	{
337 337
 		if (!empty($column_id))
338 338
 		{
339
-			$this->store['sql_array']['WHERE'][] = (is_array($column_id)) ? $this->db->sql_in_set($column, $column_id) : $column . ' = ' . (int) $column_id;
339
+			$this->store['sql_array']['WHERE'][] = (is_array($column_id)) ? $this->db->sql_in_set($column, $column_id) : $column.' = '.(int) $column_id;
340 340
 		}
341 341
 	}
342 342
 
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
 	{
349 349
 		if ($check_visibility)
350 350
 		{
351
-			$this->store['sql_array']['WHERE'][] = 't.topic_time <= ' . (int) $this->time();
351
+			$this->store['sql_array']['WHERE'][] = 't.topic_time <= '.(int) $this->time();
352 352
 			$this->store['sql_array']['WHERE'][] = $this->content_visibility->get_global_visibility_sql('topic', array_map('intval', $this->ex_fid_ary), 't.');
353 353
 		}
354 354
 	}
Please login to merge, or discard this patch.
blocks/wordgraph.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -110,8 +110,8 @@  discard block
 block discarded – undo
110 110
 			$this->ptemplate->assign_block_vars('wordgraph', array(
111 111
 				'WORD'			=> $this->show_word($word, $words_array[$word], $settings['show_word_count']),
112 112
 				'WORD_SIZE'		=> $settings['min_word_size'] + (($words_array[$word] - $params['min_count']) * $params['size_step']),
113
-				'WORD_COLOR'	=> $r . $g . $b,
114
-				'WORD_URL'		=> append_sid("{$this->phpbb_root_path}search.$this->php_ext", 'keywords=' . urlencode($word)),
113
+				'WORD_COLOR'	=> $r.$g.$b,
114
+				'WORD_URL'		=> append_sid("{$this->phpbb_root_path}search.$this->php_ext", 'keywords='.urlencode($word)),
115 115
 			));
116 116
 		}
117 117
 	}
@@ -188,8 +188,8 @@  discard block
 block discarded – undo
188 188
 				AND m.word_id = l.word_id
189 189
 				AND m.post_id = p.post_id
190 190
 				AND t.topic_id = p.topic_id
191
-				AND t.topic_time <= ' . time() . '
192
-				AND ' . $this->content_visibility->get_global_visibility_sql('topic', array_map('intval', array_keys($this->auth->acl_getf('!f_read', true))), 't.') .
191
+				AND t.topic_time <= ' . time().'
192
+				AND ' . $this->content_visibility->get_global_visibility_sql('topic', array_map('intval', array_keys($this->auth->acl_getf('!f_read', true))), 't.').
193 193
 				$sql_where,
194 194
 			'GROUP_BY'	=> 'l.word_text, l.word_count',
195 195
 			'ORDER_BY'	=> 'l.word_count DESC'
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 		if ($exclude_words)
207 207
 		{
208 208
 			$exclude_words = array_filter(explode(',', str_replace(' ', '', strtolower($exclude_words))));
209
-			$sql_where = (sizeof($exclude_words)) ? ' AND ' . $this->db->sql_in_set('l.word_text', $exclude_words, true) : '';
209
+			$sql_where = (sizeof($exclude_words)) ? ' AND '.$this->db->sql_in_set('l.word_text', $exclude_words, true) : '';
210 210
 		}
211 211
 
212 212
 		return $sql_where;
@@ -220,6 +220,6 @@  discard block
 block discarded – undo
220 220
 	 */
221 221
 	private function show_word($word, $count, $show_count)
222 222
 	{
223
-		return censor_text(($show_count) ? $word . '(' . $count . ')' : $word);
223
+		return censor_text(($show_count) ? $word.'('.$count.')' : $word);
224 224
 	}
225 225
 }
Please login to merge, or discard this patch.
services/blocks/admin_bar.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 		if ($this->config['sitemaker_default_layout'])
116 116
 		{
117 117
 			$is_default_route = ($this->config['sitemaker_default_layout'] === $route) ? true : false;
118
-			$u_default_route .= $board_url . '/' . $this->config['sitemaker_default_layout'];
118
+			$u_default_route .= $board_url.'/'.$this->config['sitemaker_default_layout'];
119 119
 			$u_default_route = reapply_sid($u_default_route);
120 120
 		}
121 121
 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
 			list($controller_service, $controller_method) = explode(':', $controller);
196 196
 			$controller_params	= $symfony_request->attributes->get('_route_params');
197 197
 			$controller_object	= $this->phpbb_container->get($controller_service);
198
-			$controller_class	= get_class($controller_object);
198
+			$controller_class = get_class($controller_object);
199 199
 
200 200
 			$r = new \ReflectionMethod($controller_class, $controller_method);
201 201
 			$class_params = $r->getParameters();
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
 				'CONTROLLER_METHOD'	=> $controller_method,
209 209
 				'CONTROLLER_PARAMS'	=> $controller_arguments,
210 210
 				'S_IS_STARTPAGE'	=> $this->is_startpage($controller_service, $controller_arguments),
211
-				'UA_EXTENSION'		=> $namespace . '/' . $extension,
211
+				'UA_EXTENSION'		=> $namespace.'/'.$extension,
212 212
 			));
213 213
 		}
214 214
 	}
@@ -243,11 +243,11 @@  discard block
 block discarded – undo
243 243
 	{
244 244
 		$routes_ary = $this->get_routes();
245 245
 
246
-		$options = '<option value="">' . $this->translator->lang('SELECT') . '</option>';
246
+		$options = '<option value="">'.$this->translator->lang('SELECT').'</option>';
247 247
 		foreach ($routes_ary as $route)
248 248
 		{
249 249
 			$selected = ($route == $current_route) ? ' selected="selected"' : '';
250
-			$options .= '<option value="' . $route . '"' . $selected . '>' . $route . '</option>';
250
+			$options .= '<option value="'.$route.'"'.$selected.'>'.$route.'</option>';
251 251
 		}
252 252
 
253 253
 		return $options;
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
 		$options = '';
265 265
 		foreach ($ex_positions as $position)
266 266
 		{
267
-			$options .= '<option value="' . $position . '" selected="selected">' . $position . '</option>';
267
+			$options .= '<option value="'.$position.'" selected="selected">'.$position.'</option>';
268 268
 		}
269 269
 
270 270
 		return $options;
Please login to merge, or discard this patch.
services/filemanager/settings.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 		$this->config_path = $config_path;
40 40
 		$this->php_ext = $php_ext;
41 41
 
42
-		$this->config_template = __DIR__ . '/default.config';
42
+		$this->config_template = __DIR__.'/default.config';
43 43
 	}
44 44
 
45 45
 	/**
@@ -109,6 +109,6 @@  discard block
 block discarded – undo
109 109
 	 */
110 110
 	protected function get_config_file()
111 111
 	{
112
-		return $this->config_path . 'config.' . $this->php_ext;
112
+		return $this->config_path.'config.'.$this->php_ext;
113 113
 	}
114 114
 }
Please login to merge, or discard this patch.
acp/settings_module.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 
154 154
 			$this->save_filemanager_settings();
155 155
 			$this->save_config_settings($settings);
156
-			$this->trigger_error($this->translator->lang('SETTINGS_SAVED') . adm_back_link($this->u_action));
156
+			$this->trigger_error($this->translator->lang('SETTINGS_SAVED').adm_back_link($this->u_action));
157 157
 		}
158 158
 	}
159 159
 
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 	{
177 177
 		$style_prefs = (array) json_decode($this->config_text->get('sm_layout_prefs'), true);
178 178
 
179
-		$result = $this->db->sql_query('SELECT style_id, style_name FROM ' . STYLES_TABLE);
179
+		$result = $this->db->sql_query('SELECT style_id, style_name FROM '.STYLES_TABLE);
180 180
 
181 181
 		$styles = array();
182 182
 		while ($row = $this->db->sql_fetchrow($result))
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
 			$path = dirname($path);
246 246
 			$name = basename($path);
247 247
 
248
-			$layouts[$name] = $this->phpbb_root_path . $path . '/';
248
+			$layouts[$name] = $this->phpbb_root_path.$path.'/';
249 249
 		}
250 250
 		ksort($layouts);
251 251
 
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
 			$id = $entity->get_menu_id();
302 302
 			$name = $entity->get_menu_name();
303 303
 			$selected = ($id == $this->config['sm_navbar_menu']) ? ' selected="selected"' : '';
304
-			$options .= '<option value="' . $id . '"' . $selected . '>' . $name . '</option>';
304
+			$options .= '<option value="'.$id.'"'.$selected.'>'.$name.'</option>';
305 305
 		}
306 306
 
307 307
 		return $options;
Please login to merge, or discard this patch.
acp/menu_module.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 			'MENU_ID'		=> $menu_id,
97 97
 			'ICON_PICKER'	=> $this->icon->picker(),
98 98
 			'T_PATH'		=> $this->phpbb_root_path,
99
-			'UA_AJAX_URL'   => $this->controller_helper->route('blitze_sitemaker_menus_admin', array(), true, '') . '/',
99
+			'UA_AJAX_URL'   => $this->controller_helper->route('blitze_sitemaker_menus_admin', array(), true, '').'/',
100 100
 		));
101 101
 
102 102
 		$this->tpl_name = 'acp_menu';
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 		$vars = array('bulk_options', 'forumslist');
151 151
 		extract($this->phpbb_dispatcher->trigger_event('blitze.sitemaker.acp_add_bulk_menu_options', compact($vars)));
152 152
 
153
-		$bulk_options['FORUMS']	= $this->get_forums_string($forumslist);
153
+		$bulk_options['FORUMS'] = $this->get_forums_string($forumslist);
154 154
 
155 155
 		$this->template->assign_var('bulk_options', $bulk_options);
156 156
 	}
@@ -161,11 +161,11 @@  discard block
 block discarded – undo
161 161
 	 */
162 162
 	protected function get_forums_string(array $forumslist)
163 163
 	{
164
-		$text = $this->language->lang('FORUM') . "|app.{$this->php_ext}/forum\n";
164
+		$text = $this->language->lang('FORUM')."|app.{$this->php_ext}/forum\n";
165 165
 		foreach ($forumslist as $forum_id => $row)
166 166
 		{
167
-			$text .= "\t" . str_replace('&nbsp; &nbsp;', "\t", $row['padding']);
168
-			$text .= $row['forum_name'] . '|';
167
+			$text .= "\t".str_replace('&nbsp; &nbsp;', "\t", $row['padding']);
168
+			$text .= $row['forum_name'].'|';
169 169
 			$text .= "viewforum.{$this->php_ext}?f=$forum_id\n";
170 170
 		}
171 171
 
Please login to merge, or discard this patch.