blitze / phpBB-ext-sitemaker

ext.php

<?php
/**
 *
 * @package sitemaker
 * @copyright (c) 2013 Daniel A. (blitze)
 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
 *
 */

namespace blitze\sitemaker;

class ext extends \phpbb\extension\base
{
	/**
	 * Check whether or not the extension can be enabled.
	 *
	 * @return bool
	 */
	public function is_enableable()
	{
		$user = $this->container->get('user');
		$user->add_lang_ext('blitze/sitemaker', 'ext');

		$lang = $user->lang;
		$metadata = $this->get_metadata('blitze/sitemaker');

		$req_phpbb_version = $metadata['extra']['soft-require']['phpbb/phpbb'];
		$phpbb_version = $this->container->get('config')['version'];
		$is_enableable = $this->version_is_ok($phpbb_version, $req_phpbb_version);

		if (!$is_enableable)
		{
			$lang['EXTENSION_NOT_ENABLEABLE'] .= '<br>' . $user->lang('PHPBB_VERSION_UNMET', $req_phpbb_version);
		}

		$user->lang = $lang;
		return $is_enableable;
	}

	/**
	 * @param string $current_version
	 * @param string $required_version
	 * @return bool
	 */
	protected function version_is_ok($current_version, &$required_version)
	{
		$required_version = html_entity_decode($required_version);
		list($min_req_version, $max_req_version) = explode(',', $required_version);

		$contraint = $this->get_version_constraint($min_req_version);
		if (!phpbb_version_compare($current_version, $contraint['version'], $contraint['operator']))
		{
			return false;
		}

		$contraint = $this->get_version_constraint($max_req_version);
		if ($constraint['version'] && !phpbb_version_compare($current_version, $contraint['version'], $contraint['operator']))

The variable $constraint does not exist. Did you maybe mean $contraint?

		{
			return false;
		}

		return true;
	}

	/**
	 * @param string $version
	 * @return array
	 */
	protected function get_version_constraint($version)
	{
		if (preg_match('/^(\D+)(.+)/i', trim($version), $matches))
		{
			list(, $operator, $version) = $matches;
		}

		return [
			'version' => str_replace('@', '', $version),
			'operator' => $operator ?: '>=',

The variable $operator does not seem to be defined for all execution paths leading up to this point.

		];
	}

	/**
	 * Get composer metadata information
	 *
	 * @param string $name
	 * @param string $element
	 * @return array
	 */
	protected function get_metadata($name, $element = 'all')
	{
		$ext_manager = $this->container->get('ext.manager');
		$metadata_manager = $ext_manager->create_extension_metadata_manager($name);
		return $metadata_manager->get_metadata($element);
	}
}