blitze\sitemaker\migrations\converter\c1_remove_modules

Complexity

Total Complexity

3

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	update_data()	0	22	3

<?php
/**
 *
 * @package sitemaker
 * @copyright (c) 2013 Daniel A. (blitze)
 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
 *
 */

namespace blitze\sitemaker\migrations\converter;

class c1_remove_modules extends \phpbb\db\migration\migration
{
	/**
	 * This does not work when uninstalling for some reason
	 *
	 * Skip this migration if the module_dir column does not exist
	 *
	 * @return bool True to skip this migration, false to run it
	 * @access public
	 *
	public function effectively_installed()
	{
		return !$this->db_tools->sql_column_exists($this->table_prefix . 'modules', 'module_dir');
	}
	*/

	public function update_data()
	{
		if (!$this->db_tools->sql_column_exists($this->table_prefix . 'modules', 'module_dir'))
		{
			return array();

The expression return array() returns the type array which is incompatible with the documented return type boolean.

		}

		$sql = 'SELECT *
			FROM ' . $this->table_prefix . "modules
			WHERE module_dir <> ''
				OR " . $this->db->sql_in_set('module_langname', array('CMS', 'GCP', 'GRP', 'PRO')) . '
			ORDER BY right_id ASC';
		$result = $this->db->sql_query($sql);

		$migrations_ary = array();
		while ($row = $this->db->sql_fetchrow($result))
		{
			$migrations_ary[] = array('module.remove', array($row['module_class'], $row['parent_id'], $row['module_id']));
		}
		$this->db->sql_freeresult($result);

		return $migrations_ary;

The expression return $migrations_ary returns the type array|array<mixed,array<integer,array|string>> which is incompatible with the documented return type boolean.

	}
}