Total Complexity | 46 |
Total Lines | 369 |
Duplicated Lines | 0 % |
Changes | 3 | ||
Bugs | 0 | Features | 0 |
Complex classes like routes often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use routes, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
12 | class routes |
||
13 | { |
||
14 | /** @var \phpbb\cache\driver\driver_interface */ |
||
15 | protected $cache; |
||
16 | |||
17 | /** @var \phpbb\config\config */ |
||
18 | protected $config; |
||
19 | |||
20 | /** @var \blitze\sitemaker\services\blocks\factory */ |
||
21 | protected $block_factory; |
||
22 | |||
23 | /** @var \blitze\sitemaker\model\mapper_factory */ |
||
24 | protected $mapper_factory; |
||
25 | |||
26 | /** @var string */ |
||
27 | protected $php_ext; |
||
28 | |||
29 | /** @var bool */ |
||
30 | protected $is_sub_route = false; |
||
31 | |||
32 | /** |
||
33 | * Constructor |
||
34 | * |
||
35 | * @param \phpbb\cache\driver\driver_interface $cache Cache driver interface |
||
36 | * @param \phpbb\config\config $config Config object |
||
37 | * @param \blitze\sitemaker\services\blocks\factory $block_factory Blocks factory object |
||
38 | * @param \blitze\sitemaker\model\mapper_factory $mapper_factory Mapper factory object |
||
39 | * @param string $php_ext phpEx |
||
40 | */ |
||
41 | public function __construct(\phpbb\cache\driver\driver_interface $cache, \phpbb\config\config $config, \blitze\sitemaker\services\blocks\factory $block_factory, \blitze\sitemaker\model\mapper_factory $mapper_factory, $php_ext) |
||
48 | } |
||
49 | |||
50 | /** |
||
51 | * @param string $current_route |
||
52 | * @param string $page_dir |
||
53 | * @param int $style_id |
||
54 | * @param bool $edit_mode |
||
55 | * @return array |
||
56 | */ |
||
57 | public function get_route_info($current_route, $page_dir, $style_id, $edit_mode = false) |
||
58 | { |
||
59 | $routes = $this->get_routes_for_style($style_id); |
||
60 | $current_route = str_replace('viewtopic.' . $this->php_ext, 'viewforum.' . $this->php_ext, $current_route); |
||
61 | $route_info = array(); |
||
62 | |||
63 | // does route have own settings? |
||
64 | if (isset($routes[$current_route])) |
||
65 | { |
||
66 | $route_info = $routes[$current_route]; |
||
67 | } |
||
68 | |||
69 | if ($edit_mode) |
||
70 | { |
||
71 | $route_info += $this->get_default_route_info($current_route, $style_id); |
||
72 | return $route_info; |
||
73 | } |
||
74 | |||
75 | return $this->inherit_route_info($routes, $route_info, $current_route, $page_dir, $style_id); |
||
76 | } |
||
77 | |||
78 | /** |
||
79 | * @param array $route_info |
||
80 | * @param int $style_id |
||
81 | * @param bool $edit_mode |
||
82 | * @return array |
||
83 | */ |
||
84 | public function get_blocks_for_route(array $route_info, $style_id, $edit_mode) |
||
85 | { |
||
86 | $blocks = $this->get_cached_blocks($edit_mode); |
||
87 | $route_id = $route_info['route_id']; |
||
88 | |||
89 | return (isset($blocks[$style_id][$route_id])) ? $blocks[$style_id][$route_id] : array(); |
||
90 | } |
||
91 | |||
92 | /** |
||
93 | * @param array $df_settings |
||
94 | * @param array $db_settings |
||
95 | * @return array |
||
96 | */ |
||
97 | public function sync_settings(array $df_settings, array $db_settings = array()) |
||
98 | { |
||
99 | $settings = array(); |
||
100 | foreach ($df_settings as $field => $vars) |
||
101 | { |
||
102 | if (!is_array($vars)) |
||
103 | { |
||
104 | continue; |
||
105 | } |
||
106 | $settings[$field] = $vars['default']; |
||
107 | } |
||
108 | |||
109 | return array_merge($settings, array_intersect_key($db_settings, $settings)); |
||
110 | } |
||
111 | |||
112 | /** |
||
113 | * Clear blocks cache |
||
114 | */ |
||
115 | public function clear_cache() |
||
116 | { |
||
117 | $this->cache->destroy('sitemaker_blocks'); |
||
118 | $this->cache->destroy('sitemaker_block_routes'); |
||
119 | } |
||
120 | |||
121 | /** |
||
122 | * @param array $routes |
||
123 | * @param array $route_info |
||
124 | * @param string $current_route |
||
125 | * @param string $page_dir |
||
126 | * @param int $style_id |
||
127 | * @return array |
||
128 | */ |
||
129 | protected function inherit_route_info(array $routes, array $route_info, $current_route, $page_dir, $style_id) |
||
130 | { |
||
131 | // if block does not have own settings, inherit settings from parent route if it exists |
||
132 | // if block has own settings but no blocks, inherit route_id and has_blocks from parent route if it exists |
||
133 | if (empty($route_info['has_blocks'])) |
||
134 | { |
||
135 | $parent_route_info = $this->get_parent_route($routes, $current_route, $page_dir); |
||
136 | |||
137 | if (sizeof($parent_route_info)) |
||
138 | { |
||
139 | $route_info['route_id'] = $parent_route_info['route_id']; |
||
140 | $route_info['has_blocks'] = $parent_route_info['has_blocks']; |
||
141 | } |
||
142 | } |
||
143 | |||
144 | // fill in missing fields, while forcing route and style props to current route and style |
||
145 | unset($route_info['style'], $route_info['route']); |
||
146 | $route_info += $this->get_default_route_info($current_route, $style_id); |
||
147 | |||
148 | return $this->set_display_route_id($routes, $route_info); |
||
149 | } |
||
150 | |||
151 | /** |
||
152 | * @param string $route |
||
153 | * @return bool |
||
154 | */ |
||
155 | public function is_forum_route($route) |
||
156 | { |
||
157 | return (strpos($route, 'viewforum.' . $this->php_ext) !== false || strpos($route, 'viewtopic.' . $this->php_ext) !== false); |
||
158 | } |
||
159 | |||
160 | /** |
||
161 | * @param string $current_route |
||
162 | * @param int $style_id |
||
163 | * @return array |
||
164 | */ |
||
165 | protected function get_default_route_info($current_route, $style_id) |
||
176 | ); |
||
177 | } |
||
178 | |||
179 | /** |
||
180 | * @param array $routes |
||
181 | * @param string $current_route |
||
182 | * @param string $page_dir |
||
183 | * @return array |
||
184 | */ |
||
185 | protected function get_parent_route(array $routes, $current_route, $page_dir) |
||
186 | { |
||
187 | if ($page_dir) |
||
188 | { |
||
189 | $route = ltrim(dirname($page_dir) . '/index.php', './'); |
||
190 | return $this->get_parent_route_info($routes, $route); |
||
191 | } |
||
192 | else if ($this->is_forum_route($current_route)) |
||
193 | { |
||
194 | $forum_id = explode('?f=', $current_route)[1]; |
||
195 | return $this->get_parent_forum_route($forum_id, $routes); |
||
|
|||
196 | } |
||
197 | |||
198 | return $this->get_virtual_parent($routes, $current_route); |
||
199 | } |
||
200 | |||
201 | /** |
||
202 | * @param int $forum_id |
||
203 | * @param array $routes |
||
204 | * @return array |
||
205 | */ |
||
206 | protected function get_parent_forum_route($forum_id, array $routes) |
||
207 | { |
||
208 | $parent_route = []; |
||
209 | $forumslist = (array) make_forum_select(false, false, true, false, false, false, true); |
||
210 | |||
211 | do |
||
212 | { |
||
213 | $forum_id = &$forumslist[$forum_id]['parent_id']; |
||
214 | $route = "viewforum.{$this->php_ext}?f={$forum_id}"; |
||
215 | |||
216 | if (isset($routes[$route]) && $routes[$route]['has_blocks']) |
||
217 | { |
||
218 | $this->is_sub_route = true; |
||
219 | $parent_route = $routes[$route]; |
||
220 | } |
||
221 | } |
||
222 | while ($forum_id && !$this->is_sub_route); |
||
223 | |||
224 | return $parent_route; |
||
225 | } |
||
226 | |||
227 | /** |
||
228 | * @param array $routes_data |
||
229 | * @param string $current_route |
||
230 | * @return array |
||
231 | */ |
||
232 | protected function get_virtual_parent(array $routes_data, $current_route) |
||
233 | { |
||
234 | $routes = array_keys($routes_data); |
||
235 | |||
236 | // We add the current route to the list and sort it in ascending order |
||
237 | // Its parent will likely come before it in the list |
||
238 | // Eg if current route is 'app.php/content/news' the route list might be: |
||
239 | // ['app.php/content', 'app.php/content/category/cars', 'app.php/content/news', 'index.php'] |
||
240 | $routes[] = $current_route; |
||
241 | sort($routes); |
||
242 | |||
243 | // We find the position of the current route in the list |
||
244 | $index = (int) array_search($current_route, $routes); |
||
245 | |||
246 | // we use it as our starting point and walk backwords to find the immediate parent |
||
247 | // in this case 'app.php/content' |
||
248 | $parent_route = array(); |
||
249 | for ($i = $index - 1; $i >= 0; $i--) |
||
250 | { |
||
251 | if (strpos($current_route, $routes[$i]) !== false) |
||
252 | { |
||
253 | $parent_route = $routes_data[$routes[$i]]; |
||
254 | $this->is_sub_route = $parent_route['has_blocks']; |
||
255 | break; |
||
256 | } |
||
257 | } |
||
258 | |||
259 | return $parent_route; |
||
260 | } |
||
261 | |||
262 | /** |
||
263 | * @param array $routes |
||
264 | * @param string $route |
||
265 | * @return array |
||
266 | */ |
||
267 | protected function get_parent_route_info(array $routes, $route) |
||
268 | { |
||
269 | $route_info = array(); |
||
270 | if (isset($routes[$route])) |
||
271 | { |
||
272 | $this->is_sub_route = $routes[$route]['has_blocks']; |
||
273 | $route_info = $routes[$route]; |
||
274 | } |
||
275 | |||
276 | return $route_info; |
||
277 | } |
||
278 | |||
279 | /** |
||
280 | * We get blocks to display by route id, so we update the route id here, |
||
281 | * to show blocks from default route if current route or it's parent has no blocks |
||
282 | * |
||
283 | * @param array $routes |
||
284 | * @param array $route_info |
||
285 | * @return array |
||
286 | */ |
||
287 | protected function set_display_route_id(array $routes, array $route_info) |
||
288 | { |
||
289 | $default_route = $this->config['sitemaker_default_layout']; |
||
290 | if (!$route_info['has_blocks'] && isset($routes[$default_route])) |
||
291 | { |
||
292 | $route_info['route_id'] = $routes[$default_route]['route_id']; |
||
293 | } |
||
294 | |||
295 | return $route_info; |
||
296 | } |
||
297 | |||
298 | /** |
||
299 | * @param array $condition |
||
300 | * @return array |
||
301 | */ |
||
302 | protected function get_all_blocks(array $condition) |
||
303 | { |
||
304 | $collection = $this->mapper_factory->create('blocks')->find($condition); |
||
305 | |||
306 | $blocks = array(); |
||
307 | foreach ($collection as $entity) |
||
308 | { |
||
309 | if (($block_instance = $this->block_factory->get_block($entity->get_name())) !== null) |
||
310 | { |
||
311 | $default_settings = $block_instance->get_config(array()); |
||
312 | $settings = $this->sync_settings($default_settings, $entity->get_settings()); |
||
313 | $entity->set_settings($settings); |
||
314 | |||
315 | $blocks[$entity->get_style()][$entity->get_route_id()][$entity->get_position()][] = $entity; |
||
316 | } |
||
317 | } |
||
318 | |||
319 | return $blocks; |
||
320 | } |
||
321 | |||
322 | /** |
||
323 | * @return array|mixed |
||
324 | */ |
||
325 | protected function get_all_routes() |
||
344 | } |
||
345 | |||
346 | /** |
||
347 | * @param int $style_id |
||
348 | * @return array |
||
349 | */ |
||
350 | protected function get_routes_for_style($style_id) |
||
354 | } |
||
355 | |||
356 | /** |
||
357 | * @param bool $edit_mode |
||
358 | * @return array |
||
359 | */ |
||
360 | protected function get_cached_blocks($edit_mode) |
||
370 | } |
||
371 | |||
372 | /** |
||
373 | * @param array $blocks |
||
374 | * @param bool $edit_mode |
||
375 | */ |
||
376 | protected function cache_block(array $blocks, $edit_mode) |
||
381 | } |
||
382 | } |
||
383 | } |
||
384 |