Inspection of "Exceptions and code coverage" - blitze/phpBB-ext-sitemaker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d0d590...4bea8e )

by Daniel

created 2016-03-31 05:17 UTC

Status

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\event;
 

Please login to merge, or discard this patch.

blocks/mybookmarks.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\event;
 

Please login to merge, or discard this patch.

blocks/whats_new.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\event;
 

Please login to merge, or discard this patch.

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -50,8 +50,7 @@  discard block
 block discarded – undo
 		if (!empty($collection))
 		{
 			return $collection->get_entities();
-		}
-		else
+		} else
 		{
 			return array();
 		}
@@ -88,8 +87,7 @@  discard block
 block discarded – undo
 		if (!$has_blocks && !$hiding_blocks && !sizeof($ex_positions))
 		{
 			$this->route_mapper->delete($route);
-		}
-		else
+		} else
 		{
 			$route->set_has_blocks($has_blocks);
 			$this->route_mapper->save($route);

Please login to merge, or discard this patch.

blocks/wordgraph.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\event;
 

Please login to merge, or discard this patch.

controller/forum.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\event;
 

Please login to merge, or discard this patch.

exception/invalid_argument.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2015 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2015 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\exception;
 
@@ -15,12 +15,12 @@  discard block
 block discarded – undo
 class unexpected_value extends base
 {
 	/**
-	* Translate this exception
-	*
-	* @param \phpbb\user $user
-	* @return array|string
-	* @access public
-	*/
+	 * Translate this exception
+	 *
+	 * @param \phpbb\user $user
+	 * @return array|string
+	 * @access public
+	 */
 	public function get_message(\phpbb\user $user)
 	{
 		return $this->translate_portions($user, $this->message_full, 'EXCEPTION_UNEXPECTED_VALUE');

Please login to merge, or discard this patch.

exception/out_of_bounds.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2015 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2015 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\exception;
 
@@ -15,12 +15,12 @@  discard block
 block discarded – undo
 class unexpected_value extends base
 {
 	/**
-	* Translate this exception
-	*
-	* @param \phpbb\user $user
-	* @return array|string
-	* @access public
-	*/
+	 * Translate this exception
+	 *
+	 * @param \phpbb\user $user
+	 * @return array|string
+	 * @access public
+	 */
 	public function get_message(\phpbb\user $user)
 	{
 		return $this->translate_portions($user, $this->message_full, 'EXCEPTION_UNEXPECTED_VALUE');

Please login to merge, or discard this patch.

language/en/common.php 1 patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package phpBB Sitemaker [English]
- * @copyright (c) 2013 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package phpBB Sitemaker [English]
+	 * @copyright (c) 2013 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 /**
 * @ignore

Please login to merge, or discard this patch.

model/base_mapper.php 2 patches

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@
 block discarded – undo
 <?php
 /**
- *
- * @package sitemaker
- * @copyright (c) 2015 Daniel A. (blitze)
- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
- *
- */
+	 *
+	 * @package sitemaker
+	 * @copyright (c) 2015 Daniel A. (blitze)
+	 * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
+	 *
+	 */
 
 namespace blitze\sitemaker\model\menus\entity;
 

Please login to merge, or discard this patch.

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

@@ -336,8 +336,7 @@  discard block
 block discarded – undo
 		if ($this->settings['display_preview'])
 		{
 			$post_data = $this->forum->get_post_data($this->settings['display_preview']);
-		}
-		else
+		} else
 		{
 			$post_data = array_fill_keys(array_keys($topic_data), array(array('post_text' => '', 'bbcode_uid' => '', 'bbcode_bitfield' => '')));
 		}
@@ -360,8 +359,7 @@  discard block
 block discarded – undo
 				$this->fields['user_colour'] = 'topic_last_poster_colour';
 
 				$this->ptemplate->assign_var('L_POST_BY_AUTHOR', $this->user->lang('LAST_POST_BY_AUTHOR'));
-			}
-			else
+			} else
 			{
 				$this->fields['time'] = 'topic_time';
 				$this->fields['user_id'] = 'topic_poster';

Please login to merge, or discard this patch.

		@@ -336,8 +336,7 @@ discard block
		block discarded – undo
336	336	if ($this->settings['display_preview'])
337	337	{
338	338	$post_data = $this->forum->get_post_data($this->settings['display_preview']);
339		- }
340		- else
	339	+ } else
341	340	{
342	341	$post_data = array_fill_keys(array_keys($topic_data), array(array('post_text' => '', 'bbcode_uid' => '', 'bbcode_bitfield' => '')));
343	342	}
		@@ -360,8 +359,7 @@ discard block
		block discarded – undo
360	359	$this->fields['user_colour'] = 'topic_last_poster_colour';
361	360
362	361	$this->ptemplate->assign_var('L_POST_BY_AUTHOR', $this->user->lang('LAST_POST_BY_AUTHOR'));
363		- }
364		- else
	362	+ } else
365	363	{
366	364	$this->fields['time'] = 'topic_time';
367	365	$this->fields['user_id'] = 'topic_poster';

		@@ -1,11 +1,11 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- *
4		- * @package sitemaker
5		- * @copyright (c) 2013 Daniel A. (blitze)
6		- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
7		- *
8		- */
	3	+ *
	4	+ * @package sitemaker
	5	+ * @copyright (c) 2013 Daniel A. (blitze)
	6	+ * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
	7	+ *
	8	+ */
9	9
10	10	namespace blitze\sitemaker\event;
11	11

		@@ -50,8 +50,7 @@ discard block
		block discarded – undo
50	50	if (!empty($collection))
51	51	{
52	52	return $collection->get_entities();
53		- }
54		- else
	53	+ } else
55	54	{
56	55	return array();
57	56	}
		@@ -88,8 +87,7 @@ discard block
		block discarded – undo
88	87	if (!$has_blocks && !$hiding_blocks && !sizeof($ex_positions))
89	88	{
90	89	$this->route_mapper->delete($route);
91		- }
92		- else
	90	+ } else
93	91	{
94	92	$route->set_has_blocks($has_blocks);
95	93	$this->route_mapper->save($route);

		@@ -1,11 +1,11 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- *
4		- * @package sitemaker
5		- * @copyright (c) 2015 Daniel A. (blitze)
6		- * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
7		- *
8		- */
	3	+ *
	4	+ * @package sitemaker
	5	+ * @copyright (c) 2015 Daniel A. (blitze)
	6	+ * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
	7	+ *
	8	+ */
9	9
10	10	namespace blitze\sitemaker\exception;
11	11
		@@ -15,12 +15,12 @@ discard block
		block discarded – undo
15	15	class unexpected_value extends base
16	16	{
17	17	/**
18		- * Translate this exception
19		- *
20		- * @param \phpbb\user $user
21		- * @return array\|string
22		- * @access public
23		- */
	18	+ * Translate this exception
	19	+ *
	20	+ * @param \phpbb\user $user
	21	+ * @return array\|string
	22	+ * @access public
	23	+ */
24	24	public function get_message(\phpbb\user $user)
25	25	{
26	26	return $this->translate_portions($user, $this->message_full, 'EXCEPTION_UNEXPECTED_VALUE');

blitze / phpBB-ext-sitemaker

Push — master ( d0d590...4bea8e )

Status

Category

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Indentation +6 added lines, -6 removed lines patch added patch discarded remove patch

Braces +2 added lines, -4 removed lines patch added patch discarded remove patch