Complex classes like data often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use data, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | class data extends query_builder |
||
| 15 | { |
||
| 16 | /** @var \phpbb\auth\auth */ |
||
| 17 | protected $auth; |
||
| 18 | |||
| 19 | /** @var \phpbb\config\config */ |
||
| 20 | protected $config; |
||
| 21 | |||
| 22 | /** @var \phpbb\content_visibility */ |
||
| 23 | protected $content_visibility; |
||
| 24 | |||
| 25 | /** @var \phpbb\db\driver\driver_interface */ |
||
| 26 | protected $db; |
||
| 27 | |||
| 28 | /** @var \phpbb\user */ |
||
| 29 | protected $user; |
||
| 30 | |||
| 31 | /** |
||
| 32 | * Constructor |
||
| 33 | * |
||
| 34 | * @param \phpbb\auth\auth $auth Auth object |
||
| 35 | * @param \phpbb\config\config $config Config object |
||
| 36 | * @param \phpbb\content_visibility $content_visibility Content visibility |
||
| 37 | * @param \phpbb\db\driver\driver_interface $db Database connection |
||
| 38 | * @param \phpbb\user $user User object |
||
| 39 | * @param integer $cache_time Cache results for 3 hours by default |
||
| 40 | */ |
||
| 41 | 24 | public function __construct(\phpbb\auth\auth $auth, \phpbb\config\config $config, \phpbb\content_visibility $content_visibility, \phpbb\db\driver\driver_interface $db, \phpbb\user $user, $cache_time = 10800) |
|
| 51 | |||
| 52 | /** |
||
| 53 | * Get topic data |
||
| 54 | * |
||
| 55 | * @param mixed|false $limit |
||
| 56 | * @param int $start |
||
| 57 | * @return array |
||
| 58 | */ |
||
| 59 | 11 | public function get_topic_data($limit = false, $start = 0) |
|
| 77 | |||
| 78 | /** |
||
| 79 | * Get post data |
||
| 80 | * |
||
| 81 | * @param mixed|false $topic_first_or_last_post (first|last) |
||
| 82 | * @param array $post_ids |
||
| 83 | * @param bool|false $limit |
||
| 84 | * @param int $start |
||
| 85 | * @param array $sql_array |
||
| 86 | * @return array |
||
| 87 | */ |
||
| 88 | 9 | public function get_post_data($topic_first_or_last_post = false, $post_ids = array(), $limit = false, $start = 0, $sql_array = array()) |
|
| 109 | |||
| 110 | /** |
||
| 111 | * Get attachments... |
||
| 112 | * |
||
| 113 | * @param int $forum_id |
||
| 114 | * @param array $allowed_extensions |
||
| 115 | * @param bool $exclude_in_message |
||
| 116 | * @param string $order_by |
||
| 117 | * @return array |
||
| 118 | */ |
||
| 119 | 6 | public function get_attachments($forum_id = 0, $allowed_extensions = array(), $exclude_in_message = true, $order_by = 'filetime DESC, post_msg_id ASC') |
|
| 139 | |||
| 140 | /** |
||
| 141 | * Get topic tracking info |
||
| 142 | * |
||
| 143 | * @param int $forum_id |
||
| 144 | * @return array |
||
| 145 | */ |
||
| 146 | 4 | public function get_topic_tracking_info($forum_id = 0) |
|
| 157 | |||
| 158 | /** |
||
| 159 | * Returns an array of topic first post or last post ids |
||
| 160 | * |
||
| 161 | * @param string $first_or_last_post |
||
| 162 | * @return array |
||
| 163 | */ |
||
| 164 | 3 | public function get_topic_post_ids($first_or_last_post = 'first') |
|
| 168 | |||
| 169 | /** |
||
| 170 | * @param mixed $topic_first_or_last_post |
||
| 171 | * @param array $post_ids |
||
| 172 | * @param array $sql_array |
||
| 173 | * @return array |
||
| 174 | */ |
||
| 175 | 9 | private function _get_posts_sql_array($topic_first_or_last_post, array $post_ids, array $sql_array) |
|
| 192 | |||
| 193 | /** |
||
| 194 | * @param array $post_ids |
||
| 195 | * @param string $topic_first_or_last_post |
||
| 196 | * @return array |
||
| 197 | */ |
||
| 198 | 9 | private function _get_post_data_where(array $post_ids, $topic_first_or_last_post) |
|
| 220 | |||
| 221 | /** |
||
| 222 | * @return array |
||
| 223 | */ |
||
| 224 | 4 | private function _get_tracking_info() |
|
| 238 | |||
| 239 | /** |
||
| 240 | * @param string $function |
||
| 241 | * @return array |
||
| 242 | */ |
||
| 243 | 4 | private function _build_tracking_info($function) |
|
| 253 | |||
| 254 | /** |
||
| 255 | * @return bool |
||
| 256 | */ |
||
| 257 | 4 | private function _can_track_by_lastread() |
|
| 261 | |||
| 262 | /** |
||
| 263 | * @return bool |
||
| 264 | */ |
||
| 265 | private function _can_track_anonymous() |
||
| 269 | |||
| 270 | /** |
||
| 271 | * @param int $forum_id |
||
| 272 | * @return bool |
||
| 273 | */ |
||
| 274 | 6 | private function _attachments_allowed($forum_id) |
|
| 278 | |||
| 279 | /** |
||
| 280 | * @param int $forum_id |
||
| 281 | * @return bool |
||
| 282 | */ |
||
| 283 | 5 | private function _user_can_download_attachments($forum_id) |
|
| 287 | |||
| 288 | /** |
||
| 289 | * @param array $allowed_extensions |
||
| 290 | * @param bool $exclude_in_message |
||
| 291 | * @param string $order_by |
||
| 292 | * @return string |
||
| 293 | */ |
||
| 294 | 5 | private function _get_attachment_sql($allowed_extensions, $exclude_in_message, $order_by) |
|
| 303 | } |
||
| 304 |