Completed
Push — master ( e581ca...436d2e )
by Daniel
08:58
created
blocks/login.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -77,9 +77,9 @@  discard block
 block discarded – undo
77 77
 			$this->ptemplate->assign_vars(array(
78 78
 				'S_SHOW_HIDE_ME'		=> ($settings['show_hide_me']) ? true : false,
79 79
 				'S_AUTOLOGIN_ENABLED'   => ($settings['allow_autologin']) ? true : false,
80
-				'S_LOGIN_ACTION'		=> append_sid("{$this->phpbb_root_path}ucp." . $this->php_ext, 'mode=login'),
81
-				'U_REGISTER'			=> append_sid("{$this->phpbb_root_path}ucp." . $this->php_ext, 'mode=register'),
82
-				'U_SEND_PASSWORD'		=> append_sid("{$this->phpbb_root_path}ucp." . $this->php_ext, 'mode=sendpassword'),
80
+				'S_LOGIN_ACTION'		=> append_sid("{$this->phpbb_root_path}ucp.".$this->php_ext, 'mode=login'),
81
+				'U_REGISTER'			=> append_sid("{$this->phpbb_root_path}ucp.".$this->php_ext, 'mode=register'),
82
+				'U_SEND_PASSWORD'		=> append_sid("{$this->phpbb_root_path}ucp.".$this->php_ext, 'mode=sendpassword'),
83 83
 				'U_REDIRECT'			=> reapply_sid(ltrim(rtrim(build_url(array('edit_mode')), '?'), './../'))
84 84
 			));
85 85
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 	private function hide_quicklogin()
105 105
 	{
106 106
 		$current_page = $this->user->page['page_name'];
107
-		if ($current_page === 'index.' . $this->php_ext)
107
+		if ($current_page === 'index.'.$this->php_ext)
108 108
 		{
109 109
 			$this->template->assign_var('S_USER_LOGGED_IN', true);
110 110
 		}
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -84,8 +84,7 @@
 block discarded – undo
84 84
 			));
85 85
 
86 86
 			$content = $this->ptemplate->render_view('blitze/sitemaker', 'blocks/login.html', 'login_block');
87
-		}
88
-		else if ($settings['show_member_menu'])
87
+		} else if ($settings['show_member_menu'])
89 88
 		{
90 89
 			$block = $this->phpbb_container->get('blitze.sitemaker.block.member_menu');
91 90
 			$block->set_template($this->ptemplate);
Please login to merge, or discard this patch.
blocks/custom.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 		$content = $this->request->variable('content', '', true);
86 86
 		$cblocks = $this->get_custom_blocks();
87 87
 
88
-		$sql_data =	$this->get_default_fields($block_id);
88
+		$sql_data = $this->get_default_fields($block_id);
89 89
 		$sql_data['block_content'] = $content;
90 90
 
91 91
 		generate_text_for_storage($sql_data['block_content'], $sql_data['bbcode_uid'], $sql_data['bbcode_bitfield'], $sql_data['bbcode_options'], true, true, true);
@@ -149,11 +149,11 @@  discard block
 block discarded – undo
149 149
 	{
150 150
 		if (!$block_exists)
151 151
 		{
152
-			$sql = 'INSERT INTO ' . $this->cblocks_table . ' ' . $this->db->sql_build_array('INSERT', $sql_data);
152
+			$sql = 'INSERT INTO '.$this->cblocks_table.' '.$this->db->sql_build_array('INSERT', $sql_data);
153 153
 		}
154 154
 		else
155 155
 		{
156
-			$sql = 'UPDATE ' . $this->cblocks_table . ' SET ' . $this->db->sql_build_array('UPDATE', $sql_data) . ' WHERE block_id = ' . (int) $sql_data['block_id'];
156
+			$sql = 'UPDATE '.$this->cblocks_table.' SET '.$this->db->sql_build_array('UPDATE', $sql_data).' WHERE block_id = '.(int) $sql_data['block_id'];
157 157
 		}
158 158
 		$this->db->sql_query($sql);
159 159
 		$this->cache->destroy('sm_cblocks');
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
 
174 174
 			$block_is_active = $status;
175 175
 			$status = ($content && $status) ? true : false;
176
-			$content = '<div id="block-editor-' . $cblock['block_id'] . '" class="editable editable-block" data-service="blitze.sitemaker.block.custom" data-method="edit" data-raw="' . $cblock['block_content'] . '" data-active="' . $block_is_active . '">' . $content . '</div>';
176
+			$content = '<div id="block-editor-'.$cblock['block_id'].'" class="editable editable-block" data-service="blitze.sitemaker.block.custom" data-method="edit" data-raw="'.$cblock['block_content'].'" data-active="'.$block_is_active.'">'.$content.'</div>';
177 177
 		}
178 178
 	}
179 179
 
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -150,8 +150,7 @@
 block discarded – undo
150 150
 		if (!$block_exists)
151 151
 		{
152 152
 			$sql = 'INSERT INTO ' . $this->cblocks_table . ' ' . $this->db->sql_build_array('INSERT', $sql_data);
153
-		}
154
-		else
153
+		} else
155 154
 		{
156 155
 			$sql = 'UPDATE ' . $this->cblocks_table . ' SET ' . $this->db->sql_build_array('UPDATE', $sql_data) . ' WHERE block_id = ' . (int) $sql_data['block_id'];
157 156
 		}
Please login to merge, or discard this patch.
model/base_collection.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
 		{
128 128
 			$this->entities = array_filter(
129 129
 				$this->entities,
130
-				function ($v) use ($key)
130
+				function($v) use ($key)
131 131
 				{
132 132
 					return $v !== $key;
133 133
 				}
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -104,8 +104,7 @@
 block discarded – undo
104 104
 			if (!isset($key))
105 105
 			{
106 106
 				$this->entities[] = $entity;
107
-			}
108
-			else
107
+			} else
109 108
 			{
110 109
 				$this->entities[$key] = $entity;
111 110
 			}
Please login to merge, or discard this patch.
model/base_mapper.php 2 patches
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	 */
86 86
 	public function save(\blitze\sitemaker\model\entity_interface $entity)
87 87
 	{
88
-		$accessor = 'get_' . $this->entity_pkey;
88
+		$accessor = 'get_'.$this->entity_pkey;
89 89
 		if (is_null($entity->$accessor()))
90 90
 		{
91 91
 			$entity = $this->insert($entity);
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 		{
108 108
 			if ($condition instanceof $this->entity_class)
109 109
 			{
110
-				$accessor = 'get_' . $this->entity_pkey;
110
+				$accessor = 'get_'.$this->entity_pkey;
111 111
 				$condition = array($this->entity_pkey, '=', $condition->$accessor());
112 112
 			}
113 113
 			else
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 		}
118 118
 
119 119
 		$sql_where = $this->get_sql_condition($condition);
120
-		$this->db->sql_query('DELETE FROM ' . $this->entity_table . (sizeof($sql_where) ? ' WHERE ' . join(' AND ', $sql_where) : ''));
120
+		$this->db->sql_query('DELETE FROM '.$this->entity_table.(sizeof($sql_where) ? ' WHERE '.join(' AND ', $sql_where) : ''));
121 121
 	}
122 122
 
123 123
 	/**
@@ -136,9 +136,9 @@  discard block
 block discarded – undo
136 136
 	 */
137 137
 	protected function insert(\blitze\sitemaker\model\entity_interface $entity)
138 138
 	{
139
-		$this->db->sql_query('INSERT INTO ' . $this->entity_table . ' ' . $this->db->sql_build_array('INSERT', $entity->to_db()));
139
+		$this->db->sql_query('INSERT INTO '.$this->entity_table.' '.$this->db->sql_build_array('INSERT', $entity->to_db()));
140 140
 
141
-		$mutator = 'set_' . $this->entity_pkey;
141
+		$mutator = 'set_'.$this->entity_pkey;
142 142
 		$entity->$mutator((int) $this->db->sql_nextid());
143 143
 
144 144
 		return $entity;
@@ -152,11 +152,11 @@  discard block
 block discarded – undo
152 152
 	 */
153 153
 	protected function update(\blitze\sitemaker\model\entity_interface $entity)
154 154
 	{
155
-		$accessor = 'get_' . $this->entity_pkey;
155
+		$accessor = 'get_'.$this->entity_pkey;
156 156
 
157
-		return $this->db->sql_query('UPDATE ' . $this->entity_table . '
158
-			SET ' . $this->db->sql_build_array('UPDATE', $entity->to_db()) . '
159
-			WHERE ' . $this->entity_pkey . ' = ' . (int) $entity->$accessor());
157
+		return $this->db->sql_query('UPDATE '.$this->entity_table.'
158
+			SET ' . $this->db->sql_build_array('UPDATE', $entity->to_db()).'
159
+			WHERE ' . $this->entity_pkey.' = '.(int) $entity->$accessor());
160 160
 	}
161 161
 
162 162
 	/**
@@ -165,8 +165,8 @@  discard block
 block discarded – undo
165 165
 	 */
166 166
 	protected function find_sql(array $sql_where)
167 167
 	{
168
-		return 'SELECT * FROM ' . $this->entity_table .
169
-			(sizeof($sql_where) ? ' WHERE ' . join(' AND ', $sql_where) : '');
168
+		return 'SELECT * FROM '.$this->entity_table.
169
+			(sizeof($sql_where) ? ' WHERE '.join(' AND ', $sql_where) : '');
170 170
 	}
171 171
 
172 172
 	/**
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 		{
183 183
 			list($field, $operator, $value) = $info;
184 184
 
185
-			$callable = 'get_sql_where_' . gettype($value);
185
+			$callable = 'get_sql_where_'.gettype($value);
186 186
 			$sql_where[] = $this->$callable($field, $value, $operator);
187 187
 		}
188 188
 
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
 	 */
224 224
 	protected function get_sql_where_string($field, $value, $operator)
225 225
 	{
226
-		return $field . " $operator '" . $this->db->sql_escape($value) . "'";
226
+		return $field." $operator '".$this->db->sql_escape($value)."'";
227 227
 	}
228 228
 
229 229
 	/**
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
 	 */
235 235
 	protected function get_sql_where_integer($field, $value, $operator)
236 236
 	{
237
-		return $field . " $operator " . (int) $value;
237
+		return $field." $operator ".(int) $value;
238 238
 	}
239 239
 
240 240
 	/**
Please login to merge, or discard this patch.
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -89,8 +89,7 @@  discard block
 block discarded – undo
89 89
 		if (is_null($entity->$accessor()))
90 90
 		{
91 91
 			$entity = $this->insert($entity);
92
-		}
93
-		else
92
+		} else
94 93
 		{
95 94
 			$this->update($entity);
96 95
 		}
@@ -109,8 +108,7 @@  discard block
 block discarded – undo
109 108
 			{
110 109
 				$accessor = 'get_' . $this->entity_pkey;
111 110
 				$condition = array($this->entity_pkey, '=', $condition->$accessor());
112
-			}
113
-			else
111
+			} else
114 112
 			{
115 113
 				throw new \blitze\sitemaker\exception\invalid_argument(array('entity', 'INVALID_ENTITY'));
116 114
 			}
Please login to merge, or discard this patch.
blocks/whats_new.php 2 patches
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -72,8 +72,7 @@  discard block
 block discarded – undo
72 72
 				'title'		=> '',
73 73
 				'content'	=> '',
74 74
 			);
75
-		}
76
-		else
75
+		} else
77 76
 		{
78 77
 			$this->fetch_new($bdata['settings']);
79 78
 
@@ -117,8 +116,7 @@  discard block
 block discarded – undo
117 116
 		{
118 117
 			$sorting = 't.topic_last_post_time';
119 118
 			$sql_array = $this->get_topics_sql();
120
-		}
121
-		else
119
+		} else
122 120
 		{
123 121
 			$sorting = 'p.post_time';
124 122
 			$sql_array = $this->get_posts_sql();
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 
95 95
 			$this->ptemplate->assign_block_vars('topicrow', array(
96 96
 				'TOPIC_TITLE'    => censor_text($row['topic_title']),
97
-				'U_VIEWTOPIC'    => append_sid($this->phpbb_root_path . 'viewtopic.' . $this->php_ext, "f=$forum_id&amp;t=$topic_id"),
97
+				'U_VIEWTOPIC'    => append_sid($this->phpbb_root_path.'viewtopic.'.$this->php_ext, "f=$forum_id&amp;t=$topic_id"),
98 98
 			));
99 99
 			unset($topic_data[$i]);
100 100
 		}
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
 	{
136 136
 		return array(
137 137
 			'WHERE'		=> array(
138
-				't.topic_last_post_time > ' . (int) $this->user->data['user_lastvisit'],
138
+				't.topic_last_post_time > '.(int) $this->user->data['user_lastvisit'],
139 139
 				't.topic_moved_id = 0',
140 140
 			),
141 141
 		);
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 				POSTS_TABLE		=> 'p',
152 152
 			),
153 153
 			'WHERE'		=> array(
154
-				't.topic_id = p.topic_id AND p.post_time > ' . $this->user->data['user_lastvisit'],
154
+				't.topic_id = p.topic_id AND p.post_time > '.$this->user->data['user_lastvisit'],
155 155
 			),
156 156
 		);
157 157
 	}
Please login to merge, or discard this patch.
services/poll.php 2 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -303,8 +303,7 @@
 block discarded – undo
303 303
 				$cur_voted_id[] = $row['poll_option_id'];
304 304
 			}
305 305
 			$this->db->sql_freeresult($result);
306
-		}
307
-		else
306
+		} else
308 307
 		{
309 308
 			// Cookie based guest tracking ... I don't like this but hum ho
310 309
 			// it's oft requested. This relies on "nice" users who don't feel
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
 	 * @param array $topic_data
64 64
 	 * @param \phpbb\template\twig\twig $template
65 65
 	 */
66
-	public function build(array $topic_data, \phpbb\template\twig\twig &$template)
66
+	public function build(array $topic_data, \phpbb\template\twig\twig & $template)
67 67
 	{
68 68
 		$this->user->add_lang('viewtopic');
69 69
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 			'S_POLL_ACTION'		=> $viewtopic_url,
96 96
 			'S_FORM_TOKEN'		=> $this->sitemaker->get_form_key('posting'),
97 97
 
98
-			'U_VIEW_RESULTS'	=> $viewtopic_url . '&amp;view=viewpoll',
98
+			'U_VIEW_RESULTS'	=> $viewtopic_url.'&amp;view=viewpoll',
99 99
 		));
100 100
 	}
101 101
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
 		$post_id = (int) $topic_data['topic_first_post_id'];
128 128
 
129 129
 		$sql = 'SELECT o.*, p.bbcode_bitfield, p.bbcode_uid
130
-			FROM ' . POLL_OPTIONS_TABLE . ' o, ' . POSTS_TABLE . " p
130
+			FROM ' . POLL_OPTIONS_TABLE.' o, '.POSTS_TABLE." p
131 131
 			WHERE o.topic_id = $topic_id
132 132
 				AND p.post_id = $post_id
133 133
 				AND p.topic_id = o.topic_id
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
 	 * @param int $poll_most
173 173
 	 * @param \phpbb\template\twig\twig $template
174 174
 	 */
175
-	private function _build_poll_options(array $cur_voted_id, array $poll_info, $poll_total, $poll_most, \phpbb\template\twig\twig &$template)
175
+	private function _build_poll_options(array $cur_voted_id, array $poll_info, $poll_total, $poll_most, \phpbb\template\twig\twig & $template)
176 176
 	{
177 177
 		foreach ($poll_info as $poll_option)
178 178
 		{
@@ -203,8 +203,8 @@  discard block
 block discarded – undo
203 203
 		if ($this->user->data['is_registered'])
204 204
 		{
205 205
 			$sql = 'SELECT poll_option_id
206
-			FROM ' . POLL_VOTES_TABLE . '
207
-			WHERE topic_id = ' . (int) $topic_id . '
206
+			FROM ' . POLL_VOTES_TABLE.'
207
+			WHERE topic_id = ' . (int) $topic_id.'
208 208
 				AND vote_user_id = ' . (int) $this->user->data['user_id'];
209 209
 			$result = $this->db->sql_query($sql);
210 210
 
@@ -219,9 +219,9 @@  discard block
 block discarded – undo
219 219
 			// Cookie based guest tracking ... I don't like this but hum ho
220 220
 			// it's oft requested. This relies on "nice" users who don't feel
221 221
 			// the need to delete cookies to mess with results.
222
-			if ($this->request->is_set($this->config['cookie_name'] . '_poll_' . $topic_id, \phpbb\request\request_interface::COOKIE))
222
+			if ($this->request->is_set($this->config['cookie_name'].'_poll_'.$topic_id, \phpbb\request\request_interface::COOKIE))
223 223
 			{
224
-				$cur_voted_id = explode(',', $this->request->variable($this->config['cookie_name'] . '_poll_' . $topic_id, '', true, \phpbb\request\request_interface::COOKIE));
224
+				$cur_voted_id = explode(',', $this->request->variable($this->config['cookie_name'].'_poll_'.$topic_id, '', true, \phpbb\request\request_interface::COOKIE));
225 225
 				$cur_voted_id = array_map('intval', $cur_voted_id);
226 226
 			}
227 227
 		}
Please login to merge, or discard this patch.
services/blocks/action/add_block.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,8 +17,8 @@
 block discarded – undo
17 17
 	 */
18 18
 	public function execute($style_id)
19 19
 	{
20
-		$name	= $this->request->variable('block', '');
21
-		$route	= $this->request->variable('route', '');
20
+		$name = $this->request->variable('block', '');
21
+		$route = $this->request->variable('route', '');
22 22
 
23 23
 		if (($block_instance = $this->block_factory->get_block($name)) === null)
24 24
 		{
Please login to merge, or discard this patch.
services/blocks/display.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 		{
72 72
 			$edit_mode = $this->toggle_edit_mode();
73 73
 			$style_id = $this->get_style_id();
74
-			$current_route = ltrim($this->user->page['page_dir'] . '/' . $this->user->page['page_name'], './');
74
+			$current_route = ltrim($this->user->page['page_dir'].'/'.$this->user->page['page_name'], './');
75 75
 
76 76
 			$this->show_sitemaker($current_route, $this->user->page['page_dir'], $style_id, $edit_mode);
77 77
 		}
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 	 */
108 108
 	protected function toggle_edit_mode()
109 109
 	{
110
-		$edit_mode = $this->request->variable($this->config['cookie_name'] . '_sm_edit_mode', false, false, \phpbb\request\request_interface::COOKIE);
110
+		$edit_mode = $this->request->variable($this->config['cookie_name'].'_sm_edit_mode', false, false, \phpbb\request\request_interface::COOKIE);
111 111
 
112 112
 		if ($this->request->is_set('edit_mode'))
113 113
 		{
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
 				);
164 164
 			}
165 165
 
166
-			$u_edit_mode = append_sid(generate_board_url() . '/' . ltrim(rtrim(build_url(array('edit_mode', 'sid', 'style')), '?'), './../'), 'edit_mode=' . (int) !$edit_mode);
166
+			$u_edit_mode = append_sid(generate_board_url().'/'.ltrim(rtrim(build_url(array('edit_mode', 'sid', 'style')), '?'), './../'), 'edit_mode='.(int) !$edit_mode);
167 167
 		}
168 168
 		else
169 169
 		{
Please login to merge, or discard this patch.
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -86,8 +86,7 @@  discard block
 block discarded – undo
86 86
 		if ($this->request->is_set('style'))
87 87
 		{
88 88
 			return $this->request->variable('style', 0);
89
-		}
90
-		else
89
+		} else
91 90
 		{
92 91
 			return (!$this->config['override_user_style']) ? $this->user->data['user_style'] : $this->config['default_style'];
93 92
 		}
@@ -131,8 +130,7 @@  discard block
 block discarded – undo
131 130
 				self::SHOW_ON_PARENT_ROUTE_ONLY	=> true,
132 131
 				self::SHOW_ON_CHILD_ROUTE_ONLY	=> false,
133 132
 			);
134
-		}
135
-		else
133
+		} else
136 134
 		{
137 135
 			$modes = array(
138 136
 				self::SHOW_ON_ALL_ROUTES		=> true,
@@ -164,8 +162,7 @@  discard block
 block discarded – undo
164 162
 			}
165 163
 
166 164
 			$u_edit_mode = append_sid(generate_board_url() . '/' . ltrim(rtrim(build_url(array('edit_mode', 'sid', 'style')), '?'), './../'), 'edit_mode=' . (int) !$edit_mode);
167
-		}
168
-		else
165
+		} else
169 166
 		{
170 167
 			$edit_mode = false;
171 168
 		}
Please login to merge, or discard this patch.
services/url_checker.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 		$status = array();
27 27
 		$headers = $this->get_headers($url, $curl);
28 28
 
29
-		preg_match('/HTTP\/.* ([0-9]+) .*/', $headers , $status);
29
+		preg_match('/HTTP\/.* ([0-9]+) .*/', $headers, $status);
30 30
 
31 31
 		return ($status[1] == 200) ? true : false;
32 32
 	}
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,8 +41,7 @@
 block discarded – undo
41 41
 		if (extension_loaded('curl') && $curl)
42 42
 		{
43 43
 			$headers = $this->curl_header($url);
44
-		}
45
-		else
44
+		} else
46 45
 		{
47 46
 			$headers = get_headers($url);
48 47
 			$headers = $headers[0];
Please login to merge, or discard this patch.