Completed
Push — master ( e581ca...436d2e )
by Daniel
08:58
created
event/listener.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -112,8 +112,8 @@  discard block
 block discarded – undo
112 112
 	public function load_permission_language(\phpbb\event\data $event)
113 113
 	{
114 114
 		$permissions = $event['permissions'];
115
-		$permissions['a_sm_manage_blocks']	= array('lang' => 'ACL_A_SM_MANAGE_BLOCKS', 'cat' => 'misc');
116
-		$permissions['a_sm_manage_menus']	= array('lang' => 'ACL_A_SM_MANAGE_MENUS', 'cat' => 'misc');
115
+		$permissions['a_sm_manage_blocks'] = array('lang' => 'ACL_A_SM_MANAGE_BLOCKS', 'cat' => 'misc');
116
+		$permissions['a_sm_manage_menus'] = array('lang' => 'ACL_A_SM_MANAGE_MENUS', 'cat' => 'misc');
117 117
 		$event['permissions'] = $permissions;
118 118
 	}
119 119
 
@@ -192,13 +192,13 @@  discard block
 block discarded – undo
192 192
 	 */
193 193
 	public function set_startpage(\phpbb\event\data $event)
194 194
 	{
195
-		if ($this->user->page['page_name'] == 'index.' . $this->php_ext && !$this->startpage && ($controller_object = $this->get_startpage_controller()) !== false)
195
+		if ($this->user->page['page_name'] == 'index.'.$this->php_ext && !$this->startpage && ($controller_object = $this->get_startpage_controller()) !== false)
196 196
 		{
197 197
 			$method = $this->config['sitemaker_startpage_method'];
198 198
 			$this->startpage = true;
199 199
 
200 200
 			$controller_dir = explode('\\', get_class($controller_object));
201
-			$controller_style_dir = 'ext/' . $controller_dir[0] . '/' . $controller_dir[1] . '/styles';
201
+			$controller_style_dir = 'ext/'.$controller_dir[0].'/'.$controller_dir[1].'/styles';
202 202
 			$this->template->set_style(array($controller_style_dir, 'styles'));
203 203
 
204 204
 			$arguments = explode('/', $this->config['sitemaker_startpage_params']);
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 	 */
220 220
 	public function add_viewonline_location(\phpbb\event\data $event)
221 221
 	{
222
-		if ($event['on_page'][1] == 'app' && strrpos($event['row']['session_page'], 'app.' . $this->php_ext . '/forum') === 0)
222
+		if ($event['on_page'][1] == 'app' && strrpos($event['row']['session_page'], 'app.'.$this->php_ext.'/forum') === 0)
223 223
 		{
224 224
 			$event['location'] = $this->user->lang('FORUM_INDEX');
225 225
 			$event['location_url'] = $this->phpbb_container->get('controller.helper')->route('blitze_sitemaker_forum');
Please login to merge, or discard this patch.
services/forum/data.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 			$this->store['topic'][$row['topic_id']] = $row;
85 85
 
86 86
 			$this->store['tracking'][$row['forum_id']]['topic_list'][] = $row['topic_id'];
87
-			$this->store['tracking'][$row['forum_id']]['mark_time'] =& $row['forum_mark_time'];
87
+			$this->store['tracking'][$row['forum_id']]['mark_time'] = & $row['forum_mark_time'];
88 88
 			$this->store['post_ids']['first'][] = $row['topic_first_post_id'];
89 89
 			$this->store['post_ids']['last'][] = $row['topic_last_post_id'];
90 90
 		}
@@ -319,10 +319,10 @@  discard block
 block discarded – undo
319 319
 	private function _get_attachment_sql($allowed_extensions, $exclude_in_message, $order_by)
320 320
 	{
321 321
 		return 'SELECT *
322
-			FROM ' . ATTACHMENTS_TABLE . '
323
-			WHERE ' . $this->db->sql_in_set('post_msg_id', $this->store['attachments']) .
324
-				(($exclude_in_message) ? ' AND in_message = 0' : '') .
325
-				(sizeof($allowed_extensions) ? ' AND ' . $this->db->sql_in_set('extension', $allowed_extensions) : '') . '
322
+			FROM ' . ATTACHMENTS_TABLE.'
323
+			WHERE ' . $this->db->sql_in_set('post_msg_id', $this->store['attachments']).
324
+				(($exclude_in_message) ? ' AND in_message = 0' : '').
325
+				(sizeof($allowed_extensions) ? ' AND '.$this->db->sql_in_set('extension', $allowed_extensions) : '').'
326 326
 			ORDER BY ' . $order_by;
327 327
 	}
328 328
 }
Please login to merge, or discard this patch.
services/menus/action/add_menu.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 
21 21
 		/** @type \blitze\sitemaker\model\menus\entity\menu $entity */
22 22
 		$entity = $menu_mapper->create_entity(array(
23
-			'menu_name' => $this->user->lang('MENU') . '-' . mt_rand(1000, 9999),
23
+			'menu_name' => $this->user->lang('MENU').'-'.mt_rand(1000, 9999),
24 24
 		));
25 25
 
26 26
 		$entity = $menu_mapper->save($entity);
Please login to merge, or discard this patch.
services/profilefields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 
46 46
 		if (!function_exists('phpbb_show_profile'))
47 47
 		{
48
-			include($this->phpbb_root_path . 'includes/functions_display.' . $this->php_ext);
48
+			include($this->phpbb_root_path.'includes/functions_display.'.$this->php_ext);
49 49
 		}
50 50
 	}
51 51
 
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
55 55
 	public function get_all_fields()
56 56
 	{
57 57
 		$sql = 'SELECT l.lang_name, f.field_ident
58
-			FROM ' . PROFILE_LANG_TABLE . ' l, ' . PROFILE_FIELDS_TABLE . ' f
59
-			WHERE l.lang_id = ' . $this->user->get_iso_lang_id() . '
58
+			FROM ' . PROFILE_LANG_TABLE.' l, '.PROFILE_FIELDS_TABLE.' f
59
+			WHERE l.lang_id = ' . $this->user->get_iso_lang_id().'
60 60
 				AND f.field_active = 1
61 61
 				AND f.field_no_view = 0
62 62
 				AND f.field_hide = 0
Please login to merge, or discard this patch.
services/userlist.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,11 +45,11 @@
 block discarded – undo
45 45
 			$curr_key = (int) array_search($settings['current_user'], $userlist);
46 46
 
47 47
 			// Remove the invalid user from the list
48
-			$new_list = str_replace($settings['current_user'] . ',', '', $settings['userlist'] . ',');
48
+			$new_list = str_replace($settings['current_user'].',', '', $settings['userlist'].',');
49 49
 			$new_list = trim($new_list, ',');
50 50
 
51 51
 			$new_userlist = self::_get_userlist($new_list);
52
-			$current_user =& $new_userlist[$curr_key - 1];
52
+			$current_user = & $new_userlist[$curr_key - 1];
53 53
 			$settings['current_user'] = (int) $current_user;
54 54
 			$settings['userlist'] = trim($new_list);
55 55
 			$settings['last_changed'] = 0;
Please login to merge, or discard this patch.
services/groups.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	public function get_users_groups()
36 36
 	{
37 37
 		$sql = 'SELECT group_id
38
-			FROM ' . USER_GROUP_TABLE . '
38
+			FROM ' . USER_GROUP_TABLE.'
39 39
 			WHERE user_id = ' . (int) $this->user->data['user_id'];
40 40
 		$result = $this->db->sql_query($sql);
41 41
 
@@ -78,13 +78,13 @@  discard block
 block discarded – undo
78 78
 		$sql = $this->_get_group_sql($mode);
79 79
 		$result = $this->db->sql_query($sql);
80 80
 
81
-		$options = '<option value="0">' . $this->user->lang('ALL') . '</option>';
81
+		$options = '<option value="0">'.$this->user->lang('ALL').'</option>';
82 82
 		while ($row = $this->db->sql_fetchrow($result))
83 83
 		{
84 84
 			$group_name = $this->_get_group_name($row);
85 85
 			$group_class = $this->_get_group_class($row['group_type']);
86 86
 			$selected_option = $this->_get_selected_option($row['group_id'], $selected);
87
-			$options .= '<option' . $group_class . ' value="' . $row['group_id'] . '"' . $selected_option . '>' . $group_name . '</option>';
87
+			$options .= '<option'.$group_class.' value="'.$row['group_id'].'"'.$selected_option.'>'.$group_name.'</option>';
88 88
 		}
89 89
 		$this->db->sql_freeresult($result);
90 90
 
@@ -98,8 +98,8 @@  discard block
 block discarded – undo
98 98
 	private function _get_group_sql($mode)
99 99
 	{
100 100
 		return 'SELECT group_id, group_name, group_type 
101
-			FROM ' . GROUPS_TABLE .
102
-			(($mode === 'special') ? ' WHERE group_type = ' . GROUP_SPECIAL : '') . '
101
+			FROM ' . GROUPS_TABLE.
102
+			(($mode === 'special') ? ' WHERE group_type = '.GROUP_SPECIAL : '').'
103 103
 			ORDER BY group_type DESC, group_name ASC';
104 104
 	}
105 105
 
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 	 */
110 110
 	private function _get_group_name(array $row)
111 111
 	{
112
-		return ($row['group_type'] == GROUP_SPECIAL) ? $this->user->lang('G_' . $row['group_name']) : ucfirst($row['group_name']);
112
+		return ($row['group_type'] == GROUP_SPECIAL) ? $this->user->lang('G_'.$row['group_name']) : ucfirst($row['group_name']);
113 113
 	}
114 114
 
115 115
 	/**
Please login to merge, or discard this patch.
services/blocks/admin_bar.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -96,13 +96,13 @@  discard block
 block discarded – undo
96 96
 	public function set_javascript_data($route, $style_id)
97 97
 	{
98 98
 		$board_url = generate_board_url();
99
-		$ajax_url = $board_url . ((!$this->config['enable_mod_rewrite']) ? '/app.' . $this->php_ext : '');
99
+		$ajax_url = $board_url.((!$this->config['enable_mod_rewrite']) ? '/app.'.$this->php_ext : '');
100 100
 
101 101
 		$is_default_route = $u_default_route = false;
102 102
 		if ($this->config['sitemaker_default_layout'])
103 103
 		{
104 104
 			$is_default_route = ($this->config['sitemaker_default_layout'] === $route) ? true : false;
105
-			$u_default_route .= $board_url . '/' . $this->config['sitemaker_default_layout'];
105
+			$u_default_route .= $board_url.'/'.$this->config['sitemaker_default_layout'];
106 106
 			$u_default_route = reapply_sid($u_default_route);
107 107
 		}
108 108
 
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 			list($controller_service, $controller_method) = explode(':', $controller);
150 150
 			$controller_params	= $symfony_request->attributes->get('_route_params');
151 151
 			$controller_object	= $this->phpbb_container->get($controller_service);
152
-			$controller_class	= get_class($controller_object);
152
+			$controller_class = get_class($controller_object);
153 153
 
154 154
 			$r = new \ReflectionMethod($controller_class, $controller_method);
155 155
 			$class_params = $r->getParameters();
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 				'CONTROLLER_METHOD'	=> $controller_method,
163 163
 				'CONTROLLER_PARAMS'	=> $controller_arguments,
164 164
 				'S_IS_STARTPAGE'	=> $this->is_startpage($controller_service, $controller_arguments),
165
-				'UA_EXTENSION'		=> $namespace . '/' . $extension,
165
+				'UA_EXTENSION'		=> $namespace.'/'.$extension,
166 166
 			));
167 167
 		}
168 168
 	}
@@ -197,11 +197,11 @@  discard block
 block discarded – undo
197 197
 	{
198 198
 		$routes_ary = $this->get_routes();
199 199
 
200
-		$options = '<option value="">' . $this->user->lang('SELECT') . '</option>';
200
+		$options = '<option value="">'.$this->user->lang('SELECT').'</option>';
201 201
 		foreach ($routes_ary as $route)
202 202
 		{
203 203
 			$selected = ($route == $current_route) ? ' selected="selected"' : '';
204
-			$options .= '<option value="' . $route . '"' . $selected . '>' . $route . '</option>';
204
+			$options .= '<option value="'.$route.'"'.$selected.'>'.$route.'</option>';
205 205
 		}
206 206
 
207 207
 		return $options;
@@ -215,10 +215,10 @@  discard block
 block discarded – undo
215 215
 	 */
216 216
 	public function get_excluded_position_options(array $ex_positions)
217 217
 	{
218
-		$options = '<option value=""' . ((!sizeof($ex_positions)) ? ' selected="selected"' : '') . '>' . $this->user->lang('NONE') . '</option>';
218
+		$options = '<option value=""'.((!sizeof($ex_positions)) ? ' selected="selected"' : '').'>'.$this->user->lang('NONE').'</option>';
219 219
 		foreach ($ex_positions as $position)
220 220
 		{
221
-			$options .= '<option value="' . $position . '" selected="selected">' . $position . '</option>';
221
+			$options .= '<option value="'.$position.'" selected="selected">'.$position.'</option>';
222 222
 		}
223 223
 
224 224
 		return $options;
Please login to merge, or discard this patch.
exception/base.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -100,10 +100,10 @@
 block discarded – undo
100 100
 		foreach ($message_portions as &$message)
101 101
 		{
102 102
 			// Attempt to translate each portion
103
-			$translated_message = $user->lang('EXCEPTION_' . $message);
103
+			$translated_message = $user->lang('EXCEPTION_'.$message);
104 104
 
105 105
 			// Check if translating did anything
106
-			if ($translated_message !== 'EXCEPTION_' . $message)
106
+			if ($translated_message !== 'EXCEPTION_'.$message)
107 107
 			{
108 108
 				// It did, so replace message with the translated version
109 109
 				$message = $translated_message;
Please login to merge, or discard this patch.
blocks/forum_topics.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 	{
140 140
 		$this->set_display_fields();
141 141
 
142
-		$view = 'S_' . strtoupper($this->settings['template']);
142
+		$view = 'S_'.strtoupper($this->settings['template']);
143 143
 		$post_data = $this->get_post_data($topic_data);
144 144
 		$topic_data = array_values($topic_data);
145 145
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 	{
165 165
 		for ($i = 0, $size = sizeof($topic_data); $i < $size; $i++)
166 166
 		{
167
-			$row =& $topic_data[$i];
167
+			$row = & $topic_data[$i];
168 168
 			$forum_id = $row['forum_id'];
169 169
 			$topic_id = $row['topic_id'];
170 170
 
@@ -179,8 +179,8 @@  discard block
 block discarded – undo
179 179
 				'VIEWS'				=> $row['topic_views'],
180 180
 				'S_UNREAD_TOPIC'	=> $this->is_unread_topic($forum_id, $topic_id, $row['topic_last_post_time']),
181 181
 
182
-				'U_VIEWTOPIC'		=> append_sid($this->phpbb_root_path . 'viewtopic.' . $this->php_ext, "f=$forum_id&amp;t=$topic_id"),
183
-				'U_VIEWFORUM'		=> append_sid($this->phpbb_root_path . 'viewforum.' . $this->php_ext, "f=$forum_id"),
182
+				'U_VIEWTOPIC'		=> append_sid($this->phpbb_root_path.'viewtopic.'.$this->php_ext, "f=$forum_id&amp;t=$topic_id"),
183
+				'U_VIEWFORUM'		=> append_sid($this->phpbb_root_path.'viewforum.'.$this->php_ext, "f=$forum_id"),
184 184
 			);
185 185
 
186 186
 			$this->ptemplate->assign_block_vars('topicrow', $tpl_ary);
Please login to merge, or discard this patch.