blitze / phpBB-ext-sitemaker

services/userlist.php

Spacing +2 added lines, -2 removed lines

@@ -45,11 +45,11 @@
 			$curr_key = (int) array_search($settings['current_user'], $userlist);
 
 			// Remove the invalid user from the list
-			$new_list = str_replace($settings['current_user'] . ',', '', $settings['userlist'] . ',');
+			$new_list = str_replace($settings['current_user'].',', '', $settings['userlist'].',');
 			$new_list = trim($new_list, ',');
 
 			$new_userlist = self::_get_userlist($new_list);
-			$current_user =& $new_userlist[$curr_key - 1];
+			$current_user = & $new_userlist[$curr_key - 1];
 			$settings['current_user'] = (int) $current_user;
 			$settings['userlist'] = trim($new_list);
 			$settings['last_changed'] = 0;

services/groups.php

Spacing +6 added lines, -6 removed lines

@@ -35,7 +35,7 @@ 
 	public function get_users_groups()
 	{
 		$sql = 'SELECT group_id
-			FROM ' . USER_GROUP_TABLE . '
+			FROM ' . USER_GROUP_TABLE.'
 			WHERE user_id = ' . (int) $this->user->data['user_id'];
 		$result = $this->db->sql_query($sql);
 
@@ -78,13 +78,13 @@ 
 		$sql = $this->_get_group_sql($mode);
 		$result = $this->db->sql_query($sql);
 
-		$options = '<option value="0">' . $this->user->lang('ALL') . '</option>';
+		$options = '<option value="0">'.$this->user->lang('ALL').'</option>';
 		while ($row = $this->db->sql_fetchrow($result))
 		{
 			$group_name = $this->_get_group_name($row);
 			$group_class = $this->_get_group_class($row['group_type']);
 			$selected_option = $this->_get_selected_option($row['group_id'], $selected);
-			$options .= '<option' . $group_class . ' value="' . $row['group_id'] . '"' . $selected_option . '>' . $group_name . '</option>';
+			$options .= '<option'.$group_class.' value="'.$row['group_id'].'"'.$selected_option.'>'.$group_name.'</option>';
 		}
 		$this->db->sql_freeresult($result);
 
@@ -98,8 +98,8 @@ 
 	private function _get_group_sql($mode)
 	{
 		return 'SELECT group_id, group_name, group_type 
-			FROM ' . GROUPS_TABLE .
-			(($mode === 'special') ? ' WHERE group_type = ' . GROUP_SPECIAL : '') . '
+			FROM ' . GROUPS_TABLE.
+			(($mode === 'special') ? ' WHERE group_type = '.GROUP_SPECIAL : '').'
 			ORDER BY group_type DESC, group_name ASC';
 	}
 
@@ -109,7 +109,7 @@ 
 	 */
 	private function _get_group_name(array $row)
 	{
-		return ($row['group_type'] == GROUP_SPECIAL) ? $this->user->lang('G_' . $row['group_name']) : ucfirst($row['group_name']);
+		return ($row['group_type'] == GROUP_SPECIAL) ? $this->user->lang('G_'.$row['group_name']) : ucfirst($row['group_name']);
 	}
 
 	/**

services/blocks/admin_bar.php

Spacing +8 added lines, -8 removed lines

@@ -96,13 +96,13 @@ 
 	public function set_javascript_data($route, $style_id)
 	{
 		$board_url = generate_board_url();
-		$ajax_url = $board_url . ((!$this->config['enable_mod_rewrite']) ? '/app.' . $this->php_ext : '');
+		$ajax_url = $board_url.((!$this->config['enable_mod_rewrite']) ? '/app.'.$this->php_ext : '');
 
 		$is_default_route = $u_default_route = false;
 		if ($this->config['sitemaker_default_layout'])
 		{
 			$is_default_route = ($this->config['sitemaker_default_layout'] === $route) ? true : false;
-			$u_default_route .= $board_url . '/' . $this->config['sitemaker_default_layout'];
+			$u_default_route .= $board_url.'/'.$this->config['sitemaker_default_layout'];
 			$u_default_route = reapply_sid($u_default_route);
 		}
 
@@ -149,7 +149,7 @@ 
 			list($controller_service, $controller_method) = explode(':', $controller);
 			$controller_params	= $symfony_request->attributes->get('_route_params');
 			$controller_object	= $this->phpbb_container->get($controller_service);
-			$controller_class	= get_class($controller_object);
+			$controller_class = get_class($controller_object);
 
 			$r = new \ReflectionMethod($controller_class, $controller_method);
 			$class_params = $r->getParameters();
@@ -162,7 +162,7 @@ 
 				'CONTROLLER_METHOD'	=> $controller_method,
 				'CONTROLLER_PARAMS'	=> $controller_arguments,
 				'S_IS_STARTPAGE'	=> $this->is_startpage($controller_service, $controller_arguments),
-				'UA_EXTENSION'		=> $namespace . '/' . $extension,
+				'UA_EXTENSION'		=> $namespace.'/'.$extension,
 			));
 		}
 	}
@@ -197,11 +197,11 @@ 
 	{
 		$routes_ary = $this->get_routes();
 
-		$options = '<option value="">' . $this->user->lang('SELECT') . '</option>';
+		$options = '<option value="">'.$this->user->lang('SELECT').'</option>';
 		foreach ($routes_ary as $route)
 		{
 			$selected = ($route == $current_route) ? ' selected="selected"' : '';
-			$options .= '<option value="' . $route . '"' . $selected . '>' . $route . '</option>';
+			$options .= '<option value="'.$route.'"'.$selected.'>'.$route.'</option>';
 		}
 
 		return $options;
@@ -215,10 +215,10 @@ 
 	 */
 	public function get_excluded_position_options(array $ex_positions)
 	{
-		$options = '<option value=""' . ((!sizeof($ex_positions)) ? ' selected="selected"' : '') . '>' . $this->user->lang('NONE') . '</option>';
+		$options = '<option value=""'.((!sizeof($ex_positions)) ? ' selected="selected"' : '').'>'.$this->user->lang('NONE').'</option>';
 		foreach ($ex_positions as $position)
 		{
-			$options .= '<option value="' . $position . '" selected="selected">' . $position . '</option>';
+			$options .= '<option value="'.$position.'" selected="selected">'.$position.'</option>';
 		}
 
 		return $options;

services/blocks/cfg_fields.php

Spacing +7 added lines, -7 removed lines

@@ -35,12 +35,12 @@ 
 	public function build_multi_select(array $option_ary, $selected_items, $field)
 	{
 		$selected_items = $this->ensure_array($selected_items);
-		$html = '<select id="' . $field . '" name="config[' . $field . '][]" multiple="multiple">';
+		$html = '<select id="'.$field.'" name="config['.$field.'][]" multiple="multiple">';
 		foreach ($option_ary as $value => $title)
 		{
 			$title = $this->user->lang($title);
 			$selected = $this->get_selected_option($value, $selected_items);
-			$html .= '<option value="' . $value . '"' . $selected . '>' . $title . '</option>';
+			$html .= '<option value="'.$value.'"'.$selected.'>'.$title.'</option>';
 		}
 		$html .= '</select>';
 
@@ -99,7 +99,7 @@ 
 		{
 			$title = $this->user->lang($title);
 			$selected = $this->get_selected_option($value, $selected_item, 'checked');
-			$html .= '<label><input type="radio" name="config[' . $key . ']" value="' . $value . '"' . $selected . ' class="radio" /> ' . $title . '</label><br />';
+			$html .= '<label><input type="radio" name="config['.$key.']" value="'.$value.'"'.$selected.' class="radio" /> '.$title.'</label><br />';
 		}
 
 		return $html;
@@ -114,7 +114,7 @@ 
 	 */
 	public function build_hidden($value, $field)
 	{
-		return '<input type="hidden" name="config[' . $field . ']" value="' . $value . '" />';
+		return '<input type="hidden" name="config['.$field.']" value="'.$value.'" />';
 	}
 
 	/**
@@ -154,7 +154,7 @@ 
 	 */
 	protected function get_selected_option($needle, array $haystack, $type = 'selected')
 	{
-		return (in_array($needle, $haystack)) ? ' ' . $type . '="' . $type . '"' : '';
+		return (in_array($needle, $haystack)) ? ' '.$type.'="'.$type.'"' : '';
 	}
 
 	/**
@@ -167,12 +167,12 @@ 
 	 */
 	protected function get_checkbox_column(array $row, array $selected_items, $field, $column_count, $column_class)
 	{
-		$column = '<div class="' . $column_class . $field . '-checkbox" id="' . $field . '-col-' . $column_count . '">';
+		$column = '<div class="'.$column_class.$field.'-checkbox" id="'.$field.'-col-'.$column_count.'">';
 		foreach ($row as $value => $title)
 		{
 			$title = $this->user->lang($title);
 			$selected = $this->get_selected_option($value, $selected_items, 'checked');
-			$column .= '<label><input type="checkbox" name="config[' . $field . '][]" value="' . $value . '"' . $selected . ' accesskey="' . $field . '" class="checkbox" /> ' . $title . '</label><br />';
+			$column .= '<label><input type="checkbox" name="config['.$field.'][]" value="'.$value.'"'.$selected.' accesskey="'.$field.'" class="checkbox" /> '.$title.'</label><br />';
 		}
 		$column .= '</div>';
 

services/blocks/cfg_handler.php

Spacing +5 added lines, -5 removed lines

@@ -62,7 +62,7 @@ 
 
 		if (!function_exists('build_cfg_template'))
 		{
-			include($this->phpbb_root_path . 'includes/functions_acp.' . $this->php_ext); // @codeCoverageIgnore
+			include($this->phpbb_root_path.'includes/functions_acp.'.$this->php_ext); // @codeCoverageIgnore
 		}
 
 		// We fake this class as it is needed by the build_cfg_template function
@@ -83,7 +83,7 @@ 
 		// @codeCoverageIgnoreStart
 		if (!function_exists('validate_config_vars'))
 		{
-			include($this->phpbb_root_path . 'includes/functions_acp.' . $this->php_ext);
+			include($this->phpbb_root_path.'includes/functions_acp.'.$this->php_ext);
 		}
 		// @codeCoverageIgnoreEnd
 
@@ -171,7 +171,7 @@ 
 		$vars['append'] = $this->append_field($vars);
 
 		$type = explode(':', $vars['type']);
-		$method = 'prep_' . $type[0] . '_field_for_display';
+		$method = 'prep_'.$type[0].'_field_for_display';
 
 		if (is_callable(array($this, $method)))
 		{
@@ -215,7 +215,7 @@ 
 		$l_explain = '';
 		if (!empty($vars['explain']))
 		{
-			$l_explain = (isset($vars['lang_explain'])) ? $this->user->lang($vars['lang_explain']) : $this->user->lang($vars['lang'] . '_EXPLAIN');
+			$l_explain = (isset($vars['lang_explain'])) ? $this->user->lang($vars['lang_explain']) : $this->user->lang($vars['lang'].'_EXPLAIN');
 		}
 
 		return $l_explain;
@@ -317,7 +317,7 @@ 
 	{
 		$this->prep_checkbox_field_for_display($vars, $type, $field);
 
-		$vars['method'] ='build_multi_select';
+		$vars['method'] = 'build_multi_select';
 	}
 
 	/**

exception/base.php

Spacing +2 added lines, -2 removed lines

@@ -100,10 +100,10 @@
 		foreach ($message_portions as &$message)
 		{
 			// Attempt to translate each portion
-			$translated_message = $user->lang('EXCEPTION_' . $message);
+			$translated_message = $user->lang('EXCEPTION_'.$message);
 
 			// Check if translating did anything
-			if ($translated_message !== 'EXCEPTION_' . $message)
+			if ($translated_message !== 'EXCEPTION_'.$message)
 			{
 				// It did, so replace message with the translated version
 				$message = $translated_message;

blocks/forum_topics.php

Spacing +4 added lines, -4 removed lines

@@ -139,7 +139,7 @@ 
 	{
 		$this->set_display_fields();
 
-		$view = 'S_' . strtoupper($this->settings['template']);
+		$view = 'S_'.strtoupper($this->settings['template']);
 		$post_data = $this->get_post_data($topic_data);
 		$topic_data = array_values($topic_data);
 
@@ -164,7 +164,7 @@ 
 	{
 		for ($i = 0, $size = sizeof($topic_data); $i < $size; $i++)
 		{
-			$row =& $topic_data[$i];
+			$row = & $topic_data[$i];
 			$forum_id = $row['forum_id'];
 			$topic_id = $row['topic_id'];
 
@@ -179,8 +179,8 @@ 
 				'VIEWS'				=> $row['topic_views'],
 				'S_UNREAD_TOPIC'	=> $this->is_unread_topic($forum_id, $topic_id, $row['topic_last_post_time']),
 
-				'U_VIEWTOPIC'		=> append_sid($this->phpbb_root_path . 'viewtopic.' . $this->php_ext, "f=$forum_id&amp;t=$topic_id"),
-				'U_VIEWFORUM'		=> append_sid($this->phpbb_root_path . 'viewforum.' . $this->php_ext, "f=$forum_id"),
+				'U_VIEWTOPIC'		=> append_sid($this->phpbb_root_path.'viewtopic.'.$this->php_ext, "f=$forum_id&amp;t=$topic_id"),
+				'U_VIEWFORUM'		=> append_sid($this->phpbb_root_path.'viewforum.'.$this->php_ext, "f=$forum_id"),
 			);
 
 			$this->ptemplate->assign_block_vars('topicrow', $tpl_ary);

blocks/stats.php

Spacing +3 added lines, -3 removed lines

@@ -46,9 +46,9 @@
 	public function display(array $settings, $edit_mode = false)
 	{
 		$content = '';
-		$content .= $this->user->lang('TOTAL_POSTS_COUNT', (int) $this->config['num_posts']) . '<br />';
-		$content .= $this->user->lang('TOTAL_TOPICS', (int) $this->config['num_topics']) . '<br />';
-		$content .= $this->user->lang('TOTAL_USERS', (int) $this->config['num_users']) . '<br />';
+		$content .= $this->user->lang('TOTAL_POSTS_COUNT', (int) $this->config['num_posts']).'<br />';
+		$content .= $this->user->lang('TOTAL_TOPICS', (int) $this->config['num_topics']).'<br />';
+		$content .= $this->user->lang('TOTAL_USERS', (int) $this->config['num_users']).'<br />';
 		$content .= $this->user->lang('NEWEST_USER', get_username_string('full', $this->config['newest_user_id'], $this->config['newest_username'], $this->config['newest_user_colour']));
 
 		return array(

controller/forum.php

Spacing +2 added lines, -2 removed lines

@@ -59,11 +59,11 @@
 		 * to fix relative paths for forum images
 		 */
 		global $phpbb_root_path;
-		$phpbb_root_path = generate_board_url() . '/';
+		$phpbb_root_path = generate_board_url().'/';
 
 		if (!function_exists('display_forums'))
 		{
-			include($this->phpbb_root_path . 'includes/functions_display.' . $this->php_ext); // @codeCoverageIgnore
+			include($this->phpbb_root_path.'includes/functions_display.'.$this->php_ext); // @codeCoverageIgnore
 		}
 
 		display_forums('', $this->config['load_moderators']);