blitze / phpBB-ext-sitemaker

model/menus/mapper/items.php

Spacing +1 added lines, -1 removed lines

@@ -172,6 +172,6 @@
 	 */
 	protected function get_sql_where($menu_id)
 	{
-		return '%smenu_id = ' . (int) $menu_id;
+		return '%smenu_id = '.(int) $menu_id;
 	}
 }

services/poll.php

Spacing +8 added lines, -8 removed lines

@@ -68,7 +68,7 @@ 
 	 * @param array $topic_data
 	 * @param \phpbb\template\twig\twig $template
 	 */
-	public function build(array $topic_data, \phpbb\template\twig\twig &$template)
+	public function build(array $topic_data, \phpbb\template\twig\twig & $template)
 	{
 		$this->translator->add_lang('viewtopic');
 
@@ -100,7 +100,7 @@ 
 			'S_POLL_ACTION'		=> $viewtopic_url,
 			'S_FORM_TOKEN'		=> $this->sitemaker->get_form_key('posting'),
 
-			'U_VIEW_RESULTS'	=> $viewtopic_url . '&view=viewpoll',
+			'U_VIEW_RESULTS'	=> $viewtopic_url.'&view=viewpoll',
 		));
 	}
 
@@ -132,7 +132,7 @@ 
 		$post_id = (int) $topic_data['topic_first_post_id'];
 
 		$sql = 'SELECT o.*, p.bbcode_bitfield, p.bbcode_uid
-			FROM ' . POLL_OPTIONS_TABLE . ' o, ' . POSTS_TABLE . " p
+			FROM ' . POLL_OPTIONS_TABLE.' o, '.POSTS_TABLE." p
 			WHERE o.topic_id = $topic_id
 				AND p.post_id = $post_id
 				AND p.topic_id = o.topic_id
@@ -177,7 +177,7 @@ 
 	 * @param int $poll_most
 	 * @param \phpbb\template\twig\twig $template
 	 */
-	private function _build_poll_options(array $cur_voted_id, array $poll_info, $poll_total, $poll_most, \phpbb\template\twig\twig &$template)
+	private function _build_poll_options(array $cur_voted_id, array $poll_info, $poll_total, $poll_most, \phpbb\template\twig\twig & $template)
 	{
 		foreach ($poll_info as $poll_option)
 		{
@@ -208,8 +208,8 @@ 
 		if ($this->user->data['is_registered'])
 		{
 			$sql = 'SELECT poll_option_id
-			FROM ' . POLL_VOTES_TABLE . '
-			WHERE topic_id = ' . (int) $topic_id . '
+			FROM ' . POLL_VOTES_TABLE.'
+			WHERE topic_id = ' . (int) $topic_id.'
 				AND vote_user_id = ' . $this->user->data['user_id'];
 			$result = $this->db->sql_query($sql);
 
@@ -224,9 +224,9 @@ 
 			// Cookie based guest tracking ... I don't like this but hum ho
 			// it's oft requested. This relies on "nice" users who don't feel
 			// the need to delete cookies to mess with results.
-			if ($this->request->is_set($this->config['cookie_name'] . '_poll_' . $topic_id, \phpbb\request\request_interface::COOKIE))
+			if ($this->request->is_set($this->config['cookie_name'].'_poll_'.$topic_id, \phpbb\request\request_interface::COOKIE))
 			{
-				$cur_voted_id = explode(',', $this->request->variable($this->config['cookie_name'] . '_poll_' . $topic_id, '', true, \phpbb\request\request_interface::COOKIE));
+				$cur_voted_id = explode(',', $this->request->variable($this->config['cookie_name'].'_poll_'.$topic_id, '', true, \phpbb\request\request_interface::COOKIE));
 				$cur_voted_id = array_map('intval', $cur_voted_id);
 			}
 		}

services/members.php

Spacing +8 added lines, -8 removed lines

@@ -62,7 +62,7 @@ 
 
 		if (!function_exists('phpbb_get_user_avatar'))
 		{
-			include($phpbb_root_path . 'includes/functions_display.' . $php_ext);
+			include($phpbb_root_path.'includes/functions_display.'.$php_ext);
 		}
 	}
 
@@ -99,8 +99,8 @@ 
 	 */
 	protected function member_posts(array $row)
 	{
-		$u_posts = append_sid($this->phpbb_root_path . 'search.' . $this->php_ext, "author_id={$row['user_id']}&sr=posts" . $this->explain_range);
-		$user_posts = '<a href="' . $u_posts . '">' . $row['user_posts'] . '</a>';
+		$u_posts = append_sid($this->phpbb_root_path.'search.'.$this->php_ext, "author_id={$row['user_id']}&amp;sr=posts".$this->explain_range);
+		$user_posts = '<a href="'.$u_posts.'">'.$row['user_posts'].'</a>';
 
 		return array(
 			'USERNAME'		=> get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']),
@@ -168,7 +168,7 @@ 
 			'WHERE'			=> $this->db->sql_in_set('u.user_type', array(USER_NORMAL, USER_FOUNDER)),
 		);
 
-		$sql_method = 'set_' . $this->settings['query_type'] . '_sql';
+		$sql_method = 'set_'.$this->settings['query_type'].'_sql';
 		call_user_func_array(array($this, $sql_method), array(&$sql_ary));
 
 		$this->set_range_sql($sql_ary);
@@ -198,7 +198,7 @@ 
 		$this->info_header = '';
 		$this->view_mode = 'member_bots';
 
-		$sql_ary['WHERE'] = 'u.user_type = ' . USER_IGNORE;
+		$sql_ary['WHERE'] = 'u.user_type = '.USER_IGNORE;
 	}
 
 	/**
@@ -207,7 +207,7 @@ 
 	protected function set_tenured_sql(array &$sql_ary)
 	{
 		$sql_ary['SELECT'] .= ', u.user_regdate as member_date';
-		$sql_ary['ORDER_BY'] = 'u.user_regdate ' . (($this->settings['query_type'] == 'tenured') ? 'ASC' : 'DESC');
+		$sql_ary['ORDER_BY'] = 'u.user_regdate '.(($this->settings['query_type'] == 'tenured') ? 'ASC' : 'DESC');
 
 		$this->sql_date_field = 'u.user_regdate';
 		$this->settings['date_range'] = '';
@@ -230,7 +230,7 @@ 
 		$sql_ary['SELECT'] .= ', COUNT(p.post_id) as user_posts';
 		$sql_ary['FROM'] += array(TOPICS_TABLE => 't');
 		$sql_ary['FROM'] += array(POSTS_TABLE => 'p');
-		$sql_ary['WHERE'] .= ' AND ' . time() . ' > t.topic_time AND t.topic_id = p.topic_id AND p.post_visibility = ' . ITEM_APPROVED . ' AND p.poster_id = u.user_id';
+		$sql_ary['WHERE'] .= ' AND '.time().' > t.topic_time AND t.topic_id = p.topic_id AND p.post_visibility = '.ITEM_APPROVED.' AND p.poster_id = u.user_id';
 		$sql_ary['GROUP_BY'] = 'u.user_id';
 		$sql_ary['ORDER_BY'] = 'user_posts DESC, u.username ASC';
 
@@ -247,7 +247,7 @@ 
 		if ($this->settings['date_range'] && $this->sql_date_field)
 		{
 			$range = $this->date_range->get($this->settings['date_range']);
-			$this->explain_range = '&amp;date=' . $range['date'];
+			$this->explain_range = '&amp;date='.$range['date'];
 
 			$sql_ary['WHERE'] .= " AND {$this->sql_date_field} BETWEEN {$range['start']} AND {$range['stop']}";
 		}

services/blocks/admin_bar.php

Spacing +8 added lines, -8 removed lines

@@ -96,13 +96,13 @@ 
 	public function set_javascript_data($route, $style_id)
 	{
 		$board_url = generate_board_url();
-		$ajax_url = $board_url . ((!$this->config['enable_mod_rewrite']) ? '/app.' . $this->php_ext : '');
+		$ajax_url = $board_url.((!$this->config['enable_mod_rewrite']) ? '/app.'.$this->php_ext : '');
 
 		$is_default_route = $u_default_route = false;
 		if ($this->config['sitemaker_default_layout'])
 		{
 			$is_default_route = ($this->config['sitemaker_default_layout'] === $route) ? true : false;
-			$u_default_route .= $board_url . '/' . $this->config['sitemaker_default_layout'];
+			$u_default_route .= $board_url.'/'.$this->config['sitemaker_default_layout'];
 			$u_default_route = reapply_sid($u_default_route);
 		}
 
@@ -149,7 +149,7 @@ 
 			list($controller_service, $controller_method) = explode(':', $controller);
 			$controller_params	= $symfony_request->attributes->get('_route_params');
 			$controller_object	= $this->phpbb_container->get($controller_service);
-			$controller_class	= get_class($controller_object);
+			$controller_class = get_class($controller_object);
 
 			$r = new \ReflectionMethod($controller_class, $controller_method);
 			$class_params = $r->getParameters();
@@ -162,7 +162,7 @@ 
 				'CONTROLLER_METHOD'	=> $controller_method,
 				'CONTROLLER_PARAMS'	=> $controller_arguments,
 				'S_IS_STARTPAGE'	=> $this->is_startpage($controller_service, $controller_arguments),
-				'UA_EXTENSION'		=> $namespace . '/' . $extension,
+				'UA_EXTENSION'		=> $namespace.'/'.$extension,
 			));
 		}
 	}
@@ -197,11 +197,11 @@ 
 	{
 		$routes_ary = $this->get_routes();
 
-		$options = '<option value="">' . $this->translator->lang('SELECT') . '</option>';
+		$options = '<option value="">'.$this->translator->lang('SELECT').'</option>';
 		foreach ($routes_ary as $route)
 		{
 			$selected = ($route == $current_route) ? ' selected="selected"' : '';
-			$options .= '<option value="' . $route . '"' . $selected . '>' . $route . '</option>';
+			$options .= '<option value="'.$route.'"'.$selected.'>'.$route.'</option>';
 		}
 
 		return $options;
@@ -215,10 +215,10 @@ 
 	 */
 	public function get_excluded_position_options(array $ex_positions)
 	{
-		$options = '<option value=""' . ((!sizeof($ex_positions)) ? ' selected="selected"' : '') . '>' . $this->translator->lang('NONE') . '</option>';
+		$options = '<option value=""'.((!sizeof($ex_positions)) ? ' selected="selected"' : '').'>'.$this->translator->lang('NONE').'</option>';
 		foreach ($ex_positions as $position)
 		{
-			$options .= '<option value="' . $position . '" selected="selected">' . $position . '</option>';
+			$options .= '<option value="'.$position.'" selected="selected">'.$position.'</option>';
 		}
 
 		return $options;

services/blocks/action/edit_block.php

Spacing +1 added lines, -1 removed lines

@@ -59,6 +59,6 @@
 		$class_name = get_class($block_instance);
 		list($namespace, $extension) = explode('\\', $class_name);
 
-		return $namespace . '/' . $extension;
+		return $namespace.'/'.$extension;
 	}
 }

services/blocks/action_handler.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
 	 */
 	public function create($action)
 	{
-		$action_class = 'blitze\\sitemaker\\services\\blocks\\action\\' . $action;
+		$action_class = 'blitze\\sitemaker\\services\\blocks\\action\\'.$action;
 
 		if (!class_exists($action_class))
 		{

services/tree/builder.php

Spacing +19 added lines, -19 removed lines

@@ -55,8 +55,8 @@ 
 	 */
 	public function get_item_info($item_id = 0)
 	{
-		$sql = 'SELECT * FROM ' . $this->table_name . ' ' . $this->get_sql_where('WHERE') .
-			(($item_id) ? " AND {$this->column_item_id} = " . (int) $item_id : '');
+		$sql = 'SELECT * FROM '.$this->table_name.' '.$this->get_sql_where('WHERE').
+			(($item_id) ? " AND {$this->column_item_id} = ".(int) $item_id : '');
 
 		$result = $this->db->sql_query($sql);
 		$row = $this->db->sql_fetchrow($result);
@@ -75,8 +75,8 @@ 
 	public function update_item($item_id, array $sql_data)
 	{
 		$sql = "UPDATE {$this->table_name}
-			SET " . $this->db->sql_build_array('UPDATE', $sql_data) . "
-			WHERE $this->column_item_id = " . (int) $item_id;
+			SET ".$this->db->sql_build_array('UPDATE', $sql_data)."
+			WHERE $this->column_item_id = ".(int) $item_id;
 		$this->db->sql_query($sql);
 
 		return $sql_data;
@@ -109,7 +109,7 @@ 
 
 		// Rather than updating each item individually, we will just delete all items
 		// then add them all over again with new parent_id|left_id|right_id
-		$this->db->sql_query("DELETE FROM {$this->table_name} " . $this->get_sql_where('WHERE'));
+		$this->db->sql_query("DELETE FROM {$this->table_name} ".$this->get_sql_where('WHERE'));
 
 		// Now we add it back
 		$sql_data = $this->add_sub_tree($tree, 0);
@@ -158,7 +158,7 @@ 
 
 			if ($depth && !$parent_id)
 			{
-				throw new \RuntimeException($this->message_prefix . 'MALFORMED_TREE');
+				throw new \RuntimeException($this->message_prefix.'MALFORMED_TREE');
 			}
 
 			$key = $i + $max_id + 1;
@@ -230,23 +230,23 @@ 
 		foreach ($branch as $i => $row)
 		{
 			$left_id	= $right_id + 1;
-			$right_id   = $right_id + 2;
+			$right_id = $right_id + 2;
 
 			$sql_data[$i] = $row;
-			$sql_data[$i]['parent_id']	= $parent_id;
-			$sql_data[$i]['left_id']	= $left_id;
-			$sql_data[$i]['right_id']	= $right_id;
-			$sql_data[$i]['depth']		= $depth;
+			$sql_data[$i]['parent_id'] = $parent_id;
+			$sql_data[$i]['left_id'] = $left_id;
+			$sql_data[$i]['right_id'] = $right_id;
+			$sql_data[$i]['depth'] = $depth;
 
 			if ($row['parent_id'])
 			{
-				$left_id	= $sql_data[$row['parent_id']]['right_id'];
-				$right_id   = $left_id + 1;
+				$left_id = $sql_data[$row['parent_id']]['right_id'];
+				$right_id = $left_id + 1;
 
-				$sql_data[$i]['parent_id']	= $row['parent_id'];
-				$sql_data[$i]['depth']		= $sql_data[$row['parent_id']]['depth'] + 1;
-				$sql_data[$i]['left_id']	= $left_id;
-				$sql_data[$i]['right_id']	= $right_id;
+				$sql_data[$i]['parent_id'] = $row['parent_id'];
+				$sql_data[$i]['depth'] = $sql_data[$row['parent_id']]['depth'] + 1;
+				$sql_data[$i]['left_id'] = $left_id;
+				$sql_data[$i]['right_id'] = $right_id;
 
 				$this->update_right_side($sql_data, $right_id, $row['parent_id'], $branch);
 			}
@@ -272,7 +272,7 @@ 
 				$this->db->sql_transaction('rollback');
 				$this->lock->release();
 
-				throw new \RuntimeException($this->message_prefix . 'INVALID_PARENT');
+				throw new \RuntimeException($this->message_prefix.'INVALID_PARENT');
 			}
 
 			// adjust items in affected branch
@@ -300,7 +300,7 @@ 
 	protected function get_max_id($column, $use_sql_where = true)
 	{
 		$sql = "SELECT MAX($column) AS $column
-			FROM {$this->table_name} " .
+			FROM {$this->table_name} ".
 			(($use_sql_where) ? $this->get_sql_where('WHERE') : '');
 		$result = $this->db->sql_query($sql);
 		$max_id = $this->db->sql_fetchfield($column);

services/date_range.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
 		$time = $this->user->create_datetime($this->time);
 		$now = phpbb_gmgetdate($time->getTimestamp() + $time->getOffset());
 
-		$method = 'get_' . $range;
+		$method = 'get_'.$range;
 		$data = array(
 			'start'	=> 0,
 			'stop'	=> 0,

services/auto_lang.php

Spacing +4 added lines, -4 removed lines

@@ -64,8 +64,8 @@ 
 			$default_lang_files = $finder
 				->prefix($lang_file)
 				->suffix(".$this->php_ext")
-				->extension_directory('/language/' . basename($this->config['default_lang']))
-				->core_path('language/' . basename($this->config['default_lang']) . '/')
+				->extension_directory('/language/'.basename($this->config['default_lang']))
+				->core_path('language/'.basename($this->config['default_lang']).'/')
 				->find();
 		}
 
@@ -84,8 +84,8 @@ 
 		$user_lang_files = $finder
 			->prefix($lang_file)
 			->suffix(".$this->php_ext")
-			->extension_directory('/language/' . $this->user->lang_name)
-			->core_path('language/' . $this->user->lang_name . '/')
+			->extension_directory('/language/'.$this->user->lang_name)
+			->core_path('language/'.$this->user->lang_name.'/')
 			->find();
 
 		$lang_files = array_unique(array_merge($user_lang_files, $english_lang_files, $default_lang_files));