Completed
Push — master ( cbbc79...7e8448 )
by Daniel
08:03
created
event/listener.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -112,8 +112,8 @@  discard block
 block discarded – undo
112 112
 	public function load_permission_language(\phpbb\event\data $event)
113 113
 	{
114 114
 		$permissions = $event['permissions'];
115
-		$permissions['a_sm_manage_blocks']	= array('lang' => 'ACL_A_SM_MANAGE_BLOCKS', 'cat' => 'misc');
116
-		$permissions['a_sm_manage_menus']	= array('lang' => 'ACL_A_SM_MANAGE_MENUS', 'cat' => 'misc');
115
+		$permissions['a_sm_manage_blocks'] = array('lang' => 'ACL_A_SM_MANAGE_BLOCKS', 'cat' => 'misc');
116
+		$permissions['a_sm_manage_menus'] = array('lang' => 'ACL_A_SM_MANAGE_MENUS', 'cat' => 'misc');
117 117
 		$event['permissions'] = $permissions;
118 118
 	}
119 119
 
@@ -192,13 +192,13 @@  discard block
 block discarded – undo
192 192
 	 */
193 193
 	public function set_startpage(\phpbb\event\data $event)
194 194
 	{
195
-		if ($this->user->page['page_name'] == 'index.' . $this->php_ext && !$this->startpage && ($controller_object = $this->get_startpage_controller()) !== false)
195
+		if ($this->user->page['page_name'] == 'index.'.$this->php_ext && !$this->startpage && ($controller_object = $this->get_startpage_controller()) !== false)
196 196
 		{
197 197
 			$method = $this->config['sitemaker_startpage_method'];
198 198
 			$this->startpage = true;
199 199
 
200 200
 			$controller_dir = explode('\\', get_class($controller_object));
201
-			$controller_style_dir = 'ext/' . $controller_dir[0] . '/' . $controller_dir[1] . '/styles';
201
+			$controller_style_dir = 'ext/'.$controller_dir[0].'/'.$controller_dir[1].'/styles';
202 202
 			$this->template->set_style(array($controller_style_dir, 'styles'));
203 203
 
204 204
 			$arguments = explode('/', $this->config['sitemaker_startpage_params']);
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 	 */
220 220
 	public function add_viewonline_location(\phpbb\event\data $event)
221 221
 	{
222
-		if ($event['on_page'][1] == 'app' && strrpos($event['row']['session_page'], 'app.' . $this->php_ext . '/forum') === 0)
222
+		if ($event['on_page'][1] == 'app' && strrpos($event['row']['session_page'], 'app.'.$this->php_ext.'/forum') === 0)
223 223
 		{
224 224
 			$event['location'] = $this->user->lang('FORUM_INDEX');
225 225
 			$event['location_url'] = $this->phpbb_container->get('controller.helper')->route('blitze_sitemaker_forum');
Please login to merge, or discard this patch.
services/forum/query_builder.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 
143 143
 		if (in_array($topic_type, array(POST_STICKY, POST_ANNOUNCE)))
144 144
 		{
145
-			$this->store['sql_array']['WHERE'][] = '(t.topic_time_limit > 0 AND (t.topic_time + t.topic_time_limit) < ' . time() . ')';
145
+			$this->store['sql_array']['WHERE'][] = '(t.topic_time_limit > 0 AND (t.topic_time + t.topic_time_limit) < '.time().')';
146 146
 		}
147 147
 
148 148
 		return $this;
@@ -160,13 +160,13 @@  discard block
 block discarded – undo
160 160
 			$this->store['sql_array']['SELECT'][] = 'tw.notify_status';
161 161
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
162 162
 				'FROM'	=> array(TOPICS_WATCH_TABLE => 'tw'),
163
-				'ON'	=> 'tw.user_id = ' . $this->user->data['user_id'] . ' AND t.topic_id = tw.topic_id'
163
+				'ON'	=> 'tw.user_id = '.$this->user->data['user_id'].' AND t.topic_id = tw.topic_id'
164 164
 			);
165 165
 
166 166
 			$this->store['sql_array']['SELECT'][] = 'fw.notify_status';
167 167
 			$this->store['sql_array']['LEFT JOIN'][] = array(
168 168
 				'FROM'	=> array(FORUMS_WATCH_TABLE => 'fw'),
169
-				'ON'	=> '(fw.forum_id = f.forum_id AND fw.user_id = ' . $this->user->data['user_id'] . ')',
169
+				'ON'	=> '(fw.forum_id = f.forum_id AND fw.user_id = '.$this->user->data['user_id'].')',
170 170
 			);
171 171
 		}
172 172
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 			$this->store['sql_array']['SELECT'][] = 'bm.topic_id as bookmarked';
186 186
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
187 187
 				'FROM'	=> array(BOOKMARKS_TABLE => 'bm'),
188
-				'ON'	=> 'bm.user_id = ' . $this->user->data['user_id'] . ' AND t.topic_id = bm.topic_id'
188
+				'ON'	=> 'bm.user_id = '.$this->user->data['user_id'].' AND t.topic_id = bm.topic_id'
189 189
 			);
190 190
 		}
191 191
 
@@ -206,12 +206,12 @@  discard block
 block discarded – undo
206 206
 			$this->store['sql_array']['SELECT'][] = 'tt.mark_time, ft.mark_time as forum_mark_time';
207 207
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
208 208
 				'FROM'	=> array(TOPICS_TRACK_TABLE => 'tt'),
209
-				'ON'	=> 'tt.user_id = ' . $this->user->data['user_id'] . ' AND t.topic_id = tt.topic_id'
209
+				'ON'	=> 'tt.user_id = '.$this->user->data['user_id'].' AND t.topic_id = tt.topic_id'
210 210
 			);
211 211
 
212 212
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
213 213
 				'FROM'	=> array(FORUMS_TRACK_TABLE => 'ft'),
214
-				'ON'	=> 'ft.user_id = ' . $this->user->data['user_id'] . ' AND t.forum_id = ft.forum_id'
214
+				'ON'	=> 'ft.user_id = '.$this->user->data['user_id'].' AND t.forum_id = ft.forum_id'
215 215
 			);
216 216
 		}
217 217
 
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 	{
231 231
 		if ($unix_start_time && $unix_stop_time)
232 232
 		{
233
-			$this->store['sql_array']['WHERE'][] = (($mode == 'topic') ? 't.topic_time' : 'p.post_time') . " BETWEEN $unix_start_time AND $unix_stop_time";
233
+			$this->store['sql_array']['WHERE'][] = (($mode == 'topic') ? 't.topic_time' : 'p.post_time')." BETWEEN $unix_start_time AND $unix_stop_time";
234 234
 		}
235 235
 
236 236
 		return $this;
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
 	 */
263 263
 	public function set_sorting($sort_key, $sort_dir = 'DESC')
264 264
 	{
265
-		$this->store['sql_array']['ORDER_BY'] = $sort_key . ' ' . $sort_dir;
265
+		$this->store['sql_array']['ORDER_BY'] = $sort_key.' '.$sort_dir;
266 266
 
267 267
 		return $this;
268 268
 	}
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
 	{
324 324
 		if (!empty($column_id))
325 325
 		{
326
-			$this->store['sql_array']['WHERE'][] = (is_array($column_id)) ? $this->db->sql_in_set($column, $column_id) : $column . ' = ' . (int) $column_id;
326
+			$this->store['sql_array']['WHERE'][] = (is_array($column_id)) ? $this->db->sql_in_set($column, $column_id) : $column.' = '.(int) $column_id;
327 327
 		}
328 328
 	}
329 329
 
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
 	{
335 335
 		if ($check_visibility)
336 336
 		{
337
-			$this->store['sql_array']['WHERE'][] = 't.topic_time <= ' . time();
337
+			$this->store['sql_array']['WHERE'][] = 't.topic_time <= '.time();
338 338
 			$this->store['sql_array']['WHERE'][] = $this->content_visibility->get_global_visibility_sql('topic', $this->ex_fid_ary, 't.');
339 339
 		}
340 340
 	}
Please login to merge, or discard this patch.
services/menus/action/add_menu.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 
21 21
 		/** @type \blitze\sitemaker\model\menus\entity\menu $entity */
22 22
 		$entity = $menu_mapper->create_entity(array(
23
-			'menu_name' => $this->user->lang('MENU') . '-' . mt_rand(1000, 9999),
23
+			'menu_name' => $this->user->lang('MENU').'-'.mt_rand(1000, 9999),
24 24
 		));
25 25
 
26 26
 		$entity = $menu_mapper->save($entity);
Please login to merge, or discard this patch.
services/profilefields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 
46 46
 		if (!function_exists('phpbb_show_profile'))
47 47
 		{
48
-			include($this->phpbb_root_path . 'includes/functions_display.' . $this->php_ext);
48
+			include($this->phpbb_root_path.'includes/functions_display.'.$this->php_ext);
49 49
 		}
50 50
 	}
51 51
 
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
55 55
 	public function get_all_fields()
56 56
 	{
57 57
 		$sql = 'SELECT l.lang_name, f.field_ident
58
-			FROM ' . PROFILE_LANG_TABLE . ' l, ' . PROFILE_FIELDS_TABLE . ' f
59
-			WHERE l.lang_id = ' . $this->user->get_iso_lang_id() . '
58
+			FROM ' . PROFILE_LANG_TABLE.' l, '.PROFILE_FIELDS_TABLE.' f
59
+			WHERE l.lang_id = ' . $this->user->get_iso_lang_id().'
60 60
 				AND f.field_active = 1
61 61
 				AND f.field_no_view = 0
62 62
 				AND f.field_hide = 0
Please login to merge, or discard this patch.
services/userlist.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,11 +45,11 @@
 block discarded – undo
45 45
 			$curr_key = (int) array_search($settings['current_user'], $userlist);
46 46
 
47 47
 			// Remove the invalid user from the list
48
-			$new_list = str_replace($settings['current_user'] . ',', '', $settings['userlist'] . ',');
48
+			$new_list = str_replace($settings['current_user'].',', '', $settings['userlist'].',');
49 49
 			$new_list = trim($new_list, ',');
50 50
 
51 51
 			$new_userlist = self::_get_userlist($new_list);
52
-			$current_user =& $new_userlist[$curr_key - 1];
52
+			$current_user = & $new_userlist[$curr_key - 1];
53 53
 			$settings['current_user'] = (int) $current_user;
54 54
 			$settings['userlist'] = trim($new_list);
55 55
 			$settings['last_changed'] = 0;
Please login to merge, or discard this patch.
services/groups.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	public function get_users_groups()
36 36
 	{
37 37
 		$sql = 'SELECT group_id
38
-			FROM ' . USER_GROUP_TABLE . '
38
+			FROM ' . USER_GROUP_TABLE.'
39 39
 			WHERE user_id = ' . (int) $this->user->data['user_id'];
40 40
 		$result = $this->db->sql_query($sql);
41 41
 
@@ -78,13 +78,13 @@  discard block
 block discarded – undo
78 78
 		$sql = $this->_get_group_sql($mode);
79 79
 		$result = $this->db->sql_query($sql);
80 80
 
81
-		$options = '<option value="0">' . $this->user->lang('ALL') . '</option>';
81
+		$options = '<option value="0">'.$this->user->lang('ALL').'</option>';
82 82
 		while ($row = $this->db->sql_fetchrow($result))
83 83
 		{
84 84
 			$group_name = $this->_get_group_name($row);
85 85
 			$group_class = $this->_get_group_class($row['group_type']);
86 86
 			$selected_option = $this->_get_selected_option($row['group_id'], $selected);
87
-			$options .= '<option' . $group_class . ' value="' . $row['group_id'] . '"' . $selected_option . '>' . $group_name . '</option>';
87
+			$options .= '<option'.$group_class.' value="'.$row['group_id'].'"'.$selected_option.'>'.$group_name.'</option>';
88 88
 		}
89 89
 		$this->db->sql_freeresult($result);
90 90
 
@@ -98,8 +98,8 @@  discard block
 block discarded – undo
98 98
 	private function _get_group_sql($mode)
99 99
 	{
100 100
 		return 'SELECT group_id, group_name, group_type 
101
-			FROM ' . GROUPS_TABLE .
102
-			(($mode === 'special') ? ' WHERE group_type = ' . GROUP_SPECIAL : '') . '
101
+			FROM ' . GROUPS_TABLE.
102
+			(($mode === 'special') ? ' WHERE group_type = '.GROUP_SPECIAL : '').'
103 103
 			ORDER BY group_type DESC, group_name ASC';
104 104
 	}
105 105
 
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 	 */
110 110
 	private function _get_group_name(array $row)
111 111
 	{
112
-		return ($row['group_type'] == GROUP_SPECIAL) ? $this->user->lang('G_' . $row['group_name']) : ucfirst($row['group_name']);
112
+		return ($row['group_type'] == GROUP_SPECIAL) ? $this->user->lang('G_'.$row['group_name']) : ucfirst($row['group_name']);
113 113
 	}
114 114
 
115 115
 	/**
Please login to merge, or discard this patch.
services/blocks/admin_bar.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -96,13 +96,13 @@  discard block
 block discarded – undo
96 96
 	public function set_javascript_data($route, $style_id)
97 97
 	{
98 98
 		$board_url = generate_board_url();
99
-		$ajax_url = $board_url . ((!$this->config['enable_mod_rewrite']) ? '/app.' . $this->php_ext : '');
99
+		$ajax_url = $board_url.((!$this->config['enable_mod_rewrite']) ? '/app.'.$this->php_ext : '');
100 100
 
101 101
 		$is_default_route = $u_default_route = false;
102 102
 		if ($this->config['sitemaker_default_layout'])
103 103
 		{
104 104
 			$is_default_route = ($this->config['sitemaker_default_layout'] === $route) ? true : false;
105
-			$u_default_route .= $board_url . '/' . $this->config['sitemaker_default_layout'];
105
+			$u_default_route .= $board_url.'/'.$this->config['sitemaker_default_layout'];
106 106
 			$u_default_route = reapply_sid($u_default_route);
107 107
 		}
108 108
 
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 			list($controller_service, $controller_method) = explode(':', $controller);
150 150
 			$controller_params	= $symfony_request->attributes->get('_route_params');
151 151
 			$controller_object	= $this->phpbb_container->get($controller_service);
152
-			$controller_class	= get_class($controller_object);
152
+			$controller_class = get_class($controller_object);
153 153
 
154 154
 			$r = new \ReflectionMethod($controller_class, $controller_method);
155 155
 			$class_params = $r->getParameters();
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
 				'CONTROLLER_METHOD'	=> $controller_method,
163 163
 				'CONTROLLER_PARAMS'	=> $controller_arguments,
164 164
 				'S_IS_STARTPAGE'	=> $this->is_startpage($controller_service, $controller_arguments),
165
-				'UA_EXTENSION'		=> $namespace . '/' . $extension,
165
+				'UA_EXTENSION'		=> $namespace.'/'.$extension,
166 166
 			));
167 167
 		}
168 168
 	}
@@ -197,11 +197,11 @@  discard block
 block discarded – undo
197 197
 	{
198 198
 		$routes_ary = $this->get_routes();
199 199
 
200
-		$options = '<option value="">' . $this->user->lang('SELECT') . '</option>';
200
+		$options = '<option value="">'.$this->user->lang('SELECT').'</option>';
201 201
 		foreach ($routes_ary as $route)
202 202
 		{
203 203
 			$selected = ($route == $current_route) ? ' selected="selected"' : '';
204
-			$options .= '<option value="' . $route . '"' . $selected . '>' . $route . '</option>';
204
+			$options .= '<option value="'.$route.'"'.$selected.'>'.$route.'</option>';
205 205
 		}
206 206
 
207 207
 		return $options;
@@ -215,10 +215,10 @@  discard block
 block discarded – undo
215 215
 	 */
216 216
 	public function get_excluded_position_options(array $ex_positions)
217 217
 	{
218
-		$options = '<option value=""' . ((!sizeof($ex_positions)) ? ' selected="selected"' : '') . '>' . $this->user->lang('NONE') . '</option>';
218
+		$options = '<option value=""'.((!sizeof($ex_positions)) ? ' selected="selected"' : '').'>'.$this->user->lang('NONE').'</option>';
219 219
 		foreach ($ex_positions as $position)
220 220
 		{
221
-			$options .= '<option value="' . $position . '" selected="selected">' . $position . '</option>';
221
+			$options .= '<option value="'.$position.'" selected="selected">'.$position.'</option>';
222 222
 		}
223 223
 
224 224
 		return $options;
Please login to merge, or discard this patch.
services/blocks/cfg_fields.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -35,12 +35,12 @@  discard block
 block discarded – undo
35 35
 	public function build_multi_select(array $option_ary, $selected_items, $field)
36 36
 	{
37 37
 		$selected_items = $this->ensure_array($selected_items);
38
-		$html = '<select id="' . $field . '" name="config[' . $field . '][]" multiple="multiple">';
38
+		$html = '<select id="'.$field.'" name="config['.$field.'][]" multiple="multiple">';
39 39
 		foreach ($option_ary as $value => $title)
40 40
 		{
41 41
 			$title = $this->user->lang($title);
42 42
 			$selected = $this->get_selected_option($value, $selected_items);
43
-			$html .= '<option value="' . $value . '"' . $selected . '>' . $title . '</option>';
43
+			$html .= '<option value="'.$value.'"'.$selected.'>'.$title.'</option>';
44 44
 		}
45 45
 		$html .= '</select>';
46 46
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 		{
100 100
 			$title = $this->user->lang($title);
101 101
 			$selected = $this->get_selected_option($value, $selected_item, 'checked');
102
-			$html .= '<label><input type="radio" name="config[' . $key . ']" value="' . $value . '"' . $selected . ' class="radio" /> ' . $title . '</label><br />';
102
+			$html .= '<label><input type="radio" name="config['.$key.']" value="'.$value.'"'.$selected.' class="radio" /> '.$title.'</label><br />';
103 103
 		}
104 104
 
105 105
 		return $html;
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 	 */
115 115
 	public function build_hidden($value, $field)
116 116
 	{
117
-		return '<input type="hidden" name="config[' . $field . ']" value="' . $value . '" />';
117
+		return '<input type="hidden" name="config['.$field.']" value="'.$value.'" />';
118 118
 	}
119 119
 
120 120
 	/**
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 	 */
155 155
 	protected function get_selected_option($needle, array $haystack, $type = 'selected')
156 156
 	{
157
-		return (in_array($needle, $haystack)) ? ' ' . $type . '="' . $type . '"' : '';
157
+		return (in_array($needle, $haystack)) ? ' '.$type.'="'.$type.'"' : '';
158 158
 	}
159 159
 
160 160
 	/**
@@ -167,12 +167,12 @@  discard block
 block discarded – undo
167 167
 	 */
168 168
 	protected function get_checkbox_column(array $row, array $selected_items, $field, $column_count, $column_class)
169 169
 	{
170
-		$column = '<div class="' . $column_class . $field . '-checkbox" id="' . $field . '-col-' . $column_count . '">';
170
+		$column = '<div class="'.$column_class.$field.'-checkbox" id="'.$field.'-col-'.$column_count.'">';
171 171
 		foreach ($row as $value => $title)
172 172
 		{
173 173
 			$title = $this->user->lang($title);
174 174
 			$selected = $this->get_selected_option($value, $selected_items, 'checked');
175
-			$column .= '<label><input type="checkbox" name="config[' . $field . '][]" value="' . $value . '"' . $selected . ' accesskey="' . $field . '" class="checkbox" /> ' . $title . '</label><br />';
175
+			$column .= '<label><input type="checkbox" name="config['.$field.'][]" value="'.$value.'"'.$selected.' accesskey="'.$field.'" class="checkbox" /> '.$title.'</label><br />';
176 176
 		}
177 177
 		$column .= '</div>';
178 178
 
Please login to merge, or discard this patch.
services/blocks/cfg_handler.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 
63 63
 		if (!function_exists('build_cfg_template'))
64 64
 		{
65
-			include($this->phpbb_root_path . 'includes/functions_acp.' . $this->php_ext); // @codeCoverageIgnore
65
+			include($this->phpbb_root_path.'includes/functions_acp.'.$this->php_ext); // @codeCoverageIgnore
66 66
 		}
67 67
 
68 68
 		// We fake this class as it is needed by the build_cfg_template function
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 		// @codeCoverageIgnoreStart
84 84
 		if (!function_exists('validate_config_vars'))
85 85
 		{
86
-			include($this->phpbb_root_path . 'includes/functions_acp.' . $this->php_ext);
86
+			include($this->phpbb_root_path.'includes/functions_acp.'.$this->php_ext);
87 87
 		}
88 88
 		// @codeCoverageIgnoreEnd
89 89
 
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 		$vars['append'] = $this->append_field($vars);
172 172
 
173 173
 		$type = explode(':', $vars['type']);
174
-		$method = 'prep_' . $type[0] . '_field_for_display';
174
+		$method = 'prep_'.$type[0].'_field_for_display';
175 175
 
176 176
 		if (is_callable(array($this, $method)))
177 177
 		{
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 		$l_explain = '';
216 216
 		if (!empty($vars['explain']))
217 217
 		{
218
-			$l_explain = (isset($vars['lang_explain'])) ? $this->user->lang($vars['lang_explain']) : $this->user->lang($vars['lang'] . '_EXPLAIN');
218
+			$l_explain = (isset($vars['lang_explain'])) ? $this->user->lang($vars['lang_explain']) : $this->user->lang($vars['lang'].'_EXPLAIN');
219 219
 		}
220 220
 
221 221
 		return $l_explain;
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
 	{
318 318
 		$this->prep_checkbox_field_for_display($vars, $type, $field);
319 319
 
320
-		$vars['method'] ='build_multi_select';
320
+		$vars['method'] = 'build_multi_select';
321 321
 	}
322 322
 
323 323
 	/**
Please login to merge, or discard this patch.