Completed
Pull Request — master (#26)
by Daniel
12:32 queued 09:49
created
services/forum/query_builder.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 			$this->store['sql_array']['SELECT'][] = 'ws.notify_status';
168 168
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
169 169
 				'FROM'	=> array($keys[$type]['table'] => 'ws'),
170
-				'ON'	=> $keys[$type]['cond'] . ' AND ws.user_id = ' . (int) $this->user->data['user_id'],
170
+				'ON'	=> $keys[$type]['cond'].' AND ws.user_id = '.(int) $this->user->data['user_id'],
171 171
 			);
172 172
 		}
173 173
 
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 			$this->store['sql_array']['SELECT'][] = 'bm.topic_id as bookmarked';
187 187
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
188 188
 				'FROM'	=> array(BOOKMARKS_TABLE => 'bm'),
189
-				'ON'	=> 'bm.user_id = ' . (int) $this->user->data['user_id'] . ' AND t.topic_id = bm.topic_id'
189
+				'ON'	=> 'bm.user_id = '.(int) $this->user->data['user_id'].' AND t.topic_id = bm.topic_id'
190 190
 			);
191 191
 		}
192 192
 
@@ -207,12 +207,12 @@  discard block
 block discarded – undo
207 207
 			$this->store['sql_array']['SELECT'][] = 'tt.mark_time, ft.mark_time as forum_mark_time';
208 208
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
209 209
 				'FROM'	=> array(TOPICS_TRACK_TABLE => 'tt'),
210
-				'ON'	=> 'tt.user_id = ' . (int) $this->user->data['user_id'] . ' AND t.topic_id = tt.topic_id'
210
+				'ON'	=> 'tt.user_id = '.(int) $this->user->data['user_id'].' AND t.topic_id = tt.topic_id'
211 211
 			);
212 212
 
213 213
 			$this->store['sql_array']['LEFT_JOIN'][] = array(
214 214
 				'FROM'	=> array(FORUMS_TRACK_TABLE => 'ft'),
215
-				'ON'	=> 'ft.user_id = ' . (int) $this->user->data['user_id'] . ' AND t.forum_id = ft.forum_id'
215
+				'ON'	=> 'ft.user_id = '.(int) $this->user->data['user_id'].' AND t.forum_id = ft.forum_id'
216 216
 			);
217 217
 		}
218 218
 
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
 	{
232 232
 		if ($unix_start_time && $unix_stop_time)
233 233
 		{
234
-			$this->store['sql_array']['WHERE'][] = (($mode == 'topic') ? 't.topic_time' : 'p.post_time') . " BETWEEN $unix_start_time AND $unix_stop_time";
234
+			$this->store['sql_array']['WHERE'][] = (($mode == 'topic') ? 't.topic_time' : 'p.post_time')." BETWEEN $unix_start_time AND $unix_stop_time";
235 235
 		}
236 236
 
237 237
 		return $this;
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
 	 */
264 264
 	public function set_sorting($sort_key, $sort_dir = 'DESC')
265 265
 	{
266
-		$this->store['sql_array']['ORDER_BY'] = $sort_key . ' ' . $sort_dir;
266
+		$this->store['sql_array']['ORDER_BY'] = $sort_key.' '.$sort_dir;
267 267
 
268 268
 		return $this;
269 269
 	}
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 	{
325 325
 		if (!empty($column_id))
326 326
 		{
327
-			$this->store['sql_array']['WHERE'][] = (is_array($column_id)) ? $this->db->sql_in_set($column, $column_id) : $column . ' = ' . (int) $column_id;
327
+			$this->store['sql_array']['WHERE'][] = (is_array($column_id)) ? $this->db->sql_in_set($column, $column_id) : $column.' = '.(int) $column_id;
328 328
 		}
329 329
 	}
330 330
 
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
 	{
336 336
 		if ($check_visibility)
337 337
 		{
338
-			$this->store['sql_array']['WHERE'][] = 't.topic_time <= ' . time();
338
+			$this->store['sql_array']['WHERE'][] = 't.topic_time <= '.time();
339 339
 			$this->store['sql_array']['WHERE'][] = $this->content_visibility->get_global_visibility_sql('topic', $this->ex_fid_ary, 't.');
340 340
 		}
341 341
 	}
Please login to merge, or discard this patch.
model/entity/item.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 	 */
137 137
 	public function set_item_icon($icon)
138 138
 	{
139
-		$this->item_icon = ($icon) ? trim($icon) . ' ' : '';
139
+		$this->item_icon = ($icon) ? trim($icon).' ' : '';
140 140
 		return $this;
141 141
 	}
142 142
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 		// add leading / for local paths, except leading hashtags
154 154
 		if ($this->is_local($this->item_url) && $this->item_url[0] !== '#')
155 155
 		{
156
-			$this->item_url = '/' . ltrim($this->item_url, './');
156
+			$this->item_url = '/'.ltrim($this->item_url, './');
157 157
 		}
158 158
 
159 159
 		return $this;
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 
169 169
 		if ($this->is_local($item_url) && $item_url[0] === '/')
170 170
 		{
171
-			$item_url = $this->board_url . $item_url;
171
+			$item_url = $this->board_url.$item_url;
172 172
 			if ($this->mod_rewrite_enabled)
173 173
 			{
174 174
 				$item_url = str_replace('app.php/', '', $item_url);
Please login to merge, or discard this patch.
blocks/links.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@
 block discarded – undo
72 72
 
73 73
 		return array(
74 74
 			'title'     => $this->title,
75
-			'content'   => $this->ptemplate->render_view('blitze/sitemaker', 'blocks/' . $this->tpl_name . '.html', $this->tpl_name . '_block'),
75
+			'content'   => $this->ptemplate->render_view('blitze/sitemaker', 'blocks/'.$this->tpl_name.'.html', $this->tpl_name.'_block'),
76 76
 		);
77 77
 	}
78 78
 
Please login to merge, or discard this patch.
services/menus/navigation.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
 	{
139 139
 		$row['is_navigable'] = $this->is_navigable($row);
140 140
 		$row['is_expandable'] = ($row['is_navigable'] && !$row['item_target']) ? true : false;
141
-		$row['url_path'] = str_replace('/index.' . $this->php_ext, '/', $row['url_path']);
141
+		$row['url_path'] = str_replace('/index.'.$this->php_ext, '/', $row['url_path']);
142 142
 	}
143 143
 
144 144
 	/**
@@ -177,8 +177,8 @@  discard block
 block discarded – undo
177 177
 	{
178 178
 		sort($row['url_query']);
179 179
 
180
-		$row['url_path'] = ($row['url_path'] === '/') ? '/index.' . $this->php_ext : $row['url_path'];
180
+		$row['url_path'] = ($row['url_path'] === '/') ? '/index.'.$this->php_ext : $row['url_path'];
181 181
 
182
-		return $row['url_path'] . ((sizeof($row['url_query'])) ? '?' . join('&', $row['url_query']) : '');
182
+		return $row['url_path'].((sizeof($row['url_query'])) ? '?'.join('&', $row['url_query']) : '');
183 183
 	}
184 184
 }
Please login to merge, or discard this patch.
services/menus/display.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@
 block discarded – undo
121 121
 			$this->find_parents($data, $row['parent_id']);
122 122
 		}
123 123
 	}
124
-	*/
124
+	 */
125 125
 
126 126
 	/**
127 127
 	 * @param array $data
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 	 * @param string $handle
71 71
 	 * @return void
72 72
 	 */
73
-	public function display_navlist(array $data, \phpbb\template\twig\twig &$template, $handle = 'tree')
73
+	public function display_navlist(array $data, \phpbb\template\twig\twig & $template, $handle = 'tree')
74 74
 	{
75 75
 		$this->set_current_item($data);
76 76
 		$this->prepare_items($data['items']);
@@ -85,10 +85,10 @@  discard block
 block discarded – undo
85 85
 				$row['num_kids'] = $this->count_descendants($row);
86 86
 
87 87
 				$template->assign_block_vars($handle, array_change_key_case($row, CASE_UPPER));
88
-				$this->close_open_tags($template, $handle . '.close', abs($prev_depth - $this_depth));
88
+				$this->close_open_tags($template, $handle.'.close', abs($prev_depth - $this_depth));
89 89
 			}
90 90
 
91
-			$this->close_open_tags($template, 'close_' . $handle, ($this_depth - $this->min_depth));
91
+			$this->close_open_tags($template, 'close_'.$handle, ($this_depth - $this->min_depth));
92 92
 		}
93 93
 	}
94 94
 
@@ -158,13 +158,13 @@  discard block
 block discarded – undo
158 158
 	 */
159 159
 	protected function get_current_path()
160 160
 	{
161
-		$curr_page = '/' . ltrim($this->user->page['page_dir'] . '/' . $this->user->page['page_name'], './');
161
+		$curr_page = '/'.ltrim($this->user->page['page_dir'].'/'.$this->user->page['page_name'], './');
162 162
 		//$curr_page = str_replace('/index.' . $this->php_ext, '/', $curr_page);
163 163
 		$curr_parts = explode('&', $this->user->page['query_string']);
164 164
 
165 165
 		sort($curr_parts);
166 166
 
167
-		return $curr_page . '?' . join('&', $curr_parts);
167
+		return $curr_page.'?'.join('&', $curr_parts);
168 168
 	}
169 169
 
170 170
 	/**
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 
207 207
 			$is_current_item = $this->is_current_item($row);
208 208
 			$is_parent = $this->is_parent_of_current_item($row);
209
-			$this_depth	= $this->parental_depth[$row['parent_id']] + 1;
209
+			$this_depth = $this->parental_depth[$row['parent_id']] + 1;
210 210
 			$leaf = $this->get_leaf_node($row, $is_current_item, $is_parent);
211 211
 
212 212
 			$this->parental_depth[$row[$this->pk]] = $this_depth;
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
 	 * @param int $repeat
288 288
 	 * @return void
289 289
 	 */
290
-	protected function close_open_tags(\phpbb\template\twig\twig &$template, $handle, $repeat)
290
+	protected function close_open_tags(\phpbb\template\twig\twig & $template, $handle, $repeat)
291 291
 	{
292 292
 		for ($i = 0; $i < $repeat; $i++)
293 293
 		{
Please login to merge, or discard this patch.
event/startpage.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -120,13 +120,13 @@
 block discarded – undo
120 120
 	 */
121 121
 	public function set_startpage()
122 122
 	{
123
-		if ($this->user->page['page_name'] == 'index.' . $this->php_ext && !$this->is_startpage && ($controller_object = $this->get_startpage_controller()) !== false)
123
+		if ($this->user->page['page_name'] == 'index.'.$this->php_ext && !$this->is_startpage && ($controller_object = $this->get_startpage_controller()) !== false)
124 124
 		{
125 125
 			$method = $this->config['sitemaker_startpage_method'];
126 126
 			$this->is_startpage = true;
127 127
 
128 128
 			$controller_dir = explode('\\', get_class($controller_object));
129
-			$controller_style_dir = 'ext/' . $controller_dir[0] . '/' . $controller_dir[1] . '/styles';
129
+			$controller_style_dir = 'ext/'.$controller_dir[0].'/'.$controller_dir[1].'/styles';
130 130
 			$this->template->set_style(array($controller_style_dir, 'styles'));
131 131
 
132 132
 			$arguments = explode('/', $this->config['sitemaker_startpage_params']);
Please login to merge, or discard this patch.
event/listener.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -68,9 +68,9 @@  discard block
 block discarded – undo
68 68
 	public function load_permission_language(\phpbb\event\data $event)
69 69
 	{
70 70
 		$permissions = $event['permissions'];
71
-		$permissions['a_sm_settings']	= array('lang' => 'ACL_A_SM_SETTINGS', 'cat' => 'misc');
72
-		$permissions['a_sm_manage_blocks']	= array('lang' => 'ACL_A_SM_MANAGE_BLOCKS', 'cat' => 'misc');
73
-		$permissions['a_sm_manage_menus']	= array('lang' => 'ACL_A_SM_MANAGE_MENUS', 'cat' => 'misc');
71
+		$permissions['a_sm_settings'] = array('lang' => 'ACL_A_SM_SETTINGS', 'cat' => 'misc');
72
+		$permissions['a_sm_manage_blocks'] = array('lang' => 'ACL_A_SM_MANAGE_BLOCKS', 'cat' => 'misc');
73
+		$permissions['a_sm_manage_menus'] = array('lang' => 'ACL_A_SM_MANAGE_MENUS', 'cat' => 'misc');
74 74
 		$event['permissions'] = $permissions;
75 75
 	}
76 76
 
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 	 */
80 80
 	public function add_viewonline_location(\phpbb\event\data $event)
81 81
 	{
82
-		if ($event['on_page'][1] == 'app' && strrpos($event['row']['session_page'], 'app.' . $this->php_ext . '/forum') === 0)
82
+		if ($event['on_page'][1] == 'app' && strrpos($event['row']['session_page'], 'app.'.$this->php_ext.'/forum') === 0)
83 83
 		{
84 84
 			$event['location'] = $this->translator->lang('FORUM_INDEX');
85 85
 			$event['location_url'] = $this->phpbb_container->get('controller.helper')->route('blitze_sitemaker_forum');
Please login to merge, or discard this patch.
acp/settings_module.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
 			$this->config->set('sm_forum_icon', $this->request->variable('forum_icon', ''));
142 142
 			$this->config->set('sm_navbar_menu', $this->request->variable('navbar_menu', 0));
143 143
 
144
-			$this->trigger_error($this->translator->lang('SETTINGS_SAVED') . adm_back_link($this->u_action));
144
+			$this->trigger_error($this->translator->lang('SETTINGS_SAVED').adm_back_link($this->u_action));
145 145
 		}
146 146
 	}
147 147
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 	{
154 154
 		$style_prefs = (array) json_decode($this->config_text->get('sm_layout_prefs'), true);
155 155
 
156
-		$result = $this->db->sql_query('SELECT style_id, style_name FROM ' . STYLES_TABLE);
156
+		$result = $this->db->sql_query('SELECT style_id, style_name FROM '.STYLES_TABLE);
157 157
 
158 158
 		$styles = array();
159 159
 		while ($row = $this->db->sql_fetchrow($result))
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
 			$path = dirname($path);
232 232
 			$name = basename($path);
233 233
 
234
-			$layouts[$name] = $this->phpbb_root_path . $path . '/';
234
+			$layouts[$name] = $this->phpbb_root_path.$path.'/';
235 235
 		}
236 236
 		ksort($layouts);
237 237
 
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 			$id = $entity->get_menu_id();
255 255
 			$name = $entity->get_menu_name();
256 256
 			$selected = ($id == $this->config['sm_navbar_menu']) ? ' selected="selected"' : '';
257
-			$options .= '<option value="' . $id . '"' . $selected . '>' . $name . '</option>';
257
+			$options .= '<option value="'.$id.'"'.$selected.'>'.$name.'</option>';
258 258
 		}
259 259
 
260 260
 		return $options;
Please login to merge, or discard this patch.