Completed
Pull Request — master (#26)
by Daniel
12:16
created
services/users/data.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
 		if (sizeof($query_ids))
85 85
 		{
86
-			$sql_where .= (($sql_where) ? ' AND ' : '') . $this->db->sql_in_set('user_id', $query_ids);
86
+			$sql_where .= (($sql_where) ? ' AND ' : '').$this->db->sql_in_set('user_id', $query_ids);
87 87
 			$this->query($sql_where);
88 88
 		}
89 89
 
@@ -160,8 +160,8 @@  discard block
 block discarded – undo
160 160
 	public function get_profile_fields()
161 161
 	{
162 162
 		$sql = 'SELECT l.lang_name, f.field_ident
163
-			FROM ' . PROFILE_LANG_TABLE . ' l, ' . PROFILE_FIELDS_TABLE . ' f
164
-			WHERE l.lang_id = ' . $this->user->get_iso_lang_id() . '
163
+			FROM ' . PROFILE_LANG_TABLE.' l, '.PROFILE_FIELDS_TABLE.' f
164
+			WHERE l.lang_id = ' . $this->user->get_iso_lang_id().'
165 165
 				AND f.field_active = 1
166 166
 				AND f.field_no_view = 0
167 167
 				AND f.field_hide = 0
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 	 */
220 220
 	protected function get_search_url($user_id)
221 221
 	{
222
-		return ($this->auth->acl_get('u_search')) ? append_sid($this->phpbb_root_path . 'search.' . $this->php_ext, "author_id=$user_id&sr=posts") : '';
222
+		return ($this->auth->acl_get('u_search')) ? append_sid($this->phpbb_root_path.'search.'.$this->php_ext, "author_id=$user_id&sr=posts") : '';
223 223
 	}
224 224
 
225 225
 	/**
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
 	{
231 231
 		if (!function_exists('phpbb_get_user_rank'))
232 232
 		{
233
-			include($this->phpbb_root_path . 'includes/functions_display.' . $this->php_ext);
233
+			include($this->phpbb_root_path.'includes/functions_display.'.$this->php_ext);
234 234
 		}
235 235
 
236 236
 		$user_rank_data = phpbb_get_user_rank($row, $row['user_posts']);
@@ -304,8 +304,8 @@  discard block
 block discarded – undo
304 304
 	protected function get_sql_statement($sql_where = '', $order_by = '')
305 305
 	{
306 306
 		return 'SELECT user_id, username, user_type, user_colour, user_avatar, user_avatar_type, user_avatar_height, user_avatar_width, user_regdate, user_lastvisit, user_birthday, user_posts, user_rank, user_email, user_allow_viewemail, user_allow_pm, user_jabber, user_inactive_reason
307
-			FROM ' . USERS_TABLE .
308
-			(($sql_where) ? ' WHERE ' . $sql_where : '') .
309
-			(($order_by) ? ' ORDER BY ' . $order_by : '');
307
+			FROM ' . USERS_TABLE.
308
+			(($sql_where) ? ' WHERE '.$sql_where : '').
309
+			(($order_by) ? ' ORDER BY '.$order_by : '');
310 310
 	}
311 311
 }
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -288,8 +288,7 @@
 block discarded – undo
288 288
 					'NAME'		=> $field_data['PROFILE_FIELD_NAME'],
289 289
 					'U_CONTACT'	=> $field_data['PROFILE_FIELD_CONTACT'],
290 290
 				);
291
-			}
292
-			else
291
+			} else
293 292
 			{
294 293
 				$this->user_cache[$user_id]['profile_fields'][$field] = $field_data;
295 294
 			}
Please login to merge, or discard this patch.
services/forum/options.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
 		// @codeCoverageIgnoreStart
23 23
 		if (!function_exists('make_forum_select'))
24 24
 		{
25
-			include($phpbb_root_path . 'includes/functions_admin.' . $php_ext);
25
+			include($phpbb_root_path.'includes/functions_admin.'.$php_ext);
26 26
 		}
27 27
 		// @codeCoverageIgnoreEnd
28 28
 	}
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 		$forum_options = array('' => 'ALL_FORUMS');
44 44
 		foreach ($forumlist as $row)
45 45
 		{
46
-			$forum_options[$row['forum_id']] = $row['padding'] . $row['forum_name'];
46
+			$forum_options[$row['forum_id']] = $row['padding'].$row['forum_name'];
47 47
 		}
48 48
 
49 49
 		return $forum_options;
Please login to merge, or discard this patch.
services/forum/manager.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 	{
65 65
 		if (!class_exists('acp_forums'))
66 66
 		{
67
-			include($this->phpbb_root_path . 'includes/acp/acp_forums.' . $this->php_ext);
67
+			include($this->phpbb_root_path.'includes/acp/acp_forums.'.$this->php_ext);
68 68
 		}
69 69
 
70 70
 		$this->translator->add_lang('acp/forums');
Please login to merge, or discard this patch.
services/menus/action/add_menu.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 
21 21
 		/** @type \blitze\sitemaker\model\entity\menu $entity */
22 22
 		$entity = $menu_mapper->create_entity(array(
23
-			'menu_name' => $this->translator->lang('MENU') . '-' . mt_rand(1000, 9999),
23
+			'menu_name' => $this->translator->lang('MENU').'-'.mt_rand(1000, 9999),
24 24
 		));
25 25
 
26 26
 		$entity = $menu_mapper->save($entity);
Please login to merge, or discard this patch.
blocks/member_menu.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -68,11 +68,11 @@  discard block
 block discarded – undo
68 68
 				'USER_POSTS'	=> $this->user->data['user_posts'],
69 69
 				'NEW_POSTS'		=> $this->get_new_posts_count(),
70 70
 
71
-				'U_PROFILE'		=> append_sid($this->phpbb_root_path . 'memberlist.' . $this->php_ext, 'mode=viewprofile&u=' . $this->user->data['user_id']),
72
-				'U_SEARCH_NEW'	=> append_sid($this->phpbb_root_path . 'search.' . $this->php_ext, 'search_id=newposts'),
73
-				'U_SEARCH_SELF'	=> append_sid($this->phpbb_root_path . 'search.' . $this->php_ext, 'search_id=egosearch'),
74
-				'U_PRIVATE_MSG'	=> append_sid($this->phpbb_root_path . 'ucp.' . $this->php_ext, 'i=pm&folder=inbox'),
75
-				'U_LOGOUT'		=> append_sid($this->phpbb_root_path . 'ucp.' . $this->php_ext, 'mode=logout', true, $this->user->session_id),
71
+				'U_PROFILE'		=> append_sid($this->phpbb_root_path.'memberlist.'.$this->php_ext, 'mode=viewprofile&u='.$this->user->data['user_id']),
72
+				'U_SEARCH_NEW'	=> append_sid($this->phpbb_root_path.'search.'.$this->php_ext, 'search_id=newposts'),
73
+				'U_SEARCH_SELF'	=> append_sid($this->phpbb_root_path.'search.'.$this->php_ext, 'search_id=egosearch'),
74
+				'U_PRIVATE_MSG'	=> append_sid($this->phpbb_root_path.'ucp.'.$this->php_ext, 'i=pm&folder=inbox'),
75
+				'U_LOGOUT'		=> append_sid($this->phpbb_root_path.'ucp.'.$this->php_ext, 'mode=logout', true, $this->user->session_id),
76 76
 				'U_MCP' 		=> $this->get_mcp_url(),
77 77
 				'U_ACP'			=> $this->get_acp_url(),
78 78
 			));
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
 	 */
100 100
 	protected function get_mcp_url()
101 101
 	{
102
-		return ($this->auth->acl_get('m_')) ? append_sid($this->phpbb_root_path . 'mcp.' . $this->php_ext, false, true, $this->user->session_id) : '';
102
+		return ($this->auth->acl_get('m_')) ? append_sid($this->phpbb_root_path.'mcp.'.$this->php_ext, false, true, $this->user->session_id) : '';
103 103
 	}
104 104
 
105 105
 	/**
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 	 */
108 108
 	protected function get_acp_url()
109 109
 	{
110
-		return ($this->auth->acl_get('a_')) ? append_sid($this->phpbb_root_path . 'adm/index.' . $this->php_ext, 'i=-blitze-sitemaker-acp-menu_module', true, $this->user->session_id) : '';
110
+		return ($this->auth->acl_get('a_')) ? append_sid($this->phpbb_root_path.'adm/index.'.$this->php_ext, 'i=-blitze-sitemaker-acp-menu_module', true, $this->user->session_id) : '';
111 111
 	}
112 112
 
113 113
 	/**
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 				POSTS_TABLE		=> 'p',
121 121
 			),
122 122
 			'WHERE'		=> array(
123
-				't.topic_id = p.topic_id AND p.post_time > ' . (int) $this->user->data['user_lastvisit'],
123
+				't.topic_id = p.topic_id AND p.post_time > '.(int) $this->user->data['user_lastvisit'],
124 124
 			),
125 125
 		);
126 126
 
Please login to merge, or discard this patch.
services/poll.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 	 * @param array $topic_data
69 69
 	 * @param \phpbb\template\twig\twig $template
70 70
 	 */
71
-	public function build(array $topic_data, \phpbb\template\twig\twig &$template)
71
+	public function build(array $topic_data, \phpbb\template\twig\twig & $template)
72 72
 	{
73 73
 		$this->translator->add_lang('viewtopic');
74 74
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 			'S_POLL_ACTION'		=> $viewtopic_url,
101 101
 			'S_FORM_TOKEN'		=> $this->sitemaker->get_form_key('posting'),
102 102
 
103
-			'U_VIEW_RESULTS'	=> $viewtopic_url . '&view=viewpoll',
103
+			'U_VIEW_RESULTS'	=> $viewtopic_url.'&view=viewpoll',
104 104
 		));
105 105
 	}
106 106
 
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 		$post_id = (int) $topic_data['topic_first_post_id'];
172 172
 
173 173
 		$sql = 'SELECT o.*, p.bbcode_bitfield, p.bbcode_uid
174
-			FROM ' . POLL_OPTIONS_TABLE . ' o, ' . POSTS_TABLE . " p
174
+			FROM ' . POLL_OPTIONS_TABLE.' o, '.POSTS_TABLE." p
175 175
 			WHERE o.topic_id = $topic_id
176 176
 				AND p.post_id = $post_id
177 177
 				AND p.topic_id = o.topic_id
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 	 * @param int $poll_most
217 217
 	 * @param \phpbb\template\twig\twig $template
218 218
 	 */
219
-	private function build_poll_options(array $cur_voted_id, array $poll_info, $poll_total, $poll_most, \phpbb\template\twig\twig &$template)
219
+	private function build_poll_options(array $cur_voted_id, array $poll_info, $poll_total, $poll_most, \phpbb\template\twig\twig & $template)
220 220
 	{
221 221
 		foreach ($poll_info as $poll_option)
222 222
 		{
@@ -247,8 +247,8 @@  discard block
 block discarded – undo
247 247
 		if ($this->user->data['is_registered'])
248 248
 		{
249 249
 			$sql = 'SELECT poll_option_id
250
-			FROM ' . POLL_VOTES_TABLE . '
251
-			WHERE topic_id = ' . (int) $topic_id . '
250
+			FROM ' . POLL_VOTES_TABLE.'
251
+			WHERE topic_id = ' . (int) $topic_id.'
252 252
 				AND vote_user_id = ' . (int) $this->user->data['user_id'];
253 253
 			$result = $this->db->sql_query($sql);
254 254
 
@@ -263,9 +263,9 @@  discard block
 block discarded – undo
263 263
 			// Cookie based guest tracking ... I don't like this but hum ho
264 264
 			// it's oft requested. This relies on "nice" users who don't feel
265 265
 			// the need to delete cookies to mess with results.
266
-			if ($this->request->is_set($this->config['cookie_name'] . '_poll_' . $topic_id, \phpbb\request\request_interface::COOKIE))
266
+			if ($this->request->is_set($this->config['cookie_name'].'_poll_'.$topic_id, \phpbb\request\request_interface::COOKIE))
267 267
 			{
268
-				$cur_voted_id = explode(',', $this->request->variable($this->config['cookie_name'] . '_poll_' . $topic_id, '', true, \phpbb\request\request_interface::COOKIE));
268
+				$cur_voted_id = explode(',', $this->request->variable($this->config['cookie_name'].'_poll_'.$topic_id, '', true, \phpbb\request\request_interface::COOKIE));
269 269
 				$cur_voted_id = array_map('intval', $cur_voted_id);
270 270
 			}
271 271
 		}
Please login to merge, or discard this patch.