blitz-php / framework

src/Validation/Validation.php

<?php

/**
 * This file is part of Blitz PHP framework.
 *
 * (c) 2022 Dimitri Sitchet Tomkeu <devcode.dst@gmail.com>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

namespace BlitzPHP\Validation;

use BlitzPHP\Contracts\Autoloader\LocatorInterface;
use BlitzPHP\Validation\Rules\AbstractRule;
use Dimtrovich\Validation\Validation as BaseValidation;

class Validation extends BaseValidation
{
    public function __construct()
    {
        parent::__construct(config('app.language'));

It seems like config('app.language') can also be of type null and object; however, parameter $locale of Dimtrovich\Validation\Validation::__construct() does only seem to accept string, maybe add an additional type check?

        $this->discoverRules();
    }

    /**
     * {@inheritDoc}
     */
    public function errors(): ErrorBag
    {
        return ErrorBag::fromBase(parent::errors());
    }

    /**
     * {@inheritDoc}
     *
     * @param list<AbstractRule> $rules

The type BlitzPHP\Validation\list was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    protected function registerRules(array $rules): void
    {
        foreach ($rules as $key => $value) {
            if (is_int($key)) {
                $name = $value::name();
                $rule = $value;
            } else {
                $name = $value;
                $rule = $key;
            }

            $this->addValidator($name, service('container')->get($rule));
        }
    }

    /**
     * Definie les fichiers qui pourront etre considerer comme regles de validations
     *
     * @return list<string> Chemins absolus des fichiers
     */
    protected function files(LocatorInterface $locator): array
    {
        $files = array_merge(
            $locator->listFiles('Rules/'), // Regles de l'application ou des fournisseurs
            $locator->listFiles('Validation/Rules/') // Regles internes du framework
        );

        return array_unique($files);

The expression return array_unique($files) returns the type array which is incompatible with the documented return type BlitzPHP\Validation\list.

    }

    /**
     * Recherche toutes les regles de validation dans le framework et dans le code de l'utilisateur
     * et collecte leurs instances pour fonctionner avec eux.
     */
    private function discoverRules()
    {
        $files = $this->files($locator = service('locator'));
        $rules = [];

        foreach ($files as $file) {
            $className = $locator->getClassname($file);

            if ($className !== '' && class_exists($className) && is_subclass_of($className, AbstractRule::class)) {
                $rules[] = $className;
            }
        }

        $this->registerRules($rules);
    }
}