blitz-php / framework

src/Exceptions/ValidationException.php

<?php

/**
 * This file is part of Blitz PHP framework.
 *
 * (c) 2022 Dimitri Sitchet Tomkeu <devcode.dst@gmail.com>
 *
 * For the full copyright and license information, please view
 * the LICENSE file that was distributed with this source code.
 */

namespace BlitzPHP\Exceptions;

use BlitzPHP\Contracts\Http\StatusCode;
use BlitzPHP\Validation\ErrorBag;
use Dimtrovich\Validation\Exceptions\ValidationException as BaseValidationException;
use Rakit\Validation\ErrorBag as RakitErrorBag;

class ValidationException extends BaseValidationException
{
    /**
     * Code d'erreur
     *
     * @var int
     */
    protected $code = StatusCode::UNPROCESSABLE_ENTITY;

    /**
     * {@inheritDoc}
     */
    public function setErrors(?RakitErrorBag $errors): self
    {
        $this->errors = new ErrorBag($errors->toArray());

The method toArray() does not exist on null.

        return $this;
    }

    /**
     * {@inheritDoc}
     */
    public function getErrors(): ?ErrorBag
    {
        if ($this->errors instanceof RakitErrorBag) {
            $this->errors = ErrorBag::fromBase($this->errors);
        }

        return $this->errors;

The expression return $this->errors could return the type Dimtrovich\Validation\ErrorBag which includes types incompatible with the type-hinted return BlitzPHP\Validation\ErrorBag|null. Consider adding an additional type-check to rule them out.

    }
}