blindsidenetworks / moodle-mod_bigbluebuttonbn

db/upgrade.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once(dirname(dirname(__FILE__)).'/locallib.php');
+require_once(dirname(dirname(__FILE__)) . '/locallib.php');
 
 /**
  * Performs data migrations and updates on upgrade.

lib.php

Indentation +4 added lines, -4 removed lines

@@ -61,7 +61,7 @@ 
  * Remove this block when restored
  */
 
- /** @var BIGBLUEBUTTONBN_DEFAULT_SERVER_URL string of default bigbluebutton server url */
+    /** @var BIGBLUEBUTTONBN_DEFAULT_SERVER_URL string of default bigbluebutton server url */
 const BIGBLUEBUTTONBN_DEFAULT_SERVER_URL = 'http://test-install.blindsidenetworks.com/bigbluebutton/';
 /** @var BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET string of default bigbluebutton server shared secret */
 const BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET = '8cd8ef52e8e101574e400365b55e11a6';
@@ -339,12 +339,12 @@ 
     $str  = '<div class="bigbluebuttonbn overview">'."\n";
     $str .= '  <div class="name">'.get_string('modulename', 'bigbluebuttonbn').':&nbsp;'."\n";
     $str .= '    <a '.$classes.'href="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bigbluebuttonbn->coursemodule.
-      '">'.$bigbluebuttonbn->name.'</a>'."\n";
+        '">'.$bigbluebuttonbn->name.'</a>'."\n";
     $str .= '  </div>'."\n";
     $str .= '  <div class="info">'.get_string($start, 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->openingtime).
         '</div>'."\n";
     $str .= '  <div class="info">'.get_string('ends_at', 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->closingtime)
-      .'</div>'."\n";
+        .'</div>'."\n";
     $str .= '</div>'."\n";
     return $str;
 }
@@ -529,7 +529,7 @@ 
             $bigbluebuttonbn->coursemodule,
             'bigbluebuttonbn',
             $bigbluebuttonbn->id, $bigbluebuttonbn->completionexpected
-          );
+            );
     }
 }
 /**

Spacing +42 added lines, -42 removed lines

@@ -28,29 +28,29 @@ 
 
 global $CFG;
 
-require_once($CFG->dirroot.'/calendar/lib.php');
-require_once($CFG->dirroot.'/message/lib.php');
-require_once($CFG->dirroot.'/mod/lti/OAuth.php');
-require_once($CFG->dirroot.'/tag/lib.php');
-require_once($CFG->libdir.'/accesslib.php');
-require_once($CFG->libdir.'/completionlib.php');
-require_once($CFG->libdir.'/datalib.php');
-require_once($CFG->libdir.'/enrollib.php');
-require_once($CFG->libdir.'/filelib.php');
-require_once($CFG->libdir.'/formslib.php');
+require_once($CFG->dirroot . '/calendar/lib.php');
+require_once($CFG->dirroot . '/message/lib.php');
+require_once($CFG->dirroot . '/mod/lti/OAuth.php');
+require_once($CFG->dirroot . '/tag/lib.php');
+require_once($CFG->libdir . '/accesslib.php');
+require_once($CFG->libdir . '/completionlib.php');
+require_once($CFG->libdir . '/datalib.php');
+require_once($CFG->libdir . '/enrollib.php');
+require_once($CFG->libdir . '/filelib.php');
+require_once($CFG->libdir . '/formslib.php');
 
 
 if (!class_exists('\Firebase\JWT\JWT') &&
-    file_exists(dirname(__FILE__).'/vendor/firebase/php-jwt/src/JWT.php')) {
-    require_once(dirname(__FILE__).'/vendor/firebase/php-jwt/src/JWT.php');
+    file_exists(dirname(__FILE__) . '/vendor/firebase/php-jwt/src/JWT.php')) {
+    require_once(dirname(__FILE__) . '/vendor/firebase/php-jwt/src/JWT.php');
 }
 
 if (!isset($CFG->bigbluebuttonbn)) {
     $CFG->bigbluebuttonbn = array();
 }
 
-if (file_exists(dirname(__FILE__).'/config.php')) {
-    require_once(dirname(__FILE__).'/config.php');
+if (file_exists(dirname(__FILE__) . '/config.php')) {
+    require_once(dirname(__FILE__) . '/config.php');
 }
 
 /*
@@ -103,18 +103,18 @@ 
         return null;
     }
     $features = array(
-        (string) FEATURE_IDNUMBER => true,
-        (string) FEATURE_GROUPS => true,
-        (string) FEATURE_GROUPINGS => true,
-        (string) FEATURE_GROUPMEMBERSONLY => true,
-        (string) FEATURE_MOD_INTRO => true,
-        (string) FEATURE_BACKUP_MOODLE2 => true,
-        (string) FEATURE_COMPLETION_TRACKS_VIEWS => true,
-        (string) FEATURE_GRADE_HAS_GRADE => false,
-        (string) FEATURE_GRADE_OUTCOMES => false,
-        (string) FEATURE_SHOW_DESCRIPTION => true,
+        (string)FEATURE_IDNUMBER => true,
+        (string)FEATURE_GROUPS => true,
+        (string)FEATURE_GROUPINGS => true,
+        (string)FEATURE_GROUPMEMBERSONLY => true,
+        (string)FEATURE_MOD_INTRO => true,
+        (string)FEATURE_BACKUP_MOODLE2 => true,
+        (string)FEATURE_COMPLETION_TRACKS_VIEWS => true,
+        (string)FEATURE_GRADE_HAS_GRADE => false,
+        (string)FEATURE_GRADE_OUTCOMES => false,
+        (string)FEATURE_SHOW_DESCRIPTION => true,
     );
-    if (isset($features[(string) $feature])) {
+    if (isset($features[(string)$feature])) {
         return $features[$feature];
     }
     return null;
@@ -213,7 +213,7 @@ 
 function bigbluebuttonbn_delete_instance_log($bigbluebuttonbn) {
     global $DB;
     $sql  = "SELECT * FROM {bigbluebuttonbn_logs} ";
-    $sql .= "WHERE bigbluebuttonbnid = ? AND log = ? AND ". $DB->sql_compare_text('meta') . " = ?";
+    $sql .= "WHERE bigbluebuttonbnid = ? AND log = ? AND " . $DB->sql_compare_text('meta') . " = ?";
     $logs = $DB->get_records_sql($sql, array($bigbluebuttonbn->id, BIGBLUEBUTTONBN_LOG_EVENT_CREATE, "{\"record\":true}"));
     $meta = "{\"has_recordings\":" . empty($logs) ? "true" : "false" . "}";
     bigbluebuttonbn_log($bigbluebuttonbn, BIGBLUEBUTTONBN_LOG_EVENT_DELETE, [], $meta);
@@ -236,10 +236,10 @@ 
 function bigbluebuttonbn_user_outline($course, $user, $mod, $bigbluebuttonbn) {
     global $DB;
     $completed = $DB->count_records('bigbluebuttonbn_logs', array('courseid' => $course->id,
-        'bigbluebuttonbnid' => $bigbluebuttonbn->id, 'userid' => $user->id, 'log' => 'Join', ), '*');
+        'bigbluebuttonbnid' => $bigbluebuttonbn->id, 'userid' => $user->id, 'log' => 'Join',), '*');
     if ($completed > 0) {
-        return fullname($user).' '.get_string('view_message_has_joined', 'bigbluebuttonbn').' '.
-            get_string('view_message_session_for', 'bigbluebuttonbn').' '.(string) $completed.' '.
+        return fullname($user) . ' ' . get_string('view_message_has_joined', 'bigbluebuttonbn') . ' ' .
+            get_string('view_message_session_for', 'bigbluebuttonbn') . ' ' . (string)$completed . ' ' .
             get_string('view_message_times', 'bigbluebuttonbn');
     }
     return '';
@@ -259,7 +259,7 @@ 
 function bigbluebuttonbn_user_complete($course, $user, $mod, $bigbluebuttonbn) {
     global $DB;
     $completed = $DB->count_records('bigbluebuttonbn_logs', array('courseid' => $course->id,
-        'bigbluebuttonbnid' => $bigbluebuttonbn->id, 'userid' => $user->id, 'log' => 'Join', ),
+        'bigbluebuttonbnid' => $bigbluebuttonbn->id, 'userid' => $user->id, 'log' => 'Join',),
         '*', IGNORE_MULTIPLE);
     return $completed > 0;
 }
@@ -345,16 +345,16 @@ 
     if ($bigbluebuttonbn->visible) {
         $classes = 'class="dimmed" ';
     }
-    $str  = '<div class="bigbluebuttonbn overview">'."\n";
-    $str .= '  <div class="name">'.get_string('modulename', 'bigbluebuttonbn').':&nbsp;'."\n";
-    $str .= '    <a '.$classes.'href="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bigbluebuttonbn->coursemodule.
-      '">'.$bigbluebuttonbn->name.'</a>'."\n";
-    $str .= '  </div>'."\n";
-    $str .= '  <div class="info">'.get_string($start, 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->openingtime).
-        '</div>'."\n";
-    $str .= '  <div class="info">'.get_string('ends_at', 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->closingtime)
-      .'</div>'."\n";
-    $str .= '</div>'."\n";
+    $str  = '<div class="bigbluebuttonbn overview">' . "\n";
+    $str .= '  <div class="name">' . get_string('modulename', 'bigbluebuttonbn') . ':&nbsp;' . "\n";
+    $str .= '    <a ' . $classes . 'href="' . $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bigbluebuttonbn->coursemodule .
+      '">' . $bigbluebuttonbn->name . '</a>' . "\n";
+    $str .= '  </div>' . "\n";
+    $str .= '  <div class="info">' . get_string($start, 'bigbluebuttonbn') . ': ' . userdate($bigbluebuttonbn->openingtime) .
+        '</div>' . "\n";
+    $str .= '  <div class="info">' . get_string('ends_at', 'bigbluebuttonbn') . ': ' . userdate($bigbluebuttonbn->closingtime)
+      .'</div>' . "\n";
+    $str .= '</div>' . "\n";
     return $str;
 }
 
@@ -573,7 +573,7 @@ 
     if (count($files) == 1) {
         // Get the first (and only) file.
         $file = reset($files);
-        $filesrc = '/'.$file->get_filename();
+        $filesrc = '/' . $file->get_filename();
     }
     return $filesrc;
 }
@@ -641,7 +641,7 @@ 
     if (!$filename) {
         return false;
     }
-    $fullpath = "/$context->id/mod_bigbluebuttonbn/$filearea/0/".$filename;
+    $fullpath = "/$context->id/mod_bigbluebuttonbn/$filearea/0/" . $filename;
     $fs = get_file_storage();
     $file = $fs->get_file_by_hash(sha1($fullpath));
     if (!$file || $file->is_directory()) {

Doc Comments +5 added lines, -5 removed lines

@@ -96,7 +96,7 @@ 
  * @uses FEATURE_GRADE_OUTCOMES
  * @uses FEATURE_SHOW_DESCRIPTION
  * @param string $feature
- * @return mixed True if yes (some features may use other values)
+ * @return null|boolean True if yes (some features may use other values)
  */
 function bigbluebuttonbn_supports($feature) {
     if (!$feature) {
@@ -181,7 +181,7 @@ 
  *
  * @param int $id Id of the module instance
  *
- * @return bool Success/Failure
+ * @return boolean|null Success/Failure
  */
 function bigbluebuttonbn_delete_instance($id) {
     global $DB;
@@ -208,7 +208,7 @@ 
  *
  * @param object $bigbluebuttonbn Id of the module instance
  *
- * @return bool Success/Failure
+ * @return boolean|null Success/Failure
  */
 function bigbluebuttonbn_delete_instance_log($bigbluebuttonbn) {
     global $DB;
@@ -231,7 +231,7 @@ 
  * @param object $mod
  * @param object $bigbluebuttonbn
  *
- * @return bool
+ * @return string
  */
 function bigbluebuttonbn_user_outline($course, $user, $mod, $bigbluebuttonbn) {
     global $DB;
@@ -610,7 +610,7 @@ 
  * @param stdClass $context       context object
  * @param string   $filearea      file area
  *
- * @return false|null false if file not valid
+ * @return boolean false if file not valid
  */
 function bigbluebuttonbn_pluginfile_valid($context, $filearea) {
 

classes/privacy/provider.php

Spacing +1 added lines, -1 removed lines

@@ -212,7 +212,7 @@
             function($instanceid, $data) use ($user, $instanceidstocmids) {
                 $context = \context_module::instance($instanceidstocmids[$instanceid]);
                 $contextdata = helper::get_context_data($context, $user);
-                $finaldata = (object) array_merge((array) $contextdata, ['logs' => $data]);
+                $finaldata = (object)array_merge((array)$contextdata, ['logs' => $data]);
                 helper::export_context_files($context, $user);
                 writer::with_context($context)->export_data([], $finaldata);
             }

Indentation +6 added lines, -6 removed lines

@@ -61,11 +61,11 @@ 
      */
     public static function _get_metadata(collection $collection) {
 
-         // The table bigbluebuttonbn stores only the room properties.
-         // However, there is a chance that some personal information is stored as metadata.
-         // This would be done in the column 'participants' where rules can be set to define BBB roles.
-         // It is fair to say that only the userid is stored, which is useless if user is removed.
-         // But if this is a concern a refactoring on the way the rules are stored will be required.
+            // The table bigbluebuttonbn stores only the room properties.
+            // However, there is a chance that some personal information is stored as metadata.
+            // This would be done in the column 'participants' where rules can be set to define BBB roles.
+            // It is fair to say that only the userid is stored, which is useless if user is removed.
+            // But if this is a concern a refactoring on the way the rules are stored will be required.
         $collection->add_database_table('bigbluebuttonbn', [
             'participants' => 'privacy:metadata:bigbluebuttonbn:participants',
         ], 'privacy:metadata:bigbluebuttonbn');
@@ -208,7 +208,7 @@ 
                     'meetingid' => $record->meetingid,
                     'log' => $record->log,
                     'meta' => $record->meta,
-                  ];
+                    ];
                 return $carry;
             },
             function($instanceid, $data) use ($user, $instanceidstocmids) {

classes/external.php

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
      * @since Moodle 3.3
      */
     public static function get_bigbluebuttonbns_by_courses_parameters() {
-        return new external_function_parameters (
+        return new external_function_parameters(
             array(
                 'courseids' => new external_multiple_structure(
                     new external_value(PARAM_INT, 'Course id'), 'Array of course ids', VALUE_DEFAULT, array()

classes/locallib/config.php

Spacing +4 added lines, -4 removed lines

@@ -55,8 +55,8 @@ 
      */
     public static function defaultvalues() {
         return array(
-            'server_url' => (string) BIGBLUEBUTTONBN_DEFAULT_SERVER_URL,
-            'shared_secret' => (string) BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET,
+            'server_url' => (string)BIGBLUEBUTTONBN_DEFAULT_SERVER_URL,
+            'shared_secret' => (string)BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET,
             'voicebridge_editable' => false,
             'importrecordings_enabled' => false,
             'importrecordings_from_deleted_enabled' => false,
@@ -124,8 +124,8 @@ 
         if (isset($CFG->bigbluebuttonbn[$setting])) {
             return (string)$CFG->bigbluebuttonbn[$setting];
         }
-        if (isset($CFG->{'bigbluebuttonbn_'.$setting})) {
-            return (string)$CFG->{'bigbluebuttonbn_'.$setting};
+        if (isset($CFG->{'bigbluebuttonbn_' . $setting})) {
+            return (string)$CFG->{'bigbluebuttonbn_' . $setting};
         }
         return self::defaultvalue($setting);
     }

Indentation +37 added lines, -37 removed lines

@@ -171,42 +171,42 @@
      */
     public static function get_options() {
         return array(
-               'version_major' => self::get_moodle_version_major(),
-               'voicebridge_editable' => self::get('voicebridge_editable'),
-               'importrecordings_enabled' => self::get('importrecordings_enabled'),
-               'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
-               'waitformoderator_default' => self::get('waitformoderator_default'),
-               'waitformoderator_editable' => self::get('waitformoderator_editable'),
-               'userlimit_default' => self::get('userlimit_default'),
-               'userlimit_editable' => self::get('userlimit_editable'),
-               'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
-               'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
-               'recordings_enabled' => self::get('recordings_enabled'),
-               'recordings_html_default' => self::get('recordings_html_default'),
-               'recordings_html_editable' => self::get('recordings_html_editable'),
-               'recordings_deleted_default' => self::get('recordings_deleted_default'),
-               'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
-               'recordings_imported_default' => self::get('recordings_imported_default'),
-               'recordings_imported_editable' => self::get('recordings_imported_editable'),
-               'recordings_preview_default' => self::get('recordings_preview_default'),
-               'recordings_preview_editable' => self::get('recordings_preview_editable'),
-               'recording_default' => self::get('recording_default'),
-               'recording_editable' => self::get('recording_editable'),
-               'recording_icons_enabled' => self::get('recording_icons_enabled'),
-               'recording_all_from_start_default' => self::get('recording_all_from_start_default'),
-               'recording_all_from_start_editable' => self::get('recording_all_from_start_editable'),
-               'recording_hide_button_default' => self::get('recording_hide_button_default'),
-               'recording_hide_button_editable' => self::get('recording_hide_button_editable'),
-               'general_warning_message' => self::get('general_warning_message'),
-               'general_warning_box_type' => self::get('general_warning_box_type'),
-               'general_warning_button_text' => self::get('general_warning_button_text'),
-               'general_warning_button_href' => self::get('general_warning_button_href'),
-               'general_warning_button_class' => self::get('general_warning_button_class'),
-               'clienttype_enabled' => self::get('clienttype_enabled'),
-               'clienttype_editable' => self::get('clienttype_editable'),
-               'clienttype_default' => self::get('clienttype_default'),
-               'muteonstart_editable' => self::get('muteonstart_editable'),
-               'muteonstart_default' => self::get('muteonstart_default'),
-          );
+                'version_major' => self::get_moodle_version_major(),
+                'voicebridge_editable' => self::get('voicebridge_editable'),
+                'importrecordings_enabled' => self::get('importrecordings_enabled'),
+                'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
+                'waitformoderator_default' => self::get('waitformoderator_default'),
+                'waitformoderator_editable' => self::get('waitformoderator_editable'),
+                'userlimit_default' => self::get('userlimit_default'),
+                'userlimit_editable' => self::get('userlimit_editable'),
+                'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
+                'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
+                'recordings_enabled' => self::get('recordings_enabled'),
+                'recordings_html_default' => self::get('recordings_html_default'),
+                'recordings_html_editable' => self::get('recordings_html_editable'),
+                'recordings_deleted_default' => self::get('recordings_deleted_default'),
+                'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
+                'recordings_imported_default' => self::get('recordings_imported_default'),
+                'recordings_imported_editable' => self::get('recordings_imported_editable'),
+                'recordings_preview_default' => self::get('recordings_preview_default'),
+                'recordings_preview_editable' => self::get('recordings_preview_editable'),
+                'recording_default' => self::get('recording_default'),
+                'recording_editable' => self::get('recording_editable'),
+                'recording_icons_enabled' => self::get('recording_icons_enabled'),
+                'recording_all_from_start_default' => self::get('recording_all_from_start_default'),
+                'recording_all_from_start_editable' => self::get('recording_all_from_start_editable'),
+                'recording_hide_button_default' => self::get('recording_hide_button_default'),
+                'recording_hide_button_editable' => self::get('recording_hide_button_editable'),
+                'general_warning_message' => self::get('general_warning_message'),
+                'general_warning_box_type' => self::get('general_warning_box_type'),
+                'general_warning_button_text' => self::get('general_warning_button_text'),
+                'general_warning_button_href' => self::get('general_warning_button_href'),
+                'general_warning_button_class' => self::get('general_warning_button_class'),
+                'clienttype_enabled' => self::get('clienttype_enabled'),
+                'clienttype_editable' => self::get('clienttype_editable'),
+                'clienttype_default' => self::get('clienttype_default'),
+                'muteonstart_editable' => self::get('muteonstart_editable'),
+                'muteonstart_default' => self::get('muteonstart_default'),
+            );
     }
 }

classes/event/meeting_ended.php

Spacing +2 added lines, -2 removed lines

@@ -41,8 +41,8 @@
      */
     protected function init($crud = 'r', $edulevel = self::LEVEL_OTHER) {
         parent::init($crud, $edulevel);
-        $this->description = "A bigbluebutton meeting for the bigbluebuttonbn activity with id ".
-            "'##objectid' for the course id '##courseid' has been forcibly ".
+        $this->description = "A bigbluebutton meeting for the bigbluebuttonbn activity with id " .
+            "'##objectid' for the course id '##courseid' has been forcibly " .
             "ended by the user with id '##userid'.";
     }
 

classes/event/meeting_left.php

Spacing +2 added lines, -2 removed lines

@@ -41,8 +41,8 @@
      */
     protected function init($crud = 'r', $edulevel = self::LEVEL_PARTICIPATING) {
         parent::init($crud, $edulevel);
-        $this->description = "The user with id '##userid' has left a bigbluebutton meeting for ".
-            "the bigbluebuttonbn activity with id '##objectid' for the course id ".
+        $this->description = "The user with id '##userid' has left a bigbluebutton meeting for " .
+            "the bigbluebuttonbn activity with id '##objectid' for the course id " .
             "'##courseid'.";
     }
 

classes/event/recording_deleted.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
      */
     protected function init($crud = 'r', $edulevel = self::LEVEL_OTHER) {
         parent::init($crud, $edulevel);
-        $this->description = "The user with id '##userid' has deleted a recording with id ".
+        $this->description = "The user with id '##userid' has deleted a recording with id " .
             "'##other' from the course id '##courseid'.";
     }
 

classes/event/recording_edited.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
      */
     protected function init($crud = 'r', $edulevel = self::LEVEL_OTHER) {
         parent::init($crud, $edulevel);
-        $this->description = "The user with id '##userid' has edited a recording with id ".
+        $this->description = "The user with id '##userid' has edited a recording with id " .
             "'##other' in the course id '##courseid'.";
     }