blindsidenetworks / moodle-mod_bigbluebuttonbn

bbb_view.php

Braces +3 added lines, -2 removed lines

@@ -88,8 +88,9 @@
                     /// Set the duration for the meeting
                     if ( bigbluebuttonbn_get_cfg_scheduled_duration_enabled() ) {
                         $durationtime = bigbluebuttonbn_get_duration($bigbluebuttonbn->openingtime, $bigbluebuttonbn->closingtime);
-                        if( $durationtime > 0 )
-                            $bbbsession['welcome'] .= '<br><br>'.str_replace("%duration%", ''.$durationtime, get_string('bbbdurationwarning', 'bigbluebuttonbn'));
+                        if( $durationtime > 0 ) {
+                                                    $bbbsession['welcome'] .= '<br><br>'.str_replace("%duration%", ''.$durationtime, get_string('bbbdurationwarning', 'bigbluebuttonbn'));
+                        }
                     } else {
                         $durationtime = 0;
                     }

bbb_broker.php

Braces +3 added lines, -2 removed lines

@@ -119,8 +119,9 @@
                         //Execute the end command
                         $meeting_info = bigbluebuttonbn_bbb_broker_do_end_meeting($params['id'], $bbbsession['modPW']);
                         // Moodle event logger: Create an event for meeting ended
-                        if( isset($bigbluebuttonbn) )
-                            bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_MEETING_ENDED, $bigbluebuttonbn, $context, $cm);
+                        if( isset($bigbluebuttonbn) ) {
+                                                    bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_MEETING_ENDED, $bigbluebuttonbn, $context, $cm);
+                        }
                         /// Update the cache
                         $meeting_info = bigbluebuttonbn_bbb_broker_get_meeting_info($params['id'], $bbbsession['modPW'], true);
 

mod_form.php

Braces +3 added lines, -2 removed lines

@@ -269,8 +269,9 @@
         // Fourth block starts here
         //-------------------------------------------------------------------------------
         $mform->addElement('header', 'schedule', get_string('mod_form_block_schedule', 'bigbluebuttonbn'));
-        if( isset($current_activity->openingtime) && $current_activity->openingtime != 0 || isset($current_activity->closingtime) && $current_activity->closingtime != 0 )
-            $mform->setExpanded('schedule');
+        if( isset($current_activity->openingtime) && $current_activity->openingtime != 0 || isset($current_activity->closingtime) && $current_activity->closingtime != 0 ) {
+                    $mform->setExpanded('schedule');
+        }
 
         $mform->addElement('date_time_selector', 'openingtime', get_string('mod_form_field_openingtime', 'bigbluebuttonbn'), array('optional' => true));
         $mform->setDefault('openingtime', 0);

lib.php

Braces +20 added lines, -14 removed lines

@@ -388,14 +388,18 @@ 
         $bigbluebuttonbn->timemodified = time();
     }
 
-    if (! isset($bigbluebuttonbn->newwindow))
-        $bigbluebuttonbn->newwindow = 0;
-    if (! isset($bigbluebuttonbn->wait))
-        $bigbluebuttonbn->wait = 0;
-    if (! isset($bigbluebuttonbn->record))
-        $bigbluebuttonbn->record = 0;
-    if (! isset($bigbluebuttonbn->tagging))
-        $bigbluebuttonbn->tagging = 0;
+    if (! isset($bigbluebuttonbn->newwindow)) {
+            $bigbluebuttonbn->newwindow = 0;
+    }
+    if (! isset($bigbluebuttonbn->wait)) {
+            $bigbluebuttonbn->wait = 0;
+    }
+    if (! isset($bigbluebuttonbn->record)) {
+            $bigbluebuttonbn->record = 0;
+    }
+    if (! isset($bigbluebuttonbn->tagging)) {
+            $bigbluebuttonbn->tagging = 0;
+    }
 
     $bigbluebuttonbn->participants = htmlspecialchars_decode($bigbluebuttonbn->participants);
 }
@@ -463,8 +467,9 @@ 
         /// Add the meeting details to the message_body
         $msg->action = ucfirst($action);
         $msg->activity_description = "";
-        if( !empty($bigbluebuttonbn->intro) )
-            $msg->activity_description = trim($bigbluebuttonbn->intro);
+        if( !empty($bigbluebuttonbn->intro) ) {
+                    $msg->activity_description = trim($bigbluebuttonbn->intro);
+        }
         $msg->activity_openingtime = "";
         if ($bigbluebuttonbn->openingtime) {
             $msg->activity_openingtime = calendar_day_representation($bigbluebuttonbn->openingtime).' '.$at.' '.calendar_time_representation($bigbluebuttonbn->openingtime);
@@ -622,10 +627,11 @@ 
 function bigbluebuttonbn_get_db_moodle_roles($rolename='all') {
     global $DB;
 
-    if( $rolename != 'all')
-        $roles = $DB->get_record('role', array('shortname' => $rolename));
-    else
-        $roles = $DB->get_records('role', array());
+    if( $rolename != 'all') {
+            $roles = $DB->get_record('role', array('shortname' => $rolename));
+    } else {
+            $roles = $DB->get_records('role', array());
+    }
 
     return $roles;
 }

locallib.php

Braces +67 added lines, -40 removed lines

@@ -69,19 +69,23 @@ 
     $params = 'name='.urlencode($name).'&meetingID='.urlencode($meetingID).'&attendeePW='.urlencode($attendeePW).'&moderatorPW='.urlencode($moderatorPW).'&logoutURL='.urlencode($logoutURL).'&record='.$record;
 
     $voiceBridge = intval($voiceBridge);
-    if ( $voiceBridge > 0 && $voiceBridge < 79999)
-        $params .= '&voiceBridge='.$voiceBridge;
+    if ( $voiceBridge > 0 && $voiceBridge < 79999) {
+            $params .= '&voiceBridge='.$voiceBridge;
+    }
 
     $duration = intval($duration);
-    if( $duration > 0 )
-        $params .= '&duration='.$duration;
+    if( $duration > 0 ) {
+            $params .= '&duration='.$duration;
+    }
 
     $maxParticipants = intval($maxParticipants);
-    if( $maxParticipants > 0 )
-        $params .= '&maxParticipants='.$maxParticipants;
+    if( $maxParticipants > 0 ) {
+            $params .= '&maxParticipants='.$maxParticipants;
+    }
 
-    if( trim( $welcome ) )
-        $params .= '&welcome='.urlencode($welcome);
+    if( trim( $welcome ) ) {
+            $params .= '&welcome='.urlencode($welcome);
+    }
 
     foreach ($metadata as $key => $value) {
         $params .= '&'.$key.'='.urlencode($value);
@@ -155,10 +159,11 @@ 
     }
 
     if ( $xml ) {
-        if ($xml->meetingID)
-            return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey, 'meetingID' => $xml->meetingID, 'attendeePW' => $xml->attendeePW, 'moderatorPW' => $xml->moderatorPW, 'hasBeenForciblyEnded' => $xml->hasBeenForciblyEnded );
-        else
-            return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey );
+        if ($xml->meetingID) {
+                    return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey, 'meetingID' => $xml->meetingID, 'attendeePW' => $xml->attendeePW, 'moderatorPW' => $xml->moderatorPW, 'hasBeenForciblyEnded' => $xml->hasBeenForciblyEnded );
+        } else {
+                    return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey );
+        }
     } else {
         return null;
     }
@@ -228,7 +233,9 @@ 
             $metadataArray = array();
             $metadata = get_object_vars($recording->metadata);
             foreach ( $metadata as $key => $value ) {
-                if ( is_object($value) ) $value = '';
+                if ( is_object($value) ) {
+                    $value = '';
+                }
                 $metadataArray['meta_'.$key] = $value;
             }
 
@@ -268,7 +275,9 @@ 
                 $metadataArray = array();
                 $metadata = get_object_vars($recording->metadata);
                 foreach ($metadata as $key => $value) {
-                    if(is_object($value)) $value = '';
+                    if(is_object($value)) {
+                        $value = '';
+                    }
                     $metadataArray['meta_'.$key] = $value;
                 }
 
@@ -282,17 +291,22 @@ 
 }
 
 function bigbluebuttonbn_recordingBuildSorter($a, $b){
-    if( $a['startTime'] < $b['startTime']) return -1;
-    else if( $a['startTime'] == $b['startTime']) return 0;
-    else return 1;
-}
+    if( $a['startTime'] < $b['startTime']) {
+        return -1;
+    } else if( $a['startTime'] == $b['startTime']) {
+        return 0;
+    } else {
+        return 1;
+    }
+    }
 
 function bigbluebuttonbn_doDeleteRecordings( $recordIDs, $URL, $SALT ) {
     $ids = 	explode(",", $recordIDs);
     foreach( $ids as $id){
         $xml = bigbluebuttonbn_wrap_xml_load_file( bigbluebuttonbn_getDeleteRecordingsURL($id, $URL, $SALT) );
-        if( $xml && $xml->returncode != 'SUCCESS' )
-            return false;
+        if( $xml && $xml->returncode != 'SUCCESS' ) {
+                    return false;
+        }
     }
     return true;
 }
@@ -301,8 +315,9 @@ 
     $ids = 	explode(",", $recordIDs);
     foreach( $ids as $id){
         $xml = bigbluebuttonbn_wrap_xml_load_file( bigbluebuttonbn_getPublishRecordingsURL($id, $set, $URL, $SALT) );
-        if( $xml && $xml->returncode != 'SUCCESS' )
-            return false;
+        if( $xml && $xml->returncode != 'SUCCESS' ) {
+                    return false;
+        }
     }
     return true;
 }
@@ -312,8 +327,7 @@ 
 
     if( $xml ) { //If the xml packet returned failure it displays the message to the user
         return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey);
-    }
-    else { //If the server is unreachable, then prompts the user of the necessary action
+    } else { //If the server is unreachable, then prompts the user of the necessary action
         return null;
     }
 }
@@ -347,7 +361,9 @@ 
 }
 
 function bigbluebuttonbn_wrap_xml_load_file($url, $method=BIGBLUEBUTTONBN_METHOD_GET, $data=null) {
-    if ( bigbluebuttonbn_debugdisplay() ) error_log("Request to: ".$url);
+    if ( bigbluebuttonbn_debugdisplay() ) {
+        error_log("Request to: ".$url);
+    }
 
     if (extension_loaded('curl')) {
         $c = new curl();
@@ -535,8 +551,9 @@ 
         // Iterate looking for all configuration
         foreach($participant_list as $participant){
             if( $participant->selectiontype == 'all' ) {
-                if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR )
-                    return true;
+                if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR ) {
+                                    return true;
+                }
             }
         }
 
@@ -547,8 +564,9 @@ 
                 foreach( $roles as $role ) {
                     $db_moodle_role = bigbluebuttonbn_moodle_db_role_lookup($db_moodle_roles, $role->roleid);
                     if( $participant->selectionid == $db_moodle_role->shortname ) {
-                        if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR )
-                            return true;
+                        if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR ) {
+                                                    return true;
+                        }
                     }
                 }
             }
@@ -558,8 +576,9 @@ 
         foreach($participant_list as $participant){
             if( $participant->selectiontype == 'user' ) {
                 if( $participant->selectionid == $user ) {
-                    if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR )
-                        return true;
+                    if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR ) {
+                                            return true;
+                    }
                 }
             }
         }
@@ -593,7 +612,9 @@ 
     if( $voicebridge != 0 ) {
         $table = "bigbluebuttonbn";
         $select = "voicebridge = ".$voicebridge;
-        if( $id ) $select .= " AND id <> ".$id;
+        if( $id ) {
+            $select .= " AND id <> ".$id;
+        }
         if ( $rooms = $DB->get_records_select($table, $select)  ) {
             $is_unique = false;
         }
@@ -929,7 +950,9 @@ 
     $error = $org_msg;
 
     if( !empty($new_msg) ) {
-        if( !empty($error) ) $error .= ' ';
+        if( !empty($error) ) {
+            $error .= ' ';
+        }
         $error .= $new_msg;
     }
 
@@ -1218,8 +1241,9 @@ 
         $capabilities = bigbluebuttonbn_getCapabilitiesArray( $endpoint, $shared_secret );
         if( $capabilities ) {
             foreach ($capabilities as $capability) {
-                if( $capability["name"] == $capability_name)
-                    $capability_offered = $capability;
+                if( $capability["name"] == $capability_name) {
+                                    $capability_offered = $capability;
+                }
             }
         }
     }
@@ -1526,7 +1550,9 @@ 
             }
             //Generates the meetingID string
             foreach ($mIDs as $mID) {
-                if (strlen($meetingID) > 0) $meetingID .= ',';
+                if (strlen($meetingID) > 0) {
+                    $meetingID .= ',';
+                }
                 $meetingID .= $mID;
             }
         }
@@ -1624,9 +1650,10 @@ 
 function bigbluebuttonbn_html2text($html, $len) {
     $text = strip_tags($html);
     $text = str_replace("&nbsp;", ' ', $text);
-    if( strlen($text) > $len )
-        $text = substr($text, 0, $len)."...";
-    else
-        $text = substr($text, 0, $len);
+    if( strlen($text) > $len ) {
+            $text = substr($text, 0, $len)."...";
+    } else {
+            $text = substr($text, 0, $len);
+    }
     return $text;
 }
\ No newline at end of file

view.php

Braces +24 added lines, -18 removed lines

@@ -84,8 +84,9 @@ 
 $bbbsession['voicebridge'] = ($bigbluebuttonbn->voicebridge > 0)? 70000 + $bigbluebuttonbn->voicebridge: $bigbluebuttonbn->voicebridge;
 $bbbsession['wait'] = $bigbluebuttonbn->wait;
 $bbbsession['record'] = $bigbluebuttonbn->record;
-if( $bigbluebuttonbn->record )
+if( $bigbluebuttonbn->record ) {
     $bbbsession['welcome'] .= '<br><br>'.get_string('bbbrecordwarning', 'bigbluebuttonbn');
+}
 $bbbsession['tagging'] = $bigbluebuttonbn->tagging;
 
 $bbbsession['openingtime'] = $bigbluebuttonbn->openingtime;
@@ -112,22 +113,24 @@ 
 // Validates if the BigBlueButton server is running
 $serverVersion = bigbluebuttonbn_getServerVersion($bbbsession['endpoint']);
 if ( !isset($serverVersion) ) { //Server is not working
-    if ( $bbbsession['administrator'] )
-        print_error( 'view_error_unable_join', 'bigbluebuttonbn', $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn' );
-    else if ( $bbbsession['moderator'] )
-        print_error( 'view_error_unable_join_teacher', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
-    else
-        print_error( 'view_error_unable_join_student', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
-} else {
-    $xml = bigbluebuttonbn_wrap_xml_load_file( bigbluebuttonbn_getMeetingsURL( $bbbsession['endpoint'], $bbbsession['shared_secret'] ) );
-    if ( !isset($xml) || !isset($xml->returncode) || $xml->returncode == 'FAILED' ){ // The shared secret is wrong
-        if ( $bbbsession['administrator'] )
+    if ( $bbbsession['administrator'] ) {
             print_error( 'view_error_unable_join', 'bigbluebuttonbn', $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn' );
-        else if ( $bbbsession['moderator'] )
+    } else if ( $bbbsession['moderator'] ) {
             print_error( 'view_error_unable_join_teacher', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
-        else
+    } else {
             print_error( 'view_error_unable_join_student', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
     }
+    } else {
+    $xml = bigbluebuttonbn_wrap_xml_load_file( bigbluebuttonbn_getMeetingsURL( $bbbsession['endpoint'], $bbbsession['shared_secret'] ) );
+    if ( !isset($xml) || !isset($xml->returncode) || $xml->returncode == 'FAILED' ){ // The shared secret is wrong
+        if ( $bbbsession['administrator'] ) {
+                    print_error( 'view_error_unable_join', 'bigbluebuttonbn', $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn' );
+        } else if ( $bbbsession['moderator'] ) {
+                    print_error( 'view_error_unable_join_teacher', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
+        } else {
+                    print_error( 'view_error_unable_join_student', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
+        }
+    }
 }
 
 // Mark viewed by user (if required)
@@ -203,10 +206,11 @@ 
     }
 
     $bbbsession['meetingid'] = $bbbsession['bigbluebuttonbn']->meetingid.'-'.$bbbsession['course']->id.'-'.$bbbsession['bigbluebuttonbn']->id.'['.$bbbsession['group'].']';
-    if( $bbbsession['group'] > 0 )
-        $group_name = groups_get_group_name($bbbsession['group']);
-    else
-        $group_name = get_string('allparticipants');
+    if( $bbbsession['group'] > 0 ) {
+            $group_name = groups_get_group_name($bbbsession['group']);
+    } else {
+            $group_name = get_string('allparticipants');
+    }
     $bbbsession['meetingname'] = $bbbsession['bigbluebuttonbn']->name.' ('.$group_name.')';
 }
 // Metadata (context)
@@ -362,7 +366,9 @@ 
             }
             //Generates the meetingID string
             foreach ($mIDs as $mID) {
-                if (strlen($meetingID) > 0) $meetingID .= ',';
+                if (strlen($meetingID) > 0) {
+                    $meetingID .= ',';
+                }
                 $meetingID .= $mID;
             }
         }