brokerlib.php ➔ bigbluebuttonbn_broker_meeting_events()

Complexity

Conditions	6
Paths	11

Size

Total Lines

53

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function bigbluebuttonbn_broker_meeting_events($bigbluebuttonbn) {
    // Decodes the received JWT string.
    try {
        // Get the HTTP headers (getallheaders is a PHP function that may only work with Apache).
        $headers = getallheaders();

        // Pull the Bearer from the headers.
        if (!array_key_exists('Authorization', $headers)) {
            $msg = 'Authorization failed';
            header('HTTP/1.0 400 Bad Request. ' . $msg);
            return;
        }
        $authorization = explode(" ", $headers['Authorization']);

        // Verify the authenticity of the request.
        $token = \Firebase\JWT\JWT::decode($authorization[1],

$token is not used, you could remove the assignment.

            \mod_bigbluebuttonbn\locallib\config::get('shared_secret'), array('HS512'));

It seems like \mod_bigbluebuttonbn\locallib\config::get('shared_secret') targeting mod_bigbluebuttonbn\locallib\config::get() can also be of type boolean or null; however, Firebase\JWT\JWT::decode() does only seem to accept string|array, maybe add an additional type check?

        // Get JSON string from the body.
        $jsonstr = file_get_contents('php://input');

        // Convert JSON string to a JSON object.
        $jsonobj = json_decode($jsonstr);
    } catch (Exception $e) {
        $msg = 'Caught exception: ' . $e->getMessage();
        header('HTTP/1.0 400 Bad Request. ' . $msg);
        return;
    }

    // Validate that the bigbluebuttonbn activity corresponds to the meeting_id received.
    $meetingidelements = explode('[', $jsonobj->{'meeting_id'});
    $meetingidelements = explode('-', $meetingidelements[0]);
    if (!isset($bigbluebuttonbn) || $bigbluebuttonbn->meetingid != $meetingidelements[0]) {
        $msg = 'The activity may have been deleted';
        header('HTTP/1.0 410 Gone. ' . $msg);
        return;
    }

    // We make sure events are processed only once.
    $overrides = array('meetingid' => $jsonobj->{'meeting_id'});
    $meta['recordid'] = $jsonobj->{'internal_meeting_id'};

$meta was never initialized. Although not strictly required by PHP, it is generally a good practice to add $meta = array(); before regardless.

    $meta['callback'] = 'meeting_events';
    bigbluebuttonbn_log($bigbluebuttonbn, BIGBLUEBUTTON_LOG_EVENT_CALLBACK, $overrides, json_encode($meta));
    if (bigbluebuttonbn_get_count_callback_event_log($jsonobj->{'internal_meeting_id'}, 'meeting_events') == 1) {
        // Process the events.
        bigbluebuttonbn_process_meeting_events($bigbluebuttonbn, $jsonobj);
        $msg = 'Enqueued.';
        header('HTTP/1.0 202 Accepted. ' . $msg);
        return;
    }
    $msg = 'Already processed.';
    header('HTTP/1.0 202 Accepted. ' . $msg);
}