Completed
Pull Request — master (#53)
by
unknown
21:15
created
lang/en/bigbluebuttonbn.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -390,5 +390,5 @@
 block discarded – undo
390 390
 $string['view_error_action_not_completed'] = 'Action could not be completed';
391 391
 $string['view_warning_default_server'] = 'This Moodle server is making use of the BigBlueButton testing server that comes pre-configured by default. It should be replaced for production.';
392 392
 
393
-$string['config_enable_html5'] =  'Default HTML5 Client';
393
+$string['config_enable_html5'] = 'Default HTML5 Client';
394 394
 $string['config_enable_html5_description'] = 'This settings will enable HTML5 client by default instead of Flash client but it will check whether HTML5 is running or not. If running then it will redirect to HTML5 client otherwise fallback to Flash.';
395 395
\ No newline at end of file
Please login to merge, or discard this patch.
classes/locallib/config.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
55 55
      */
56 56
     public static function defaultvalues() {
57 57
         return array(
58
-            'server_url' => (string) BIGBLUEBUTTONBN_DEFAULT_SERVER_URL,
59
-            'shared_secret' => (string) BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET,
58
+            'server_url' => (string)BIGBLUEBUTTONBN_DEFAULT_SERVER_URL,
59
+            'shared_secret' => (string)BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET,
60 60
 			'enable_html5' => 'false',
61 61
             'voicebridge_editable' => 'false',
62 62
             'importrecordings_enabled' => 'false',
@@ -122,8 +122,8 @@  discard block
 block discarded – undo
122 122
         if (isset($CFG->bigbluebuttonbn[$setting])) {
123 123
             return (string)$CFG->bigbluebuttonbn[$setting];
124 124
         }
125
-        if (isset($CFG->{'bigbluebuttonbn_'.$setting})) {
126
-            return (string)$CFG->{'bigbluebuttonbn_'.$setting};
125
+        if (isset($CFG->{'bigbluebuttonbn_' . $setting})) {
126
+            return (string)$CFG->{'bigbluebuttonbn_' . $setting};
127 127
         }
128 128
         return  self::defaultvalue($setting);
129 129
     }
Please login to merge, or discard this patch.
classes/locallib/bigbluebutton.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -52,20 +52,20 @@
 block discarded – undo
52 52
             $params .= '&' . $key . '=' . urlencode($value);
53 53
         }
54 54
         foreach ($metadata as $key => $value) {
55
-            $params .= '&' . 'meta_' . $key.'=' . urlencode($value);
55
+            $params .= '&' . 'meta_' . $key . '=' . urlencode($value);
56 56
         }
57 57
 		
58 58
 		$enable_html5 = trim(\mod_bigbluebuttonbn\locallib\config::get('enable_html5'));
59 59
 		
60
-		if($enable_html5){
60
+		if ($enable_html5) {
61 61
 			// from https://github.com/blindsidenetworks/moodle-mod_bigbluebuttonbn/pull/37
62 62
 			$parsed_url = parse_url($baseurl);
63
-			$statusHTML5 = file_get_contents($parsed_url["scheme"]."://".$parsed_url["host"]."/html5client/check");
63
+			$statusHTML5 = file_get_contents($parsed_url["scheme"] . "://" . $parsed_url["host"] . "/html5client/check");
64 64
 			
65
-			if($statusHTML5 == '{"html5clientStatus":"running"}') {
65
+			if ($statusHTML5 == '{"html5clientStatus":"running"}') {
66 66
 				// HTML5 client is running => joining HTML5 client
67
-				$clientURL = $parsed_url["scheme"]."://".$parsed_url["host"]."/html5client/join";
68
-				$params = $params.'&clientURL='.urlencode($clientURL);
67
+				$clientURL = $parsed_url["scheme"] . "://" . $parsed_url["host"] . "/html5client/join";
68
+				$params = $params . '&clientURL=' . urlencode($clientURL);
69 69
 			}
70 70
 			
71 71
 		}
Please login to merge, or discard this patch.
classes/settings/validator.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 defined('MOODLE_INTERNAL') || die();
29 29
 
30 30
 require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
31
-require_once($CFG->libdir.'/adminlib.php');
31
+require_once($CFG->libdir . '/adminlib.php');
32 32
 
33 33
 /**
34 34
  * Helper class for validating settings used HTML for settings.php.
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
     public static function section_general_shown() {
47 47
         global $CFG;
48 48
         return (!isset($CFG->bigbluebuttonbn['server_url']) ||
49
-                !isset($CFG->bigbluebuttonbn['shared_secret'])||
49
+                !isset($CFG->bigbluebuttonbn['shared_secret']) ||
50 50
 				!isset($CFG->bigbluebuttonbn['enable_html5']));
51 51
     }
52 52
 
Please login to merge, or discard this patch.