blindsidenetworks / moodle-mod_bigbluebuttonbn

view.php

Braces +21 added lines, -17 removed lines

@@ -85,8 +85,9 @@ 
 $bbbsession['voicebridge'] = ($bigbluebuttonbn->voicebridge > 0)? 70000 + $bigbluebuttonbn->voicebridge: $bigbluebuttonbn->voicebridge;
 $bbbsession['wait'] = $bigbluebuttonbn->wait;
 $bbbsession['record'] = $bigbluebuttonbn->record;
-if( $bigbluebuttonbn->record )
+if( $bigbluebuttonbn->record ) {
     $bbbsession['welcome'] .= '<br><br>'.get_string('bbbrecordwarning', 'bigbluebuttonbn');
+}
 $bbbsession['tagging'] = $bigbluebuttonbn->tagging;
 
 $bbbsession['openingtime'] = $bigbluebuttonbn->openingtime;
@@ -118,22 +119,24 @@ 
 // Validates if the BigBlueButton server is running
 $serverVersion = bigbluebuttonbn_getServerVersion($bbbsession['endpoint']);
 if ( !isset($serverVersion) ) { //Server is not working
-    if ( $bbbsession['administrator'] )
-        print_error( 'view_error_unable_join', 'bigbluebuttonbn', $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn' );
-    else if ( $bbbsession['moderator'] )
-        print_error( 'view_error_unable_join_teacher', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
-    else
-        print_error( 'view_error_unable_join_student', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
-} else {
-    $xml = bigbluebuttonbn_wrap_xml_load_file( bigbluebuttonbn_getMeetingsURL( $bbbsession['endpoint'], $bbbsession['shared_secret'] ) );
-    if ( !isset($xml) || !isset($xml->returncode) || $xml->returncode == 'FAILED' ){ // The shared secret is wrong
-        if ( $bbbsession['administrator'] )
+    if ( $bbbsession['administrator'] ) {
             print_error( 'view_error_unable_join', 'bigbluebuttonbn', $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn' );
-        else if ( $bbbsession['moderator'] )
+    } else if ( $bbbsession['moderator'] ) {
             print_error( 'view_error_unable_join_teacher', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
-        else
+    } else {
             print_error( 'view_error_unable_join_student', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
     }
+    } else {
+    $xml = bigbluebuttonbn_wrap_xml_load_file( bigbluebuttonbn_getMeetingsURL( $bbbsession['endpoint'], $bbbsession['shared_secret'] ) );
+    if ( !isset($xml) || !isset($xml->returncode) || $xml->returncode == 'FAILED' ){ // The shared secret is wrong
+        if ( $bbbsession['administrator'] ) {
+                    print_error( 'view_error_unable_join', 'bigbluebuttonbn', $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn' );
+        } else if ( $bbbsession['moderator'] ) {
+                    print_error( 'view_error_unable_join_teacher', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
+        } else {
+                    print_error( 'view_error_unable_join_student', 'bigbluebuttonbn', $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course );
+        }
+    }
 }
 
 // Mark viewed by user (if required)
@@ -209,10 +212,11 @@ 
     }
 
     $bbbsession['meetingid'] = $bigbluebuttonbn->meetingid.'-'.$bbbsession['course']->id.'-'.$bbbsession['bigbluebuttonbnid'].'['.$bbbsession['group'].']';
-    if( $bbbsession['group'] > 0 )
-        $group_name = groups_get_group_name($bbbsession['group']);
-    else
-        $group_name = get_string('allparticipants');
+    if( $bbbsession['group'] > 0 ) {
+            $group_name = groups_get_group_name($bbbsession['group']);
+    } else {
+            $group_name = get_string('allparticipants');
+    }
     $bbbsession['meetingname'] = $bigbluebuttonbn->name.' ('.$group_name.')';
 }
 // Metadata (contextActivityName updated after meeting name is assigned)

lib.php

Braces +23 added lines, -16 removed lines

@@ -353,14 +353,18 @@ 
         $bigbluebuttonbn->timemodified = time();
     }
 
-    if (! isset($bigbluebuttonbn->newwindow))
-        $bigbluebuttonbn->newwindow = 0;
-    if (! isset($bigbluebuttonbn->wait))
-        $bigbluebuttonbn->wait = 0;
-    if (! isset($bigbluebuttonbn->record))
-        $bigbluebuttonbn->record = 0;
-    if (! isset($bigbluebuttonbn->tagging))
-        $bigbluebuttonbn->tagging = 0;
+    if (! isset($bigbluebuttonbn->newwindow)) {
+            $bigbluebuttonbn->newwindow = 0;
+    }
+    if (! isset($bigbluebuttonbn->wait)) {
+            $bigbluebuttonbn->wait = 0;
+    }
+    if (! isset($bigbluebuttonbn->record)) {
+            $bigbluebuttonbn->record = 0;
+    }
+    if (! isset($bigbluebuttonbn->tagging)) {
+            $bigbluebuttonbn->tagging = 0;
+    }
 
     $bigbluebuttonbn->participants = htmlspecialchars_decode($bigbluebuttonbn->participants);
 }
@@ -422,16 +426,18 @@ 
         /// Build the message_body
         $msg->action = $action;
         $msg->activity_type = "";
-        if( isset($bigbluebuttonbn->type) && $bigbluebuttonbn->type != 0 )
-            $msg->activity_type = bigbluebuttonbn_get_predefinedprofile_name($bigbluebuttonbn->type);
+        if( isset($bigbluebuttonbn->type) && $bigbluebuttonbn->type != 0 ) {
+                    $msg->activity_type = bigbluebuttonbn_get_predefinedprofile_name($bigbluebuttonbn->type);
+        }
         $msg->activity_title = $bigbluebuttonbn->name;
         $message_text = '<p>'.$msg->activity_type.' &quot;'.$msg->activity_title.'&quot; '.get_string('email_body_notification_meeting_has_been', 'bigbluebuttonbn').' '.$msg->action.'.</p>';
 
         /// Add the meeting details to the message_body
         $msg->action = ucfirst($action);
         $msg->activity_description = "";
-        if( !empty($bigbluebuttonbn->intro) )
-            $msg->activity_description = trim($bigbluebuttonbn->intro);
+        if( !empty($bigbluebuttonbn->intro) ) {
+                    $msg->activity_description = trim($bigbluebuttonbn->intro);
+        }
         $msg->activity_openingtime = "";
         if ($bigbluebuttonbn->openingtime) {
             $msg->activity_openingtime = calendar_day_representation($bigbluebuttonbn->openingtime).' '.$at.' '.calendar_time_representation($bigbluebuttonbn->openingtime);
@@ -589,10 +595,11 @@ 
 function bigbluebuttonbn_get_db_moodle_roles($rolename='all') {
     global $DB;
 
-    if( $rolename != 'all')
-        $roles = $DB->get_record('role', array('shortname' => $rolename));
-    else
-        $roles = $DB->get_records('role', array());
+    if( $rolename != 'all') {
+            $roles = $DB->get_record('role', array('shortname' => $rolename));
+    } else {
+            $roles = $DB->get_records('role', array());
+    }
 
     return $roles;
 }

bbb_view.php

Braces +3 added lines, -2 removed lines

@@ -88,8 +88,9 @@
                     /// Set the duration for the meeting
                     if ( bigbluebuttonbn_get_cfg_scheduled_duration_enabled() ) {
                         $durationtime = bigbluebuttonbn_get_duration($bigbluebuttonbn->openingtime, $bigbluebuttonbn->closingtime);
-                        if( $durationtime > 0 )
-                            $bbbsession['welcome'] .= '<br><br>'.str_replace("%duration%", ''.$durationtime, get_string('bbbdurationwarning', 'bigbluebuttonbn'));
+                        if( $durationtime > 0 ) {
+                                                    $bbbsession['welcome'] .= '<br><br>'.str_replace("%duration%", ''.$durationtime, get_string('bbbdurationwarning', 'bigbluebuttonbn'));
+                        }
                     } else {
                         $durationtime = 0;
                     }

locallib.php

Braces +60 added lines, -36 removed lines

@@ -47,8 +47,9 @@ 
     $log->userid = $bbbsession['userID'];
     $log->timecreated = time();
     $log->event = $event;
-    if( $event == BIGBLUEBUTTONBN_LOG_EVENT_CREATE)
-        $log->meta = '{"record":'.($bbbsession['record']? 'true': 'false').'}';
+    if( $event == BIGBLUEBUTTONBN_LOG_EVENT_CREATE) {
+            $log->meta = '{"record":'.($bbbsession['record']? 'true': 'false').'}';
+    }
 
     $returnid = $DB->insert_record('bigbluebuttonbn_log', $log);
 }
@@ -68,15 +69,18 @@ 
     $params = 'name='.urlencode($name).'&meetingID='.urlencode($meetingID).'&attendeePW='.urlencode($attendeePW).'&moderatorPW='.urlencode($moderatorPW).'&logoutURL='.urlencode($logoutURL).'&record='.$record;
 
     $voiceBridge = intval($voiceBridge);
-    if ( $voiceBridge > 0 && $voiceBridge < 79999)
-        $params .= '&voiceBridge='.$voiceBridge;
+    if ( $voiceBridge > 0 && $voiceBridge < 79999) {
+            $params .= '&voiceBridge='.$voiceBridge;
+    }
 
     $duration = intval($duration);
-    if( $duration > 0 )
-        $params .= '&duration='.$duration;
+    if( $duration > 0 ) {
+            $params .= '&duration='.$duration;
+    }
 
-    if( trim( $welcome ) )
-        $params .= '&welcome='.urlencode($welcome);
+    if( trim( $welcome ) ) {
+            $params .= '&welcome='.urlencode($welcome);
+    }
 
     foreach ($metadata as $key => $value) {
         $params .= '&'.$key.'='.urlencode($value);
@@ -148,10 +152,12 @@ 
     }
 
     if( $xml ) {
-        if($xml->meetingID) return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey, 'meetingID' => $xml->meetingID, 'attendeePW' => $xml->attendeePW, 'moderatorPW' => $xml->moderatorPW, 'hasBeenForciblyEnded' => $xml->hasBeenForciblyEnded );
-        else return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey );
-    }
-    else {
+        if($xml->meetingID) {
+            return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey, 'meetingID' => $xml->meetingID, 'attendeePW' => $xml->attendeePW, 'moderatorPW' => $xml->moderatorPW, 'hasBeenForciblyEnded' => $xml->hasBeenForciblyEnded );
+        } else {
+            return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey );
+        }
+    } else {
         return null;
     }
 }
@@ -223,7 +229,9 @@ 
             $metadataArray = array();
             $metadata = get_object_vars($recording->metadata);
             foreach ($metadata as $key => $value) {
-                if(is_object($value)) $value = '';
+                if(is_object($value)) {
+                    $value = '';
+                }
                 $metadataArray['meta_'.$key] = $value;
             }
 
@@ -261,7 +269,9 @@ 
                 $metadataArray = array();
                 $metadata = get_object_vars($recording->metadata);
                 foreach ($metadata as $key => $value) {
-                    if(is_object($value)) $value = '';
+                    if(is_object($value)) {
+                        $value = '';
+                    }
                     $metadataArray['meta_'.$key] = $value;
                 }
 
@@ -280,17 +290,22 @@ 
 }
 
 function bigbluebuttonbn_recordingBuildSorter($a, $b){
-    if( $a['startTime'] < $b['startTime']) return -1;
-    else if( $a['startTime'] == $b['startTime']) return 0;
-    else return 1;
-}
+    if( $a['startTime'] < $b['startTime']) {
+        return -1;
+    } else if( $a['startTime'] == $b['startTime']) {
+        return 0;
+    } else {
+        return 1;
+    }
+    }
 
 function bigbluebuttonbn_doDeleteRecordings( $recordIDs, $URL, $SALT ) {
     $ids = 	explode(",", $recordIDs);
     foreach( $ids as $id){
         $xml = bigbluebuttonbn_wrap_xml_load_file( bigbluebuttonbn_getDeleteRecordingsURL($id, $URL, $SALT) );
-        if( $xml && $xml->returncode != 'SUCCESS' )
-            return false;
+        if( $xml && $xml->returncode != 'SUCCESS' ) {
+                    return false;
+        }
     }
     return true;
 }
@@ -299,8 +314,9 @@ 
     $ids = 	explode(",", $recordIDs);
     foreach( $ids as $id){
         $xml = bigbluebuttonbn_wrap_xml_load_file( bigbluebuttonbn_getPublishRecordingsURL($id, $set, $URL, $SALT) );
-        if( $xml && $xml->returncode != 'SUCCESS' )
-            return false;
+        if( $xml && $xml->returncode != 'SUCCESS' ) {
+                    return false;
+        }
     }
     return true;
 }
@@ -310,8 +326,7 @@ 
 
     if( $xml ) { //If the xml packet returned failure it displays the message to the user
         return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey);
-    }
-    else { //If the server is unreachable, then prompts the user of the necessary action
+    } else { //If the server is unreachable, then prompts the user of the necessary action
         return null;
     }
 }
@@ -531,8 +546,9 @@ 
         // Iterate looking for all configuration
         foreach($participant_list as $participant){
             if( $participant->selectiontype == 'all' ) {
-                if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR )
-                    return true;
+                if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR ) {
+                                    return true;
+                }
             }
         }
 
@@ -543,8 +559,9 @@ 
                 foreach( $roles as $role ) {
                     $db_moodle_role = bigbluebuttonbn_moodle_db_role_lookup($db_moodle_roles, $role->roleid);
                     if( $participant->selectionid == $db_moodle_role->shortname ) {
-                        if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR )
-                            return true;
+                        if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR ) {
+                                                    return true;
+                        }
                     }
                 }
             }
@@ -554,8 +571,9 @@ 
         foreach($participant_list as $participant){
             if( $participant->selectiontype == 'user' ) {
                 if( $participant->selectionid == $user ) {
-                    if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR )
-                        return true;
+                    if ( $participant->role == BIGBLUEBUTTONBN_ROLE_MODERATOR ) {
+                                            return true;
+                    }
                 }
             }
         }
@@ -588,7 +606,9 @@ 
     if( $voicebridge != 0 ) {
         $table = "bigbluebuttonbn";
         $select = "voicebridge = ".$voicebridge;
-        if( $id ) $select .= " AND id <> ".$id;
+        if( $id ) {
+            $select .= " AND id <> ".$id;
+        }
         if ( $rooms = $DB->get_records_select($table, $select)  ) {
             $is_unique = false;
         }
@@ -887,7 +907,9 @@ 
     $error = $org_msg;
 
     if( !empty($new_msg) ) {
-        if( !empty($error) ) $error .= ' ';
+        if( !empty($error) ) {
+            $error .= ' ';
+        }
         $error .= $new_msg;
     }
 
@@ -1092,8 +1114,9 @@ 
 
     /// Build the message_body
     $msg->activity_type = "";
-    if( isset($bigbluebuttonbn->type) && $bigbluebuttonbn->type != 0 )
-        $msg->activity_type = bigbluebuttonbn_get_predefinedprofile_name($bigbluebuttonbn->type);
+    if( isset($bigbluebuttonbn->type) && $bigbluebuttonbn->type != 0 ) {
+            $msg->activity_type = bigbluebuttonbn_get_predefinedprofile_name($bigbluebuttonbn->type);
+    }
     $msg->activity_title = $bigbluebuttonbn->name;
     $message_text = '<p>'.get_string('email_body_recording_ready_for', 'bigbluebuttonbn').' '.$msg->activity_type.' &quot;'.$msg->activity_title.'&quot; '.get_string('email_body_recording_ready_is_ready', 'bigbluebuttonbn').'.</p>';
     
@@ -1119,8 +1142,9 @@ 
         $capabilities = bigbluebuttonbn_getCapabilitiesArray( $endpoint, $shared_secret );
         if( $capabilities ) {
             foreach ($capabilities as $capability) {
-                if( $capability["name"] == $capability_name)
-                    $capability_offered = $capability;
+                if( $capability["name"] == $capability_name) {
+                                    $capability_offered = $capability;
+                }
             }
         }
     }

bbb_broker.php

Braces +3 added lines, -2 removed lines

@@ -119,8 +119,9 @@
                         //Execute the end command
                         $meeting_info = bigbluebuttonbn_bbb_broker_do_end_meeting($params['id'], $bbbsession['modPW']);
                         // Moodle event logger: Create an event for meeting ended
-                        if( isset($bigbluebuttonbn) )
-                            bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_MEETING_ENDED, $bigbluebuttonbn, $context, $cm);
+                        if( isset($bigbluebuttonbn) ) {
+                                                    bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_MEETING_ENDED, $bigbluebuttonbn, $context, $cm);
+                        }
                         /// Update the cache
                         $meeting_info = bigbluebuttonbn_bbb_broker_get_meeting_info($params['id'], $bbbsession['modPW'], true);
 

mod_form.php

Braces +3 added lines, -2 removed lines

@@ -269,8 +269,9 @@
         // Fourth block starts here
         //-------------------------------------------------------------------------------
         $mform->addElement('header', 'schedule', get_string('mod_form_block_schedule', 'bigbluebuttonbn'));
-        if( isset($current_activity->openingtime) && $current_activity->openingtime != 0 || isset($current_activity->closingtime) && $current_activity->closingtime != 0 )
-            $mform->setExpanded('schedule');
+        if( isset($current_activity->openingtime) && $current_activity->openingtime != 0 || isset($current_activity->closingtime) && $current_activity->closingtime != 0 ) {
+                    $mform->setExpanded('schedule');
+        }
 
         $mform->addElement('date_time_selector', 'openingtime', get_string('mod_form_field_openingtime', 'bigbluebuttonbn'), array('optional' => true));
         $mform->setDefault('openingtime', 0);