blindsidenetworks / moodle-mod_bigbluebuttonbn

classes/event/recording_imported.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
      */
     protected function init($crud = 'r', $edulevel = self::LEVEL_OTHER) {
         parent::init($crud, $edulevel);
-        $this->description = "The user with id '##userid' has imported a recording with id ".
+        $this->description = "The user with id '##userid' has imported a recording with id " .
             "'##other' in the course id '##courseid'.";
     }
 

classes/event/meeting_joined.php

Spacing +2 added lines, -2 removed lines

@@ -41,8 +41,8 @@
      */
     protected function init($crud = 'r', $edulevel = self::LEVEL_PARTICIPATING) {
         parent::init($crud, $edulevel);
-        $this->description = "The user with id '##userid' has joined a bigbluebutton meeting for ".
-            "the bigbluebuttonbn activity with id '##objectid' for the course id ".
+        $this->description = "The user with id '##userid' has joined a bigbluebutton meeting for " .
+            "the bigbluebuttonbn activity with id '##objectid' for the course id " .
             "'##courseid'.";
     }
 

classes/event/recording_protected.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
      */
     protected function init($crud = 'r', $edulevel = self::LEVEL_OTHER) {
         parent::init($crud, $edulevel);
-        $this->description = "The user with id '##userid' has protected a recording with id ".
+        $this->description = "The user with id '##userid' has protected a recording with id " .
             "'##other' in the course id '##courseid'.";
     }
 

classes/event/recording_viewed.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
      */
     protected function init($crud = 'r', $edulevel = self::LEVEL_OTHER) {
         parent::init($crud, $edulevel);
-        $this->description = "The user with id '##userid' has viewed a recording with id ".
+        $this->description = "The user with id '##userid' has viewed a recording with id " .
             "'##other' from the course id '##courseid'.";
     }
 

mod_form.php

Indentation +11 added lines, -11 removed lines

@@ -209,8 +209,8 @@ 
             $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
                 $field['description_key'], 0, ['maxlength' => 4, 'size' => 6],
                 ['message' => get_string('mod_form_field_voicebridge_format_error', 'bigbluebuttonbn'),
-                 'type' => 'numeric', 'rule' => '####', 'validator' => 'server']
-              );
+                    'type' => 'numeric', 'rule' => '####', 'validator' => 'server']
+                );
         } else {
             $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
                 $field['description_key'], 0, ['maxlength' => 4, 'size' => 6]);
@@ -248,7 +248,7 @@ 
      */
     private function bigbluebuttonbn_mform_add_block_room_recordings(&$mform, $cfg) {
         $field = ['type' => 'hidden', 'name' => 'recordings_html', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['recordings_html_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_html';
@@ -256,7 +256,7 @@ 
         $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
             $field['description_key'], $cfg['recordings_html_default']);
         $field = ['type' => 'hidden', 'name' => 'recordings_deleted', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['recordings_deleted_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_deleted';
@@ -264,7 +264,7 @@ 
         $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
             $field['description_key'], $cfg['recordings_deleted_default']);
         $field = ['type' => 'hidden', 'name' => 'recordings_imported', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['importrecordings_enabled'] && $cfg['recordings_imported_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_imported';
@@ -272,7 +272,7 @@ 
         $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
             $field['description_key'], $cfg['recordings_imported_default']);
         $field = ['type' => 'hidden', 'name' => 'recordings_preview', 'data_type' => PARAM_INT,
-                  'description_key' => null];
+                    'description_key' => null];
         if ($cfg['recordings_preview_editable']) {
             $field['type'] = 'checkbox';
             $field['description_key'] = 'mod_form_field_recordings_preview';
@@ -342,7 +342,7 @@ 
         $htmlselectiontype = html_writer::select($participantselection['type_options'],
             'bigbluebuttonbn_participant_selection_type', $participantselection['type_selected'], array(),
             array('id' => 'bigbluebuttonbn_participant_selection_type',
-                  'onchange' => 'M.mod_bigbluebuttonbn.modform.participantSelectionSet(); return 0;'));
+                    'onchange' => 'M.mod_bigbluebuttonbn.modform.participantSelectionSet(); return 0;'));
         $htmlselectionoptions = html_writer::select($participantselection['options'], 'bigbluebuttonbn_participant_selection',
             $participantselection['selected'], array(),
             array('id' => 'bigbluebuttonbn_participant_selection', 'disabled' => 'disabled'));
@@ -350,7 +350,7 @@ 
             'type' => 'button', 'class' => 'btn btn-secondary',
             'value' => get_string('mod_form_field_participant_list_action_add', 'bigbluebuttonbn'),
             'onclick' => 'M.mod_bigbluebuttonbn.modform.participantAdd(); return 0;'
-          ));
+            ));
         $htmladdparticipant = html_writer::tag('div',
             $htmlselectiontype . '  ' . $htmlselectionoptions . '  ' . $htmlselectioninput, null);
         $mform->addElement('html', "\n\n");
@@ -392,9 +392,9 @@ 
             $field['type'] = 'select';
             $field['data_type'] = PARAM_TEXT;
             $field['description_key'] = 'mod_form_field_block_clienttype';
-             $choices = array(BIGBLUEBUTTON_CLIENTTYPE_FLASH => get_string('mod_form_block_clienttype_flash', 'bigbluebuttonbn'),
-                             BIGBLUEBUTTON_CLIENTTYPE_HTML5 => get_string('mod_form_block_clienttype_html5', 'bigbluebuttonbn'));
-             $mform->addElement('header', 'clienttypeselection', get_string('mod_form_block_clienttype', 'bigbluebuttonbn'));
+                $choices = array(BIGBLUEBUTTON_CLIENTTYPE_FLASH => get_string('mod_form_block_clienttype_flash', 'bigbluebuttonbn'),
+                                BIGBLUEBUTTON_CLIENTTYPE_HTML5 => get_string('mod_form_block_clienttype_html5', 'bigbluebuttonbn'));
+                $mform->addElement('header', 'clienttypeselection', get_string('mod_form_block_clienttype', 'bigbluebuttonbn'));
             $this->bigbluebuttonbn_mform_add_element($mform, $field['type'], $field['name'], $field['data_type'],
                                     $field['description_key'], $cfg['clienttype_default'], $choices);
             return;

Spacing +6 added lines, -6 removed lines

@@ -26,8 +26,8 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once(dirname(__FILE__).'/locallib.php');
-require_once($CFG->dirroot.'/course/moodleform_mod.php');
+require_once(dirname(__FILE__) . '/locallib.php');
+require_once($CFG->dirroot . '/course/moodleform_mod.php');
 
 /**
  * Moodle class for mod_form.
@@ -48,7 +48,7 @@ 
         $serverversion = bigbluebuttonbn_get_server_version();
         if (is_null($serverversion)) {
             print_error('general_error_unable_connect', 'bigbluebuttonbn',
-                $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn');
+                $CFG->wwwroot . '/admin/settings.php?section=modsettingbigbluebuttonbn');
             return;
         }
         // Context.
@@ -79,7 +79,7 @@ 
         // If none is allowed, fail and return
         if (empty($jsvars['instanceTypeProfiles'])) {
             print_error('general_error_not_allowed_to_create_instances)', 'bigbluebuttonbn',
-                $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn');
+                $CFG->wwwroot . '/admin/settings.php?section=modsettingbigbluebuttonbn');
             return;
         }
         $this->bigbluebuttonbn_mform_add_block_profiles($mform, $jsvars['instanceTypeProfiles']);
@@ -127,7 +127,7 @@ 
                 );
                 $defaultvalues['presentation'] = $draftitemid;
             } catch (Exception $e) {
-                debugging('Presentation could not be loaded: '.$e->getMessage(), DEBUG_DEVELOPER);
+                debugging('Presentation could not be loaded: ' . $e->getMessage(), DEBUG_DEVELOPER);
                 return;
             }
         }
@@ -453,7 +453,7 @@ 
             return;
         }
         $mform->addElement($type, $name, get_string($descriptionkey, 'bigbluebuttonbn'), $options);
-        if (get_string_manager()->string_exists($descriptionkey.'_help', 'bigbluebuttonbn')) {
+        if (get_string_manager()->string_exists($descriptionkey . '_help', 'bigbluebuttonbn')) {
             $mform->addHelpButton($name, $descriptionkey, 'bigbluebuttonbn');
         }
         if (!empty($rule)) {

classes/output/mobile.php

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 defined('MOODLE_INTERNAL') || die();
 
 use context_module;
-use mod_bigbluebuttonbn_external;
 require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
 
 /**

Spacing +7 added lines, -7 removed lines

@@ -54,7 +54,7 @@ 
 
         global $OUTPUT, $SESSION, $CFG;
 
-        $args = (object) $args;
+        $args = (object)$args;
         $viewinstance = bigbluebuttonbn_view_validator($args->cmid, null);
         if (!$viewinstance) {
             $error = get_string('view_error_url_missing_parameters', 'bigbluebuttonbn');
@@ -66,7 +66,7 @@ 
         $bigbluebuttonbn = $viewinstance['bigbluebuttonbn'];
         $context = context_module::instance($cm->id);
 
-        require_login($course->id, false , $cm, true, true);
+        require_login($course->id, false, $cm, true, true);
         require_capability('mod/bigbluebuttonbn:join', $context);
 
         // Add view event.
@@ -111,7 +111,7 @@ 
 
         // Check if the BBB server is working.
         $serverversion = bigbluebuttonbn_get_server_version();
-        $bbbsession['serverversion'] = (string) $serverversion;
+        $bbbsession['serverversion'] = (string)$serverversion;
         if (is_null($serverversion)) {
 
             if ($bbbsession['administrator']) {
@@ -138,7 +138,7 @@ 
 
         // Operation URLs.
         $bbbsession['bigbluebuttonbnURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bbbsession['cm']->id;
-        $bbbsession['logoutURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=logout&id='.$args->cmid .
+        $bbbsession['logoutURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=logout&id=' . $args->cmid .
             '&bn=' . $bbbsession['bigbluebuttonbn']->id;
         $bbbsession['recordingReadyURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_broker.php?action=recording_' .
             'ready&bigbluebuttonbn=' . $bbbsession['bigbluebuttonbn']->id;
@@ -181,7 +181,7 @@ 
             }
             if ($response['returncode'] == 'FAILED') {
                 // The meeting could not be created.
-                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'],  'view_error_create');
+                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'], 'view_error_create');
                 $e = get_string($errorkey, 'bigbluebuttonbn');
                 return(self::mobile_print_error($e));
             }
@@ -194,7 +194,7 @@ 
             bigbluebuttonbn_event_log(\mod_bigbluebuttonbn\event\events::$events['meeting_create'], $bigbluebuttonbn);
             // Insert a record that meeting was created.
             $overrides = array('meetingid' => $bbbsession['meetingid']);
-            $meta = '{"record":'.($bbbsession['record'] ? 'true' : 'false').'}';
+            $meta = '{"record":' . ($bbbsession['record'] ? 'true' : 'false') . '}';
             bigbluebuttonbn_log($bbbsession['bigbluebuttonbn'], BIGBLUEBUTTONBN_LOG_EVENT_CREATE, $overrides, $meta);
         }
 
@@ -212,7 +212,7 @@ 
 
         $data = array(
             'bigbluebuttonbn' => $bigbluebuttonbn,
-            'bbbsession' => (object) $bbbsession,
+            'bbbsession' => (object)$bbbsession,
             'urltojoin' => $urltojoin,
             'cmid' => $cm->id,
             'courseid' => $args->courseid

classes/locallib/mobileview.php

Spacing +4 added lines, -4 removed lines

@@ -58,7 +58,7 @@ 
         $session['importrecordings'] = ($session['managerecordings']);
         $session['modPW'] = $session['bigbluebuttonbn']->moderatorpass;
         $session['viewerPW'] = $session['bigbluebuttonbn']->viewerpass;
-        $session['meetingid'] = $session['bigbluebuttonbn']->meetingid.'-'.$session['course']->id.'-'.
+        $session['meetingid'] = $session['bigbluebuttonbn']->meetingid . '-' . $session['course']->id . '-' .
             $session['bigbluebuttonbn']->id;
         $session['meetingname'] = $session['bigbluebuttonbn']->name;
         $session['meetingdescription'] = $session['bigbluebuttonbn']->intro;
@@ -77,7 +77,7 @@ 
             $session['welcome'] = get_string('mod_form_field_welcome_default', 'bigbluebuttonbn');
         }
         if ($session['bigbluebuttonbn']->record) {
-            $session['welcome'] .= '<br><br>'.get_string('bbbrecordwarning', 'bigbluebuttonbn');
+            $session['welcome'] .= '<br><br>' . get_string('bbbrecordwarning', 'bigbluebuttonbn');
         }
         $session['openingtime'] = $session['bigbluebuttonbn']->openingtime;
         $session['closingtime'] = $session['bigbluebuttonbn']->closingtime;
@@ -88,7 +88,7 @@ 
         $session['originServerName'] = $parsedurl['host'];
         $session['originServerUrl'] = $CFG->wwwroot;
         $session['originServerCommonName'] = '';
-        $session['originTag'] = 'moodle-mod_bigbluebuttonbn ('.get_config('mod_bigbluebuttonbn', 'version').')';
+        $session['originTag'] = 'moodle-mod_bigbluebuttonbn (' . get_config('mod_bigbluebuttonbn', 'version') . ')';
         $session['bnserver'] = bigbluebuttonbn_is_bn_server();
         $session['clienttype'] = \mod_bigbluebuttonbn\locallib\config::get('clienttype_default');
 
@@ -201,7 +201,7 @@ 
             $data['welcome'] .= '<br><br>';
             $data['welcome'] .= str_replace(
                 '%duration%',
-                (string) $durationtime,
+                (string)$durationtime,
                 get_string('bbbdurationwarning', 'bigbluebuttonbn')
             );
         }

view.php

Spacing +26 added lines, -26 removed lines

@@ -24,8 +24,8 @@ 
  * @author    Fred Dixon  (ffdixon [at] blindsidenetworks [dt] com)
  */
 
-require_once(dirname(dirname(dirname(__FILE__))).'/config.php');
-require_once(dirname(__FILE__).'/locallib.php');
+require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
+require_once(dirname(__FILE__) . '/locallib.php');
 
 $id = required_param('id', PARAM_INT);
 $bn = optional_param('bn', 0, PARAM_INT);
@@ -57,19 +57,19 @@ 
 if (is_null($serverversion)) {
     if ($bbbsession['administrator']) {
         print_error('view_error_unable_join', 'bigbluebuttonbn',
-            $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn');
+            $CFG->wwwroot . '/admin/settings.php?section=modsettingbigbluebuttonbn');
         exit;
     }
     if ($bbbsession['moderator']) {
         print_error('view_error_unable_join_teacher', 'bigbluebuttonbn',
-            $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course);
+            $CFG->wwwroot . '/course/view.php?id=' . $bigbluebuttonbn->course);
         exit;
     }
     print_error('view_error_unable_join_student', 'bigbluebuttonbn',
-        $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course);
+        $CFG->wwwroot . '/course/view.php?id=' . $bigbluebuttonbn->course);
     exit;
 }
-$bbbsession['serverversion'] = (string) $serverversion;
+$bbbsession['serverversion'] = (string)$serverversion;
 
 // Mark viewed by user (if required).
 $completion = new completion_info($course);
@@ -77,7 +77,7 @@ 
 
 // Print the page header.
 $PAGE->set_context($context);
-$PAGE->set_url($CFG->wwwroot.'/mod/bigbluebuttonbn/view.php', array('id' => $cm->id));
+$PAGE->set_url($CFG->wwwroot . '/mod/bigbluebuttonbn/view.php', array('id' => $cm->id));
 $PAGE->set_title(format_string($bigbluebuttonbn->name));
 $PAGE->set_cacheable(false);
 $PAGE->set_heading($course->fullname);
@@ -87,11 +87,11 @@ 
 if (!has_capability('moodle/category:manage', $context) && !has_capability('mod/bigbluebuttonbn:join', $context)) {
     echo $OUTPUT->header();
     if (isguestuser()) {
-        echo $OUTPUT->confirm('<p>'.get_string('view_noguests', 'bigbluebuttonbn').'</p>'.get_string('liketologin'),
-            get_login_url(), $CFG->wwwroot.'/course/view.php?id='.$course->id);
+        echo $OUTPUT->confirm('<p>' . get_string('view_noguests', 'bigbluebuttonbn') . '</p>' . get_string('liketologin'),
+            get_login_url(), $CFG->wwwroot . '/course/view.php?id=' . $course->id);
     } else {
-        echo $OUTPUT->confirm('<p>'.get_string('view_nojoin', 'bigbluebuttonbn').'</p>'.get_string('liketologin'),
-            get_login_url(), $CFG->wwwroot.'/course/view.php?id='.$course->id);
+        echo $OUTPUT->confirm('<p>' . get_string('view_nojoin', 'bigbluebuttonbn') . '</p>' . get_string('liketologin'),
+            get_login_url(), $CFG->wwwroot . '/course/view.php?id=' . $course->id);
     }
     echo $OUTPUT->footer();
     exit;
@@ -99,7 +99,7 @@ 
 
 // Operation URLs.
 $bbbsession['bigbluebuttonbnURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bbbsession['cm']->id;
-$bbbsession['logoutURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=logout&id='.$id .
+$bbbsession['logoutURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=logout&id=' . $id .
     '&bn=' . $bbbsession['bigbluebuttonbn']->id;
 $bbbsession['recordingReadyURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_broker.php?action=recording_' .
     'ready&bigbluebuttonbn=' . $bbbsession['bigbluebuttonbn']->id;
@@ -119,7 +119,7 @@ 
 echo $OUTPUT->footer();
 
 // Shows version as a comment.
-echo '<!-- '.$bbbsession['originTag'].' -->'."\n";
+echo '<!-- ' . $bbbsession['originTag'] . ' -->' . "\n";
 
 // Initialize session variable used across views.
 $SESSION->bigbluebuttonbn_bbbsession = $bbbsession;
@@ -151,8 +151,8 @@ 
         $groupname = groups_get_group_name($bbbsession['group']);
     }
     // Assign group default values.
-    $bbbsession['meetingid'] .= '['.$bbbsession['group'].']';
-    $bbbsession['meetingname'] .= ' ('.$groupname.')';
+    $bbbsession['meetingid'] .= '[' . $bbbsession['group'] . ']';
+    $bbbsession['meetingname'] .= ' (' . $groupname . ')';
     if (count($groups) == 0) {
         // Only the All participants group exists.
         bigbluebuttonbn_view_message_box($bbbsession, get_string('view_groups_notenrolled_warning', 'bigbluebuttonbn'), 'info');
@@ -162,7 +162,7 @@ 
     if (has_capability('moodle/site:accessallgroups', $context)) {
         bigbluebuttonbn_view_message_box($bbbsession, get_string('view_groups_selection_warning', 'bigbluebuttonbn'));
     }
-    $urltoroot = $CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bbbsession['cm']->id;
+    $urltoroot = $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bbbsession['cm']->id;
     groups_print_activity_menu($bbbsession['cm'], $urltoroot);
     echo '<br><br>';
 }
@@ -229,7 +229,7 @@ 
         $recordingsdisabled = get_string('view_message_recordings_disabled', 'bigbluebuttonbn');
         $output .= bigbluebuttonbn_render_warning($recordingsdisabled, 'danger');
     }
-    echo $output.html_writer::empty_tag('br').html_writer::empty_tag('br').html_writer::empty_tag('br');
+    echo $output . html_writer::empty_tag('br') . html_writer::empty_tag('br') . html_writer::empty_tag('br');
     $PAGE->requires->yui_module('moodle-mod_bigbluebuttonbn-broker', 'M.mod_bigbluebuttonbn.broker.init', array($jsvars));
 }
 
@@ -298,12 +298,12 @@ 
     // JavaScript variables for room.
     $openingtime = '';
     if ($bbbsession['openingtime']) {
-        $openingtime = get_string('mod_form_field_openingtime', 'bigbluebuttonbn').': '.
+        $openingtime = get_string('mod_form_field_openingtime', 'bigbluebuttonbn') . ': ' .
             userdate($bbbsession['openingtime']);
     }
     $closingtime = '';
     if ($bbbsession['closingtime']) {
-        $closingtime = get_string('mod_form_field_closingtime', 'bigbluebuttonbn').': '.
+        $closingtime = get_string('mod_form_field_closingtime', 'bigbluebuttonbn') . ': ' .
             userdate($bbbsession['closingtime']);
     }
     $jsvars += array(
@@ -320,7 +320,7 @@ 
     $output .= $OUTPUT->box_end();
     // Action button box.
     $output .= $OUTPUT->box_start('generalbox boxaligncenter', 'bigbluebuttonbn_view_action_button_box');
-    $output .= '<br><br><span id="join_button"></span>&nbsp;<span id="end_button"></span>'."\n";
+    $output .= '<br><br><span id="join_button"></span>&nbsp;<span id="end_button"></span>' . "\n";
     $output .= $OUTPUT->box_end();
     if ($activity == 'ended') {
         $output .= bigbluebuttonbn_view_ended($bbbsession);
@@ -373,7 +373,7 @@ 
     // If there are meetings with recordings load the data to the table.
     if ($bbbsession['bigbluebuttonbn']->recordings_html) {
         // Render a plain html table.
-        return bigbluebuttonbn_output_recording_table($bbbsession, $recordings)."\n";
+        return bigbluebuttonbn_output_recording_table($bbbsession, $recordings) . "\n";
     }
     // JavaScript variables for recordings with YUI.
     $jsvars += array(
@@ -401,8 +401,8 @@ 
         array('type' => 'button',
               'value' => get_string('view_recording_button_import', 'bigbluebuttonbn'),
               'class' => 'btn btn-secondary',
-              'onclick' => 'window.location=\''.$CFG->wwwroot.'/mod/bigbluebuttonbn/import_view.php?bn='.
-                  $bbbsession['bigbluebuttonbn']->id.'\''));
+              'onclick' => 'window.location=\'' . $CFG->wwwroot . '/mod/bigbluebuttonbn/import_view.php?bn=' .
+                  $bbbsession['bigbluebuttonbn']->id . '\''));
     $output  = html_writer::empty_tag('br');
     $output .= html_writer::tag('span', $button, array('id' => 'import_recording_links_button'));
     $output .= html_writer::tag('span', '', array('id' => 'import_recording_links_table'));
@@ -421,10 +421,10 @@ 
     if (!is_null($bbbsession['presentation']['url'])) {
         $attributes = array('title' => $bbbsession['presentation']['name']);
         $icon = new pix_icon($bbbsession['presentation']['icon'], $bbbsession['presentation']['mimetype_description']);
-        return '<h4>'.get_string('view_section_title_presentation', 'bigbluebuttonbn').'</h4>'.
-                $OUTPUT->action_icon($bbbsession['presentation']['url'], $icon, null, array(), false).
+        return '<h4>' . get_string('view_section_title_presentation', 'bigbluebuttonbn') . '</h4>' .
+                $OUTPUT->action_icon($bbbsession['presentation']['url'], $icon, null, array(), false) .
                 $OUTPUT->action_link($bbbsession['presentation']['url'],
-                $bbbsession['presentation']['name'], null, $attributes).'<br><br>';
+                $bbbsession['presentation']['name'], null, $attributes) . '<br><br>';
     }
     return '';
 }

Indentation +9 added lines, -9 removed lines

@@ -444,12 +444,12 @@ 
     $recordings = bigbluebuttonbn_get_recordings(
         $bbbsession['course']->id, $bigbluebuttonbnid, $enabledfeatures['showroom'],
         $bbbsession['bigbluebuttonbn']->recordings_deleted
-      );
+        );
     if ($enabledfeatures['importrecordings']) {
         // Get recording links.
         $recordingsimported = bigbluebuttonbn_get_recordings_imported_array(
             $bbbsession['course']->id, $bigbluebuttonbnid, $enabledfeatures['showroom']
-          );
+            );
         /* Perform aritmetic addition instead of merge so the imported recordings corresponding to existent
          * recordings are not included. */
         if ($bbbsession['bigbluebuttonbn']->recordings_imported) {
@@ -467,7 +467,7 @@ 
     // JavaScript variables for recordings.
     $jsvars += array(
             'recordings_html' => $bbbsession['bigbluebuttonbn']->recordings_html == '1',
-          );
+            );
     // If there are meetings with recordings load the data to the table.
     if ($bbbsession['bigbluebuttonbn']->recordings_html) {
         // Render a plain html table.
@@ -477,7 +477,7 @@ 
     $jsvars += array(
             'columns' => bigbluebuttonbn_get_recording_columns($bbbsession),
             'data' => bigbluebuttonbn_get_recording_data($bbbsession, $recordings),
-          );
+            );
     // Render a YUI table.
     $reset = get_string('reset');
     $search = get_string('search');
@@ -506,10 +506,10 @@ 
     }
     $button = html_writer::tag('input', '',
         array('type' => 'button',
-              'value' => get_string('view_recording_button_import', 'bigbluebuttonbn'),
-              'class' => 'btn btn-secondary',
-              'onclick' => 'window.location=\''.$CFG->wwwroot.'/mod/bigbluebuttonbn/import_view.php?bn='.
-                  $bbbsession['bigbluebuttonbn']->id.'\''));
+                'value' => get_string('view_recording_button_import', 'bigbluebuttonbn'),
+                'class' => 'btn btn-secondary',
+                'onclick' => 'window.location=\''.$CFG->wwwroot.'/mod/bigbluebuttonbn/import_view.php?bn='.
+                    $bbbsession['bigbluebuttonbn']->id.'\''));
     $output  = html_writer::empty_tag('br');
     $output .= html_writer::tag('span', $button, array('id' => 'import_recording_links_button'));
     $output .= html_writer::tag('span', '', array('id' => 'import_recording_links_table'));
@@ -570,5 +570,5 @@ 
         (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_href'),
         (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_text'),
         (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_class')
-      );
+        );
 }

index.php

Doc Comments -1 removed lines

@@ -260,7 +260,6 @@
 /**
  * Add Join Session button.
  *
- * @param boolean $moderator
  * @param object $course
  * @param object $bigbluebuttonbn
  * @param object $groupobj

Spacing +24 added lines, -24 removed lines

@@ -24,8 +24,8 @@ 
  * @author    Fred Dixon  (ffdixon [at] blindsidenetworks [dt] com)
  */
 
-require_once(dirname(dirname(dirname(__FILE__))).'/config.php');
-require_once(dirname(__FILE__).'/locallib.php');
+require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
+require_once(dirname(__FILE__) . '/locallib.php');
 
 $id = required_param('id', PARAM_INT);
 $a = optional_param('a', 0, PARAM_INT);
@@ -89,13 +89,13 @@ 
     if ($moderator || $administrator) {
         bigbluebuttonbn_event_log(\mod_bigbluebuttonbn\event\events::$events['meeting_end'], $bigbluebuttonbn);
         echo get_string('index_ending', 'bigbluebuttonbn');
-        $meetingid = $bigbluebuttonbn->meetingid.'-'.$course->id.'-'.$bigbluebuttonbn->id;
+        $meetingid = $bigbluebuttonbn->meetingid . '-' . $course->id . '-' . $bigbluebuttonbn->id;
         if ($g != '0') {
-            $meetingid .= '['.$g.']';
+            $meetingid .= '[' . $g . ']';
         }
 
         bigbluebuttonbn_end_meeting($meetingid, $bigbluebuttonbn->moderatorpass);
-        redirect('index.php?id='.$id);
+        redirect('index.php?id=' . $id);
     }
 }
 
@@ -112,7 +112,7 @@ 
 
         $groupmode = groups_get_activity_groupmode($cm) > 0;
         if ($groupmode) {
-            $groupobj = (object) array('id' => 0, 'name' => get_string('allparticipants'));
+            $groupobj = (object)array('id' => 0, 'name' => get_string('allparticipants'));
         }
         $table->data[] = bigbluebuttonbn_index_display_room($canmoderate, $course, $bigbluebuttonbn, $groupobj);
         if ($groupmode) {
@@ -142,12 +142,12 @@ 
  * @return array
  */
 function bigbluebuttonbn_index_display_room($moderator, $course, $bigbluebuttonbn, $groupobj = null) {
-    $meetingid = $bigbluebuttonbn->meetingid.'-'.$course->id.'-'.$bigbluebuttonbn->id;
+    $meetingid = $bigbluebuttonbn->meetingid . '-' . $course->id . '-' . $bigbluebuttonbn->id;
     $paramgroup = '';
     $groupname = '';
     if ($groupobj) {
-        $meetingid .= '['.$groupobj->id.']';
-        $paramgroup = '&group='.$groupobj->id;
+        $meetingid .= '[' . $groupobj->id . ']';
+        $paramgroup = '&group=' . $groupobj->id;
         $groupname = $groupobj->name;
     }
     $meetinginfo = bigbluebuttonbn_get_meeting_info_array($meetingid);
@@ -162,7 +162,7 @@ 
         return;
     }
     // Output Users in the meeting.
-    $joinurl = '<a href="view.php?id='.$bigbluebuttonbn->coursemodule.$paramgroup.'">'.format_string($bigbluebuttonbn->name).'</a>';
+    $joinurl = '<a href="view.php?id=' . $bigbluebuttonbn->coursemodule . $paramgroup . '">' . format_string($bigbluebuttonbn->name) . '</a>';
     $group = $groupname;
     $users = '';
     $viewerlist = '';
@@ -207,7 +207,7 @@ 
         $attendeecount = 0;
         foreach ($meetinginfo['attendees']->attendee as $attendee) {
             if ($attendee->role == $role) {
-                $attendeelist .= ($attendeecount++ > 0 ? ', ' : '').$attendee->fullName;
+                $attendeelist .= ($attendeecount++ > 0 ? ', ' : '') . $attendee->fullName;
             }
         }
     }
@@ -241,18 +241,18 @@ 
 function bigbluebuttonbn_index_display_room_actions($moderator, $course, $bigbluebuttonbn, $groupobj = null) {
     $actions = '';
     if ($moderator) {
-        $actions .= '<form name="form1" method="post" action="" class="bbb_index_form">'."\n";
-        $actions .= '  <INPUT type="hidden" name="id" value="'.$course->id.'">'."\n";
-        $actions .= '  <INPUT type="hidden" name="a" value="'.$bigbluebuttonbn->id.'">'."\n";
-        $actions .= '  <INPUT type="hidden" name="action" value="end">'."\n";
+        $actions .= '<form name="form1" method="post" action="" class="bbb_index_form">' . "\n";
+        $actions .= '  <INPUT type="hidden" name="id" value="' . $course->id . '">' . "\n";
+        $actions .= '  <INPUT type="hidden" name="a" value="' . $bigbluebuttonbn->id . '">' . "\n";
+        $actions .= '  <INPUT type="hidden" name="action" value="end">' . "\n";
         if ($groupobj != null) {
-            $actions .= '  <INPUT type="hidden" name="g" value="'.$groupobj->id.'">'."\n";
+            $actions .= '  <INPUT type="hidden" name="g" value="' . $groupobj->id . '">' . "\n";
         }
         $actions .= '  <INPUT type="submit" name="submit" value="' .
             get_string('view_conference_action_end', 'bigbluebuttonbn') .
             '" class="btn btn-primary btn-sm" onclick="return confirm(\'' .
             get_string('index_confirm_end', 'bigbluebuttonbn') . '\')">' . "\n";
-        $actions .= '</form>'."\n";
+        $actions .= '</form>' . "\n";
     }
     return $actions;
 }
@@ -287,15 +287,15 @@ 
     $cm = get_fast_modinfo($course->id)->instances['bigbluebuttonbn'][$bigbluebuttonbn->id];
     $url = new \moodle_url('/mod/bigbluebuttonbn/bbb_view.php');
 
-    $actions .= '<form action="'.$url->out().'" target="_blank" class="bbb_index_form">'."\n";
-    $actions .= '<input type="hidden" name="action" value="join">'."\n";
-    $actions .= '<input type="hidden" name="id" value="'.$cm->id.'">'."\n";
-    $actions .= '<input type="hidden" name="bn" value="'.$bigbluebuttonbn->id.'">'."\n";
-    $actions .= '<input type="hidden" name="index" value="1">'."\n";
+    $actions .= '<form action="' . $url->out() . '" target="_blank" class="bbb_index_form">' . "\n";
+    $actions .= '<input type="hidden" name="action" value="join">' . "\n";
+    $actions .= '<input type="hidden" name="id" value="' . $cm->id . '">' . "\n";
+    $actions .= '<input type="hidden" name="bn" value="' . $bigbluebuttonbn->id . '">' . "\n";
+    $actions .= '<input type="hidden" name="index" value="1">' . "\n";
     if ($groupobj) {
-        $actions .= '<input type="hidden" name="group" value="'.$groupobj->id.'">'."\n";
+        $actions .= '<input type="hidden" name="group" value="' . $groupobj->id . '">' . "\n";
     }
-    $actions .= '<input type="submit" value="'.get_string('view_conference_action_join', 'bigbluebuttonbn').'" />'."\n";
+    $actions .= '<input type="submit" value="' . get_string('view_conference_action_join', 'bigbluebuttonbn') . '" />' . "\n";
     $actions .= '</form>';
 
     return $actions;