blindsidenetworks / moodle-mod_bigbluebuttonbn

classes/event/bigbluebuttonbn_recording_deleted.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
      * @return string
      */
     public function get_description() {
-        $rid = isset($this->other['rid'])? $this->other['rid']: '';
+        $rid = isset($this->other['rid']) ? $this->other['rid'] : '';
         return "The user with id '$this->userid' has deleted a recording with id '$rid' for " .
         "the course id '$this->contextinstanceid'.";
     }

bbb_broker.php

Spacing +44 added lines, -44 removed lines

@@ -8,12 +8,12 @@ 
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v2 or later
  */
 
-require_once(dirname(dirname(dirname(__FILE__))).'/config.php');
-require_once(dirname(__FILE__).'/locallib.php');
+require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
+require_once(dirname(__FILE__) . '/locallib.php');
 
 global $PAGE, $USER, $CFG, $SESSION, $DB;
 
-$params['action']  = optional_param('action', '', PARAM_TEXT);
+$params['action'] = optional_param('action', '', PARAM_TEXT);
 $params['callback'] = optional_param('callback', '', PARAM_TEXT);
 $params['id'] = optional_param('id', '', PARAM_TEXT);
 $params['idx'] = optional_param('idx', '', PARAM_TEXT);
@@ -25,13 +25,13 @@ 
 
 $error = '';
 
-if( empty($params['action']) ) {
+if (empty($params['action'])) {
     $error = bigbluebuttonbn_bbb_broker_add_error($error, "Parameter [action] was not included");
 
 } else {
     $error = bigbluebuttonbn_bbb_broker_validate_parameters($params);
 
-    if( empty($error) && $params['action'] != "recording_ready" ) {
+    if (empty($error) && $params['action'] != "recording_ready") {
 
         if ($params['bigbluebuttonbn'] != 0) {
             $bigbluebuttonbn = $DB->get_record('bigbluebuttonbn', array('id' => $params['bigbluebuttonbn']), '*', MUST_EXIST);
@@ -40,7 +40,7 @@ 
             $context = bigbluebuttonbn_get_context_module($cm->id);
         }
 
-        if ( isset($SESSION->bigbluebuttonbn_bbbsession) && !is_null($SESSION->bigbluebuttonbn_bbbsession) ) {
+        if (isset($SESSION->bigbluebuttonbn_bbbsession) && !is_null($SESSION->bigbluebuttonbn_bbbsession)) {
             $bbbsession = $SESSION->bigbluebuttonbn_bbbsession;
         } else {
             $error = bigbluebuttonbn_bbb_broker_add_error($error, "No session variable set");
@@ -49,7 +49,7 @@ 
 }
 
 header('Content-Type: application/javascript; charset=utf-8');
-if ( empty($error) ) {
+if (empty($error)) {
 
     if (!isloggedin() && $PAGE->course->id == SITEID) {
         $userid = guest_user()->id;
@@ -58,21 +58,21 @@ 
     }
     $hascourseaccess = ($PAGE->course->id == SITEID) || can_access_course($PAGE->course, $userid);
 
-    if( !$hascourseaccess ){
+    if (!$hascourseaccess) {
         header("HTTP/1.0 401 Unauthorized");
         return;
     } else {
         try {
-            switch ( strtolower($params['action']) ){
+            switch (strtolower($params['action'])) {
                 case 'meeting_info':
                     $meeting_info = bigbluebuttonbn_bbb_broker_get_meeting_info($params['id'], $bbbsession['modPW']);
                     $meeting_running = bigbluebuttonbn_bbb_broker_is_meeting_running($meeting_info); 
 
                     $status_can_end = '';
                     $status_can_tag = '';
-                    if( $meeting_running ) {
+                    if ($meeting_running) {
                         $join_button_text = get_string('view_conference_action_join', 'bigbluebuttonbn');
-                        if( $bbbsession['userlimit'] == 0 || $meeting_info->participantCount < $bbbsession['userlimit'] ) {
+                        if ($bbbsession['userlimit'] == 0 || $meeting_info->participantCount < $bbbsession['userlimit']) {
                             $initial_message = get_string('view_message_conference_in_progress', 'bigbluebuttonbn');
                             $can_join = true;
 
@@ -81,50 +81,50 @@ 
                             $can_join = false;
                         }
 
-                        if( $bbbsession['administrator'] || $bbbsession['moderator'] ) {
+                        if ($bbbsession['administrator'] || $bbbsession['moderator']) {
                             $end_button_text = get_string('view_conference_action_end', 'bigbluebuttonbn');
                             $can_end = true;
-                            $status_can_end = '"can_end": true, "end_button_text": "'.$end_button_text.'", ';
+                            $status_can_end = '"can_end": true, "end_button_text": "' . $end_button_text . '", ';
                         }
 
                     } else {
                         // If user is administrator, moderator or if is viewer and no waiting is required
-                        if ( $bbbsession['administrator'] || $bbbsession['moderator'] || !$bbbsession['wait'] ) {
+                        if ($bbbsession['administrator'] || $bbbsession['moderator'] || !$bbbsession['wait']) {
                             $initial_message = get_string('view_message_conference_room_ready', 'bigbluebuttonbn');
                             $join_button_text = get_string('view_conference_action_join', 'bigbluebuttonbn');
                             $can_join = true;
 
                         } else {
                             $initial_message = get_string('view_message_conference_not_started', 'bigbluebuttonbn');
-                            if ( $bbbsession['wait'] ) {
-                                $initial_message .= ' '.get_string('view_message_conference_wait_for_moderator', 'bigbluebuttonbn');
+                            if ($bbbsession['wait']) {
+                                $initial_message .= ' ' . get_string('view_message_conference_wait_for_moderator', 'bigbluebuttonbn');
                             }
                             $join_button_text = get_string('view_conference_action_lineup', 'bigbluebuttonbn');
                             $can_join = false;
                         }
 
-                        if( $bbbsession['tagging'] && ($bbbsession['administrator'] || $bbbsession['moderator']) ) {
+                        if ($bbbsession['tagging'] && ($bbbsession['administrator'] || $bbbsession['moderator'])) {
                             $can_tag = true;
 
                         } else {
                             $can_tag = false;
                         }
-                        $status_can_end = '"can_tag": '.($can_tag? 'true': 'false').', ';
+                        $status_can_end = '"can_tag": ' . ($can_tag ? 'true' : 'false') . ', ';
                     }
 
-                    echo $params['callback'].'({ "running": '.($meeting_running? 'true':'false').', "info": '.json_encode($meeting_info).', "status": {"can_join": '.($can_join? 'true':'false').',"join_url": "'.$bbbsession['joinURL'].'","join_button_text": "'.$join_button_text.'", '.$status_can_end.$status_can_tag.'"message": "'.$initial_message.'"} });';
+                    echo $params['callback'] . '({ "running": ' . ($meeting_running ? 'true' : 'false') . ', "info": ' . json_encode($meeting_info) . ', "status": {"can_join": ' . ($can_join ? 'true' : 'false') . ',"join_url": "' . $bbbsession['joinURL'] . '","join_button_text": "' . $join_button_text . '", ' . $status_can_end . $status_can_tag . '"message": "' . $initial_message . '"} });';
                     break;
                 case 'meeting_end':
-                    if( $bbbsession['administrator'] || $bbbsession['moderator'] ) {
+                    if ($bbbsession['administrator'] || $bbbsession['moderator']) {
                         //Execute the end command
                         $meeting_info = bigbluebuttonbn_bbb_broker_do_end_meeting($params['id'], $bbbsession['modPW']);
                         // Moodle event logger: Create an event for meeting ended
-                        if( isset($bigbluebuttonbn) )
+                        if (isset($bigbluebuttonbn))
                             bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_MEETING_ENDED, $bigbluebuttonbn, $context, $cm);
                         /// Update the cache
                         $meeting_info = bigbluebuttonbn_bbb_broker_get_meeting_info($params['id'], $bbbsession['modPW'], true);
 
-                        echo $params['callback'].'({ "status": true });';
+                        echo $params['callback'] . '({ "status": true });';
                     } else {
                         error_log("ERROR: User not authorized to execute end command");
                         header("HTTP/1.0 401 Unauthorized. User not authorized to execute end command");
@@ -134,41 +134,41 @@ 
                     break;
                 case 'recording_info':
                     $recording = bigbluebuttonbn_getRecordingArray($params['id'], $params['idx'], $endpoint, $shared_secret);
-                    if ( isset($recording) && !empty($recording) && !array_key_exists('messageKey', $recording)) {  // The recording was found
-                        echo $params['callback'].'({ "status": "true", "published": "'.$recording['published'].'"});';
+                    if (isset($recording) && !empty($recording) && !array_key_exists('messageKey', $recording)) {  // The recording was found
+                        echo $params['callback'] . '({ "status": "true", "published": "' . $recording['published'] . '"});';
                     } else {
-                        echo $params['callback'].'({ "status": "false" });';
+                        echo $params['callback'] . '({ "status": "false" });';
                     }
                     break;
                 case 'recording_publish':
-                    if( $bbbsession['managerecordings'] ) {
+                    if ($bbbsession['managerecordings']) {
                         $meeting_info = bigbluebuttonbn_bbb_broker_do_publish_recording($params['id'], true);
                         // Moodle event logger: Create an event for recording published
-                        if( isset($bigbluebuttonbn) ) {
+                        if (isset($bigbluebuttonbn)) {
                             bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_RECORDING_PUBLISHED, $bigbluebuttonbn, $context, $cm);
                         }
                     }
-                    echo $params['callback'].'({ "status": "true" });';
+                    echo $params['callback'] . '({ "status": "true" });';
                     break;
                 case 'recording_unpublish':
-                    if( $bbbsession['managerecordings'] ) {
+                    if ($bbbsession['managerecordings']) {
                         $meeting_info = bigbluebuttonbn_bbb_broker_do_publish_recording($params['id'], false);
                         // Moodle event logger: Create an event for recording unpublished
-                        if( isset($bigbluebuttonbn) ) {
+                        if (isset($bigbluebuttonbn)) {
                             bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_RECORDING_UNPUBLISHED, $bigbluebuttonbn, $context, $cm);
                         }
                     }
-                    echo $params['callback'].'({ "status": "true" });';
+                    echo $params['callback'] . '({ "status": "true" });';
                     break;
                 case 'recording_delete':
-                    if( $bbbsession['managerecordings'] ) {
+                    if ($bbbsession['managerecordings']) {
                         $meeting_info = bigbluebuttonbn_bbb_broker_do_delete_recording($params['id']);
                         // Moodle event logger: Create an event for recording deleted
-                        if( isset($bigbluebuttonbn) ) {
+                        if (isset($bigbluebuttonbn)) {
                             bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_RECORDING_DELETED, $bigbluebuttonbn, $context, $cm);
                         }
                     }
-                    echo $params['callback'].'({ "status": "true" });';
+                    echo $params['callback'] . '({ "status": "true" });';
                     break;
                 case 'recording_ready':
                     //Decodes the received JWT string
@@ -176,9 +176,9 @@ 
                         $decoded_parameters = JWT::decode($params['signed_parameters'], $shared_secret, array('HS256'));
 
                     } catch (Exception $e) {
-                        $error = 'Caught exception: '.$e->getMessage();
+                        $error = 'Caught exception: ' . $e->getMessage();
                         error_log($error);
-                        header("HTTP/1.0 400 Bad Request. ".$error);
+                        header("HTTP/1.0 400 Bad Request. " . $error);
                         return;
                     }
 
@@ -189,9 +189,9 @@ 
                         $bigbluebuttonbn = $DB->get_record('bigbluebuttonbn', array('id' => $meeting_id_elements[2]), '*', MUST_EXIST);
 
                     } catch (Exception $e) {
-                        $error = 'Caught exception: '.$e->getMessage();
+                        $error = 'Caught exception: ' . $e->getMessage();
                         error_log($error);
-                        header("HTTP/1.0 410 Gone. ".$error);
+                        header("HTTP/1.0 410 Gone. " . $error);
                         return;
                     }
 
@@ -201,9 +201,9 @@ 
                         header("HTTP/1.0 202 Accepted");
                         return;
                     } catch (Exception $e) {
-                        $error = 'Caught exception: '.$e->getMessage();
+                        $error = 'Caught exception: ' . $e->getMessage();
                         error_log($error);
-                        header("HTTP/1.0 503 Service Unavailable. ".$error);
+                        header("HTTP/1.0 503 Service Unavailable. " . $error);
                         return;
                     }
                     break;
@@ -213,14 +213,14 @@ 
                     break;
             }
 
-        } catch(Exception $e) {
-            error_log("BBB_BROKER ERROR: ".$e->getCode().", ".$e->getMessage());
-            header("HTTP/1.0 502 Bad Gateway. ".$e->getMessage());
+        } catch (Exception $e) {
+            error_log("BBB_BROKER ERROR: " . $e->getCode() . ", " . $e->getMessage());
+            header("HTTP/1.0 502 Bad Gateway. " . $e->getMessage());
             return;
         }
     }
 
 } else {
-    header("HTTP/1.0 400 Bad Request. ".$error);
+    header("HTTP/1.0 400 Bad Request. " . $error);
     return;
 }
\ No newline at end of file

Braces +3 added lines, -2 removed lines

@@ -119,8 +119,9 @@
                         //Execute the end command
                         $meeting_info = bigbluebuttonbn_bbb_broker_do_end_meeting($params['id'], $bbbsession['modPW']);
                         // Moodle event logger: Create an event for meeting ended
-                        if( isset($bigbluebuttonbn) )
-                            bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_MEETING_ENDED, $bigbluebuttonbn, $context, $cm);
+                        if( isset($bigbluebuttonbn) ) {
+                                                    bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_MEETING_ENDED, $bigbluebuttonbn, $context, $cm);
+                        }
                         /// Update the cache
                         $meeting_info = bigbluebuttonbn_bbb_broker_get_meeting_info($params['id'], $bbbsession['modPW'], true);
 

settings.php

Indentation +18 added lines, -18 removed lines

@@ -190,27 +190,27 @@
 
     //// Configuration for "scheduled duration" feature
     if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_scheduled_duration_enabled) ) {
-      $settings->add( new admin_setting_heading('config_scheduled',
-              get_string('config_scheduled', 'bigbluebuttonbn'),
-              get_string('config_scheduled_description', 'bigbluebuttonbn')));
+        $settings->add( new admin_setting_heading('config_scheduled',
+                get_string('config_scheduled', 'bigbluebuttonbn'),
+                get_string('config_scheduled_description', 'bigbluebuttonbn')));
 
-      // calculated duration for 'scheduled session' feature
-      $settings->add(new admin_setting_configcheckbox('bigbluebuttonbn_scheduled_duration_enabled',
-              get_string('config_scheduled_duration_enabled', 'bigbluebuttonbn'),
-              get_string('config_scheduled_duration_enabled_description', 'bigbluebuttonbn'),
-              1));
+        // calculated duration for 'scheduled session' feature
+        $settings->add(new admin_setting_configcheckbox('bigbluebuttonbn_scheduled_duration_enabled',
+                get_string('config_scheduled_duration_enabled', 'bigbluebuttonbn'),
+                get_string('config_scheduled_duration_enabled_description', 'bigbluebuttonbn'),
+                1));
 
-      // compensatory time for 'scheduled session' feature
-      $settings->add(new admin_setting_configtext('bigbluebuttonbn_scheduled_duration_compensation',
-              get_string('config_scheduled_duration_compensation', 'bigbluebuttonbn'),
-              get_string('config_scheduled_duration_compensation_description', 'bigbluebuttonbn'),
-              10, PARAM_INT));
+        // compensatory time for 'scheduled session' feature
+        $settings->add(new admin_setting_configtext('bigbluebuttonbn_scheduled_duration_compensation',
+                get_string('config_scheduled_duration_compensation', 'bigbluebuttonbn'),
+                get_string('config_scheduled_duration_compensation_description', 'bigbluebuttonbn'),
+                10, PARAM_INT));
 
-      // pre-opening time for 'scheduled session' feature
-      $settings->add(new admin_setting_configtext('bigbluebuttonbn_scheduled_pre_opening',
-              get_string('config_scheduled_pre_opening', 'bigbluebuttonbn'),
-              get_string('config_scheduled_pre_opening_description', 'bigbluebuttonbn'),
-              10, PARAM_INT));
+        // pre-opening time for 'scheduled session' feature
+        $settings->add(new admin_setting_configtext('bigbluebuttonbn_scheduled_pre_opening',
+                get_string('config_scheduled_pre_opening', 'bigbluebuttonbn'),
+                get_string('config_scheduled_pre_opening_description', 'bigbluebuttonbn'),
+                10, PARAM_INT));
     }
       
     //// Configuration for defining the default role/user that will be moderator on new activities

Spacing +51 added lines, -51 removed lines

@@ -13,52 +13,52 @@ 
 
 global $BIGBLUEBUTTONBN_CFG;
 
-require_once(dirname(__FILE__).'/locallib.php');
+require_once(dirname(__FILE__) . '/locallib.php');
 
 if ($ADMIN->fulltree) {
-    if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_server_url) || 
-        !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_shared_secret) ) {
-        $settings->add( new admin_setting_heading('bigbluebuttonbn_config_general',
+    if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_server_url) || 
+        !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_shared_secret)) {
+        $settings->add(new admin_setting_heading('bigbluebuttonbn_config_general',
                 get_string('config_general', 'bigbluebuttonbn'),
                 get_string('config_general_description', 'bigbluebuttonbn')));
 
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_server_url) ) {
-            $settings->add( new admin_setting_configtext( 'bigbluebuttonbn_server_url',
-                    get_string( 'config_server_url', 'bigbluebuttonbn' ),
-                    get_string( 'config_server_url_description', 'bigbluebuttonbn' ),
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_server_url)) {
+            $settings->add(new admin_setting_configtext('bigbluebuttonbn_server_url',
+                    get_string('config_server_url', 'bigbluebuttonbn'),
+                    get_string('config_server_url_description', 'bigbluebuttonbn'),
                     bigbluebuttonbn_get_cfg_server_url_default()));
         }
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_shared_secret) ) {
-            $settings->add( new admin_setting_configtext( 'bigbluebuttonbn_shared_secret',
-                    get_string( 'config_shared_secret', 'bigbluebuttonbn' ),
-                    get_string( 'config_shared_secret_description', 'bigbluebuttonbn' ),
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_shared_secret)) {
+            $settings->add(new admin_setting_configtext('bigbluebuttonbn_shared_secret',
+                    get_string('config_shared_secret', 'bigbluebuttonbn'),
+                    get_string('config_shared_secret_description', 'bigbluebuttonbn'),
                     bigbluebuttonbn_get_cfg_shared_secret_default()));
         }
     }
 
     //// Configuration for recording feature
-    if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recording_default) || 
+    if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recording_default) || 
         !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recording_editable) || 
-        !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recording_icons_enabled) ) {
-        $settings->add( new admin_setting_heading('bigbluebuttonbn_recording',
+        !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recording_icons_enabled)) {
+        $settings->add(new admin_setting_heading('bigbluebuttonbn_recording',
                 get_string('config_feature_recording', 'bigbluebuttonbn'),
                 get_string('config_feature_recording_description', 'bigbluebuttonbn')));
 
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recording_default) ) {
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recording_default)) {
             // default value for 'recording' feature
             $settings->add(new admin_setting_configcheckbox('bigbluebuttonbn_recording_default',
                     get_string('config_feature_recording_default', 'bigbluebuttonbn'),
                     get_string('config_feature_recording_default_description', 'bigbluebuttonbn'),
                     1));
         }
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recording_editable) ) {
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recording_editable)) {
             // UI for 'recording' feature
             $settings->add(new admin_setting_configcheckbox('bigbluebuttonbn_recording_editable',
                     get_string('config_feature_recording_editable', 'bigbluebuttonbn'),
                     get_string('config_feature_recording_editable_description', 'bigbluebuttonbn'),
                     1));
         }
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recording_icons_enabled) ) {
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recording_icons_enabled)) {
             // Front panel for 'recording' managment feature
             $settings->add(new admin_setting_configcheckbox('bigbluebuttonbn_recording_icons_enabled',
                     get_string('config_feature_recording_icons_enabled', 'bigbluebuttonbn'),
@@ -68,13 +68,13 @@ 
     }
 
     //// Configuration for recording feature
-    if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recordingtagging_default) || 
-        !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recordingtagging_editable) ) {
-        $settings->add( new admin_setting_heading('bigbluebuttonbn_recordingtagging',
+    if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recordingtagging_default) || 
+        !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recordingtagging_editable)) {
+        $settings->add(new admin_setting_heading('bigbluebuttonbn_recordingtagging',
                 get_string('config_feature_recordingtagging', 'bigbluebuttonbn'),
                 get_string('config_feature_recordingtagging_description', 'bigbluebuttonbn')));
 
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recordingtagging_default) ) {
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recordingtagging_default)) {
             // default value for 'recording tagging' feature
             $settings->add(new admin_setting_configcheckbox('bigbluebuttonbn_recordingtagging_default',
                     get_string('config_feature_recordingtagging_default', 'bigbluebuttonbn'),
@@ -82,7 +82,7 @@ 
                     0));
         }
         // UI for 'recording tagging' feature
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recordingtagging_editable) ) {
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recordingtagging_editable)) {
             $settings->add(new admin_setting_configcheckbox('bigbluebuttonbn_recordingtagging_editable',
                     get_string('config_feature_recordingtagging_editable', 'bigbluebuttonbn'),
                     get_string('config_feature_recordingtagging_editable_description', 'bigbluebuttonbn'),
@@ -91,36 +91,36 @@ 
     }
 
     //// Configuration for wait for moderator feature
-    if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_default) ||
+    if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_default) ||
         !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_editable) || 
         !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_ping_interval) || 
-        !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_cache_ttl) ) {
-        $settings->add( new admin_setting_heading('bigbluebuttonbn_feature_waitformoderator',
+        !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_cache_ttl)) {
+        $settings->add(new admin_setting_heading('bigbluebuttonbn_feature_waitformoderator',
                 get_string('config_feature_waitformoderator', 'bigbluebuttonbn'),
                 get_string('config_feature_waitformoderator_description', 'bigbluebuttonbn')));
 
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_default) ) {
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_default)) {
             //default value for 'wait for moderator' feature
             $settings->add(new admin_setting_configcheckbox('bigbluebuttonbn_waitformoderator_default',
                     get_string('config_feature_waitformoderator_default', 'bigbluebuttonbn'),
                     get_string('config_feature_waitformoderator_default_description', 'bigbluebuttonbn'),
                     0));
         }
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_editable) ) {
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_editable)) {
             // UI for 'wait for moderator' feature
             $settings->add(new admin_setting_configcheckbox('bigbluebuttonbn_waitformoderator_editable',
                     get_string('config_feature_waitformoderator_editable', 'bigbluebuttonbn'),
                     get_string('config_feature_waitformoderator_editable_description', 'bigbluebuttonbn'),
                     1));
         }
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_ping_interval) ) {
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_ping_interval)) {
             //ping interval value for 'wait for moderator' feature
             $settings->add(new admin_setting_configtext('bigbluebuttonbn_waitformoderator_ping_interval',
                     get_string('config_feature_waitformoderator_ping_interval', 'bigbluebuttonbn'),
                     get_string('config_feature_waitformoderator_ping_interval_description', 'bigbluebuttonbn'),
                     10, PARAM_INT));
         }
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_cache_ttl) ) {
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_waitformoderator_cache_ttl)) {
             //cache TTL value for 'wait for moderator' feature
             $settings->add(new admin_setting_configtext('bigbluebuttonbn_waitformoderator_cache_ttl',
                     get_string('config_feature_waitformoderator_cache_ttl', 'bigbluebuttonbn'),
@@ -130,8 +130,8 @@ 
     }
 
     //// Configuration for "static voice bridge" feature
-    if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_voicebridge_editable) ) {
-        $settings->add( new admin_setting_heading('bigbluebuttonbn_feature_voicebridge',
+    if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_voicebridge_editable)) {
+        $settings->add(new admin_setting_heading('bigbluebuttonbn_feature_voicebridge',
                 get_string('config_feature_voicebridge', 'bigbluebuttonbn'),
                 get_string('config_feature_voicebridge_description', 'bigbluebuttonbn')));
 
@@ -143,10 +143,10 @@ 
     }
 
     //// Configuration for "preupload presentation" feature
-    if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_preuploadpresentation_enabled) ) {
+    if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_preuploadpresentation_enabled)) {
         // This feature only works if curl is installed
         if (extension_loaded('curl')) {
-            $settings->add( new admin_setting_heading('bigbluebuttonbn_feature_preuploadpresentation',
+            $settings->add(new admin_setting_heading('bigbluebuttonbn_feature_preuploadpresentation',
                 get_string('config_feature_preuploadpresentation', 'bigbluebuttonbn'),
                 get_string('config_feature_preuploadpresentation_description', 'bigbluebuttonbn')
                 ));
@@ -157,29 +157,29 @@ 
                 get_string('config_feature_preuploadpresentation_enabled_description', 'bigbluebuttonbn'),
                 0));
         } else {
-            $settings->add( new admin_setting_heading('bigbluebuttonbn_feature_preuploadpresentation',
+            $settings->add(new admin_setting_heading('bigbluebuttonbn_feature_preuploadpresentation',
                 get_string('config_feature_preuploadpresentation', 'bigbluebuttonbn'),
-                get_string('config_feature_preuploadpresentation_description', 'bigbluebuttonbn').'<br><br>'.
-                '<div class="form-defaultinfo">'.get_string('config_warning_curl_not_installed', 'bigbluebuttonbn').'</div><br>'
+                get_string('config_feature_preuploadpresentation_description', 'bigbluebuttonbn') . '<br><br>' .
+                '<div class="form-defaultinfo">' . get_string('config_warning_curl_not_installed', 'bigbluebuttonbn') . '</div><br>'
                 ));
         }
     }
 
     //// Configuration for "user limit" feature
-    if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_userlimit_default) || 
-        !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_userlimit_editable) ) {
-        $settings->add( new admin_setting_heading('config_userlimit',
+    if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_userlimit_default) || 
+        !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_userlimit_editable)) {
+        $settings->add(new admin_setting_heading('config_userlimit',
                 get_string('config_feature_userlimit', 'bigbluebuttonbn'),
                 get_string('config_feature_userlimit_description', 'bigbluebuttonbn')));
 
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_userlimit_default) ) {
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_userlimit_default)) {
             //default value for 'user limit' feature
             $settings->add(new admin_setting_configtext('bigbluebuttonbn_userlimit_default',
                     get_string('config_feature_userlimit_default', 'bigbluebuttonbn'),
                     get_string('config_feature_userlimit_default_description', 'bigbluebuttonbn'),
                     0, PARAM_INT));
         }
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_userlimit_editable) ) {
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_userlimit_editable)) {
             // UI for 'user limit' feature
             $settings->add(new admin_setting_configcheckbox('bigbluebuttonbn_userlimit_editable',
                     get_string('config_feature_userlimit_editable', 'bigbluebuttonbn'),
@@ -189,8 +189,8 @@ 
     }
 
     //// Configuration for "scheduled duration" feature
-    if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_scheduled_duration_enabled) ) {
-      $settings->add( new admin_setting_heading('config_scheduled',
+    if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_scheduled_duration_enabled)) {
+      $settings->add(new admin_setting_heading('config_scheduled',
               get_string('config_scheduled', 'bigbluebuttonbn'),
               get_string('config_scheduled_description', 'bigbluebuttonbn')));
 
@@ -214,8 +214,8 @@ 
     }
       
     //// Configuration for defining the default role/user that will be moderator on new activities
-    if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_moderator_default) ) {
-        $settings->add( new admin_setting_heading('bigbluebuttonbn_permission',
+    if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_moderator_default)) {
+        $settings->add(new admin_setting_heading('bigbluebuttonbn_permission',
                 get_string('config_permission', 'bigbluebuttonbn'),
                 get_string('config_permission_description', 'bigbluebuttonbn')));
 
@@ -229,8 +229,8 @@ 
     }
 
     //// Configuration for "send notifications" feature
-    if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_sendnotifications_enabled) ) {
-        $settings->add( new admin_setting_heading('bigbluebuttonbn_feature_sendnotifications',
+    if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_sendnotifications_enabled)) {
+        $settings->add(new admin_setting_heading('bigbluebuttonbn_feature_sendnotifications',
                 get_string('config_feature_sendnotifications', 'bigbluebuttonbn'),
                 get_string('config_feature_sendnotifications_description', 'bigbluebuttonbn')));
 
@@ -242,10 +242,10 @@ 
     }
 
     //// Configuration for extended BN capabilities
-    if( bigbluebuttonbn_server_offers_bn_capabilities() ) {
+    if (bigbluebuttonbn_server_offers_bn_capabilities()) {
         //// Configuration for 'notify users when recording ready' feature
-        if( !isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recordingready_enabled) ) {
-            $settings->add( new admin_setting_heading('bigbluebuttonbn_extended_capabilities',
+        if (!isset($BIGBLUEBUTTONBN_CFG->bigbluebuttonbn_recordingready_enabled)) {
+            $settings->add(new admin_setting_heading('bigbluebuttonbn_extended_capabilities',
                     get_string('config_extended_capabilities', 'bigbluebuttonbn'),
                     get_string('config_extended_capabilities_description', 'bigbluebuttonbn')));
 

mod_form.php

Indentation +32 added lines, -32 removed lines

@@ -183,30 +183,30 @@ 
         $mform->setType('participants', PARAM_TEXT);
 
         $html_participant_selection = ''.
-             '<div id="fitem_bigbluebuttonbn_participant_selection" class="fitem fitem_fselect">'."\n".
-             '  <div class="fitemtitle">'."\n".
-             '    <label for="bigbluebuttonbn_participant_selectiontype">'.get_string('mod_form_field_participant_add', 'bigbluebuttonbn').' </label>'."\n".
-             '  </div>'."\n".
-             '  <div class="felement fselect">'."\n".
-             '    <select id="bigbluebuttonbn_participant_selection_type" onchange="bigbluebuttonbn_participant_selection_set(); return 0;">'."\n".
-             '      <option value="all" selected="selected">'.get_string('mod_form_field_participant_list_type_all', 'bigbluebuttonbn').'</option>'."\n".
-             '      <option value="role">'.get_string('mod_form_field_participant_list_type_role', 'bigbluebuttonbn').'</option>'."\n".
-             '      <option value="user">'.get_string('mod_form_field_participant_list_type_user', 'bigbluebuttonbn').'</option>'."\n".
-             '    </select>'."\n".
-             '    &nbsp;&nbsp;'."\n".
-             '    <select id="bigbluebuttonbn_participant_selection" disabled="disabled">'."\n".
-             '      <option value="all" selected="selected">---------------</option>'."\n".
-             '    </select>'."\n".
-             '    &nbsp;&nbsp;'."\n".
-             '    <input value="'.get_string('mod_form_field_participant_list_action_add', 'bigbluebuttonbn').'" type="button" id="id_addselectionid" onclick="bigbluebuttonbn_participant_add(); return 0;" />'."\n".
-             '  </div>'."\n".
-             '</div>'."\n".
-             '<div id="fitem_bigbluebuttonbn_participant_list" class="fitem">'."\n".
-             '  <div class="fitemtitle">'."\n".
-             '    <label for="bigbluebuttonbn_participant_list">'.get_string('mod_form_field_participant_list', 'bigbluebuttonbn').' </label>'."\n".
-             '  </div>'."\n".
-             '  <div class="felement fselect">'."\n".
-             '    <table id="participant_list_table">'."\n";
+                '<div id="fitem_bigbluebuttonbn_participant_selection" class="fitem fitem_fselect">'."\n".
+                '  <div class="fitemtitle">'."\n".
+                '    <label for="bigbluebuttonbn_participant_selectiontype">'.get_string('mod_form_field_participant_add', 'bigbluebuttonbn').' </label>'."\n".
+                '  </div>'."\n".
+                '  <div class="felement fselect">'."\n".
+                '    <select id="bigbluebuttonbn_participant_selection_type" onchange="bigbluebuttonbn_participant_selection_set(); return 0;">'."\n".
+                '      <option value="all" selected="selected">'.get_string('mod_form_field_participant_list_type_all', 'bigbluebuttonbn').'</option>'."\n".
+                '      <option value="role">'.get_string('mod_form_field_participant_list_type_role', 'bigbluebuttonbn').'</option>'."\n".
+                '      <option value="user">'.get_string('mod_form_field_participant_list_type_user', 'bigbluebuttonbn').'</option>'."\n".
+                '    </select>'."\n".
+                '    &nbsp;&nbsp;'."\n".
+                '    <select id="bigbluebuttonbn_participant_selection" disabled="disabled">'."\n".
+                '      <option value="all" selected="selected">---------------</option>'."\n".
+                '    </select>'."\n".
+                '    &nbsp;&nbsp;'."\n".
+                '    <input value="'.get_string('mod_form_field_participant_list_action_add', 'bigbluebuttonbn').'" type="button" id="id_addselectionid" onclick="bigbluebuttonbn_participant_add(); return 0;" />'."\n".
+                '  </div>'."\n".
+                '</div>'."\n".
+                '<div id="fitem_bigbluebuttonbn_participant_list" class="fitem">'."\n".
+                '  <div class="fitemtitle">'."\n".
+                '    <label for="bigbluebuttonbn_participant_list">'.get_string('mod_form_field_participant_list', 'bigbluebuttonbn').' </label>'."\n".
+                '  </div>'."\n".
+                '  <div class="felement fselect">'."\n".
+                '    <table id="participant_list_table">'."\n";
 
         // Add participant list
         foreach($participant_list as $participant){
@@ -243,11 +243,11 @@ 
         }
 
         $html_participant_selection .= ''.
-             '    </table>'."\n".
-             '  </div>'."\n".
-             '</div>'."\n".
-             '<script type="text/javascript" src="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/mod_form.js">'."\n".
-             '</script>'."\n";
+                '    </table>'."\n".
+                '  </div>'."\n".
+                '</div>'."\n".
+                '<script type="text/javascript" src="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/mod_form.js">'."\n".
+                '</script>'."\n";
 
         $mform->addElement('html', $html_participant_selection);
 
@@ -255,9 +255,9 @@ 
         $mform->addElement('html', '<script type="text/javascript">var bigbluebuttonbn_participant_selection = {"all": [], "role": '.json_encode($roles).', "user": '.bigbluebuttonbn_get_users_json($users).'}; </script>');
         $mform->addElement('html', '<script type="text/javascript">var bigbluebuttonbn_participant_list = '.json_encode($participant_list).'; </script>');
         $bigbluebuttonbn_strings = Array( "as" => get_string('mod_form_field_participant_list_text_as', 'bigbluebuttonbn'),
-                                          "viewer" => get_string('mod_form_field_participant_bbb_role_viewer', 'bigbluebuttonbn'),
-                                          "moderator" => get_string('mod_form_field_participant_bbb_role_moderator', 'bigbluebuttonbn'),
-                                          "remove" => get_string('mod_form_field_participant_list_action_remove', 'bigbluebuttonbn'),
+                                            "viewer" => get_string('mod_form_field_participant_bbb_role_viewer', 'bigbluebuttonbn'),
+                                            "moderator" => get_string('mod_form_field_participant_bbb_role_moderator', 'bigbluebuttonbn'),
+                                            "remove" => get_string('mod_form_field_participant_list_action_remove', 'bigbluebuttonbn'),
                                     );
         $mform->addElement('html', '<script type="text/javascript">var bigbluebuttonbn_strings = '.json_encode($bigbluebuttonbn_strings).'; </script>');
         //-------------------------------------------------------------------------------

Spacing +87 added lines, -87 removed lines

@@ -11,8 +11,8 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once(dirname(__FILE__).'/locallib.php');
-require_once($CFG->dirroot.'/course/moodleform_mod.php');
+require_once(dirname(__FILE__) . '/locallib.php');
+require_once($CFG->dirroot . '/course/moodleform_mod.php');
 
 class mod_bigbluebuttonbn_mod_form extends moodleform_mod {
 
@@ -51,24 +51,24 @@ 
 
         //Validates if the BigBlueButton server is running 
         $serverVersion = bigbluebuttonbn_getServerVersion($endpoint);
-        if ( !isset($serverVersion) ) {
-            print_error( 'general_error_unable_connect', 'bigbluebuttonbn', $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn' );
+        if (!isset($serverVersion)) {
+            print_error('general_error_unable_connect', 'bigbluebuttonbn', $CFG->wwwroot . '/admin/settings.php?section=modsettingbigbluebuttonbn');
         }
 
-        $mform =& $this->_form;
-        $current_activity =& $this->current;
+        $mform = & $this->_form;
+        $current_activity = & $this->current;
 
         //-------------------------------------------------------------------------------
         // First block starts here
         //-------------------------------------------------------------------------------
         $mform->addElement('header', 'general', get_string('mod_form_block_general', 'bigbluebuttonbn'));
 
-        $mform->addElement('text', 'name', get_string('mod_form_field_name','bigbluebuttonbn'), 'maxlength="64" size="32"');
+        $mform->addElement('text', 'name', get_string('mod_form_field_name', 'bigbluebuttonbn'), 'maxlength="64" size="32"');
         $mform->setType('name', PARAM_TEXT);
         $mform->addRule('name', null, 'required', null, 'client');
 
         $version_major = bigbluebuttonbn_get_moodle_version_major();
-        if ( $version_major < '2015051100' ) {
+        if ($version_major < '2015051100') {
             //This is valid before v2.9
             $this->add_intro_editor(false, get_string('mod_form_field_intro', 'bigbluebuttonbn'));
         } else {
@@ -78,62 +78,62 @@ 
         $mform->setAdvanced('introeditor');
         $mform->setAdvanced('showdescription');
 
-        $mform->addElement('textarea', 'welcome', get_string('mod_form_field_welcome','bigbluebuttonbn'), 'wrap="virtual" rows="5" cols="60"');
+        $mform->addElement('textarea', 'welcome', get_string('mod_form_field_welcome', 'bigbluebuttonbn'), 'wrap="virtual" rows="5" cols="60"');
         $mform->addHelpButton('welcome', 'mod_form_field_welcome', 'bigbluebuttonbn');
         $mform->setType('welcome', PARAM_TEXT);
         $mform->setAdvanced('welcome');
 
-        if ( $voicebridge_editable ) {
-            $mform->addElement('text', 'voicebridge', get_string('mod_form_field_voicebridge','bigbluebuttonbn'), array('maxlength'=>4, 'size'=>6));
+        if ($voicebridge_editable) {
+            $mform->addElement('text', 'voicebridge', get_string('mod_form_field_voicebridge', 'bigbluebuttonbn'), array('maxlength'=>4, 'size'=>6));
             $mform->setType('voicebridge', PARAM_INT);
             $mform->addRule('voicebridge', get_string('mod_form_field_voicebridge_format_error', 'bigbluebuttonbn'), 'numeric', '####', 'server');
-            $mform->setDefault( 'voicebridge', 0 );
+            $mform->setDefault('voicebridge', 0);
             $mform->addHelpButton('voicebridge', 'mod_form_field_voicebridge', 'bigbluebuttonbn');
             $mform->setAdvanced('voicebridge');
         }
 
-        if ( $waitformoderator_editable ) {
+        if ($waitformoderator_editable) {
             $mform->addElement('checkbox', 'wait', get_string('mod_form_field_wait', 'bigbluebuttonbn'));
             $mform->addHelpButton('wait', 'mod_form_field_wait', 'bigbluebuttonbn');
             $mform->setType('wait', PARAM_INT);
-            $mform->setDefault( 'wait', $waitformoderator_default );
+            $mform->setDefault('wait', $waitformoderator_default);
             $mform->setAdvanced('wait');
         } else {
-            $mform->addElement('hidden', 'wait', $waitformoderator_default );
+            $mform->addElement('hidden', 'wait', $waitformoderator_default);
             $mform->setType('wait', PARAM_INT);
         }
 
-        if ( $userlimit_editable ) {
-            $mform->addElement('text', 'userlimit', get_string('mod_form_field_userlimit','bigbluebuttonbn'), 'maxlength="3" size="5"' );
+        if ($userlimit_editable) {
+            $mform->addElement('text', 'userlimit', get_string('mod_form_field_userlimit', 'bigbluebuttonbn'), 'maxlength="3" size="5"');
             $mform->addHelpButton('userlimit', 'mod_form_field_userlimit', 'bigbluebuttonbn');
-            $mform->setDefault( 'userlimit', $userlimit_default );
+            $mform->setDefault('userlimit', $userlimit_default);
             $mform->setType('userlimit', PARAM_TEXT);
         } else {
-            $mform->addElement('hidden', 'userlimit', $userlimit_default );
+            $mform->addElement('hidden', 'userlimit', $userlimit_default);
             $mform->setType('userlimit', PARAM_INT);
         }
 
-        if ( floatval($serverVersion) >= 0.8 ) {
-            if ( $recording_editable ) {
+        if (floatval($serverVersion) >= 0.8) {
+            if ($recording_editable) {
                 $mform->addElement('checkbox', 'record', get_string('mod_form_field_record', 'bigbluebuttonbn'));
-                $mform->setDefault( 'record', $recording_default );
+                $mform->setDefault('record', $recording_default);
                 $mform->setAdvanced('record');
             } else {
                 $mform->addElement('hidden', 'record', $recording_default);
             }
             $mform->setType('record', PARAM_INT);
 
-            if ( $recording_tagging_editable ) {
+            if ($recording_tagging_editable) {
                 $mform->addElement('checkbox', 'tagging', get_string('mod_form_field_recordingtagging', 'bigbluebuttonbn'));
                 $mform->setDefault('tagging', $recording_tagging_default);
                 $mform->setAdvanced('tagging');
             } else {
-                $mform->addElement('hidden', 'tagging', $recording_tagging_default );
+                $mform->addElement('hidden', 'tagging', $recording_tagging_default);
             }
             $mform->setType('tagging', PARAM_INT);
         }
 
-        if ( $sendnotifications_enabled ) {
+        if ($sendnotifications_enabled) {
             $mform->addElement('checkbox', 'notification', get_string('mod_form_field_notification', 'bigbluebuttonbn'));
             if ($this->current->instance) {
                 $mform->addHelpButton('notification', 'mod_form_field_notification', 'bigbluebuttonbn');
@@ -150,7 +150,7 @@ 
         //-------------------------------------------------------------------------------
         // Second block starts here
         //-------------------------------------------------------------------------------
-        if ( $preuploadpresentation_enabled ) {
+        if ($preuploadpresentation_enabled) {
             $mform->addElement('header', 'preupload', get_string('mod_form_block_presentation', 'bigbluebuttonbn'));
             $mform->setExpanded('preupload');
 
@@ -182,84 +182,84 @@ 
         $mform->addElement('hidden', 'participants', json_encode($participant_list));
         $mform->setType('participants', PARAM_TEXT);
 
-        $html_participant_selection = ''.
-             '<div id="fitem_bigbluebuttonbn_participant_selection" class="fitem fitem_fselect">'."\n".
-             '  <div class="fitemtitle">'."\n".
-             '    <label for="bigbluebuttonbn_participant_selectiontype">'.get_string('mod_form_field_participant_add', 'bigbluebuttonbn').' </label>'."\n".
-             '  </div>'."\n".
-             '  <div class="felement fselect">'."\n".
-             '    <select id="bigbluebuttonbn_participant_selection_type" onchange="bigbluebuttonbn_participant_selection_set(); return 0;">'."\n".
-             '      <option value="all" selected="selected">'.get_string('mod_form_field_participant_list_type_all', 'bigbluebuttonbn').'</option>'."\n".
-             '      <option value="role">'.get_string('mod_form_field_participant_list_type_role', 'bigbluebuttonbn').'</option>'."\n".
-             '      <option value="user">'.get_string('mod_form_field_participant_list_type_user', 'bigbluebuttonbn').'</option>'."\n".
-             '    </select>'."\n".
-             '    &nbsp;&nbsp;'."\n".
-             '    <select id="bigbluebuttonbn_participant_selection" disabled="disabled">'."\n".
-             '      <option value="all" selected="selected">---------------</option>'."\n".
-             '    </select>'."\n".
-             '    &nbsp;&nbsp;'."\n".
-             '    <input value="'.get_string('mod_form_field_participant_list_action_add', 'bigbluebuttonbn').'" type="button" id="id_addselectionid" onclick="bigbluebuttonbn_participant_add(); return 0;" />'."\n".
-             '  </div>'."\n".
-             '</div>'."\n".
-             '<div id="fitem_bigbluebuttonbn_participant_list" class="fitem">'."\n".
-             '  <div class="fitemtitle">'."\n".
-             '    <label for="bigbluebuttonbn_participant_list">'.get_string('mod_form_field_participant_list', 'bigbluebuttonbn').' </label>'."\n".
-             '  </div>'."\n".
-             '  <div class="felement fselect">'."\n".
-             '    <table id="participant_list_table">'."\n";
+        $html_participant_selection = '' .
+             '<div id="fitem_bigbluebuttonbn_participant_selection" class="fitem fitem_fselect">' . "\n" .
+             '  <div class="fitemtitle">' . "\n" .
+             '    <label for="bigbluebuttonbn_participant_selectiontype">' . get_string('mod_form_field_participant_add', 'bigbluebuttonbn') . ' </label>' . "\n" .
+             '  </div>' . "\n" .
+             '  <div class="felement fselect">' . "\n" .
+             '    <select id="bigbluebuttonbn_participant_selection_type" onchange="bigbluebuttonbn_participant_selection_set(); return 0;">' . "\n" .
+             '      <option value="all" selected="selected">' . get_string('mod_form_field_participant_list_type_all', 'bigbluebuttonbn') . '</option>' . "\n" .
+             '      <option value="role">' . get_string('mod_form_field_participant_list_type_role', 'bigbluebuttonbn') . '</option>' . "\n" .
+             '      <option value="user">' . get_string('mod_form_field_participant_list_type_user', 'bigbluebuttonbn') . '</option>' . "\n" .
+             '    </select>' . "\n" .
+             '    &nbsp;&nbsp;' . "\n" .
+             '    <select id="bigbluebuttonbn_participant_selection" disabled="disabled">' . "\n" .
+             '      <option value="all" selected="selected">---------------</option>' . "\n" .
+             '    </select>' . "\n" .
+             '    &nbsp;&nbsp;' . "\n" .
+             '    <input value="' . get_string('mod_form_field_participant_list_action_add', 'bigbluebuttonbn') . '" type="button" id="id_addselectionid" onclick="bigbluebuttonbn_participant_add(); return 0;" />' . "\n" .
+             '  </div>' . "\n" .
+             '</div>' . "\n" .
+             '<div id="fitem_bigbluebuttonbn_participant_list" class="fitem">' . "\n" .
+             '  <div class="fitemtitle">' . "\n" .
+             '    <label for="bigbluebuttonbn_participant_list">' . get_string('mod_form_field_participant_list', 'bigbluebuttonbn') . ' </label>' . "\n" .
+             '  </div>' . "\n" .
+             '  <div class="felement fselect">' . "\n" .
+             '    <table id="participant_list_table">' . "\n";
 
         // Add participant list
-        foreach($participant_list as $participant){
+        foreach ($participant_list as $participant) {
             $participant_selectionid = '';
             $participant_selectiontype = $participant['selectiontype'];
-            if( $participant_selectiontype == 'all') {
-                $participant_selectiontype = '<b><i>'.get_string('mod_form_field_participant_list_type_'.$participant_selectiontype, 'bigbluebuttonbn').'</i></b>';
+            if ($participant_selectiontype == 'all') {
+                $participant_selectiontype = '<b><i>' . get_string('mod_form_field_participant_list_type_' . $participant_selectiontype, 'bigbluebuttonbn') . '</i></b>';
             } else {
-                if ( $participant_selectiontype == 'role') {
+                if ($participant_selectiontype == 'role') {
                     $participant_selectionid = bigbluebuttonbn_get_role_name($participant['selectionid']);
                 } else {
-                    foreach($users as $user){
-                        if( $user->id == $participant['selectionid']) {
-                            $participant_selectionid = $user->firstname.' '.$user->lastname;
+                    foreach ($users as $user) {
+                        if ($user->id == $participant['selectionid']) {
+                            $participant_selectionid = $user->firstname . ' ' . $user->lastname;
                             break;
                         }
                     }
                 }
-                $participant_selectiontype = '<b><i>'.get_string('mod_form_field_participant_list_type_'.$participant_selectiontype, 'bigbluebuttonbn').':</i></b>&nbsp;';
+                $participant_selectiontype = '<b><i>' . get_string('mod_form_field_participant_list_type_' . $participant_selectiontype, 'bigbluebuttonbn') . ':</i></b>&nbsp;';
             }
-            $participant_role = get_string('mod_form_field_participant_bbb_role_'.$participant['role'], 'bigbluebuttonbn');
-
-            $html_participant_selection .= ''.
-                '      <tr id="participant_list_tr_'.$participant['selectiontype'].'-'.$participant['selectionid'].'">'."\n".
-                '        <td width="20px"><a onclick="bigbluebuttonbn_participant_remove(\''.$participant['selectiontype'].'\', \''.$participant['selectionid'].'\'); return 0;" title="'.get_string('mod_form_field_participant_list_action_remove', 'bigbluebuttonbn').'">x</a></td>'."\n".
-                '        <td width="125px">'.$participant_selectiontype.'</td>'."\n".
-                '        <td>'.$participant_selectionid.'</td>'."\n".
-                '        <td><i>&nbsp;'.get_string('mod_form_field_participant_list_text_as', 'bigbluebuttonbn').'&nbsp;</i>'."\n".
-                '          <select id="participant_list_role_'.$participant['selectiontype'].'-'.$participant['selectionid'].'" onchange="bigbluebuttonbn_participant_list_role_update(\''.$participant['selectiontype'].'\', \''.$participant['selectionid'].'\'); return 0;">'."\n".
-                '            <option value="'.BIGBLUEBUTTONBN_ROLE_VIEWER.'" '.($participant['role'] == BIGBLUEBUTTONBN_ROLE_VIEWER? 'selected="selected" ': '').'>'.get_string('mod_form_field_participant_bbb_role_'.BIGBLUEBUTTONBN_ROLE_VIEWER, 'bigbluebuttonbn').'</option>'."\n".
-                '            <option value="'.BIGBLUEBUTTONBN_ROLE_MODERATOR.'" '.($participant['role'] == BIGBLUEBUTTONBN_ROLE_MODERATOR? 'selected="selected" ': '').'>'.get_string('mod_form_field_participant_bbb_role_'.BIGBLUEBUTTONBN_ROLE_MODERATOR, 'bigbluebuttonbn').'</option><select>'."\n".
-                '        </td>'."\n".
-                '      </tr>'."\n";
+            $participant_role = get_string('mod_form_field_participant_bbb_role_' . $participant['role'], 'bigbluebuttonbn');
+
+            $html_participant_selection .= '' .
+                '      <tr id="participant_list_tr_' . $participant['selectiontype'] . '-' . $participant['selectionid'] . '">' . "\n" .
+                '        <td width="20px"><a onclick="bigbluebuttonbn_participant_remove(\'' . $participant['selectiontype'] . '\', \'' . $participant['selectionid'] . '\'); return 0;" title="' . get_string('mod_form_field_participant_list_action_remove', 'bigbluebuttonbn') . '">x</a></td>' . "\n" .
+                '        <td width="125px">' . $participant_selectiontype . '</td>' . "\n" .
+                '        <td>' . $participant_selectionid . '</td>' . "\n" .
+                '        <td><i>&nbsp;' . get_string('mod_form_field_participant_list_text_as', 'bigbluebuttonbn') . '&nbsp;</i>' . "\n" .
+                '          <select id="participant_list_role_' . $participant['selectiontype'] . '-' . $participant['selectionid'] . '" onchange="bigbluebuttonbn_participant_list_role_update(\'' . $participant['selectiontype'] . '\', \'' . $participant['selectionid'] . '\'); return 0;">' . "\n" .
+                '            <option value="' . BIGBLUEBUTTONBN_ROLE_VIEWER . '" ' . ($participant['role'] == BIGBLUEBUTTONBN_ROLE_VIEWER ? 'selected="selected" ' : '') . '>' . get_string('mod_form_field_participant_bbb_role_' . BIGBLUEBUTTONBN_ROLE_VIEWER, 'bigbluebuttonbn') . '</option>' . "\n" .
+                '            <option value="' . BIGBLUEBUTTONBN_ROLE_MODERATOR . '" ' . ($participant['role'] == BIGBLUEBUTTONBN_ROLE_MODERATOR ? 'selected="selected" ' : '') . '>' . get_string('mod_form_field_participant_bbb_role_' . BIGBLUEBUTTONBN_ROLE_MODERATOR, 'bigbluebuttonbn') . '</option><select>' . "\n" .
+                '        </td>' . "\n" .
+                '      </tr>' . "\n";
         }
 
-        $html_participant_selection .= ''.
-             '    </table>'."\n".
-             '  </div>'."\n".
-             '</div>'."\n".
-             '<script type="text/javascript" src="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/mod_form.js">'."\n".
-             '</script>'."\n";
+        $html_participant_selection .= '' .
+             '    </table>' . "\n" .
+             '  </div>' . "\n" .
+             '</div>' . "\n" .
+             '<script type="text/javascript" src="' . $CFG->wwwroot . '/mod/bigbluebuttonbn/mod_form.js">' . "\n" .
+             '</script>' . "\n";
 
         $mform->addElement('html', $html_participant_selection);
 
         // Add data
-        $mform->addElement('html', '<script type="text/javascript">var bigbluebuttonbn_participant_selection = {"all": [], "role": '.json_encode($roles).', "user": '.bigbluebuttonbn_get_users_json($users).'}; </script>');
-        $mform->addElement('html', '<script type="text/javascript">var bigbluebuttonbn_participant_list = '.json_encode($participant_list).'; </script>');
-        $bigbluebuttonbn_strings = Array( "as" => get_string('mod_form_field_participant_list_text_as', 'bigbluebuttonbn'),
+        $mform->addElement('html', '<script type="text/javascript">var bigbluebuttonbn_participant_selection = {"all": [], "role": ' . json_encode($roles) . ', "user": ' . bigbluebuttonbn_get_users_json($users) . '}; </script>');
+        $mform->addElement('html', '<script type="text/javascript">var bigbluebuttonbn_participant_list = ' . json_encode($participant_list) . '; </script>');
+        $bigbluebuttonbn_strings = Array("as" => get_string('mod_form_field_participant_list_text_as', 'bigbluebuttonbn'),
                                           "viewer" => get_string('mod_form_field_participant_bbb_role_viewer', 'bigbluebuttonbn'),
                                           "moderator" => get_string('mod_form_field_participant_bbb_role_moderator', 'bigbluebuttonbn'),
                                           "remove" => get_string('mod_form_field_participant_list_action_remove', 'bigbluebuttonbn'),
                                     );
-        $mform->addElement('html', '<script type="text/javascript">var bigbluebuttonbn_strings = '.json_encode($bigbluebuttonbn_strings).'; </script>');
+        $mform->addElement('html', '<script type="text/javascript">var bigbluebuttonbn_strings = ' . json_encode($bigbluebuttonbn_strings) . '; </script>');
         //-------------------------------------------------------------------------------
         // Third block ends here
         //-------------------------------------------------------------------------------
@@ -269,7 +269,7 @@ 
         // Fourth block starts here
         //-------------------------------------------------------------------------------
         $mform->addElement('header', 'schedule', get_string('mod_form_block_schedule', 'bigbluebuttonbn'));
-        if( isset($current_activity->openingtime) && $current_activity->openingtime != 0 || isset($current_activity->closingtime) && $current_activity->closingtime != 0 )
+        if (isset($current_activity->openingtime) && $current_activity->openingtime != 0 || isset($current_activity->closingtime) && $current_activity->closingtime != 0)
             $mform->setExpanded('schedule');
 
         $mform->addElement('date_time_selector', 'openingtime', get_string('mod_form_field_openingtime', 'bigbluebuttonbn'), array('optional' => true));
@@ -303,14 +303,14 @@ 
 
         $errors = parent::validation($data, $files);
 
-        if ( isset($data['openingtime']) && isset($data['closingtime']) ) {
-            if ( $data['openingtime'] != 0 && $data['closingtime'] != 0 && $data['closingtime'] < $data['openingtime']) {
+        if (isset($data['openingtime']) && isset($data['closingtime'])) {
+            if ($data['openingtime'] != 0 && $data['closingtime'] != 0 && $data['closingtime'] < $data['openingtime']) {
                 $errors['closingtime'] = get_string('bbbduetimeoverstartingtime', 'bigbluebuttonbn');
             }
         }
         
-        if ( isset($data['voicebridge']) ) {
-            if ( !bigbluebuttonbn_voicebridge_unique($data['voicebridge'], $data['instance'])) {
+        if (isset($data['voicebridge'])) {
+            if (!bigbluebuttonbn_voicebridge_unique($data['voicebridge'], $data['instance'])) {
                 $errors['voicebridge'] = get_string('mod_form_field_voicebridge_notunique_error', 'bigbluebuttonbn');
             }
         }

Braces +3 added lines, -2 removed lines

@@ -269,8 +269,9 @@
         // Fourth block starts here
         //-------------------------------------------------------------------------------
         $mform->addElement('header', 'schedule', get_string('mod_form_block_schedule', 'bigbluebuttonbn'));
-        if( isset($current_activity->openingtime) && $current_activity->openingtime != 0 || isset($current_activity->closingtime) && $current_activity->closingtime != 0 )
-            $mform->setExpanded('schedule');
+        if( isset($current_activity->openingtime) && $current_activity->openingtime != 0 || isset($current_activity->closingtime) && $current_activity->closingtime != 0 ) {
+                    $mform->setExpanded('schedule');
+        }
 
         $mform->addElement('date_time_selector', 'openingtime', get_string('mod_form_field_openingtime', 'bigbluebuttonbn'), array('optional' => true));
         $mform->setDefault('openingtime', 0);