blindsidenetworks / moodle-mod_bigbluebuttonbn

bbb_broker.php

Spacing +7 added lines, -7 removed lines

@@ -24,9 +24,9 @@ 
  * @author    Darko Miletic  (darko.miletic [at] gmail [dt] com)
  */
 
-require(__DIR__.'/../../config.php');
-require_once(__DIR__.'/locallib.php');
-require_once(__DIR__.'/brokerlib.php');
+require(__DIR__ . '/../../config.php');
+require_once(__DIR__ . '/locallib.php');
+require_once(__DIR__ . '/brokerlib.php');
 
 use \Firebase\JWT\JWT;
 
@@ -35,7 +35,7 @@ 
 $params = $_REQUEST;
 
 if (!isset($params['action']) || empty($params['action'])) {
-    header('HTTP/1.0 400 Bad Request. Parameter ['.$params['action'].'] was not included');
+    header('HTTP/1.0 400 Bad Request. Parameter [' . $params['action'] . '] was not included');
     return;
 }
 
@@ -50,7 +50,7 @@ 
 
 $error = bigbluebuttonbn_broker_validate_parameters($params);
 if (!empty($error)) {
-    header('HTTP/1.0 400 Bad Request. '.$error);
+    header('HTTP/1.0 400 Bad Request. ' . $error);
     return;
 }
 
@@ -71,7 +71,7 @@ 
         bigbluebuttonbn_broker_meeting_events($bigbluebuttonbn);
         return;
     }
-    header('HTTP/1.0 400 Bad request. The action '. $a . ' doesn\'t exist');
+    header('HTTP/1.0 400 Bad request. The action ' . $a . ' doesn\'t exist');
 } catch (Exception $e) {
-    header('HTTP/1.0 500 Internal Server Error. '.$e->getMessage());
+    header('HTTP/1.0 500 Internal Server Error. ' . $e->getMessage());
 }

lib.php

Doc Comments +4 added lines, -4 removed lines

@@ -103,7 +103,7 @@ 
  * @uses FEATURE_GRADE_OUTCOMES
  * @uses FEATURE_SHOW_DESCRIPTION
  * @param string $feature
- * @return mixed True if yes (some features may use other values)
+ * @return null|boolean True if yes (some features may use other values)
  */
 function bigbluebuttonbn_supports($feature) {
     if (!$feature) {
@@ -272,7 +272,7 @@ 
  *
  * @param object $bigbluebuttonbn Id of the module instance
  *
- * @return bool Success/Failure
+ * @return boolean|null Success/Failure
  */
 function bigbluebuttonbn_delete_instance_log($bigbluebuttonbn) {
     global $DB;
@@ -293,7 +293,7 @@ 
  * @param object $mod
  * @param object $bigbluebuttonbn
  *
- * @return bool
+ * @return string
  */
 function bigbluebuttonbn_user_outline($course, $user, $mod, $bigbluebuttonbn) {
     if ($completed = bigbluebuttonbn_user_complete($course, $user, $bigbluebuttonbn)) {
@@ -869,7 +869,7 @@ 
  * @param stdClass $context       context object
  * @param string   $filearea      file area
  *
- * @return false|null false if file not valid
+ * @return boolean false if file not valid
  */
 function bigbluebuttonbn_pluginfile_valid($context, $filearea) {
 

Indentation +3 added lines, -3 removed lines

@@ -360,7 +360,7 @@ 
     $sql = "SELECT COUNT(*) FROM {bigbluebuttonbn_logs} ";
     $sql .= "WHERE courseid = ? AND bigbluebuttonbnid = ? AND userid = ? AND (log = ? OR log = ?)";
     $result = $DB->count_records_sql($sql, array($course->id, $bigbluebuttonbn->id, $user->id,
-                                              BIGBLUEBUTTONBN_LOG_EVENT_JOIN, BIGBLUEBUTTONBN_LOG_EVENT_PLAYED));
+                                                BIGBLUEBUTTONBN_LOG_EVENT_JOIN, BIGBLUEBUTTONBN_LOG_EVENT_PLAYED));
     return $result;
 }
 
@@ -593,7 +593,7 @@ 
     $str  = '<div class="bigbluebuttonbn overview">'."\n";
     $str .= '  <div class="name">'.get_string('modulename', 'bigbluebuttonbn').':&nbsp;'."\n";
     $str .= '    <a '.$classes.'href="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bigbluebuttonbn->coursemodule.
-      '">'.$bigbluebuttonbn->name.'</a>'."\n";
+        '">'.$bigbluebuttonbn->name.'</a>'."\n";
     $str .= '  </div>'."\n";
     $str .= '  <div class="info">'.get_string($start, 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->openingtime).
         '</div>'."\n";
@@ -846,7 +846,7 @@ 
             'bigbluebuttonbn',
             $bigbluebuttonbn->id,
             $bigbluebuttonbn->completionexpected
-          );
+            );
     }
 }
 

Spacing +35 added lines, -35 removed lines

@@ -30,10 +30,10 @@ 
 
 // JWT is included in Moodle 3.7 core, but a local package is still needed for backward compatibility.
 if (!class_exists('\Firebase\JWT\JWT')) {
-    if (file_exists($CFG->libdir.'/php-jwt/src/JWT.php')) {
-        require_once($CFG->libdir.'/php-jwt/src/JWT.php');
+    if (file_exists($CFG->libdir . '/php-jwt/src/JWT.php')) {
+        require_once($CFG->libdir . '/php-jwt/src/JWT.php');
     } else {
-        require_once($CFG->dirroot.'/mod/bigbluebuttonbn/vendor/firebase/php-jwt/src/JWT.php');
+        require_once($CFG->dirroot . '/mod/bigbluebuttonbn/vendor/firebase/php-jwt/src/JWT.php');
     }
 }
 
@@ -44,8 +44,8 @@ 
         $CFG->bigbluebuttonbn = array();
     }
 
-    if (file_exists(dirname(__FILE__).'/config.php')) {
-        require_once(dirname(__FILE__).'/config.php');
+    if (file_exists(dirname(__FILE__) . '/config.php')) {
+        require_once(dirname(__FILE__) . '/config.php');
     }
 
     /*
@@ -103,19 +103,19 @@ 
         return null;
     }
     $features = array(
-        (string) FEATURE_IDNUMBER => true,
-        (string) FEATURE_GROUPS => true,
-        (string) FEATURE_GROUPINGS => true,
-        (string) FEATURE_GROUPMEMBERSONLY => true,
-        (string) FEATURE_MOD_INTRO => true,
-        (string) FEATURE_BACKUP_MOODLE2 => true,
-        (string) FEATURE_COMPLETION_TRACKS_VIEWS => true,
-        (string) FEATURE_COMPLETION_HAS_RULES => true,
-        (string) FEATURE_GRADE_HAS_GRADE => false,
-        (string) FEATURE_GRADE_OUTCOMES => false,
-        (string) FEATURE_SHOW_DESCRIPTION => true,
+        (string)FEATURE_IDNUMBER => true,
+        (string)FEATURE_GROUPS => true,
+        (string)FEATURE_GROUPINGS => true,
+        (string)FEATURE_GROUPMEMBERSONLY => true,
+        (string)FEATURE_MOD_INTRO => true,
+        (string)FEATURE_BACKUP_MOODLE2 => true,
+        (string)FEATURE_COMPLETION_TRACKS_VIEWS => true,
+        (string)FEATURE_COMPLETION_HAS_RULES => true,
+        (string)FEATURE_GRADE_HAS_GRADE => false,
+        (string)FEATURE_GRADE_OUTCOMES => false,
+        (string)FEATURE_SHOW_DESCRIPTION => true,
     );
-    if (isset($features[(string) $feature])) {
+    if (isset($features[(string)$feature])) {
         return $features[$feature];
     }
     return null;
@@ -308,7 +308,7 @@ 
 function bigbluebuttonbn_delete_instance_log($bigbluebuttonbn) {
     global $DB;
     $sql  = "SELECT * FROM {bigbluebuttonbn_logs} ";
-    $sql .= "WHERE bigbluebuttonbnid = ? AND log = ? AND ". $DB->sql_compare_text('meta') . " = ?";
+    $sql .= "WHERE bigbluebuttonbnid = ? AND log = ? AND " . $DB->sql_compare_text('meta') . " = ?";
     $logs = $DB->get_records_sql($sql, array($bigbluebuttonbn->id, BIGBLUEBUTTONBN_LOG_EVENT_CREATE, "{\"record\":true}"));
     $meta = "{\"has_recordings\":" . empty($logs) ? "true" : "false" . "}";
     bigbluebuttonbn_log($bigbluebuttonbn, BIGBLUEBUTTONBN_LOG_EVENT_DELETE, [], $meta);
@@ -329,7 +329,7 @@ 
 function bigbluebuttonbn_user_outline($course, $user, $mod, $bigbluebuttonbn) {
     if ($completed = bigbluebuttonbn_user_complete($course, $user, $bigbluebuttonbn)) {
         return fullname($user) . ' ' . get_string('view_message_has_joined', 'bigbluebuttonbn') . ' ' .
-            get_string('view_message_session_for', 'bigbluebuttonbn') . ' ' . (string) $completed . ' ' .
+            get_string('view_message_session_for', 'bigbluebuttonbn') . ' ' . (string)$completed . ' ' .
             get_string('view_message_times', 'bigbluebuttonbn');
     }
     return '';
@@ -521,7 +521,7 @@ 
  * @return array status array
  */
 function bigbluebuttonbn_reset_recordings($courseid) {
-    require_once(__DIR__.'/locallib.php');
+    require_once(__DIR__ . '/locallib.php');
     // Criteria for search [courseid | bigbluebuttonbn=null | subset=false | includedeleted=true].
     $recordings = bigbluebuttonbn_get_recordings($courseid, null, false, true);
     // Remove all the recordings.
@@ -590,18 +590,18 @@ 
     if ($bigbluebuttonbn->visible) {
         $classes = 'class="dimmed" ';
     }
-    $str  = '<div class="bigbluebuttonbn overview">'."\n";
-    $str .= '  <div class="name">'.get_string('modulename', 'bigbluebuttonbn').':&nbsp;'."\n";
-    $str .= '    <a '.$classes.'href="'.$CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bigbluebuttonbn->coursemodule.
-      '">'.$bigbluebuttonbn->name.'</a>'."\n";
-    $str .= '  </div>'."\n";
-    $str .= '  <div class="info">'.get_string($start, 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->openingtime).
-        '</div>'."\n";
+    $str  = '<div class="bigbluebuttonbn overview">' . "\n";
+    $str .= '  <div class="name">' . get_string('modulename', 'bigbluebuttonbn') . ':&nbsp;' . "\n";
+    $str .= '    <a ' . $classes . 'href="' . $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bigbluebuttonbn->coursemodule .
+      '">' . $bigbluebuttonbn->name . '</a>' . "\n";
+    $str .= '  </div>' . "\n";
+    $str .= '  <div class="info">' . get_string($start, 'bigbluebuttonbn') . ': ' . userdate($bigbluebuttonbn->openingtime) .
+        '</div>' . "\n";
     if (!empty($bigbluebuttonbn->closingtime)) {
-        $str .= '  <div class="info">'.get_string('ends_at', 'bigbluebuttonbn').': '.userdate($bigbluebuttonbn->closingtime)
-                .'</div>'."\n";
+        $str .= '  <div class="info">' . get_string('ends_at', 'bigbluebuttonbn') . ': ' . userdate($bigbluebuttonbn->closingtime)
+                .'</div>' . "\n";
     }
-    $str .= '</div>'."\n";
+    $str .= '</div>' . "\n";
     return $str;
 }
 
@@ -689,7 +689,7 @@ 
  * @return void
  **/
 function bigbluebuttonbn_process_pre_save_instance(&$bigbluebuttonbn) {
-    require_once(__DIR__.'/locallib.php');
+    require_once(__DIR__ . '/locallib.php');
     $bigbluebuttonbn->timemodified = time();
     if ((integer)$bigbluebuttonbn->instance == 0) {
         $bigbluebuttonbn->meetingid = 0;
@@ -700,7 +700,7 @@ 
         $bigbluebuttonbn->viewerpass = bigbluebuttonbn_random_password(12, $bigbluebuttonbn->moderatorpass);
         $bigbluebuttonbn->guestlinkid = bigbluebuttonbn_random_password(12);
     }
-    if (!property_exists($bigbluebuttonbn, 'guestlinkid') ) {
+    if (!property_exists($bigbluebuttonbn, 'guestlinkid')) {
         $bigbluebuttonbn->guestlinkid = bigbluebuttonbn_random_password(12);
     }
 }
@@ -826,7 +826,7 @@ 
  **/
 function bigbluebuttonbn_process_post_save_event(&$bigbluebuttonbn) {
     global $CFG, $DB;
-    require_once($CFG->dirroot.'/calendar/lib.php');
+    require_once($CFG->dirroot . '/calendar/lib.php');
     $eventid = $DB->get_field('event', 'id', array('modulename' => 'bigbluebuttonbn',
         'instance' => $bigbluebuttonbn->id));
     // Delete the event from calendar when/if openingtime is NOT set.
@@ -913,7 +913,7 @@ 
     if (count($files) == 1) {
         // Get the first (and only) file.
         $file = reset($files);
-        $filesrc = '/'.$file->get_filename();
+        $filesrc = '/' . $file->get_filename();
     }
     return $filesrc;
 }
@@ -982,7 +982,7 @@ 
     if (!$filename) {
         return false;
     }
-    $fullpath = "/$context->id/mod_bigbluebuttonbn/$filearea/0/".$filename;
+    $fullpath = "/$context->id/mod_bigbluebuttonbn/$filearea/0/" . $filename;
     $fs = get_file_storage();
     $file = $fs->get_file_by_hash(sha1($fullpath));
     if (!$file || $file->is_directory()) {

classes/locallib/notifier.php

Doc Comments +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
      *
      * @param object $bigbluebuttonbn
      *
-     * @return void
+     * @return string
      */
     public static function htmlmsg_recording_ready($bigbluebuttonbn) {
         return '<p>'.get_string('email_body_recording_ready_for', 'bigbluebuttonbn').

Spacing +28 added lines, -28 removed lines

@@ -47,29 +47,29 @@ 
      * @return string
      */
     public static function htmlmsg_instance_updated($msg) {
-        $messagetext = '<p>'.get_string('pluginname', 'bigbluebuttonbn').
-            ' <b>'.$msg->activity_url.'</b> '.
-            get_string('email_body_notification_meeting_has_been', 'bigbluebuttonbn').' '.$msg->action.'.</p>'."\n";
-        $messagetext .= '<p>'.get_string('email_body_notification_meeting_details', 'bigbluebuttonbn').':'."\n";
-        $messagetext .= '<table border="0" style="margin: 5px 0 0 20px"><tbody>'."\n";
-        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">'.
-            get_string('email_body_notification_meeting_title', 'bigbluebuttonbn').': </td><td>'."\n";
-        $messagetext .= $msg->activity_title.'</td></tr>'."\n";
-        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">'.
-            get_string('email_body_notification_meeting_description', 'bigbluebuttonbn').': </td><td>'."\n";
-        $messagetext .= $msg->activity_description.'</td></tr>'."\n";
-        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">'.
-            get_string('email_body_notification_meeting_start_date', 'bigbluebuttonbn').': </td><td>'."\n";
-        $messagetext .= $msg->activity_openingtime.'</td></tr>'."\n";
-        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">'.
-            get_string('email_body_notification_meeting_end_date', 'bigbluebuttonbn').': </td><td>'."\n";
-        $messagetext .= $msg->activity_closingtime.'</td></tr>'."\n";
-        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">'.$msg->action.' '.
-            get_string('email_body_notification_meeting_by', 'bigbluebuttonbn').': </td><td>'."\n";
-        $messagetext .= $msg->activity_owner.'</td></tr></tbody></table></p>'."\n";
-        $messagetext .= '<p><hr/><br/>'.get_string('email_footer_sent_by', 'bigbluebuttonbn').' '.
-            $msg->user_name.' ';
-        $messagetext .= get_string('email_footer_sent_from', 'bigbluebuttonbn').' '.$msg->course_name.'.</p>';
+        $messagetext = '<p>' . get_string('pluginname', 'bigbluebuttonbn') .
+            ' <b>' . $msg->activity_url . '</b> ' .
+            get_string('email_body_notification_meeting_has_been', 'bigbluebuttonbn') . ' ' . $msg->action . '.</p>' . "\n";
+        $messagetext .= '<p>' . get_string('email_body_notification_meeting_details', 'bigbluebuttonbn') . ':' . "\n";
+        $messagetext .= '<table border="0" style="margin: 5px 0 0 20px"><tbody>' . "\n";
+        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">' .
+            get_string('email_body_notification_meeting_title', 'bigbluebuttonbn') . ': </td><td>' . "\n";
+        $messagetext .= $msg->activity_title . '</td></tr>' . "\n";
+        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">' .
+            get_string('email_body_notification_meeting_description', 'bigbluebuttonbn') . ': </td><td>' . "\n";
+        $messagetext .= $msg->activity_description . '</td></tr>' . "\n";
+        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">' .
+            get_string('email_body_notification_meeting_start_date', 'bigbluebuttonbn') . ': </td><td>' . "\n";
+        $messagetext .= $msg->activity_openingtime . '</td></tr>' . "\n";
+        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">' .
+            get_string('email_body_notification_meeting_end_date', 'bigbluebuttonbn') . ': </td><td>' . "\n";
+        $messagetext .= $msg->activity_closingtime . '</td></tr>' . "\n";
+        $messagetext .= '<tr><td style="font-weight:bold;color:#555;">' . $msg->action . ' ' .
+            get_string('email_body_notification_meeting_by', 'bigbluebuttonbn') . ': </td><td>' . "\n";
+        $messagetext .= $msg->activity_owner . '</td></tr></tbody></table></p>' . "\n";
+        $messagetext .= '<p><hr/><br/>' . get_string('email_footer_sent_by', 'bigbluebuttonbn') . ' ' .
+            $msg->user_name . ' ';
+        $messagetext .= get_string('email_footer_sent_from', 'bigbluebuttonbn') . ' ' . $msg->course_name . '.</p>';
         return $messagetext;
     }
 
@@ -86,7 +86,7 @@ 
         $course = $coursemodinfo->get_course($bigbluebuttonbn->course);
         $sender = $USER;
         // Prepare message.
-        $msg = (object) array();
+        $msg = (object)array();
         // Build the message_body.
         $msg->action = $action;
         $msg->activity_url = html_writer::link(
@@ -120,9 +120,9 @@ 
      * @return void
      */
     public static function htmlmsg_recording_ready($bigbluebuttonbn) {
-        return '<p>'.get_string('email_body_recording_ready_for', 'bigbluebuttonbn').
-            ' &quot;' . $bigbluebuttonbn->name . '&quot; '.
-            get_string('email_body_recording_ready_is_ready', 'bigbluebuttonbn').'.</p>';
+        return '<p>' . get_string('email_body_recording_ready_for', 'bigbluebuttonbn') .
+            ' &quot;' . $bigbluebuttonbn->name . '&quot; ' .
+            get_string('email_body_recording_ready_is_ready', 'bigbluebuttonbn') . '.</p>';
     }
 
     /**
@@ -164,7 +164,7 @@ 
                     // Enqueue it.
                     \core\task\manager::queue_adhoc_task($task);
                 } catch (Exception $e) {
-                    mtrace("Error while enqueuing completion_uopdate_state task. " . (string) $e);
+                    mtrace("Error while enqueuing completion_uopdate_state task. " . (string)$e);
                 }
             }
         }

locallib.php

Doc Comments +14 added lines, -14 removed lines

@@ -317,7 +317,7 @@ 
  * Helper function to retrieve imported recordings from the Moodle database.
  * The references are stored as events in bigbluebuttonbn_logs.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -345,7 +345,7 @@ 
 /**
  * Helper function to retrive the default config.xml file.
  *
- * @return string
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_get_default_config_xml() {
     $xml = bigbluebuttonbn_wrap_xml_load_file(
@@ -427,7 +427,7 @@ 
  * @param object $a
  * @param object $b
  *
- * @return array
+ * @return integer
  */
 function bigbluebuttonbn_recording_build_sorter($a, $b) {
     global $CFG;
@@ -541,7 +541,7 @@ 
  * @param string $data
  * @param string $contenttype
  *
- * @return object
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_wrap_xml_load_file($url, $method = 'GET', $data = null, $contenttype = 'text/xml') {
     if (extension_loaded('curl')) {
@@ -582,7 +582,7 @@ 
  * @param string $data
  * @param string $contenttype
  *
- * @return object
+ * @return string
  */
 function bigbluebuttonbn_wrap_xml_load_file_curl_request($url, $method = 'GET', $data = null, $contenttype = 'text/xml') {
     global $CFG;
@@ -974,7 +974,7 @@ 
  * @param integer $instance
  * @param integer $voicebridge
  *
- * @return string
+ * @return boolean
  */
 function bigbluebuttonbn_voicebridge_unique($instance, $voicebridge) {
     global $DB;
@@ -1322,7 +1322,7 @@ 
  * @param string $meetingid
  * @param string $configxml
  *
- * @return object
+ * @return null|SimpleXMLElement
  */
 function bigbluebuttonbn_set_config_xml($meetingid, $configxml) {
     $urldefaultconfig = \mod_bigbluebuttonbn\locallib\config::get('server_url') . 'api/setConfigXML?';
@@ -1376,7 +1376,7 @@ 
  * @param array $recording
  * @param array $tools
  *
- * @return array
+ * @return null|stdClass
  */
 function bigbluebuttonbn_get_recording_data_row($bbbsession, $recording, $tools = ['protect', 'publish', 'delete']) {
     if (!bigbluebuttonbn_include_recording_table_row($bbbsession, $recording)) {
@@ -2018,7 +2018,7 @@ 
  *
  * @param array $bbbsession
  * @param array $recording
- * @param object $rowdata
+ * @param stdClass $rowdata
  *
  * @return object
  */
@@ -2215,7 +2215,7 @@ 
  *
  * @param array $bbbsession
  * @param array $recordings
- * @param array $tools
+ * @param string[] $tools
  *
  * @return array
  */
@@ -2296,7 +2296,7 @@ 
  * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included
  * in the getRecordings request considering only those that belong to deleted activities.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -2320,7 +2320,7 @@ 
  * Helper function to define the sql used for gattering the bigbluebuttonbnids whose meetingids should be included
  * in the getRecordings request considering only those that belong to imported recordings.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  *
@@ -2343,7 +2343,7 @@ 
 /**
  * Helper function to get recordings and imported recordings together.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  * @param bool   $includedeleted
@@ -2361,7 +2361,7 @@ 
  * Helper function to retrieve recordings from the BigBlueButton. The references are stored as events
  * in bigbluebuttonbn_logs.
  *
- * @param string $courseid
+ * @param integer $courseid
  * @param string $bigbluebuttonbnid
  * @param bool   $subset
  * @param bool   $includedeleted

Indentation +2 added lines, -2 removed lines

@@ -796,7 +796,7 @@ 
     $data['role'] = array(
         'name' => get_string('mod_form_field_participant_list_type_role', 'bigbluebuttonbn'),
         'children' => bigbluebuttonbn_get_roles_select($context, true)
-      );
+        );
     $data['user'] = array(
         'name' => get_string('mod_form_field_participant_list_type_user', 'bigbluebuttonbn'),
         'children' => bigbluebuttonbn_get_users_select($context, $bbactivity),
@@ -1704,7 +1704,7 @@ 
         'data-action' => 'play',
         'data-target' => $playback['type'],
         'data-href' => $href,
-      );
+        );
     if ($CFG->bigbluebuttonbn_recordings_validate_url && !bigbluebuttonbn_is_bn_server()
             && !bigbluebuttonbn_is_valid_resource(trim($playback['url']))) {
         $linkattributes['class'] = 'btn btn-sm btn-warning';

Spacing +70 added lines, -70 removed lines

@@ -145,8 +145,8 @@ 
     $payload = null;
     if (!is_null($pname) && !is_null($purl)) {
         $method = 'POST';
-        $payload = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='".
-            $purl."' /></module></modules>";
+        $payload = "<?xml version='1.0' encoding='UTF-8'?><modules><module name='presentation'><document url='" .
+            $purl . "' /></module></modules>";
     }
     $xml = bigbluebuttonbn_wrap_xml_load_file($createmeetingurl, $method, $payload);
     if ($xml) {
@@ -190,7 +190,7 @@ 
     }
     if ($xml) {
         // Either failure or success without meeting info.
-        return (array) $xml;
+        return (array)$xml;
     }
     // If the server is unreachable, then prompts the user of the necessary action.
     return array('returncode' => 'FAILED', 'message' => 'unreachable', 'messageKey' => 'Server is unreachable');
@@ -283,7 +283,7 @@ 
                 foreach ($recordingxml->breakoutRooms->breakoutRoom as $breakoutroom) {
                     $url = \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url(
                         'getRecordings',
-                        ['recordID' => implode(',', (array) $breakoutroom)]
+                        ['recordID' => implode(',', (array)$breakoutroom)]
                     );
                     $xml = bigbluebuttonbn_wrap_xml_load_file($url);
                     if ($xml && $xml->returncode == 'SUCCESS' && isset($xml->recordings)) {
@@ -339,7 +339,7 @@ 
         // Override imported flag with actual ID.
         $recording['imported'] = $recordimported->id;
         if (isset($recordimported->protected)) {
-            $recording['protected'] = (string) $recordimported->protected;
+            $recording['protected'] = (string)$recordimported->protected;
         }
         $recordsimportedarray[$recording['recordID']] = $recording;
     }
@@ -369,21 +369,21 @@ 
     // Add formats.
     $playbackarray = array();
     foreach ($recording->playback->format as $format) {
-        $playbackarray[(string) $format->type] = array('type' => (string) $format->type,
-            'url' => trim((string) $format->url), 'length' => (string) $format->length);
+        $playbackarray[(string)$format->type] = array('type' => (string)$format->type,
+            'url' => trim((string)$format->url), 'length' => (string)$format->length);
         // Add preview per format when existing.
         if ($format->preview) {
-            $playbackarray[(string) $format->type]['preview'] = bigbluebuttonbn_get_recording_preview_images($format->preview);
+            $playbackarray[(string)$format->type]['preview'] = bigbluebuttonbn_get_recording_preview_images($format->preview);
         }
     }
     // Add the metadata to the recordings array.
     $metadataarray = bigbluebuttonbn_get_recording_array_meta(get_object_vars($recording->metadata));
-    $recordingarray = array('recordID' => (string) $recording->recordID,
-        'meetingID' => (string) $recording->meetingID, 'meetingName' => (string) $recording->name,
-        'published' => (string) $recording->published, 'startTime' => (string) $recording->startTime,
-        'endTime' => (string) $recording->endTime, 'playbacks' => $playbackarray);
+    $recordingarray = array('recordID' => (string)$recording->recordID,
+        'meetingID' => (string)$recording->meetingID, 'meetingName' => (string)$recording->name,
+        'published' => (string)$recording->published, 'startTime' => (string)$recording->startTime,
+        'endTime' => (string)$recording->endTime, 'playbacks' => $playbackarray);
     if (isset($recording->protected)) {
-        $recordingarray['protected'] = (string) $recording->protected;
+        $recordingarray['protected'] = (string)$recording->protected;
     }
     return $recordingarray + $metadataarray;
 }
@@ -398,9 +398,9 @@ 
 function bigbluebuttonbn_get_recording_preview_images($preview) {
     $imagesarray = array();
     foreach ($preview->images->image as $image) {
-        $imagearray = array('url' => trim((string) $image));
+        $imagearray = array('url' => trim((string)$image));
         foreach ($image->attributes() as $attkey => $attvalue) {
-            $imagearray[$attkey] = (string) $attvalue;
+            $imagearray[$attkey] = (string)$attvalue;
         }
         array_push($imagesarray, $imagearray);
     }
@@ -495,7 +495,7 @@ 
     $ids = explode(',', $recordids);
     foreach ($ids as $id) {
         $xml = bigbluebuttonbn_wrap_xml_load_file(
-            \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('updateRecordings', ['recordID' => $id] + (array) $params)
+            \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('updateRecordings', ['recordID' => $id] + (array)$params)
         );
         if ($xml && $xml->returncode != 'SUCCESS') {
             return false;
@@ -666,7 +666,7 @@ 
  * @return array $users
  */
 function bigbluebuttonbn_get_users(context $context = null) {
-    $users = (array) get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
+    $users = (array)get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
     foreach ($users as $key => $value) {
         $users[$key] = fullname($value);
     }
@@ -685,7 +685,7 @@ 
 function bigbluebuttonbn_get_users_select(context_course $context, $bbactivity = null) {
     // CONTRIB-7972, check the group of current user and course group mode.
     $groups = null;
-    $users = (array) get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
+    $users = (array)get_enrolled_users($context, '', 0, 'u.*', null, 0, 0, true);
     $course = get_course($context->instanceid);
     $groupmode = groups_get_course_groupmode($course);
     if ($bbactivity) {
@@ -698,7 +698,7 @@ 
         $groups = groups_get_all_groups($course->id, $USER->id);
         $users = [];
         foreach ($groups as $g) {
-            $users += (array) get_enrolled_users($context, '', $g->id, 'u.*', null, 0, 0, true);
+            $users += (array)get_enrolled_users($context, '', $g->id, 'u.*', null, 0, 0, true);
         }
     }
     return array_map(
@@ -720,12 +720,12 @@ 
     global $CFG;
 
     if ($onlyviewableroles == true && $CFG->branch >= 35) {
-        $roles = (array) get_viewable_roles($context);
+        $roles = (array)get_viewable_roles($context);
         foreach ($roles as $key => $value) {
             $roles[$key] = $value;
         }
     } else {
-        $roles = (array) role_get_names($context);
+        $roles = (array)role_get_names($context);
         foreach ($roles as $key => $value) {
             $roles[$key] = $value->localname;
         }
@@ -746,12 +746,12 @@ 
     global $CFG;
 
     if ($onlyviewableroles == true && $CFG->branch >= 35) {
-        $roles = (array) get_viewable_roles($context);
+        $roles = (array)get_viewable_roles($context);
         foreach ($roles as $key => $value) {
             $roles[$key] = array('id' => $key, 'name' => $value);
         }
     } else {
-        $roles = (array) role_get_names($context);
+        $roles = (array)role_get_names($context);
         foreach ($roles as $key => $value) {
             $roles[$key] = array('id' => $value->id, 'name' => $value->localname);
         }
@@ -768,9 +768,9 @@ 
  * @return object $role
  */
 function bigbluebuttonbn_get_role($id) {
-    $roles = (array) role_get_names();
+    $roles = (array)role_get_names();
     if (is_numeric($id) && isset($roles[$id])) {
-        return (object) $roles[$id];
+        return (object)$roles[$id];
     }
     foreach ($roles as $role) {
         if ($role->shortname == $id) {
@@ -850,7 +850,7 @@ 
             if (!empty($ownerid) && is_enrolled($context, $ownerid)) {
                 $participantlist[] = array(
                     'selectiontype' => 'user',
-                    'selectionid' => (string) $ownerid,
+                    'selectionid' => (string)$ownerid,
                     'role' => BIGBLUEBUTTONBN_ROLE_MODERATOR);
             }
             continue;
@@ -1032,7 +1032,7 @@ 
     $now = time();
     if ($closingtime > 0 && $now < $closingtime) {
         $duration = ceil(($closingtime - $now) / 60);
-        $compensationtime = intval((int) \mod_bigbluebuttonbn\locallib\config::get('scheduled_duration_compensation'));
+        $compensationtime = intval((int)\mod_bigbluebuttonbn\locallib\config::get('scheduled_duration_compensation'));
         $duration = intval($duration) + $compensationtime;
     }
     return $duration;
@@ -1234,16 +1234,16 @@ 
  * @return array
  */
 function bigbluebuttonbn_get_meeting_info($meetingid, $updatecache = false) {
-    $cachettl = (int) \mod_bigbluebuttonbn\locallib\config::get('waitformoderator_cache_ttl');
+    $cachettl = (int)\mod_bigbluebuttonbn\locallib\config::get('waitformoderator_cache_ttl');
     $cache = cache::make_from_params(cache_store::MODE_APPLICATION, 'mod_bigbluebuttonbn', 'meetings_cache');
     $result = $cache->get($meetingid);
     $now = time();
     if (!$updatecache && !empty($result) && $now < ($result['creation_time'] + $cachettl)) {
         // Use the value in the cache.
-        return (array) json_decode($result['meeting_info']);
+        return (array)json_decode($result['meeting_info']);
     }
     // Ping again and refresh the cache.
-    $meetinginfo = (array) bigbluebuttonbn_wrap_xml_load_file(
+    $meetinginfo = (array)bigbluebuttonbn_wrap_xml_load_file(
         \mod_bigbluebuttonbn\locallib\bigbluebutton::action_url('getMeetingInfo', ['meetingID' => $meetingid])
     );
     $cache->set($meetingid, array('creation_time' => time(), 'meeting_info' => json_encode($meetinginfo)));
@@ -1390,7 +1390,7 @@ 
  */
 function bigbluebuttonbn_set_config_xml_array($meetingid, $configxml) {
     $configxml = bigbluebuttonbn_set_config_xml($meetingid, $configxml);
-    $configxmlarray = (array) $configxml;
+    $configxmlarray = (array)$configxml;
     if ($configxmlarray['returncode'] != 'SUCCESS') {
         debugging('BigBlueButton was not able to set the custom config.xml file', DEBUG_DEVELOPER);
         return '';
@@ -1443,7 +1443,7 @@ 
  * @return boolean
  */
 function bigbluebuttonbn_get_recording_data_row_editable($bbbsession) {
-    return ($bbbsession['managerecordings'] && ((double) $bbbsession['serverversion'] >= 1.0 || $bbbsession['bnserver']));
+    return ($bbbsession['managerecordings'] && ((double)$bbbsession['serverversion'] >= 1.0 || $bbbsession['bnserver']));
 }
 
 /**
@@ -1454,7 +1454,7 @@ 
  * @return boolean
  */
 function bigbluebuttonbn_get_recording_data_preview_enabled($bbbsession) {
-    return ((double) $bbbsession['serverversion'] >= 1.0 && $bbbsession['bigbluebuttonbn']->recordings_preview == '1');
+    return ((double)$bbbsession['serverversion'] >= 1.0 && $bbbsession['bigbluebuttonbn']->recordings_preview == '1');
 }
 
 /**
@@ -1880,7 +1880,7 @@ 
     }
     $id = 'recording-' . $target . '-' . $recording['recordID'];
     $onclick = 'M.mod_bigbluebuttonbn.recordings.recording' . ucfirst($data['action']) . '(this); return false;';
-    if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recording_icons_enabled')) {
+    if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('recording_icons_enabled')) {
         // With icon for $manageaction.
         $iconattributes = array('id' => $id, 'class' => 'iconsmall');
         $linkattributes = array(
@@ -2143,7 +2143,7 @@ 
         // Enqueue it.
         \core\task\manager::queue_adhoc_task($task);
     } catch (Exception $e) {
-        mtrace("Error while enqueuing completion_update_state task. " . (string) $e);
+        mtrace("Error while enqueuing completion_update_state task. " . (string)$e);
     }
 }
 
@@ -2157,7 +2157,7 @@ 
  */
 function bigbluebuttonbn_completion_update_state($bigbluebuttonbn, $userid) {
     global $CFG;
-    require_once($CFG->libdir.'/completionlib.php');
+    require_once($CFG->libdir . '/completionlib.php');
     list($course, $cm) = get_course_and_cm_from_instance($bigbluebuttonbn, 'bigbluebuttonbn');
     $completion = new completion_info($course);
     if (!$completion->is_enabled($cm)) {
@@ -2587,7 +2587,7 @@ 
  */
 function bigbluebuttonbn_format_activity_time($time) {
     global $CFG;
-    require_once($CFG->dirroot.'/calendar/lib.php');
+    require_once($CFG->dirroot . '/calendar/lib.php');
     $activitytime = '';
     if ($time) {
         $activitytime = calendar_day_representation($time) . ' ' .
@@ -2685,7 +2685,7 @@ 
  */
 function bigbluebuttonbn_settings_general(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_general_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_general_shown()) {
         $renderer->render_group_header('general');
         $renderer->render_group_element(
             'server_url',
@@ -2707,7 +2707,7 @@ 
  */
 function bigbluebuttonbn_settings_record(&$renderer) {
     // Configuration for 'recording' feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_record_meeting_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_record_meeting_shown()) {
         $renderer->render_group_header('recording');
         $renderer->render_group_element(
             'recording_default',
@@ -2751,7 +2751,7 @@ 
  */
 function bigbluebuttonbn_settings_importrecordings(&$renderer) {
     // Configuration for 'import recordings' feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_import_recordings_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_import_recordings_shown()) {
         $renderer->render_group_header('importrecordings');
         $renderer->render_group_element(
             'importrecordings_enabled',
@@ -2773,7 +2773,7 @@ 
  */
 function bigbluebuttonbn_settings_showrecordings(&$renderer) {
     // Configuration for 'show recordings' feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_show_recordings_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_show_recordings_shown()) {
         $renderer->render_group_header('recordings');
         $renderer->render_group_element(
             'recordings_html_default',
@@ -2827,7 +2827,7 @@ 
  */
 function bigbluebuttonbn_settings_waitmoderator(&$renderer) {
     // Configuration for wait for moderator feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_wait_moderator_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_wait_moderator_shown()) {
         $renderer->render_group_header('waitformoderator');
         $renderer->render_group_element(
             'waitformoderator_default',
@@ -2857,7 +2857,7 @@ 
  */
 function bigbluebuttonbn_settings_voicebridge(&$renderer) {
     // Configuration for "static voice bridge" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_static_voice_bridge_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_static_voice_bridge_shown()) {
         $renderer->render_group_header('voicebridge');
         $renderer->render_group_element(
             'voicebridge_editable',
@@ -2875,7 +2875,7 @@ 
  */
 function bigbluebuttonbn_settings_preupload(&$renderer) {
     // Configuration for "preupload presentation" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_preupload_presentation_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_preupload_presentation_shown()) {
         // This feature only works if curl is installed.
         $preuploaddescripion = get_string('config_preuploadpresentation_description', 'bigbluebuttonbn');
         if (!extension_loaded('curl')) {
@@ -2903,7 +2903,7 @@ 
  */
 function bigbluebuttonbn_settings_preupload_manage_default_file(&$renderer) {
     // Configuration for "preupload presentation" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_preupload_presentation_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_preupload_presentation_shown()) {
         if (extension_loaded('curl')) {
             // This feature only works if curl is installed.
             $renderer->render_filemanager_default_file_presentation("presentation_default");
@@ -2920,7 +2920,7 @@ 
  */
 function bigbluebuttonbn_settings_userlimit(&$renderer) {
     // Configuration for "user limit" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_user_limit_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_user_limit_shown()) {
         $renderer->render_group_header('userlimit');
         $renderer->render_group_element(
             'userlimit_default',
@@ -2942,7 +2942,7 @@ 
  */
 function bigbluebuttonbn_settings_duration(&$renderer) {
     // Configuration for "scheduled duration" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_scheduled_duration_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_scheduled_duration_shown()) {
         $renderer->render_group_header('scheduled');
         $renderer->render_group_element(
             'scheduled_duration_enabled',
@@ -2968,7 +2968,7 @@ 
  */
 function bigbluebuttonbn_settings_participants(&$renderer) {
     // Configuration for defining the default role/user that will be moderator on new activities.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_moderator_default_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_moderator_default_shown()) {
         $renderer->render_group_header('participant');
         $renderer->render_group_element(
             'participant_guestlink',
@@ -3001,7 +3001,7 @@ 
  */
 function bigbluebuttonbn_settings_notifications(&$renderer) {
     // Configuration for "send notifications" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_send_notifications_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_send_notifications_shown()) {
         $renderer->render_group_header('sendnotifications');
         $renderer->render_group_element(
             'sendnotifications_enabled',
@@ -3019,14 +3019,14 @@ 
  */
 function bigbluebuttonbn_settings_clienttype(&$renderer) {
     // Configuration for "clienttype" feature.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_clienttype_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_clienttype_shown()) {
         $renderer->render_group_header('clienttype');
         $renderer->render_group_element(
             'clienttype_editable',
             $renderer->render_group_element_checkbox('clienttype_editable', 0)
         );
         // Web Client default.
-        $default = intval((int) \mod_bigbluebuttonbn\locallib\config::get('clienttype_default'));
+        $default = intval((int)\mod_bigbluebuttonbn\locallib\config::get('clienttype_default'));
         $choices = array(BIGBLUEBUTTON_CLIENTTYPE_FLASH => get_string('mod_form_block_clienttype_flash', 'bigbluebuttonbn'),
             BIGBLUEBUTTON_CLIENTTYPE_HTML5 => get_string('mod_form_block_clienttype_html5', 'bigbluebuttonbn'));
         $renderer->render_group_element(
@@ -3049,7 +3049,7 @@ 
  */
 function bigbluebuttonbn_settings_muteonstart(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_muteonstart_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_muteonstart_shown()) {
         $renderer->render_group_header('muteonstart');
         $renderer->render_group_element(
             'muteonstart_default',
@@ -3092,7 +3092,7 @@ 
  */
 function bigbluebuttonbn_settings_disablecam(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_disablecam_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_disablecam_shown()) {
         $renderer->render_group_element(
             'disablecam_default',
             $renderer->render_group_element_checkbox('disablecam_default', 0)
@@ -3113,7 +3113,7 @@ 
  */
 function bigbluebuttonbn_settings_disablemic(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_disablemic_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_disablemic_shown()) {
         $renderer->render_group_element(
             'disablemic_default',
             $renderer->render_group_element_checkbox('disablemic_default', 0)
@@ -3134,7 +3134,7 @@ 
  */
 function bigbluebuttonbn_settings_disableprivatechat(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_disableprivatechat_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_disableprivatechat_shown()) {
         $renderer->render_group_element(
             'disableprivatechat_default',
             $renderer->render_group_element_checkbox('disableprivatechat_default', 0)
@@ -3155,7 +3155,7 @@ 
  */
 function bigbluebuttonbn_settings_disablepublicchat(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_disablepublicchat_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_disablepublicchat_shown()) {
         $renderer->render_group_element(
             'disablepublicchat_default',
             $renderer->render_group_element_checkbox('disablepublicchat_default', 0)
@@ -3176,7 +3176,7 @@ 
  */
 function bigbluebuttonbn_settings_disablenote(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_disablenote_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_disablenote_shown()) {
         $renderer->render_group_element(
             'disablenote_default',
             $renderer->render_group_element_checkbox('disablenote_default', 0)
@@ -3197,7 +3197,7 @@ 
  */
 function bigbluebuttonbn_settings_hideuserlist(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_hideuserlist_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_hideuserlist_shown()) {
         $renderer->render_group_element(
             'hideuserlist_default',
             $renderer->render_group_element_checkbox('hideuserlist_default', 0)
@@ -3218,7 +3218,7 @@ 
  */
 function bigbluebuttonbn_settings_lockedlayout(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_lockedlayout_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_lockedlayout_shown()) {
         $renderer->render_group_element(
             'lockedlayout_default',
             $renderer->render_group_element_checkbox('lockedlayout_default', 0)
@@ -3239,7 +3239,7 @@ 
  */
 function bigbluebuttonbn_settings_lockonjoin(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_lockonjoin_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_lockonjoin_shown()) {
         $renderer->render_group_element(
             'lockonjoin_default',
             $renderer->render_group_element_checkbox('lockonjoin_default', 0)
@@ -3260,7 +3260,7 @@ 
  */
 function bigbluebuttonbn_settings_lockonjoinconfigurable(&$renderer) {
     // Configuration for BigBlueButton.
-    if ((boolean) \mod_bigbluebuttonbn\settings\validator::section_lockonjoinconfigurable_shown()) {
+    if ((boolean)\mod_bigbluebuttonbn\settings\validator::section_lockonjoinconfigurable_shown()) {
         $renderer->render_group_element(
             'lockonjoinconfigurable_default',
             $renderer->render_group_element_checkbox('lockonjoinconfigurable_default', 0)
@@ -3281,7 +3281,7 @@ 
  */
 function bigbluebuttonbn_settings_extended(&$renderer) {
     // Configuration for extended capabilities.
-    if (!(boolean) \mod_bigbluebuttonbn\settings\validator::section_settings_extended_shown()) {
+    if (!(boolean)\mod_bigbluebuttonbn\settings\validator::section_settings_extended_shown()) {
         return;
     }
     $renderer->render_group_header('extended_capabilities');
@@ -3319,7 +3319,7 @@ 
     global $DB;
     do {
         $encodedseed = sha1(bigbluebuttonbn_random_password(12));
-        $meetingid = (string) $DB->get_field('bigbluebuttonbn', 'meetingid', array('meetingid' => $encodedseed));
+        $meetingid = (string)$DB->get_field('bigbluebuttonbn', 'meetingid', array('meetingid' => $encodedseed));
     } while ($meetingid == $encodedseed);
     return $encodedseed;
 }
@@ -3532,7 +3532,7 @@ 
 function bigbluebuttonbn_instance_ownerid($bigbluebuttonbn) {
     global $DB;
     $filters = array('bigbluebuttonbnid' => $bigbluebuttonbn->id, 'log' => 'Add');
-    $ownerid = (integer) $DB->get_field('bigbluebuttonbn_logs', 'userid', $filters);
+    $ownerid = (integer)$DB->get_field('bigbluebuttonbn_logs', 'userid', $filters);
     return $ownerid;
 }
 
@@ -3639,7 +3639,7 @@ 
         'bbb-recording-tags' => bigbluebuttonbn_get_tags($bbbsession['cm']->id), // Same as $id.
     ];
     // Special metadata for recording processing.
-    if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recordingstatus_enabled')) {
+    if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('recordingstatus_enabled')) {
         $metadata["bn-recording-status"] = json_encode(
             array(
                 'email' => array('"' . fullname($USER) . '" <' . $USER->email . '>'),
@@ -3647,10 +3647,10 @@ 
             )
         );
     }
-    if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('recordingready_enabled')) {
+    if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('recordingready_enabled')) {
         $metadata['bn-recording-ready-url'] = $bbbsession['recordingReadyURL'];
     }
-    if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) {
+    if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('meetingevents_enabled')) {
         $metadata['analytics-callback-url'] = $bbbsession['meetingEventsURL'];
     }
     return $metadata;
@@ -3668,7 +3668,7 @@ 
     $meetinginfo = bigbluebuttonbn_get_meeting_info($bbbsession['meetingid'], BIGBLUEBUTTONBN_UPDATE_CACHE);
     if ($bbbsession['userlimit'] > 0 && intval($meetinginfo['participantCount']) >= $bbbsession['userlimit']) {
         // No more users allowed to join.
-        header('Location: '.$bbbsession['logoutURL']);
+        header('Location: ' . $bbbsession['logoutURL']);
         return;
     }
     // Build the URL.
@@ -3682,13 +3682,13 @@ 
     bigbluebuttonbn_event_log(\mod_bigbluebuttonbn\event\events::$events['meeting_join'], $bigbluebuttonbn);
     // Internal logger: Instert a record with the meeting created.
     $overrides = array('meetingid' => $bbbsession['meetingid']);
-    $meta = '{"origin":'.$origin.'}';
+    $meta = '{"origin":' . $origin . '}';
     bigbluebuttonbn_log($bbbsession['bigbluebuttonbn'], BIGBLUEBUTTONBN_LOG_EVENT_JOIN, $overrides, $meta);
     // Before executing the redirect, increment the number of participants.
     bigbluebuttonbn_participant_joined($bbbsession['meetingid'],
         ($bbbsession['administrator'] || $bbbsession['moderator']));
     // Execute the redirect.
-    header('Location: '.$joinurl);
+    header('Location: ' . $joinurl);
 }
 
 /**

classes/output/index.php

Spacing +9 added lines, -9 removed lines

@@ -35,7 +35,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Class index
@@ -91,7 +91,7 @@ 
                 // Add a the data for the bigbluebuttonbn instance.
                 $groupobj = null;
                 if (groups_get_activity_groupmode($cm) > 0) {
-                    $groupobj = (object) array('id' => 0, 'name' => get_string('allparticipants'));
+                    $groupobj = (object)array('id' => 0, 'name' => get_string('allparticipants'));
                 }
                 $table->data[] = self::bigbluebuttonbn_index_display_room($canmoderate, $course, $bigbluebuttonbn, $groupobj);
                 // Add a the data for the groups belonging to the bigbluebuttonbn instance, if any.
@@ -181,7 +181,7 @@ 
             $attendeecount = 0;
             foreach ($meetinginfo['attendees']->attendee as $attendee) {
                 if ($attendee->role == $role) {
-                    $attendeelist .= ($attendeecount++ > 0 ? ', ' : '').$attendee->fullName;
+                    $attendeelist .= ($attendeecount++ > 0 ? ', ' : '') . $attendee->fullName;
                 }
             }
         }
@@ -215,18 +215,18 @@ 
     public static function bigbluebuttonbn_index_display_room_actions($moderator, $course, $bigbluebuttonbn, $groupobj = null) {
         $actions = '';
         if ($moderator) {
-            $actions .= '<form name="form1" method="post" action="">'."\n";
-            $actions .= '  <INPUT type="hidden" name="id" value="'.$course->id.'">'."\n";
-            $actions .= '  <INPUT type="hidden" name="a" value="'.$bigbluebuttonbn->id.'">'."\n";
-            $actions .= '  <INPUT type="hidden" name="action" value="end">'."\n";
+            $actions .= '<form name="form1" method="post" action="">' . "\n";
+            $actions .= '  <INPUT type="hidden" name="id" value="' . $course->id . '">' . "\n";
+            $actions .= '  <INPUT type="hidden" name="a" value="' . $bigbluebuttonbn->id . '">' . "\n";
+            $actions .= '  <INPUT type="hidden" name="action" value="end">' . "\n";
             if ($groupobj != null) {
-                $actions .= '  <INPUT type="hidden" name="g" value="'.$groupobj->id.'">'."\n";
+                $actions .= '  <INPUT type="hidden" name="g" value="' . $groupobj->id . '">' . "\n";
             }
             $actions .= '  <INPUT type="submit" name="submit" value="' .
                 get_string('view_conference_action_end', 'bigbluebuttonbn') .
                 '" class="btn btn-primary btn-sm" onclick="return confirm(\'' .
                 get_string('index_confirm_end', 'bigbluebuttonbn') . '\')">' . "\n";
-            $actions .= '</form>'."\n";
+            $actions .= '</form>' . "\n";
         }
         return $actions;
     }

brokerlib.php

Spacing +9 added lines, -9 removed lines

@@ -208,7 +208,7 @@ 
 function bigbluebuttonbn_broker_recording_info_current($recording, $params) {
     $callbackresponse['status'] = true;
     $callbackresponse['found'] = true;
-    $callbackresponse['published'] = (string) $recording['published'];
+    $callbackresponse['published'] = (string)$recording['published'];
     if (!isset($params['meta']) || empty($params['meta'])) {
         return $callbackresponse;
     }
@@ -559,8 +559,8 @@ 
             array('HS256')
         );
     } catch (Exception $e) {
-        $error = 'Caught exception: '.$e->getMessage();
-        header('HTTP/1.0 400 Bad Request. '.$error);
+        $error = 'Caught exception: ' . $e->getMessage();
+        header('HTTP/1.0 400 Bad Request. ' . $error);
         return;
     }
     // Validate that the bigbluebuttonbn activity corresponds to the meeting_id received.
@@ -590,8 +590,8 @@ 
         bigbluebuttonbn_log($bigbluebuttonbn, BIGBLUEBUTTON_LOG_EVENT_CALLBACK, $overrides, json_encode($meta));
         header('HTTP/1.0 202 Accepted');
     } catch (Exception $e) {
-        $error = 'Caught exception: '.$e->getMessage();
-        header('HTTP/1.0 503 Service Unavailable. '.$error);
+        $error = 'Caught exception: ' . $e->getMessage();
+        header('HTTP/1.0 503 Service Unavailable. ' . $error);
     }
 }
 
@@ -612,13 +612,13 @@ 
     $importrecordings = $SESSION->bigbluebuttonbn_importrecordings;
     if (!isset($importrecordings[$params['id']])) {
         $error = "Recording {$params['id']} could not be found. It can not be imported";
-        header('HTTP/1.0 404 Not found. '.$error);
+        header('HTTP/1.0 404 Not found. ' . $error);
         return;
     }
     $callbackresponse = array('status' => true);
     $importrecordings[$params['id']]['imported'] = true;
     $overrides = array('meetingid' => $importrecordings[$params['id']]['meetingID']);
-    $meta = '{"recording":'.json_encode($importrecordings[$params['id']]).'}';
+    $meta = '{"recording":' . json_encode($importrecordings[$params['id']]) . '}';
     bigbluebuttonbn_log($bbbsession['bigbluebuttonbn'], BIGBLUEBUTTONBN_LOG_EVENT_IMPORT, $overrides, $meta);
     // Moodle event logger: Create an event for recording imported.
     if (isset($bbbsession['bigbluebutton']) && isset($bbbsession['cm'])) {
@@ -712,7 +712,7 @@ 
     $action = strtolower($params['action']);
     $requiredparams = bigbluebuttonbn_broker_required_parameters();
     if (!array_key_exists($action, $requiredparams)) {
-        return 'Action '.$params['action'].' can not be performed.';
+        return 'Action ' . $params['action'] . ' can not be performed.';
     }
     return bigbluebuttonbn_broker_validate_parameters_message($params, $requiredparams[$action]);
 }
@@ -858,7 +858,7 @@ 
     $tabledata = array();
     $typeprofiles = bigbluebuttonbn_get_instance_type_profiles();
     $tabledata['activity'] = bigbluebuttonbn_view_get_activity_status($bbbsession);
-    $tabledata['ping_interval'] = (int) \mod_bigbluebuttonbn\locallib\config::get('waitformoderator_ping_interval') * 1000;
+    $tabledata['ping_interval'] = (int)\mod_bigbluebuttonbn\locallib\config::get('waitformoderator_ping_interval') * 1000;
     $tabledata['locale'] = bigbluebuttonbn_get_localcode();
     $tabledata['profile_features'] = $typeprofiles[0]['features'];
     $tabledata['recordings_html'] = $bbbsession['bigbluebuttonbn']->recordings_html == '1';

config-dist.php

Indentation +15 added lines, -15 removed lines

@@ -103,7 +103,7 @@ 
  * recordings from a different activity even from a different course.
  **/
 
- /*
+    /*
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
  * activities will have the 'import recordings' capability enabled.
  * $CFG->bigbluebuttonbn['importrecordings_enabled'] = 0;
@@ -124,7 +124,7 @@ 
  * 'Join session' button enabled
  **/
 
- /*
+    /*
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
  * activities will have the 'wait for moderator' capability enabled by
  * default.
@@ -276,7 +276,7 @@ 
  * $CFG->bigbluebuttonbn['recordings_preview_editable'] = 0;
  */
 
- /* When the value is set to 1 (checked) the playback URLs will be validated
+    /* When the value is set to 1 (checked) the playback URLs will be validated
   * before the user access it.
   * $CFG->bigbluebuttonbn['recordings_validate_url'] = 1;
   */
@@ -347,7 +347,7 @@ 
  * $CFG->bigbluebuttonbn['disablecam_editable'] = 0;
  */
 
- /*
+    /*
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
  * activities will have user microphones disabled.
  * default.
@@ -360,7 +360,7 @@ 
  * $CFG->bigbluebuttonbn['disablemic_editable'] = 0;
  */
 
- /*
+    /*
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
  * activities will have private chat disabled.
  * default.
@@ -373,7 +373,7 @@ 
  * $CFG->bigbluebuttonbn['disableprivatechat_editable'] = 0;
  */
 
- /*
+    /*
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
  * activities will have public chat disabled.
  * default.
@@ -386,7 +386,7 @@ 
  * $CFG->bigbluebuttonbn['disablepublicchat_editable'] = 0;
  */
 
- /*
+    /*
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
  * activities will have shared notes disabled.
  * default.
@@ -399,7 +399,7 @@ 
  * $CFG->bigbluebuttonbn['disablenote_editable'] = 0;
  */
 
- /*
+    /*
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
  * activities will have the user list hidden.
  * default.
@@ -412,7 +412,7 @@ 
  * $CFG->bigbluebuttonbn['hideuserlist_editable'] = 0;
  */
 
- /*
+    /*
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
  * activities will have a locked layout.
  * default.
@@ -425,7 +425,7 @@ 
  * $CFG->bigbluebuttonbn['lockedlayout_editable'] = 0;
  */
 
- /*
+    /*
  * When the value is set to 1 (checked) the bigbluebuttonbn rooms or
  * activities will ignore the locking settings.
  * default.
@@ -438,7 +438,7 @@ 
  * $CFG->bigbluebuttonbn['lockonjoin_editable'] = 0;
  */
 
- /*
+    /*
  * When the value is set to 1 (checked) the capability to ignore
  * locking settings is enabled.
  * $CFG->bigbluebuttonbn['lockonjoinconfigurable_default'] = 0;
@@ -489,27 +489,27 @@ 
  * $CFG->bigbluebuttonbn['general_warning_message'] = "Would you like to record your BigBlueButton sessions for later viewing? ";
  */
 
- /*
+    /*
  * The warning box is always shown to administrators, but it is also possible to define other roles
  * to whom the it will be shown. The roles are based on the shortnames defined by Moodle:
  *     'manager,coursecreator,editingteacher,teacher,student,guest,user,frontpage'
  * $CFG->bigbluebuttonbn['general_warning_roles'] = 'editingteacher,teacher';
  */
 
- /*
+    /*
  * As the general_warning_message is shown in a box, its type can be defined with general_warning_type
  * The default type is 'info' which is normaly rendered in blue when using a bootstrap theme.
  * All the modifiers for boxed in bootstrap can be used [info|success|warning|danger].
  * $CFG->bigbluebuttonbn['general_warning_box_type'] = 'info';
  */
 
- /*
+    /*
  * Additionally, when general_warning_button_href value is different than "", a button
  * can also be shown right after the message.
  * $CFG->bigbluebuttonbn['general_warning_button_href'] = "http://blindsidenetworks.com/";
  */
 
- /*
+    /*
  * Finally, the text and class for the button can be modified
  * $CFG->bigbluebuttonbn['general_warning_button_text'] = "Upgrade your site";
  * $CFG->bigbluebuttonbn['general_warning_button_class'] = "btn btn-primary";

classes/settings/renderer.php

Spacing +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
 defined('MOODLE_INTERNAL') || die();
 
 require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
-require_once($CFG->libdir.'/adminlib.php');
+require_once($CFG->libdir . '/adminlib.php');
 
 /**
  * Helper class for rendering HTML for settings.php.
@@ -66,7 +66,7 @@ 
             $itemname = get_string('config_' . $name, 'bigbluebuttonbn');
         }
         if ($itemdescription === null) {
-            $itemdescription = get_string('config_' .$name . '_description', 'bigbluebuttonbn');
+            $itemdescription = get_string('config_' . $name . '_description', 'bigbluebuttonbn');
         }
         $item = new \admin_setting_heading('bigbluebuttonbn_config_' . $name, $itemname, $itemdescription);
         $this->settings->add($item);
@@ -166,7 +166,7 @@ 
      */
     public function render_warning_message($name, $message, $type = 'warning', $closable = true) {
         $output = $this->output->box_start('box boxalignleft adminerror alert alert-' . $type . ' alert-block fade in',
-            'bigbluebuttonbn_' . $name)."\n";
+            'bigbluebuttonbn_' . $name) . "\n";
         if ($closable) {
             $output .= '  <button type="button" class="close" data-dismiss="alert">&times;</button>' . "\n";
         }

classes/output/mobile.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-use context_module;
 use mod_bigbluebuttonbn\locallib\bigbluebutton;
 
 require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');

Spacing +4 added lines, -4 removed lines

@@ -56,7 +56,7 @@ 
 
         global $OUTPUT, $SESSION;
 
-        $args = (object) $args;
+        $args = (object)$args;
         $viewinstance = bigbluebuttonbn_view_validator($args->cmid, null);
         if (!$viewinstance) {
             $error = get_string('view_error_url_missing_parameters', 'bigbluebuttonbn');
@@ -164,7 +164,7 @@ 
             }
             if ($response['returncode'] == 'FAILED') {
                 // The meeting could not be created.
-                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'],  'view_error_create');
+                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'], 'view_error_create');
                 $e = get_string($errorkey, 'bigbluebuttonbn');
                 return(self::mobile_print_error($e));
             }
@@ -177,7 +177,7 @@ 
             bigbluebuttonbn_event_log(\mod_bigbluebuttonbn\event\events::$events['meeting_create'], $bigbluebuttonbn);
             // Insert a record that meeting was created.
             $overrides = array('meetingid' => $bbbsession['meetingid']);
-            $meta = '{"record":'.($bbbsession['record'] ? 'true' : 'false').'}';
+            $meta = '{"record":' . ($bbbsession['record'] ? 'true' : 'false') . '}';
             bigbluebuttonbn_log($bbbsession['bigbluebuttonbn'], BIGBLUEBUTTONBN_LOG_EVENT_CREATE, $overrides, $meta);
         }
 
@@ -203,7 +203,7 @@ 
 
         $data = array(
             'bigbluebuttonbn' => $bigbluebuttonbn,
-            'bbbsession' => (object) $bbbsession,
+            'bbbsession' => (object)$bbbsession,
             'msjgroup' => $msjgroup,
             'urltojoin' => $urltojoin,
             'cmid' => $cm->id,