blindsidenetworks / moodle-mod_bigbluebuttonbn

db/upgrade.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once(dirname(dirname(__FILE__)).'/locallib.php');
+require_once(dirname(dirname(__FILE__)) . '/locallib.php');
 
 /**
  * Performs data migrations and updates on upgrade.

classes/privacy/provider.php

Spacing +1 added lines, -1 removed lines

@@ -212,7 +212,7 @@
             function($instanceid, $data) use ($user, $instanceidstocmids) {
                 $context = \context_module::instance($instanceidstocmids[$instanceid]);
                 $contextdata = helper::get_context_data($context, $user);
-                $finaldata = (object) array_merge((array) $contextdata, ['logs' => $data]);
+                $finaldata = (object)array_merge((array)$contextdata, ['logs' => $data]);
                 helper::export_context_files($context, $user);
                 writer::with_context($context)->export_data([], $finaldata);
             }

Indentation +6 added lines, -6 removed lines

@@ -61,11 +61,11 @@ 
      */
     public static function _get_metadata(collection $collection) {
 
-         // The table bigbluebuttonbn stores only the room properties.
-         // However, there is a chance that some personal information is stored as metadata.
-         // This would be done in the column 'participants' where rules can be set to define BBB roles.
-         // It is fair to say that only the userid is stored, which is useless if user is removed.
-         // But if this is a concern a refactoring on the way the rules are stored will be required.
+            // The table bigbluebuttonbn stores only the room properties.
+            // However, there is a chance that some personal information is stored as metadata.
+            // This would be done in the column 'participants' where rules can be set to define BBB roles.
+            // It is fair to say that only the userid is stored, which is useless if user is removed.
+            // But if this is a concern a refactoring on the way the rules are stored will be required.
         $collection->add_database_table('bigbluebuttonbn', [
             'participants' => 'privacy:metadata:bigbluebuttonbn:participants',
         ], 'privacy:metadata:bigbluebuttonbn');
@@ -208,7 +208,7 @@ 
                     'meetingid' => $record->meetingid,
                     'log' => $record->log,
                     'meta' => $record->meta,
-                  ];
+                    ];
                 return $carry;
             },
             function($instanceid, $data) use ($user, $instanceidstocmids) {

view.php

Indentation +9 added lines, -9 removed lines

@@ -434,12 +434,12 @@ 
     $recordings = bigbluebuttonbn_get_recordings(
         $bbbsession['course']->id, $bigbluebuttonbnid, $enabledfeatures['showroom'],
         $bbbsession['bigbluebuttonbn']->recordings_deleted
-      );
+        );
     if ($enabledfeatures['importrecordings']) {
         // Get recording links.
         $recordingsimported = bigbluebuttonbn_get_recordings_imported_array(
             $bbbsession['course']->id, $bigbluebuttonbnid, $enabledfeatures['showroom']
-          );
+            );
         /* Perform aritmetic addition instead of merge so the imported recordings corresponding to existent
          * recordings are not included. */
         if ($bbbsession['bigbluebuttonbn']->recordings_imported) {
@@ -457,7 +457,7 @@ 
     // JavaScript variables for recordings.
     $jsvars += array(
             'recordings_html' => $bbbsession['bigbluebuttonbn']->recordings_html == '1',
-          );
+            );
     // If there are meetings with recordings load the data to the table.
     if ($bbbsession['bigbluebuttonbn']->recordings_html) {
         // Render a plain html table.
@@ -467,7 +467,7 @@ 
     $jsvars += array(
             'columns' => bigbluebuttonbn_get_recording_columns($bbbsession),
             'data' => bigbluebuttonbn_get_recording_data($bbbsession, $recordings),
-          );
+            );
     // Render a YUI table.
     return html_writer::div('', '', array('id' => 'bigbluebuttonbn_recordings_table'));
 }
@@ -487,10 +487,10 @@ 
     }
     $button = html_writer::tag('input', '',
         array('type' => 'button',
-              'value' => get_string('view_recording_button_import', 'bigbluebuttonbn'),
-              'class' => 'btn btn-secondary',
-              'onclick' => 'window.location=\''.$CFG->wwwroot.'/mod/bigbluebuttonbn/import_view.php?bn='.
-                  $bbbsession['bigbluebuttonbn']->id.'\''));
+                'value' => get_string('view_recording_button_import', 'bigbluebuttonbn'),
+                'class' => 'btn btn-secondary',
+                'onclick' => 'window.location=\''.$CFG->wwwroot.'/mod/bigbluebuttonbn/import_view.php?bn='.
+                    $bbbsession['bigbluebuttonbn']->id.'\''));
     $output  = html_writer::empty_tag('br');
     $output .= html_writer::tag('span', $button, array('id' => 'import_recording_links_button'));
     $output .= html_writer::tag('span', '', array('id' => 'import_recording_links_table'));
@@ -569,5 +569,5 @@ 
         (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_href'),
         (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_text'),
         (string)\mod_bigbluebuttonbn\locallib\config::get('general_warning_button_class')
-      );
+        );
 }

Spacing +29 added lines, -29 removed lines

@@ -24,8 +24,8 @@ 
  * @author    Fred Dixon  (ffdixon [at] blindsidenetworks [dt] com)
  */
 
-require_once(dirname(dirname(dirname(__FILE__))).'/config.php');
-require_once(dirname(__FILE__).'/locallib.php');
+require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
+require_once(dirname(__FILE__) . '/locallib.php');
 
 $id = required_param('id', PARAM_INT);
 $bn = optional_param('n', 0, PARAM_INT);
@@ -60,19 +60,19 @@ 
 if (is_null($serverversion)) {
     if ($bbbsession['administrator']) {
         print_error('view_error_unable_join', 'bigbluebuttonbn',
-            $CFG->wwwroot.'/admin/settings.php?section=modsettingbigbluebuttonbn');
+            $CFG->wwwroot . '/admin/settings.php?section=modsettingbigbluebuttonbn');
         exit;
     }
     if ($bbbsession['moderator']) {
         print_error('view_error_unable_join_teacher', 'bigbluebuttonbn',
-            $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course);
+            $CFG->wwwroot . '/course/view.php?id=' . $bigbluebuttonbn->course);
         exit;
     }
     print_error('view_error_unable_join_student', 'bigbluebuttonbn',
-        $CFG->wwwroot.'/course/view.php?id='.$bigbluebuttonbn->course);
+        $CFG->wwwroot . '/course/view.php?id=' . $bigbluebuttonbn->course);
     exit;
 }
-$bbbsession['serverversion'] = (string) $serverversion;
+$bbbsession['serverversion'] = (string)$serverversion;
 
 // Mark viewed by user (if required).
 $completion = new completion_info($course);
@@ -80,7 +80,7 @@ 
 
 // Print the page header.
 $PAGE->set_context($context);
-$PAGE->set_url($CFG->wwwroot.'/mod/bigbluebuttonbn/view.php', array('id' => $cm->id));
+$PAGE->set_url($CFG->wwwroot . '/mod/bigbluebuttonbn/view.php', array('id' => $cm->id));
 $PAGE->set_title(format_string($bigbluebuttonbn->name));
 $PAGE->set_cacheable(false);
 $PAGE->set_heading($course->fullname);
@@ -90,11 +90,11 @@ 
 if (!has_capability('moodle/category:manage', $context) && !has_capability('mod/bigbluebuttonbn:join', $context)) {
     echo $OUTPUT->header();
     if (isguestuser()) {
-        echo $OUTPUT->confirm('<p>'.get_string('view_noguests', 'bigbluebuttonbn').'</p>'.get_string('liketologin'),
-            get_login_url(), $CFG->wwwroot.'/course/view.php?id='.$course->id);
+        echo $OUTPUT->confirm('<p>' . get_string('view_noguests', 'bigbluebuttonbn') . '</p>' . get_string('liketologin'),
+            get_login_url(), $CFG->wwwroot . '/course/view.php?id=' . $course->id);
     } else {
-        echo $OUTPUT->confirm('<p>'.get_string('view_nojoin', 'bigbluebuttonbn').'</p>'.get_string('liketologin'),
-            get_login_url(), $CFG->wwwroot.'/course/view.php?id='.$course->id);
+        echo $OUTPUT->confirm('<p>' . get_string('view_nojoin', 'bigbluebuttonbn') . '</p>' . get_string('liketologin'),
+            get_login_url(), $CFG->wwwroot . '/course/view.php?id=' . $course->id);
     }
     echo $OUTPUT->footer();
     exit;
@@ -102,7 +102,7 @@ 
 
 // Operation URLs.
 $bbbsession['bigbluebuttonbnURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bbbsession['cm']->id;
-$bbbsession['logoutURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=logout&id='.$id .
+$bbbsession['logoutURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=logout&id=' . $id .
     '&bn=' . $bbbsession['bigbluebuttonbn']->id;
 $bbbsession['recordingReadyURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_broker.php?action=recording_' .
     'ready&bigbluebuttonbn=' . $bbbsession['bigbluebuttonbn']->id;
@@ -122,7 +122,7 @@ 
 echo $OUTPUT->footer();
 
 // Shows version as a comment.
-echo '<!-- '.$bbbsession['originTag'].' -->'."\n";
+echo '<!-- ' . $bbbsession['originTag'] . ' -->' . "\n";
 
 // Initialize session variable used across views.
 $SESSION->bigbluebuttonbn_bbbsession = $bbbsession;
@@ -150,7 +150,7 @@ 
     $bbbsession['modPW'] = $bbbsession['bigbluebuttonbn']->moderatorpass;
     $bbbsession['viewerPW'] = $bbbsession['bigbluebuttonbn']->viewerpass;
     // Database info related to the activity.
-    $bbbsession['meetingid'] = $bbbsession['bigbluebuttonbn']->meetingid.'-'.$bbbsession['course']->id.'-'.
+    $bbbsession['meetingid'] = $bbbsession['bigbluebuttonbn']->meetingid . '-' . $bbbsession['course']->id . '-' .
         $bbbsession['bigbluebuttonbn']->id;
     $bbbsession['meetingname'] = $bbbsession['bigbluebuttonbn']->name;
     $bbbsession['meetingdescription'] = $bbbsession['bigbluebuttonbn']->intro;
@@ -170,7 +170,7 @@ 
         $bbbsession['welcome'] = get_string('mod_form_field_welcome_default', 'bigbluebuttonbn');
     }
     if ($bbbsession['bigbluebuttonbn']->record) {
-        $bbbsession['welcome'] .= '<br><br>'.get_string('bbbrecordwarning', 'bigbluebuttonbn');
+        $bbbsession['welcome'] .= '<br><br>' . get_string('bbbrecordwarning', 'bigbluebuttonbn');
     }
     $bbbsession['openingtime'] = $bbbsession['bigbluebuttonbn']->openingtime;
     $bbbsession['closingtime'] = $bbbsession['bigbluebuttonbn']->closingtime;
@@ -183,7 +183,7 @@ 
     $bbbsession['originServerName'] = $parsedurl['host'];
     $bbbsession['originServerUrl'] = $CFG->wwwroot;
     $bbbsession['originServerCommonName'] = '';
-    $bbbsession['originTag'] = 'moodle-mod_bigbluebuttonbn ('.get_config('mod_bigbluebuttonbn', 'version').')';
+    $bbbsession['originTag'] = 'moodle-mod_bigbluebuttonbn (' . get_config('mod_bigbluebuttonbn', 'version') . ')';
     $bbbsession['bnserver'] = bigbluebuttonbn_is_bn_server();
     // Setting for clienttype, assign flash if not enabled, or default if not editable.
     $bbbsession['clienttype'] = \mod_bigbluebuttonbn\locallib\config::get('clienttype_default');
@@ -246,8 +246,8 @@ 
         $groupname = groups_get_group_name($bbbsession['group']);
     }
     // Assign group default values.
-    $bbbsession['meetingid'] .= '['.$bbbsession['group'].']';
-    $bbbsession['meetingname'] .= ' ('.$groupname.')';
+    $bbbsession['meetingid'] .= '[' . $bbbsession['group'] . ']';
+    $bbbsession['meetingname'] .= ' (' . $groupname . ')';
     if (count($groups) == 0) {
         // Only the All participants group exists.
         bigbluebuttonbn_view_message_box($bbbsession, get_string('view_groups_notenrolled_warning', 'bigbluebuttonbn'), 'info');
@@ -257,7 +257,7 @@ 
     if (has_capability('moodle/site:accessallgroups', $context)) {
         bigbluebuttonbn_view_message_box($bbbsession, get_string('view_groups_selection_warning', 'bigbluebuttonbn'));
     }
-    $urltoroot = $CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bbbsession['cm']->id;
+    $urltoroot = $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bbbsession['cm']->id;
     groups_print_activity_menu($bbbsession['cm'], $urltoroot);
     echo '<br><br>';
 }
@@ -324,7 +324,7 @@ 
         $recordingsdisabled = get_string('view_message_recordings_disabled', 'bigbluebuttonbn');
         $output .= bigbluebuttonbn_render_warning($recordingsdisabled, 'danger');
     }
-    echo $output.html_writer::empty_tag('br').html_writer::empty_tag('br').html_writer::empty_tag('br');
+    echo $output . html_writer::empty_tag('br') . html_writer::empty_tag('br') . html_writer::empty_tag('br');
     $PAGE->requires->yui_module('moodle-mod_bigbluebuttonbn-broker', 'M.mod_bigbluebuttonbn.broker.init', array($jsvars));
 }
 
@@ -393,12 +393,12 @@ 
     // JavaScript variables for room.
     $openingtime = '';
     if ($bbbsession['openingtime']) {
-        $openingtime = get_string('mod_form_field_openingtime', 'bigbluebuttonbn').': '.
+        $openingtime = get_string('mod_form_field_openingtime', 'bigbluebuttonbn') . ': ' .
             userdate($bbbsession['openingtime']);
     }
     $closingtime = '';
     if ($bbbsession['closingtime']) {
-        $closingtime = get_string('mod_form_field_closingtime', 'bigbluebuttonbn').': '.
+        $closingtime = get_string('mod_form_field_closingtime', 'bigbluebuttonbn') . ': ' .
             userdate($bbbsession['closingtime']);
     }
     $jsvars += array(
@@ -415,7 +415,7 @@ 
     $output .= $OUTPUT->box_end();
     // Action button box.
     $output .= $OUTPUT->box_start('generalbox boxaligncenter', 'bigbluebuttonbn_view_action_button_box');
-    $output .= '<br><br><span id="join_button"></span>&nbsp;<span id="end_button"></span>'."\n";
+    $output .= '<br><br><span id="join_button"></span>&nbsp;<span id="end_button"></span>' . "\n";
     $output .= $OUTPUT->box_end();
     if ($activity == 'ended') {
         $output .= bigbluebuttonbn_view_ended($bbbsession);
@@ -468,7 +468,7 @@ 
     // If there are meetings with recordings load the data to the table.
     if ($bbbsession['bigbluebuttonbn']->recordings_html) {
         // Render a plain html table.
-        return bigbluebuttonbn_output_recording_table($bbbsession, $recordings)."\n";
+        return bigbluebuttonbn_output_recording_table($bbbsession, $recordings) . "\n";
     }
     // JavaScript variables for recordings with YUI.
     $jsvars += array(
@@ -496,8 +496,8 @@ 
         array('type' => 'button',
               'value' => get_string('view_recording_button_import', 'bigbluebuttonbn'),
               'class' => 'btn btn-secondary',
-              'onclick' => 'window.location=\''.$CFG->wwwroot.'/mod/bigbluebuttonbn/import_view.php?bn='.
-                  $bbbsession['bigbluebuttonbn']->id.'\''));
+              'onclick' => 'window.location=\'' . $CFG->wwwroot . '/mod/bigbluebuttonbn/import_view.php?bn=' .
+                  $bbbsession['bigbluebuttonbn']->id . '\''));
     $output  = html_writer::empty_tag('br');
     $output .= html_writer::tag('span', $button, array('id' => 'import_recording_links_button'));
     $output .= html_writer::tag('span', '', array('id' => 'import_recording_links_table'));
@@ -516,10 +516,10 @@ 
     if (!is_null($bbbsession['presentation']['url'])) {
         $attributes = array('title' => $bbbsession['presentation']['name']);
         $icon = new pix_icon($bbbsession['presentation']['icon'], $bbbsession['presentation']['mimetype_description']);
-        return '<h4>'.get_string('view_section_title_presentation', 'bigbluebuttonbn').'</h4>'.
-                $OUTPUT->action_icon($bbbsession['presentation']['url'], $icon, null, array(), false).
+        return '<h4>' . get_string('view_section_title_presentation', 'bigbluebuttonbn') . '</h4>' .
+                $OUTPUT->action_icon($bbbsession['presentation']['url'], $icon, null, array(), false) .
                 $OUTPUT->action_link($bbbsession['presentation']['url'],
-                $bbbsession['presentation']['name'], null, $attributes).'<br><br>';
+                $bbbsession['presentation']['name'], null, $attributes) . '<br><br>';
     }
     return '';
 }

bbb_broker.php

Indentation +21 added lines, -21 removed lines

@@ -440,26 +440,26 @@ 
             return array(
                 'status' => false,
                 'message' => get_string('view_recording_publish_link_deleted', 'bigbluebuttonbn')
-              );
+                );
         }
         if ($realrecordings[$params['id']]['published'] !== 'true') {
             return array(
                 'status' => false,
                 'message' => get_string('view_recording_publish_link_not_published', 'bigbluebuttonbn')
-              );
+                );
         }
         return array(
             'status' => bigbluebuttonbn_publish_recording_imported(
                 $recordings[$params['id']]['imported'], true
             )
-          );
+            );
     }
     // As the recordingid was not identified as imported recording link, execute actual publish.
     return array(
         'status' => bigbluebuttonbn_publish_recordings(
             $params['id'], 'true'
         )
-      );
+        );
 }
 
 /**
@@ -480,26 +480,26 @@ 
             return array(
                 'status' => false,
                 'message' => get_string('view_recording_unprotect_link_deleted', 'bigbluebuttonbn')
-              );
+                );
         }
         if ($realrecordings[$params['id']]['protected'] === 'true') {
             return array(
                 'status' => false,
                 'message' => get_string('view_recording_unprotect_link_not_unprotected', 'bigbluebuttonbn')
-              );
+                );
         }
         return array(
             'status' => bigbluebuttonbn_protect_recording_imported(
                 $recordings[$params['id']]['imported'], false
             )
-          );
+            );
     }
     // As the recordingid was not identified as imported recording link, execute actual uprotect.
     return array(
         'status' => bigbluebuttonbn_update_recordings(
             $params['id'], array('protect' => 'false')
         )
-      );
+        );
 }
 
 /**
@@ -518,7 +518,7 @@ 
             'status' => bigbluebuttonbn_publish_recording_imported(
                 $recordings[$params['id']]['imported'], false
             )
-          );
+            );
     }
     // As the recordingid was not identified as imported recording link, execute unpublish on a real recording.
     // First: Unpublish imported links associated to the recording.
@@ -536,7 +536,7 @@ 
         'status' => bigbluebuttonbn_publish_recordings(
             $params['id'], 'false'
         )
-      );
+        );
 }
 
 /**
@@ -555,7 +555,7 @@ 
             'status' => bigbluebuttonbn_protect_recording_imported(
                 $recordings[$params['id']]['imported'], true
             )
-          );
+            );
     }
     // As the recordingid was not identified as imported recording link, execute protect on a real recording.
     // First: Protect imported links associated to the recording.
@@ -573,7 +573,7 @@ 
         'status' => bigbluebuttonbn_update_recordings(
             $params['id'], array('protect' => 'true')
         )
-      );
+        );
 }
 
 /**
@@ -592,7 +592,7 @@ 
             'status' => bigbluebuttonbn_delete_recording_imported(
                 $recordings[$params['id']]['imported']
             )
-          );
+            );
     }
     // As the recordingid was not identified as imported recording link, execute delete on a real recording.
     // First: Delete imported links associated to the recording.
@@ -606,7 +606,7 @@ 
     // Second: Execute the actual delete.
     return array(
         'status' => bigbluebuttonbn_delete_recordings($params['id'])
-      );
+        );
 }
 
 /**
@@ -624,7 +624,7 @@ 
             'status' => bigbluebuttonbn_update_recording_imported(
                 $recordings[$params['id']]['imported'], json_decode($params['meta'], true)
             )
-          );
+            );
     }
 
     // As the recordingid was not identified as imported recording link, execute update on a real recording.
@@ -634,7 +634,7 @@ 
         'status' => bigbluebuttonbn_update_recordings(
             $params['id'], json_decode($params['meta'])
         )
-      );
+        );
 }
 
 /**
@@ -800,11 +800,11 @@ 
     $params['recording_ready'] = [
             'bigbluebuttonbn' => 'An id for the bigbluebuttonbn instance should be included.',
             'signed_parameters' => 'A JWT encoded string must be included as [signed_parameters].'
-          ];
+            ];
     $params['live_session_events'] = [
             'bigbluebuttonbn' => 'An id for the bigbluebuttonbn instance should be included.',
             'signed_parameters' => 'A JWT encoded string must be included as [signed_parameters].'
-          ];
+            ];
     return $params;
 }
 
@@ -815,9 +815,9 @@ 
  */
 function bigbluebuttonbn_broker_required_parameters_default($id) {
     return [
-              'id' => "The {$id} must be specified.",
-              'callback' => 'This call must include a javascript callback.'
-           ];
+                'id' => "The {$id} must be specified.",
+                'callback' => 'This call must include a javascript callback.'
+            ];
 }
 
 /**

Spacing +17 added lines, -17 removed lines

@@ -24,8 +24,8 @@ 
  */
 
 
-require_once(dirname(dirname(dirname(__FILE__))).'/config.php');
-require_once(dirname(__FILE__).'/locallib.php');
+require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
+require_once(dirname(__FILE__) . '/locallib.php');
 
 use \Firebase\JWT\JWT;
 
@@ -41,13 +41,13 @@ 
 $params['meta'] = optional_param('meta', '', PARAM_TEXT);
 
 if (empty($params['action'])) {
-    header('HTTP/1.0 400 Bad Request. Parameter ['.$params['action'].'] was not included');
+    header('HTTP/1.0 400 Bad Request. Parameter [' . $params['action'] . '] was not included');
     return;
 }
 
 $error = bigbluebuttonbn_broker_validate_parameters($params);
 if (!empty($error)) {
-    header('HTTP/1.0 400 Bad Request. '.$error);
+    header('HTTP/1.0 400 Bad Request. ' . $error);
     return;
 }
 
@@ -132,11 +132,11 @@ 
         bigbluebuttonbn_broker_live_session_events($params, $bigbluebuttonbn, $cm);
         return;
     }
-    header('HTTP/1.0 400 Bad request. The action '. $a . ' doesn\'t exist');
+    header('HTTP/1.0 400 Bad request. The action ' . $a . ' doesn\'t exist');
     return;
 
 } catch (Exception $e) {
-    header('HTTP/1.0 500 Internal Server Error. '.$e->getMessage());
+    header('HTTP/1.0 500 Internal Server Error. ' . $e->getMessage());
     return;
 }
 
@@ -322,7 +322,7 @@ 
 function bigbluebuttonbn_broker_recording_info_current($recording, $params) {
     $callbackresponse['status'] = true;
     $callbackresponse['found'] = true;
-    $callbackresponse['published'] = (string) $recording['published'];
+    $callbackresponse['published'] = (string)$recording['published'];
     if (!isset($params['meta']) || empty($params['meta'])) {
         return $callbackresponse;
     }
@@ -651,8 +651,8 @@ 
         $decodedparameters = JWT::decode($params['signed_parameters'],
             \mod_bigbluebuttonbn\locallib\config::get('shared_secret'), array('HS256'));
     } catch (Exception $e) {
-        $error = 'Caught exception: '.$e->getMessage();
-        header('HTTP/1.0 400 Bad Request. '.$error);
+        $error = 'Caught exception: ' . $e->getMessage();
+        header('HTTP/1.0 400 Bad Request. ' . $error);
         return;
     }
 
@@ -678,12 +678,12 @@ 
             bigbluebuttonbn_send_notification_recording_ready($bigbluebuttonbn);
         }
         $overrides = array('meetingid' => $decodedparameters->meeting_id);
-        $meta = '{"recordid":"'.$decodedparameters->record_id.'"}';
+        $meta = '{"recordid":"' . $decodedparameters->record_id . '"}';
         bigbluebuttonbn_log($bigbluebuttonbn, BIGBLUEBUTTON_LOG_EVENT_CALLBACK, $overrides, $meta);
         header('HTTP/1.0 202 Accepted');
     } catch (Exception $e) {
-        $error = 'Caught exception: '.$e->getMessage();
-        header('HTTP/1.0 503 Service Unavailable. '.$error);
+        $error = 'Caught exception: ' . $e->getMessage();
+        header('HTTP/1.0 503 Service Unavailable. ' . $error);
     }
 }
 
@@ -704,13 +704,13 @@ 
     $importrecordings = $SESSION->bigbluebuttonbn_importrecordings;
     if (!isset($importrecordings[$params['id']])) {
         $error = "Recording {$params['id']} could not be found. It can not be imported";
-        header('HTTP/1.0 404 Not found. '.$error);
+        header('HTTP/1.0 404 Not found. ' . $error);
         return;
     }
     $callbackresponse = array('status' => true);
     $importrecordings[$params['id']]['imported'] = true;
     $overrides = array('meetingid' => $importrecordings[$params['id']]['meetingID']);
-    $meta = '{"recording":'.json_encode($importrecordings[$params['id']]).'}';
+    $meta = '{"recording":' . json_encode($importrecordings[$params['id']]) . '}';
     bigbluebuttonbn_log($bbbsession['bigbluebuttonbn'], BIGBLUEBUTTONBN_LOG_EVENT_IMPORT, $overrides, $meta);
     // Moodle event logger: Create an event for recording imported.
     if (isset($bbbsession['bigbluebutton']) && isset($bbbsession['cm'])) {
@@ -736,8 +736,8 @@ 
         $decodedparameters = JWT::decode($params['signed_parameters'],
             \mod_bigbluebuttonbn\locallib\config::get('shared_secret'), array('HS256'));
     } catch (Exception $e) {
-        $error = 'Caught exception: '.$e->getMessage();
-        header('HTTP/1.0 400 Bad Request. '.$error);
+        $error = 'Caught exception: ' . $e->getMessage();
+        header('HTTP/1.0 400 Bad Request. ' . $error);
         return;
     }
     // Validate that the bigbluebuttonbn activity corresponds to the meeting_id received.
@@ -772,7 +772,7 @@ 
     $requiredparams = bigbluebuttonbn_broker_required_parameters();
     $action = strtolower($params['action']);
     if (!array_key_exists($action, $requiredparams)) {
-        return 'Action '.$params['action'].' can not be performed.';
+        return 'Action ' . $params['action'] . ' can not be performed.';
     }
     return bigbluebuttonbn_broker_validate_parameters_message($params, $requiredparams[$action]);
 }

classes/locallib/config.php

Indentation +31 added lines, -31 removed lines

@@ -165,36 +165,36 @@
      */
     public static function get_options() {
         return array(
-               'version_major' => self::get_moodle_version_major(),
-               'voicebridge_editable' => self::get('voicebridge_editable'),
-               'importrecordings_enabled' => self::get('importrecordings_enabled'),
-               'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
-               'waitformoderator_default' => self::get('waitformoderator_default'),
-               'waitformoderator_editable' => self::get('waitformoderator_editable'),
-               'userlimit_default' => self::get('userlimit_default'),
-               'userlimit_editable' => self::get('userlimit_editable'),
-               'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
-               'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
-               'recordings_enabled' => self::get('recordings_enabled'),
-               'recordings_html_default' => self::get('recordings_html_default'),
-               'recordings_html_editable' => self::get('recordings_html_editable'),
-               'recordings_deleted_default' => self::get('recordings_deleted_default'),
-               'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
-               'recordings_imported_default' => self::get('recordings_imported_default'),
-               'recordings_imported_editable' => self::get('recordings_imported_editable'),
-               'recordings_preview_default' => self::get('recordings_preview_default'),
-               'recordings_preview_editable' => self::get('recordings_preview_editable'),
-               'recording_default' => self::get('recording_default'),
-               'recording_editable' => self::get('recording_editable'),
-               'recording_icons_enabled' => self::get('recording_icons_enabled'),
-               'general_warning_message' => self::get('general_warning_message'),
-               'general_warning_box_type' => self::get('general_warning_box_type'),
-               'general_warning_button_text' => self::get('general_warning_button_text'),
-               'general_warning_button_href' => self::get('general_warning_button_href'),
-               'general_warning_button_class' => self::get('general_warning_button_class'),
-               'clienttype_enabled' => self::get('clienttype_enabled'),
-               'clienttype_editable' => self::get('clienttype_editable'),
-               'clienttype_default' => self::get('clienttype_default'),
-          );
+                'version_major' => self::get_moodle_version_major(),
+                'voicebridge_editable' => self::get('voicebridge_editable'),
+                'importrecordings_enabled' => self::get('importrecordings_enabled'),
+                'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
+                'waitformoderator_default' => self::get('waitformoderator_default'),
+                'waitformoderator_editable' => self::get('waitformoderator_editable'),
+                'userlimit_default' => self::get('userlimit_default'),
+                'userlimit_editable' => self::get('userlimit_editable'),
+                'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
+                'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
+                'recordings_enabled' => self::get('recordings_enabled'),
+                'recordings_html_default' => self::get('recordings_html_default'),
+                'recordings_html_editable' => self::get('recordings_html_editable'),
+                'recordings_deleted_default' => self::get('recordings_deleted_default'),
+                'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
+                'recordings_imported_default' => self::get('recordings_imported_default'),
+                'recordings_imported_editable' => self::get('recordings_imported_editable'),
+                'recordings_preview_default' => self::get('recordings_preview_default'),
+                'recordings_preview_editable' => self::get('recordings_preview_editable'),
+                'recording_default' => self::get('recording_default'),
+                'recording_editable' => self::get('recording_editable'),
+                'recording_icons_enabled' => self::get('recording_icons_enabled'),
+                'general_warning_message' => self::get('general_warning_message'),
+                'general_warning_box_type' => self::get('general_warning_box_type'),
+                'general_warning_button_text' => self::get('general_warning_button_text'),
+                'general_warning_button_href' => self::get('general_warning_button_href'),
+                'general_warning_button_class' => self::get('general_warning_button_class'),
+                'clienttype_enabled' => self::get('clienttype_enabled'),
+                'clienttype_editable' => self::get('clienttype_editable'),
+                'clienttype_default' => self::get('clienttype_default'),
+            );
     }
 }

Spacing +4 added lines, -4 removed lines

@@ -55,8 +55,8 @@ 
      */
     public static function defaultvalues() {
         return array(
-            'server_url' => (string) BIGBLUEBUTTONBN_DEFAULT_SERVER_URL,
-            'shared_secret' => (string) BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET,
+            'server_url' => (string)BIGBLUEBUTTONBN_DEFAULT_SERVER_URL,
+            'shared_secret' => (string)BIGBLUEBUTTONBN_DEFAULT_SHARED_SECRET,
             'voicebridge_editable' => false,
             'importrecordings_enabled' => false,
             'importrecordings_from_deleted_enabled' => false,
@@ -124,8 +124,8 @@ 
         if (isset($CFG->bigbluebuttonbn[$setting])) {
             return (string)$CFG->bigbluebuttonbn[$setting];
         }
-        if (isset($CFG->{'bigbluebuttonbn_'.$setting})) {
-            return (string)$CFG->{'bigbluebuttonbn_'.$setting};
+        if (isset($CFG->{'bigbluebuttonbn_' . $setting})) {
+            return (string)$CFG->{'bigbluebuttonbn_' . $setting};
         }
         return self::defaultvalue($setting);
     }