blindsidenetworks / moodle-mod_bigbluebuttonbn

classes/locallib/mobileview.php

Spacing +5 added lines, -5 removed lines

@@ -26,7 +26,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Methods used to render view BBB in mobile.
@@ -62,8 +62,8 @@ 
             $session['bigbluebuttonbn']->id;
         $session['meetingname'] = $session['bigbluebuttonbn']->name;
         $session['meetingdescription'] = $session['bigbluebuttonbn']->intro;
-        $session['userlimit'] = intval((int)\mod_bigbluebuttonbn\locallib\config::get('userlimit_default'));
-        if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('userlimit_editable')) {
+        $session['userlimit'] = intval((int) \mod_bigbluebuttonbn\locallib\config::get('userlimit_default'));
+        if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('userlimit_editable')) {
             $session['userlimit'] = intval($session['bigbluebuttonbn']->userlimit);
         }
         $session['voicebridge'] = $session['bigbluebuttonbn']->voicebridge;
@@ -223,7 +223,7 @@ 
      * @return string
      */
     public static function create_meeting_data_record($record) {
-        if ((boolean)\mod_bigbluebuttonbn\locallib\config::recordings_enabled() && $record) {
+        if ((boolean) \mod_bigbluebuttonbn\locallib\config::recordings_enabled() && $record) {
             return 'true';
         }
         return 'false';
@@ -236,7 +236,7 @@ 
      * @return integer
      */
     public static function create_meeting_data_duration($closingtime) {
-        if ((boolean)\mod_bigbluebuttonbn\locallib\config::get('scheduled_duration_enabled')) {
+        if ((boolean) \mod_bigbluebuttonbn\locallib\config::get('scheduled_duration_enabled')) {
             return bigbluebuttonbn_get_duration($closingtime);
         }
         return 0;

classes/locallib/config.php

Indentation +38 added lines, -38 removed lines

@@ -170,43 +170,43 @@
      */
     public static function get_options() {
         return array(
-               'version_major' => self::get_moodle_version_major(),
-               'voicebridge_editable' => self::get('voicebridge_editable'),
-               'importrecordings_enabled' => self::get('importrecordings_enabled'),
-               'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
-               'waitformoderator_default' => self::get('waitformoderator_default'),
-               'waitformoderator_editable' => self::get('waitformoderator_editable'),
-               'userlimit_default' => self::get('userlimit_default'),
-               'userlimit_editable' => self::get('userlimit_editable'),
-               'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
-               'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
-               'recordings_enabled' => self::get('recordings_enabled'),
-               'meetingevents_enabled' => self::get('meetingevents_enabled'),
-               'recordings_html_default' => self::get('recordings_html_default'),
-               'recordings_html_editable' => self::get('recordings_html_editable'),
-               'recordings_deleted_default' => self::get('recordings_deleted_default'),
-               'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
-               'recordings_imported_default' => self::get('recordings_imported_default'),
-               'recordings_imported_editable' => self::get('recordings_imported_editable'),
-               'recordings_preview_default' => self::get('recordings_preview_default'),
-               'recordings_preview_editable' => self::get('recordings_preview_editable'),
-               'recording_default' => self::get('recording_default'),
-               'recording_editable' => self::get('recording_editable'),
-               'recording_icons_enabled' => self::get('recording_icons_enabled'),
-               'recording_all_from_start_default' => self::get('recording_all_from_start_default'),
-               'recording_all_from_start_editable' => self::get('recording_all_from_start_editable'),
-               'recording_hide_button_default' => self::get('recording_hide_button_default'),
-               'recording_hide_button_editable' => self::get('recording_hide_button_editable'),
-               'general_warning_message' => self::get('general_warning_message'),
-               'general_warning_box_type' => self::get('general_warning_box_type'),
-               'general_warning_button_text' => self::get('general_warning_button_text'),
-               'general_warning_button_href' => self::get('general_warning_button_href'),
-               'general_warning_button_class' => self::get('general_warning_button_class'),
-               'clienttype_enabled' => self::get('clienttype_enabled'),
-               'clienttype_editable' => self::get('clienttype_editable'),
-               'clienttype_default' => self::get('clienttype_default'),
-               'muteonstart_editable' => self::get('muteonstart_editable'),
-               'muteonstart_default' => self::get('muteonstart_default'),
-          );
+                'version_major' => self::get_moodle_version_major(),
+                'voicebridge_editable' => self::get('voicebridge_editable'),
+                'importrecordings_enabled' => self::get('importrecordings_enabled'),
+                'importrecordings_from_deleted_enabled' => self::get('importrecordings_from_deleted_enabled'),
+                'waitformoderator_default' => self::get('waitformoderator_default'),
+                'waitformoderator_editable' => self::get('waitformoderator_editable'),
+                'userlimit_default' => self::get('userlimit_default'),
+                'userlimit_editable' => self::get('userlimit_editable'),
+                'preuploadpresentation_enabled' => self::get('preuploadpresentation_enabled'),
+                'sendnotifications_enabled' => self::get('sendnotifications_enabled'),
+                'recordings_enabled' => self::get('recordings_enabled'),
+                'meetingevents_enabled' => self::get('meetingevents_enabled'),
+                'recordings_html_default' => self::get('recordings_html_default'),
+                'recordings_html_editable' => self::get('recordings_html_editable'),
+                'recordings_deleted_default' => self::get('recordings_deleted_default'),
+                'recordings_deleted_editable' => self::get('recordings_deleted_editable'),
+                'recordings_imported_default' => self::get('recordings_imported_default'),
+                'recordings_imported_editable' => self::get('recordings_imported_editable'),
+                'recordings_preview_default' => self::get('recordings_preview_default'),
+                'recordings_preview_editable' => self::get('recordings_preview_editable'),
+                'recording_default' => self::get('recording_default'),
+                'recording_editable' => self::get('recording_editable'),
+                'recording_icons_enabled' => self::get('recording_icons_enabled'),
+                'recording_all_from_start_default' => self::get('recording_all_from_start_default'),
+                'recording_all_from_start_editable' => self::get('recording_all_from_start_editable'),
+                'recording_hide_button_default' => self::get('recording_hide_button_default'),
+                'recording_hide_button_editable' => self::get('recording_hide_button_editable'),
+                'general_warning_message' => self::get('general_warning_message'),
+                'general_warning_box_type' => self::get('general_warning_box_type'),
+                'general_warning_button_text' => self::get('general_warning_button_text'),
+                'general_warning_button_href' => self::get('general_warning_button_href'),
+                'general_warning_button_class' => self::get('general_warning_button_class'),
+                'clienttype_enabled' => self::get('clienttype_enabled'),
+                'clienttype_editable' => self::get('clienttype_editable'),
+                'clienttype_default' => self::get('clienttype_default'),
+                'muteonstart_editable' => self::get('muteonstart_editable'),
+                'muteonstart_default' => self::get('muteonstart_default'),
+            );
     }
 }

Spacing +6 added lines, -6 removed lines

@@ -27,7 +27,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Handles the global configuration based on config.php.
@@ -128,10 +128,10 @@ 
     public static function get($setting) {
         global $CFG;
         if (isset($CFG->bigbluebuttonbn[$setting])) {
-            return (string)$CFG->bigbluebuttonbn[$setting];
+            return (string) $CFG->bigbluebuttonbn[$setting];
         }
         if (isset($CFG->{'bigbluebuttonbn_'.$setting})) {
-            return (string)$CFG->{'bigbluebuttonbn_'.$setting};
+            return (string) $CFG->{'bigbluebuttonbn_'.$setting};
         }
         return self::defaultvalue($setting);
     }
@@ -142,7 +142,7 @@ 
      * @return boolean
      */
     public static function recordings_enabled() {
-        return (boolean)self::get('recordings_enabled');
+        return (boolean) self::get('recordings_enabled');
     }
 
     /**
@@ -151,7 +151,7 @@ 
      * @return boolean
      */
     public static function importrecordings_enabled() {
-        return (boolean)self::get('importrecordings_enabled');
+        return (boolean) self::get('importrecordings_enabled');
     }
 
     /**
@@ -160,7 +160,7 @@ 
      * @return boolean
      */
     public static function clienttype_enabled() {
-        return (boolean)self::get('clienttype_enabled');
+        return (boolean) self::get('clienttype_enabled');
     }
 
     /**

classes/locallib/bigbluebutton.php

Spacing +8 added lines, -8 removed lines

@@ -27,7 +27,7 @@ 
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Wrapper for executing http requests on a BigBlueButton server.
@@ -46,15 +46,15 @@ 
      * @return string
      */
     public static function action_url($action = '', $data = array(), $metadata = array()) {
-        $baseurl = self::sanitized_url() . $action . '?';
+        $baseurl = self::sanitized_url().$action.'?';
         $params = '';
         foreach ($data as $key => $value) {
-            $params .= '&' . $key . '=' . urlencode($value);
+            $params .= '&'.$key.'='.urlencode($value);
         }
         foreach ($metadata as $key => $value) {
-            $params .= '&' . 'meta_' . $key.'=' . urlencode($value);
+            $params .= '&'.'meta_'.$key.'='.urlencode($value);
         }
-        return $baseurl . $params . '&checksum=' . sha1($action . $params . self::sanitized_secret());
+        return $baseurl.$params.'&checksum='.sha1($action.$params.self::sanitized_secret());
     }
 
     /**
@@ -70,7 +70,7 @@ 
         if (substr($serverurl, -4) == '/api') {
             $serverurl = rtrim($serverurl, '/api');
         }
-        return $serverurl . '/api/';
+        return $serverurl.'/api/';
     }
 
     /**
@@ -91,8 +91,8 @@ 
         $pserverurl = parse_url(trim(\mod_bigbluebuttonbn\locallib\config::get('server_url')));
         $pserverurlport = "";
         if (isset($pserverurl['port'])) {
-            $pserverurlport = ":" . $pserverurl['port'];
+            $pserverurlport = ":".$pserverurl['port'];
         }
-        return $pserverurl['scheme'] . "://" . $pserverurl['host'] . $pserverurlport . "/";
+        return $pserverurl['scheme']."://".$pserverurl['host'].$pserverurlport."/";
     }
 }

classes/privacy/provider.php

Indentation +6 added lines, -6 removed lines

@@ -59,11 +59,11 @@ 
      */
     public static function _get_metadata(collection $collection) {
 
-         // The table bigbluebuttonbn stores only the room properties.
-         // However, there is a chance that some personal information is stored as metadata.
-         // This would be done in the column 'participants' where rules can be set to define BBB roles.
-         // It is fair to say that only the userid is stored, which is useless if user is removed.
-         // But if this is a concern a refactoring on the way the rules are stored will be required.
+            // The table bigbluebuttonbn stores only the room properties.
+            // However, there is a chance that some personal information is stored as metadata.
+            // This would be done in the column 'participants' where rules can be set to define BBB roles.
+            // It is fair to say that only the userid is stored, which is useless if user is removed.
+            // But if this is a concern a refactoring on the way the rules are stored will be required.
         $collection->add_database_table('bigbluebuttonbn', [
             'participants' => 'privacy:metadata:bigbluebuttonbn:participants',
         ], 'privacy:metadata:bigbluebuttonbn');
@@ -207,7 +207,7 @@ 
                     'meetingid' => $record->meetingid,
                     'log' => $record->log,
                     'meta' => $record->meta,
-                  ];
+                    ];
                 return $carry;
             },
             function($instanceid, $data) use ($user, $instanceidstocmids) {

Doc Comments +2 added lines

@@ -54,6 +54,7 @@ 
          * Get the list of users who have data within a context.
          *
          * @param   userlist $userlist The userlist containing the list of users who have data in this context/plugin combination.
+         * @return void
          */
         public static function get_users_in_context(userlist $userlist);
 
@@ -61,6 +62,7 @@ 
          * Delete multiple users within a single context.
          *
          * @param   approved_userlist       $userlist The approved context and user information to delete information for.
+         * @return void
          */
         public static function delete_data_for_users(approved_userlist $userlist);
     }

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 global $CFG;
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /*
  * This part is to be eliminated as soon as possible but allows the phpunit test to pass Ok on MOODLE_33 and below WHILST allowing

classes/output/import_view.php

Spacing +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
             }
             $recordings = bigbluebuttonbn_get_allrecordings(
                 $selected, $bigbluebuttonbnid, false,
-                (boolean)\mod_bigbluebuttonbn\locallib\config::get('importrecordings_from_deleted_enabled')
+                (boolean) \mod_bigbluebuttonbn\locallib\config::get('importrecordings_from_deleted_enabled')
             );
             // Exclude the ones that are already imported.
             if (!empty($recordings)) {

classes/output/index.php

Spacing +4 added lines, -4 removed lines

@@ -221,10 +221,10 @@
             if ($groupobj != null) {
                 $actions .= '  <INPUT type="hidden" name="g" value="'.$groupobj->id.'">'."\n";
             }
-            $actions .= '  <INPUT type="submit" name="submit" value="' .
-                get_string('view_conference_action_end', 'bigbluebuttonbn') .
-                '" class="btn btn-primary btn-sm" onclick="return confirm(\'' .
-                get_string('index_confirm_end', 'bigbluebuttonbn') . '\')">' . "\n";
+            $actions .= '  <INPUT type="submit" name="submit" value="'.
+                get_string('view_conference_action_end', 'bigbluebuttonbn').
+                '" class="btn btn-primary btn-sm" onclick="return confirm(\''.
+                get_string('index_confirm_end', 'bigbluebuttonbn').'\')">'."\n";
             $actions .= '</form>'."\n";
         }
         return $actions;

classes/output/mobile.php

Spacing +13 added lines, -13 removed lines

@@ -29,8 +29,8 @@ 
 
 use context_module;
 use mod_bigbluebuttonbn_external;
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
-require_once($CFG->dirroot . '/lib/grouplib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/lib/grouplib.php');
 
 /**
  * Mobile output class for bigbluebuttonbn
@@ -67,7 +67,7 @@ 
         $bigbluebuttonbn = $viewinstance['bigbluebuttonbn'];
         $context = context_module::instance($cm->id);
 
-        require_login($course->id, false , $cm, true, true);
+        require_login($course->id, false, $cm, true, true);
         require_capability('mod/bigbluebuttonbn:join', $context);
 
         // Add view event.
@@ -138,15 +138,15 @@ 
         }
 
         // Operation URLs.
-        $bbbsession['bigbluebuttonbnURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/view.php?id=' . $bbbsession['cm']->id;
-        $bbbsession['logoutURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=logout&id='.$args->cmid .
-            '&bn=' . $bbbsession['bigbluebuttonbn']->id;
-        $bbbsession['recordingReadyURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_broker.php?action=recording_' .
-            'ready&bigbluebuttonbn=' . $bbbsession['bigbluebuttonbn']->id;
-        $bbbsession['meetingEventsURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_broker.php?action=meeting' .
-            '_events&bigbluebuttonbn=' . $bbbsession['bigbluebuttonbn']->id;
-        $bbbsession['joinURL'] = $CFG->wwwroot . '/mod/bigbluebuttonbn/bbb_view.php?action=join&id=' . $args->cmid .
-            '&bn=' . $bbbsession['bigbluebuttonbn']->id;
+        $bbbsession['bigbluebuttonbnURL'] = $CFG->wwwroot.'/mod/bigbluebuttonbn/view.php?id='.$bbbsession['cm']->id;
+        $bbbsession['logoutURL'] = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_view.php?action=logout&id='.$args->cmid.
+            '&bn='.$bbbsession['bigbluebuttonbn']->id;
+        $bbbsession['recordingReadyURL'] = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_broker.php?action=recording_'.
+            'ready&bigbluebuttonbn='.$bbbsession['bigbluebuttonbn']->id;
+        $bbbsession['meetingEventsURL'] = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_broker.php?action=meeting'.
+            '_events&bigbluebuttonbn='.$bbbsession['bigbluebuttonbn']->id;
+        $bbbsession['joinURL'] = $CFG->wwwroot.'/mod/bigbluebuttonbn/bbb_view.php?action=join&id='.$args->cmid.
+            '&bn='.$bbbsession['bigbluebuttonbn']->id;
 
         // Initialize session variable used across views.
         $SESSION->bigbluebuttonbn_bbbsession = $bbbsession;
@@ -182,7 +182,7 @@ 
             }
             if ($response['returncode'] == 'FAILED') {
                 // The meeting could not be created.
-                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'],  'view_error_create');
+                $errorkey = bigbluebuttonbn_get_error_key($response['messageKey'], 'view_error_create');
                 $e = get_string($errorkey, 'bigbluebuttonbn');
                 return(self::mobile_print_error($e));
             }

Unused Use Statements -1 removed lines

@@ -28,7 +28,6 @@
 defined('MOODLE_INTERNAL') || die();
 
 use context_module;
-use mod_bigbluebuttonbn_external;
 require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
 require_once($CFG->dirroot . '/lib/grouplib.php');
 

classes/search/tags.php

Spacing +4 added lines, -4 removed lines

@@ -65,8 +65,8 @@ 
             return null;
         }
 
-        $result = $DB->get_recordset_sql('SELECT modtable.* FROM {' . $this->get_module_name() .
-            '} modtable ' . $contextjoin, array_merge($contextparams));
+        $result = $DB->get_recordset_sql('SELECT modtable.* FROM {'.$this->get_module_name().
+            '} modtable '.$contextjoin, array_merge($contextparams));
 
         return($result);
     }
@@ -96,12 +96,12 @@ 
 
         } catch (\dml_missing_record_exception $ex) {
             // Notify it as we run here as admin, we should see everything.
-            debugging('Error retrieving ' . $this->areaid . ' ' . $record->id . ' document, not all required data is available: ' .
+            debugging('Error retrieving '.$this->areaid.' '.$record->id.' document, not all required data is available: '.
                 $ex->getMessage(), DEBUG_DEVELOPER);
             return false;
         } catch (\dml_exception $ex) {
             // Notify it as we run here as admin, we should see everything.
-            debugging('Error retrieving ' . $this->areaid . ' ' . $record->id . ' document: ' . $ex->getMessage(), DEBUG_DEVELOPER);
+            debugging('Error retrieving '.$this->areaid.' '.$record->id.' document: '.$ex->getMessage(), DEBUG_DEVELOPER);
             return false;
         }
 

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
  */
 
 namespace mod_bigbluebuttonbn\search;
-use core_tag\output\tag;
 
 defined('MOODLE_INTERNAL') || die();
 

classes/task/completion_update_state.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/bigbluebuttonbn/locallib.php');
+require_once($CFG->dirroot.'/mod/bigbluebuttonbn/locallib.php');
 
 /**
  * Class containing the scheduled task for lti module.