blindsidenetworks / moodle-mod_bigbluebuttonbn

bbb_view.php

Braces +3 added lines, -2 removed lines

@@ -88,8 +88,9 @@
                     /// Set the duration for the meeting
                     if ( bigbluebuttonbn_get_cfg_scheduled_duration_enabled() ) {
                         $durationtime = bigbluebuttonbn_get_duration($bigbluebuttonbn->openingtime, $bigbluebuttonbn->closingtime);
-                        if( $durationtime > 0 )
-                            $bbbsession['welcome'] .= '<br><br>'.str_replace("%duration%", ''.$durationtime, get_string('bbbdurationwarning', 'bigbluebuttonbn'));
+                        if( $durationtime > 0 ) {
+                                                    $bbbsession['welcome'] .= '<br><br>'.str_replace("%duration%", ''.$durationtime, get_string('bbbdurationwarning', 'bigbluebuttonbn'));
+                        }
                     } else {
                         $durationtime = 0;
                     }

bbb_broker.php

Braces +3 added lines, -2 removed lines

@@ -119,8 +119,9 @@
                         //Execute the end command
                         $meeting_info = bigbluebuttonbn_bbb_broker_do_end_meeting($params['id'], $bbbsession['modPW']);
                         // Moodle event logger: Create an event for meeting ended
-                        if( isset($bigbluebuttonbn) )
-                            bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_MEETING_ENDED, $bigbluebuttonbn, $context, $cm);
+                        if( isset($bigbluebuttonbn) ) {
+                                                    bigbluebuttonbn_event_log(BIGBLUEBUTTON_EVENT_MEETING_ENDED, $bigbluebuttonbn, $context, $cm);
+                        }
                         /// Update the cache
                         $meeting_info = bigbluebuttonbn_bbb_broker_get_meeting_info($params['id'], $bbbsession['modPW'], true);
 

mod_form.php

Braces +3 added lines, -2 removed lines

@@ -269,8 +269,9 @@
         // Fourth block starts here
         //-------------------------------------------------------------------------------
         $mform->addElement('header', 'schedule', get_string('mod_form_block_schedule', 'bigbluebuttonbn'));
-        if( isset($current_activity->openingtime) && $current_activity->openingtime != 0 || isset($current_activity->closingtime) && $current_activity->closingtime != 0 )
-            $mform->setExpanded('schedule');
+        if( isset($current_activity->openingtime) && $current_activity->openingtime != 0 || isset($current_activity->closingtime) && $current_activity->closingtime != 0 ) {
+                    $mform->setExpanded('schedule');
+        }
 
         $mform->addElement('date_time_selector', 'openingtime', get_string('mod_form_field_openingtime', 'bigbluebuttonbn'), array('optional' => true));
         $mform->setDefault('openingtime', 0);

lib.php

Braces +20 added lines, -14 removed lines

@@ -388,14 +388,18 @@ 
         $bigbluebuttonbn->timemodified = time();
     }
 
-    if (! isset($bigbluebuttonbn->newwindow))
-        $bigbluebuttonbn->newwindow = 0;
-    if (! isset($bigbluebuttonbn->wait))
-        $bigbluebuttonbn->wait = 0;
-    if (! isset($bigbluebuttonbn->record))
-        $bigbluebuttonbn->record = 0;
-    if (! isset($bigbluebuttonbn->tagging))
-        $bigbluebuttonbn->tagging = 0;
+    if (! isset($bigbluebuttonbn->newwindow)) {
+            $bigbluebuttonbn->newwindow = 0;
+    }
+    if (! isset($bigbluebuttonbn->wait)) {
+            $bigbluebuttonbn->wait = 0;
+    }
+    if (! isset($bigbluebuttonbn->record)) {
+            $bigbluebuttonbn->record = 0;
+    }
+    if (! isset($bigbluebuttonbn->tagging)) {
+            $bigbluebuttonbn->tagging = 0;
+    }
 
     $bigbluebuttonbn->participants = htmlspecialchars_decode($bigbluebuttonbn->participants);
 }
@@ -463,8 +467,9 @@ 
         /// Add the meeting details to the message_body
         $msg->action = ucfirst($action);
         $msg->activity_description = "";
-        if( !empty($bigbluebuttonbn->intro) )
-            $msg->activity_description = trim($bigbluebuttonbn->intro);
+        if( !empty($bigbluebuttonbn->intro) ) {
+                    $msg->activity_description = trim($bigbluebuttonbn->intro);
+        }
         $msg->activity_openingtime = "";
         if ($bigbluebuttonbn->openingtime) {
             $msg->activity_openingtime = calendar_day_representation($bigbluebuttonbn->openingtime).' '.$at.' '.calendar_time_representation($bigbluebuttonbn->openingtime);
@@ -622,10 +627,11 @@ 
 function bigbluebuttonbn_get_db_moodle_roles($rolename='all') {
     global $DB;
 
-    if( $rolename != 'all')
-        $roles = $DB->get_record('role', array('shortname' => $rolename));
-    else
-        $roles = $DB->get_records('role', array());
+    if( $rolename != 'all') {
+            $roles = $DB->get_record('role', array('shortname' => $rolename));
+    } else {
+            $roles = $DB->get_records('role', array());
+    }
 
     return $roles;
 }

locallib.php

Braces +7 added lines, -4 removed lines

@@ -320,8 +320,7 @@ 
 
     if( $xml ) { //If the xml packet returned failure it displays the message to the user
         return array('returncode' => $xml->returncode, 'message' => $xml->message, 'messageKey' => $xml->messageKey);
-    }
-    else { //If the server is unreachable, then prompts the user of the necessary action
+    } else { //If the server is unreachable, then prompts the user of the necessary action
         return null;
     }
 }
@@ -355,7 +354,9 @@ 
 }
 
 function bigbluebuttonbn_wrap_xml_load_file($url, $method=BIGBLUEBUTTONBN_METHOD_GET, $data=null) {
-    if ( bigbluebuttonbn_debugdisplay() ) error_log("Request to: ".$url);
+    if ( bigbluebuttonbn_debugdisplay() ) {
+        error_log("Request to: ".$url);
+    }
 
     if (extension_loaded('curl')) {
         $c = new curl();
@@ -942,7 +943,9 @@ 
     $error = $org_msg;
 
     if( !empty($new_msg) ) {
-        if( !empty($error) ) $error .= ' ';
+        if( !empty($error) ) {
+            $error .= ' ';
+        }
         $error .= $new_msg;
     }
 

view.php

Braces +19 added lines, -14 removed lines

@@ -84,8 +84,9 @@ 
 $bbbsession['voicebridge'] = ($bigbluebuttonbn->voicebridge > 0) ? 70000 + $bigbluebuttonbn->voicebridge : $bigbluebuttonbn->voicebridge;
 $bbbsession['wait'] = $bigbluebuttonbn->wait;
 $bbbsession['record'] = $bigbluebuttonbn->record;
-if ($bigbluebuttonbn->record)
+if ($bigbluebuttonbn->record) {
     $bbbsession['welcome'] .= '<br><br>' . get_string('bbbrecordwarning', 'bigbluebuttonbn');
+}
 $bbbsession['tagging'] = $bigbluebuttonbn->tagging;
 
 $bbbsession['openingtime'] = $bigbluebuttonbn->openingtime;
@@ -112,22 +113,24 @@ 
 // Validates if the BigBlueButton server is running
 $serverVersion = bigbluebuttonbn_getServerVersion($bbbsession['endpoint']);
 if (!isset($serverVersion)) { //Server is not working
-    if ($bbbsession['administrator'])
-        print_error('view_error_unable_join', 'bigbluebuttonbn', $CFG->wwwroot . '/admin/settings.php?section=modsettingbigbluebuttonbn');
-    else if ($bbbsession['moderator'])
-        print_error('view_error_unable_join_teacher', 'bigbluebuttonbn', $CFG->wwwroot . '/course/view.php?id=' . $bigbluebuttonbn->course);
-    else
-        print_error('view_error_unable_join_student', 'bigbluebuttonbn', $CFG->wwwroot . '/course/view.php?id=' . $bigbluebuttonbn->course);
-} else {
-    $xml = bigbluebuttonbn_wrap_xml_load_file(bigbluebuttonbn_getMeetingsURL($bbbsession['endpoint'], $bbbsession['shared_secret']));
-    if (!isset($xml) || !isset($xml->returncode) || $xml->returncode == 'FAILED') { // The shared secret is wrong
-        if ($bbbsession['administrator'])
+    if ($bbbsession['administrator']) {
             print_error('view_error_unable_join', 'bigbluebuttonbn', $CFG->wwwroot . '/admin/settings.php?section=modsettingbigbluebuttonbn');
-        else if ($bbbsession['moderator'])
+    } else if ($bbbsession['moderator']) {
             print_error('view_error_unable_join_teacher', 'bigbluebuttonbn', $CFG->wwwroot . '/course/view.php?id=' . $bigbluebuttonbn->course);
-        else
+    } else {
             print_error('view_error_unable_join_student', 'bigbluebuttonbn', $CFG->wwwroot . '/course/view.php?id=' . $bigbluebuttonbn->course);
     }
+    } else {
+    $xml = bigbluebuttonbn_wrap_xml_load_file(bigbluebuttonbn_getMeetingsURL($bbbsession['endpoint'], $bbbsession['shared_secret']));
+    if (!isset($xml) || !isset($xml->returncode) || $xml->returncode == 'FAILED') { // The shared secret is wrong
+        if ($bbbsession['administrator']) {
+                    print_error('view_error_unable_join', 'bigbluebuttonbn', $CFG->wwwroot . '/admin/settings.php?section=modsettingbigbluebuttonbn');
+        } else if ($bbbsession['moderator']) {
+                    print_error('view_error_unable_join_teacher', 'bigbluebuttonbn', $CFG->wwwroot . '/course/view.php?id=' . $bigbluebuttonbn->course);
+        } else {
+                    print_error('view_error_unable_join_student', 'bigbluebuttonbn', $CFG->wwwroot . '/course/view.php?id=' . $bigbluebuttonbn->course);
+        }
+    }
 }
 
 // Mark viewed by user (if required)
@@ -338,7 +341,9 @@ 
             }
             //Generates the meetingID string
             foreach ($mIDs as $mID) {
-                if (strlen($meetingID) > 0) $meetingID .= ',';
+                if (strlen($meetingID) > 0) {
+                    $meetingID .= ',';
+                }
                 $meetingID .= $mID;
             }
         }