Issues in InfoCommandTest.php (master) - Issues in master - bldr-io/bldr - Measure and Improve Code Quality continuously with Scrutinizer

Issues (37)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/Command/Task/InfoCommandTest.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * This file is part of Bldr.io
 *
 * (c) Aaron Scherer <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE
 */

namespace Bldr\Test\Command\Task;

use Bldr\Block\Core\Command\Task\InfoCommand;
use Bldr\Registry\TaskRegistry;
use Bldr\Test\Mock\MockApplication;
use Mockery\MockInterface;
use Symfony\Component\Console\Tester\CommandTester;

/**
 * @author Wouter J <[email protected]>
 */
class InfoCommandTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @type MockInterface
     */
    protected $container;

    /**
     * @type InfoCommand
     */
    protected $command;

    /**
     * @type MockInterface
     */
    protected $task1;

    /**
     * @type MockInterface
     */
    protected $task2;

    /**
     *
     */
    public function setUp()
    {
        $this->container = \Mockery::mock('Symfony\Component\DependencyInjection\Container');

        $this->command = new InfoCommand();
        $this->command->setContainer($this->container);

        $this->task1 = \Mockery::mock('Bldr\Block\Core\Task\AbstractTask');
        $this->task1->shouldReceive('configure');
        $this->task1->shouldReceive('validate');
        $this->task1->shouldReceive('setEventDispatcher');
        $this->task1->shouldReceive('getName')->andReturn('Name 1');

        $this->task2 = \Mockery::mock('Bldr\Task\TaskInterface');
        $this->task2->shouldReceive('configure');
        $this->task2->shouldReceive('validate');
        $this->task2->shouldReceive('getName')->andReturn('Name 2');

        $registry = new TaskRegistry(
            \Mockery::mock('Symfony\Component\EventDispatcher\EventDispatcherInterface'), [$this->task1, $this->task2]
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->container
            ->shouldReceive('get')
            ->with('bldr.registry.task')
            ->andReturn($registry);
    }

    /**
     *
     */
    public function testCommand()
    {
        $this->task1->shouldReceive('getDescription')->andReturn('A first description.');
        $this->task1->shouldReceive('getParameterDefinition')->andReturn(
            [
                ['name' => 'option1', 'default' => null, 'description' => '', 'required' => false],
                [
                    'name'        => 'option2',
                    'default'     => 'bldr!',
                    'description' => 'Option 2 description',
                    'required'    => true
                ],
                ['name' => 'option3', 'default' => true, 'description' => '', 'required' => false],
            ]
        );

        $this->task2->shouldReceive('getDescription')->andReturnNull();

        $application = new MockApplication();
        $application->add($this->command);

        $tester = new CommandTester($application->find('task:info'));
        $tester->execute(['task' => 'Name 1']);

        $this->assertEquals(
            <<<EOO

Task Name: Name 1
Task Description: A first description.

Options:
+---------+----------------------+----------+---------+
| Option  | Description          | Required | Default |
+---------+----------------------+----------+---------+
| option1 | No Description       | No       | null    |
| option2 | Option 2 description | Yes      | "bldr!" |
| option3 | No Description       | No       | true    |
+---------+----------------------+----------+---------+

EOO
            ,

            $tester->getDisplay()
        );

        $tester = new CommandTester($application->find('task:info'));
        $tester->execute(['task' => 'Name 2']);

        $this->assertEquals(
            <<<EOO

Task Name: Name 2

EOO
            ,

            $tester->getDisplay()
        );
    }
}


1			<?php
2
3			/**
4			* This file is part of Bldr.io
5			*
6			* (c) Aaron Scherer <[email protected]>
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this source code in the file LICENSE
10			*/
11
12			namespace Bldr\Test\Command\Task;
13
14			use Bldr\Block\Core\Command\Task\InfoCommand;
15			use Bldr\Registry\TaskRegistry;
16			use Bldr\Test\Mock\MockApplication;
17			use Mockery\MockInterface;
18			use Symfony\Component\Console\Tester\CommandTester;
19
20			/**
21			* @author Wouter J <[email protected]>
22			*/
23			class InfoCommandTest extends \PHPUnit_Framework_TestCase
24			{
25			/**
26			* @type MockInterface
27			*/
28			protected $container;
29
30			/**
31			* @type InfoCommand
32			*/
33			protected $command;
34
35			/**
36			* @type MockInterface
37			*/
38			protected $task1;
39
40			/**
41			* @type MockInterface
42			*/
43			protected $task2;
44
45			/**
46			*
47			*/
48			public function setUp()
49			{
50			$this->container = \Mockery::mock('Symfony\Component\DependencyInjection\Container');
51
52			$this->command = new InfoCommand();
53			$this->command->setContainer($this->container);
54
55			$this->task1 = \Mockery::mock('Bldr\Block\Core\Task\AbstractTask');
56			$this->task1->shouldReceive('configure');
57			$this->task1->shouldReceive('validate');
58			$this->task1->shouldReceive('setEventDispatcher');
59			$this->task1->shouldReceive('getName')->andReturn('Name 1');
60
61			$this->task2 = \Mockery::mock('Bldr\Task\TaskInterface');
62			$this->task2->shouldReceive('configure');
63			$this->task2->shouldReceive('validate');
64			$this->task2->shouldReceive('getName')->andReturn('Name 2');
65
66			$registry = new TaskRegistry(
67			\Mockery::mock('Symfony\Component\EventDispatcher\EventDispatcherInterface'), [$this->task1, $this->task2]
			0 ignored issues – show Documentation introduced 2016-02-18 08:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array($this->task1, $this->task2)` is of type `array<integer,object<Moc...kery\\MockInterface>"}>`, but the function expects a `array<integer,object<Bldr\Task\TaskInterface>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
68			);
69
70			$this->container
71			->shouldReceive('get')
72			->with('bldr.registry.task')
73			->andReturn($registry);
74			}
75
76			/**
77			*
78			*/
79			public function testCommand()
80			{
81			$this->task1->shouldReceive('getDescription')->andReturn('A first description.');
82			$this->task1->shouldReceive('getParameterDefinition')->andReturn(
83			[
84			['name' => 'option1', 'default' => null, 'description' => '', 'required' => false],
85			[
86			'name' => 'option2',
87			'default' => 'bldr!',
88			'description' => 'Option 2 description',
89			'required' => true
90			],
91			['name' => 'option3', 'default' => true, 'description' => '', 'required' => false],
92			]
93			);
94
95			$this->task2->shouldReceive('getDescription')->andReturnNull();
96
97			$application = new MockApplication();
98			$application->add($this->command);
99
100			$tester = new CommandTester($application->find('task:info'));
101			$tester->execute(['task' => 'Name 1']);
102
103			$this->assertEquals(
104			<<<EOO
105
106			Task Name: Name 1
107			Task Description: A first description.
108
109			Options:
110			+---------+----------------------+----------+---------+
111			\| Option \| Description \| Required \| Default \|
112			+---------+----------------------+----------+---------+
113			\| option1 \| No Description \| No \| null \|
114			\| option2 \| Option 2 description \| Yes \| "bldr!" \|
115			\| option3 \| No Description \| No \| true \|
116			+---------+----------------------+----------+---------+
117
118			EOO
119			,
			0 ignored issues – show Coding Style introduced 2016-02-18 08:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this Space found before comma in function call Loading history...
120			$tester->getDisplay()
121			);
122
123			$tester = new CommandTester($application->find('task:info'));
124			$tester->execute(['task' => 'Name 2']);
125
126			$this->assertEquals(
127			<<<EOO
128
129			Task Name: Name 2
130
131			EOO
132			,
			0 ignored issues – show Coding Style introduced 2016-02-18 08:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this Space found before comma in function call Loading history...
133			$tester->getDisplay()
134			);
135			}
136			}
137

bldr-io / bldr

Issues (37)

Security Analysis no request data

tests/Command/Task/InfoCommandTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like