BldrBlock::addTaskOptions() - Code Metrics - bldr-io/bldr - Measure and Improve Code Quality continuously with Scrutinizer

BldrBlock::addTaskOptions() B
last analyzed 2016-06-10 14:07 UTC

↳ Parent: BldrBlock

Complexity

Conditions	6
Paths	4

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	8.8571
c	0
b	0
f	0
cc	6
eloc	9
nc	4
nop	2

<?php

/**
 * This file is part of Bldr.io
 *
 * (c) Aaron Scherer <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE
 */

namespace Bldr\Block\Core;

use Bldr\DependencyInjection\AbstractBlock;
use Symfony\Component\DependencyInjection\ContainerBuilder as SymfonyContainerBuilder;

/**
 * @author Aaron Scherer <[email protected]>
 */
class BldrBlock extends AbstractBlock
{
    /**
     * {@inheritDoc}
     */
    public function assemble(array $config, SymfonyContainerBuilder $container)
    {
        $this->addTaskOptions($config, $this->originalConfiguration);

        $this->setParameter('name', $config['name']);
        $this->setParameter('description', $config['description']);
        $this->setParameter('profiles', $config['profiles']);
        $this->setParameter('jobs', $config['jobs']);

        $this->addService('bldr.dispatcher', 'Symfony\Component\EventDispatcher\EventDispatcher');
        $this->addService('bldr.registry.job', 'Bldr\Registry\JobRegistry');
    }

    /**
     * {@inheritDoc}
     */
    public function getCompilerPasses()
    {
        return [
            new CompilerPass\CoreCompilerPass()
        ];
    }

    /**
     * {@inheritDoc}
     */
    protected function getConfigurationClass()
    {
        return 'Bldr\Block\Core\Configuration';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param array $configuration
     * @param array $configs
     */
    private function addTaskOptions(array &$configuration, array $configs)
    {
        foreach ($configs as $config) {
            foreach ($configuration['jobs'] as $name => $job) {
                if (!isset($config['jobs'])) {
                    continue;
                }

                foreach ($job['tasks'] as $index => $task) {
                    if (isset($config['jobs'][$name], $config['jobs'][$name]['tasks'][$index])) {
                        $options = $config['jobs'][$name]['tasks'][$index];
                        $configuration['jobs'][$name]['tasks'][$index] = array_merge($task, $options);
                    }
                }
            }
        }
    }
}


1			<?php
2
3			/**
4			* This file is part of Bldr.io
5			*
6			* (c) Aaron Scherer <[email protected]>
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this source code in the file LICENSE
10			*/
11
12			namespace Bldr\Block\Core;
13
14			use Bldr\DependencyInjection\AbstractBlock;
15			use Symfony\Component\DependencyInjection\ContainerBuilder as SymfonyContainerBuilder;
16
17			/**
18			* @author Aaron Scherer <[email protected]>
19			*/
20			class BldrBlock extends AbstractBlock
21			{
22			/**
23			* {@inheritDoc}
24			*/
25			public function assemble(array $config, SymfonyContainerBuilder $container)
26			{
27			$this->addTaskOptions($config, $this->originalConfiguration);
28
29			$this->setParameter('name', $config['name']);
30			$this->setParameter('description', $config['description']);
31			$this->setParameter('profiles', $config['profiles']);
32			$this->setParameter('jobs', $config['jobs']);
33
34			$this->addService('bldr.dispatcher', 'Symfony\Component\EventDispatcher\EventDispatcher');
35			$this->addService('bldr.registry.job', 'Bldr\Registry\JobRegistry');
36			}
37
38			/**
39			* {@inheritDoc}
40			*/
41			public function getCompilerPasses()
42			{
43			return [
44			new CompilerPass\CoreCompilerPass()
45			];
46			}
47
48			/**
49			* {@inheritDoc}
50			*/
51			protected function getConfigurationClass()
52			{
53			return 'Bldr\Block\Core\Configuration';
			0 ignored issues – show Bug Best Practice introduced 2016-02-18 08:37 UTC by Report Bug Copy Issue Report The return type of `return 'Bldr\\Block\\Core\\Configuration';` (`string`) is incompatible with the return type of the parent method `Bldr\DependencyInjection...::getConfigurationClass` of type `boolean`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
54			}
55
56			/**
57			* @param array $configuration
58			* @param array $configs
59			*/
60			private function addTaskOptions(array &$configuration, array $configs)
61			{
62			foreach ($configs as $config) {
63			foreach ($configuration['jobs'] as $name => $job) {
64			if (!isset($config['jobs'])) {
65			continue;
66			}
67
68			foreach ($job['tasks'] as $index => $task) {
69			if (isset($config['jobs'][$name], $config['jobs'][$name]['tasks'][$index])) {
70			$options = $config['jobs'][$name]['tasks'][$index];
71			$configuration['jobs'][$name]['tasks'][$index] = array_merge($task, $options);
72			}
73			}
74			}
75			}
76			}
77			}
78

bldr-io / bldr

BldrBlock::addTaskOptions() B last analyzed 2016-06-10 14:07 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

BldrBlock::addTaskOptions() B
last analyzed 2016-06-10 14:07 UTC