Blasttech\EloquentRelatedPlus\RelatedPlusHelpers::parseRelationNames()

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	RelatedPlusHelpers::getTableFromColumn()	0	5	2

<?php

namespace Blasttech\EloquentRelatedPlus;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\Relation;

/**
 * Class RelatedPlusHelpers
 *
 * @property array order_fields
 * @property array order_defaults
 * @property array order_relations
 * @property array order_with
 * @property array search_fields
 * @property string connection
 */
class RelatedPlusHelpers
{
    /**
     * Return the sql for a query with the bindings replaced with the binding values
     *
     * @param Builder $builder
     * @return string
     */
    public static function toSqlWithBindings($builder)
    {
        $replacements = array_map('addslashes', $builder->getBindings());

It seems like $builder->getBindings() can also be of type Illuminate\Database\Eloquent\Builder; however, parameter $arr1 of array_map() does only seem to accept array, maybe add an additional type check?

        $sql = $builder->toSql();

        foreach ($replacements as &$replacement) {
            if (!is_numeric($replacement)) {
                $replacement = '"' . $replacement . '"';
            }
        }

        return preg_replace_callback(
            '/(\?)(?=(?:[^\'"]|["\'][^\'"]*["\'])*$)/',
            function () use (&$replacements) {
                return array_shift($replacements);
            },
            $sql
        );
    }

    /**
     * Get table name from column name
     *
     * @param string $column
     * @return string
     */
    public static function getTableFromColumn($column)
    {
        $periodPos = strpos($column, '.');

        return ($periodPos !== false ? substr($column, 0, $periodPos) : $column);

The condition $periodPos !== false can never be false.

    }

    /**
     * Remove any global scopes which contain $scopeName in their name
     *
     * @param RelatedPlusTrait|Model $model
     * @param Builder $query
     * @param string $scopeName
     * @return Relation|Builder
     */
    public static function removeGlobalScopes($model, $query, $scopeName)
    {
        $query->withoutGlobalScopes(collect($model->getGlobalScopes())->keys()->filter(function (

It seems like getGlobalScopes() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $value
        ) use ($scopeName) {
            return stripos($value, $scopeName) !== false;
        })->toArray());

        return $query;
    }
}