Issues (689)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Admin/Traits/ManyToManyManager.php (5 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
/*
4
 * This file is part of the Blast Project package.
5
 *
6
 * Copyright (C) 2015-2017 Libre Informatique
7
 *
8
 * This file is licenced under the GNU LGPL v3.
9
 * For the full copyright and license information, please view the LICENSE.md
10
 * file that was distributed with this source code.
11
 */
12
13
namespace Blast\CoreBundle\Admin\Traits;
14
15
/**
16
 * This trait is used to delete many-to-many associated entities when the current
17
 * entity is not on the owning side.
18
 */
19
trait ManyToManyManager
20
{
21
    protected $manyToManyCollections = [];
22
23
    /**
24
     * @return array
25
     * */
26
    public function getManyToManyCollections()
27
    {
28
        return $this->manyToManyCollections;
29
    }
30
31
    /**
32
     * @param string|array $collections
33
     *
34
     * @return self
35
     */
36
    public function addManyToManyCollections($collections)
37
    {
38
        if (!is_array($collections)) {
39
            $collections = [$collections];
40
        }
41
        $this->manyToManyCollections = array_merge($this->manyToManyCollections, $collections);
42
43
        return $this;
44
    }
45
46
    /**
47
     * Delete many-to-many associated entities when the current entity is not on the owning side
48
     * This is called by the PreEvents::prePersistOrUpdate() method.
49
     *
50
     * @param object $object
51
     */
52
    protected function preUpdateManyToManyManager($object)
53
    {
54
        $this->configureManyToManyManager();
55
56
        $rc = new \ReflectionClass($this->getClass());
0 ignored issues
show
It seems like getClass() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
57
        $remove_method = 'remove' . ucfirst($rc->getShortName());
58
59
        foreach ($this->manyToManyCollections as $fieldname) {
60
            $get_method = 'get' . ucfirst($fieldname);
61
            $orig_collection = $object->$get_method()->getSnapshot();
62
            $new_collection = $object->$get_method();
63
            foreach ($orig_collection as $entity) {
64
                if (!$new_collection->contains($entity)) {
65
                    $entity->$remove_method($object);
66
                    $this->getModelManager()->update($entity);
0 ignored issues
show
It seems like getModelManager() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
67
                }
68
            }
69
        }
70
    }
71
72 View Code Duplication
    private function configureManyToManyManager()
0 ignored issues
show
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
73
    {
74
        $librinfo = $this->getConfigurationPool()->getContainer()->getParameter('blast');
0 ignored issues
show
It seems like getConfigurationPool() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
75
        $key = 'manyToMany'; // name of the key in the librinfo.yml
76
77
        // merge configuration/parameters
78
        foreach ($this->getCurrentComposition() as $class) {
0 ignored issues
show
It seems like getCurrentComposition() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
79
            if (isset($librinfo[$class])
80
          && isset($librinfo[$class]['manage'])
81
          && isset($librinfo[$class]['manage'][$key])) {
82
                if (!is_array($librinfo[$class]['manage'][$key])) {
83
                    $librinfo[$class]['manage'][$key] = [$librinfo[$class]['manage'][$key]];
84
                }
85
                $this->addManyToManyCollections($librinfo[$class]['manage'][$key]);
86
            }
87
        }
88
89
        return $this;
90
    }
91
}
92