Blast\Bundle\CoreBundle\Generator\ControllerGenerator

Complexity

Total Complexity

5

Size/Duplication

Total Lines	66
Duplicated Lines	10.61 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	generate()	7	23	2
A	getClass()	0	4	1
A	getFile()	0	4	1

<?php

/*
 * This file is part of the Blast Project package.
 *
 * Copyright (C) 2015-2017 Libre Informatique
 *
 * This file is licenced under the GNU LGPL v3.
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

namespace Blast\Bundle\CoreBundle\Generator;

use Symfony\Component\HttpKernel\Bundle\BundleInterface;
use Sonata\AdminBundle\Generator\ControllerGenerator as BaseControllerGenerator;

/**
 * Class ControllerGenerator.
 */
class ControllerGenerator extends BaseControllerGenerator
{
    /**
     * @var string|null
     */
    private $class;

Consider using a different property name as you override a private property of the parent class.

    /**
     * @var string|null
     */
    private $file;

Consider using a different property name as you override a private property of the parent class.

    /**
     * @param array|string $skeletonDirectory
     */
    public function __construct($skeletonDirectory)
    {
        $this->setSkeletonDirs($skeletonDirectory);

It seems like $skeletonDirectory defined by parameter $skeletonDirectory on line 36 can also be of type string; however, Sensio\Bundle\GeneratorBundle\Generator\Generator::setSkeletonDirs() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @param BundleInterface $bundle
     * @param string          $controllerClassBasename
     *
     * @throws \RuntimeException
     */
    public function generate(BundleInterface $bundle, $controllerClassBasename)
    {
        $this->class = sprintf('%s\Controller\%s', $bundle->getNamespace(), $controllerClassBasename);
        $this->file = sprintf(
            '%s/Controller/%s.php',
            $bundle->getPath(),
            str_replace('\\', '/', $controllerClassBasename)
        );
        $parts = explode('\\', $this->class);

        if (file_exists($this->file)) {

This code seems to be duplicated across your project.

            throw new \RuntimeException(sprintf(
                'Unable to generate the admin controller class "%s". The file "%s" already exists.',
                $this->class,
                realpath($this->file)
            ));
        }

        $this->renderFile('AdminController.php.twig', $this->file, array(
            'classBasename' => array_pop($parts),
            'namespace'     => implode('\\', $parts),
        ));
    }

    /**
     * @return string|null
     */
    public function getClass()
    {
        return $this->class;
    }

    /**
     * @return string|null
     */
    public function getFile()
    {
        return $this->file;
    }
}