Blast\Bundle\CoreBundle\Command\Traits\Interaction

Complexity

Total Complexity

12

Size/Duplication

Total Lines	92
Duplicated Lines	46.74 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	writeError()	0	4	1
A	askAndValidate()	3	17	3
A	askConfirmation()	19	19	4
A	getQuestionHelper()	21	21	4

<?php

/*
 * This file is part of the Blast Project package.
 *
 * Copyright (C) 2015-2017 Libre Informatique
 *
 * This file is licenced under the GNU LGPL v3.
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

namespace Blast\Bundle\CoreBundle\Command\Traits;

use Sensio\Bundle\GeneratorBundle\Command\Helper\DialogHelper;
use Sensio\Bundle\GeneratorBundle\Command\Helper\QuestionHelper;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Console\Question\Question;

/**
 * This trait is the perfect copy of the Blast\Bundle\OuterExtensionBundle\Command\Traits\Interaction
 * They are still distinct because of the few amount of code to factorize, but it will be done
 * as soon as we have a bit more to make generic.
 **/
trait Interaction
{
    /**
     * @param OutputInterface $output
     * @param string          $message
     */
    private function writeError(OutputInterface $output, $message)

This method is not used, and could be removed.

    {
        $output->writeln(sprintf("\n<error>%s</error>", $message));
    }

    /**
     * @param InputInterface  $input
     * @param OutputInterface $output
     * @param string          $questionText
     * @param mixed           $default
     * @param callable        $validator
     *
     * @return mixed
     */
    private function askAndValidate(InputInterface $input, OutputInterface $output, $questionText, $default = null, $validator = null)

This method is not used, and could be removed.

    {
        $questionHelper = $this->getQuestionHelper();

        // NEXT_MAJOR: Remove this BC code for SensioGeneratorBundle 2.3/2.4 after dropping support for Symfony 2.3
        if ($questionHelper instanceof DialogHelper) {

The class Sensio\Bundle\GeneratorBundle\Command\Helper\DialogHelper does not exist. Did you forget a USE statement, or did you not list all dependencies?

This code seems to be duplicated across your project.

            return $questionHelper->askAndValidate($output, $questionHelper->getQuestion($questionText, $default), $validator, false, $default);
        }

        $question = new Question($questionHelper->getQuestion($questionText, $default), $default);

        if (null !== $validator) {
            $question->setValidator($validator);
        }

        return $questionHelper->ask($input, $output, $question);
    }

    /**
     * @param InputInterface  $input
     * @param OutputInterface $output
     * @param string          $questionText
     * @param string          $default
     * @param string          $separator
     *
     * @return string
     */
    private function askConfirmation(InputInterface $input, OutputInterface $output, $questionText, $default, $separator)

This method is not used, and could be removed.

This method seems to be duplicated in your project.

    {
        $questionHelper = $this->getQuestionHelper();

        // NEXT_MAJOR: Remove this BC code for SensioGeneratorBundle 2.3/2.4 after dropping support for Symfony 2.3
        if ($questionHelper instanceof DialogHelper) {

The class Sensio\Bundle\GeneratorBundle\Command\Helper\DialogHelper does not exist. Did you forget a USE statement, or did you not list all dependencies?

            $question = $questionHelper->getQuestion($questionText, $default, $separator);

            return $questionHelper->askConfirmation($output, $question, ($default === 'no' ? false : true));
        }

        $question = new ConfirmationQuestion($questionHelper->getQuestion(
            $questionText,
            $default,
            $separator
        ), ($default === 'no' ? false : true));

        return $questionHelper->ask($input, $output, $question);
    }

    /**
     * @return QuestionHelper|DialogHelper
     */
    private function getQuestionHelper()

This method seems to be duplicated in your project.

    {
        // NEXT_MAJOR: Remove this BC code for SensioGeneratorBundle 2.3/2.4 after dropping support for Symfony 2.3
        if (class_exists('Sensio\Bundle\GeneratorBundle\Command\Helper\DialogHelper')) {
            $questionHelper = $this->getHelper('dialog');

It seems like getHelper() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if (!$questionHelper instanceof DialogHelper) {

The class Sensio\Bundle\GeneratorBundle\Command\Helper\DialogHelper does not exist. Did you forget a USE statement, or did you not list all dependencies?

                $questionHelper = new DialogHelper();
                $this->getHelperSet()->set($questionHelper);

It seems like getHelperSet() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        } else {
            $questionHelper = $this->getHelper('question');

It seems like getHelper() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            if (!$questionHelper instanceof QuestionHelper) {
                $questionHelper = new QuestionHelper();
                $this->getHelperSet()->set($questionHelper);

It seems like getHelperSet() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        }

        return $questionHelper;
    }
}