BlastCoreExtension - Code Metrics - Inspection of "[Blast] [Patcher] Move all patcher into bundle" - blast-project/CoreBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — wip-platform ( 53fa26...cf78ce )

unknown

created 2017-12-14 10:20 UTC

BlastCoreExtension A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	210
Duplicated Lines	8.1 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

Metric	Value
wmc	21
lcom	1
cbo	7
dl	17
loc	210
rs	10
c	0
b	0
f	0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	11	1
A	buildLoader()	0	4	1
A	loadServices()	8	8	2
A	loadCodeGenerators()	0	4	1
A	loadDataFixtures()	0	4	1
A	loadBlasts()	0	9	2
A	loadParameters()	9	9	2
A	loadSecurity()	0	4	1
A	loadSonataAdmin()	0	12	2
A	loadListeners()	0	4	1
A	doLoad()	0	4	1
A	load()	0	16	1
B	mergeParameter()	0	20	5

How to fix Duplicated Code

<?php

/*
 *
 * Copyright (C) 2015-2017 Libre Informatique
 *
 * This file is licenced under the GNU LGPL v3.
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

namespace Blast\Bundle\CoreBundle\DependencyInjection;

use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;
use Symfony\Component\DependencyInjection\Loader\FileLoader;
use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
use Symfony\Component\Yaml\Yaml;

/**
 * This is the class that loads and manages your bundle configuration.
 *
 * To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html}
 */
class BlastCoreExtension extends Extension
{
    /**
     * {@inheritdoc}
     */
    public function load(array $configs, ContainerBuilder $container)
    {
        $config = $this->processConfiguration($this->getConfiguration([], $container), $configs);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->initialize();
        $loader = $this->buildLoader($container);

        // $this->loadParameters($container, $loader);

        $this->loadServices($loader);
        $this->loadCodeGenerators($container, $config);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->loadDataFixtures($container, $loader);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->loadBlasts($container, $loader);
        $this->loadSecurity($container);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->loadSonataAdmin($container, $loader);
        $this->loadListeners($container, $config);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->doLoad($container, $loader, $config);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }

    /**
     * @return self
     */
    public function initialize()
    {
        $rc = new \ReflectionClass($this);
        $this->dir = dirname($rc->getFileName());
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->prefix = '/../Resources/config/';
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->bundlesPrefix = $this->prefix . 'bundles/';

        $this->suffix = '.yml';
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->file = 'blast';
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;
    }

    /**
     * the buildLoader returns the required FileLoader.
     *
     * @param ContainerBuilder $container
     *
     * @return FileLoader
     */
    public function buildLoader(ContainerBuilder $container)
    {
        return new YamlFileLoader($container, new FileLocator($this->dir . $this->prefix));
    }

    /**
     * This method is called during the self::load() process, to add the logic related to SonataAdmin.
     *
     * @param FileLoader $loader
     *
     * @return self
     */
    public function loadServices(FileLoader $loader)

    {
        if (file_exists($this->dir . $this->prefix . 'services' . $this->suffix)) {
            $loader->load('services' . $this->suffix);
        }

        return $this;
    }

    /**
     * This method is called after loading the services in the self::load() process, to load code generators.
     *
     * @param ContainerBuilder $container
     * @param array            $config
     *
     * @return self
     */
    public function loadCodeGenerators(ContainerBuilder $container, array $config)

    {
        return $this;
    }

    /**
     * This method is called after loading the services in the self::load() process, to load data fixtures.
     *
     * @param ContainerBuilder $container
     * @param FileLoader       $loader
     *
     * @return self
     */
    public function loadDataFixtures(ContainerBuilder $container, FileLoader $loader)

    {
        return $this;
    }

    /**
     * @param ContainerBuilder $container
     *
     * @return self
     */
    public function loadBlasts(ContainerBuilder $container, FileLoader $loader)

    {
        // the blast.yml
        if (file_exists($this->dir . $this->prefix . $this->file . $this->suffix)) {
            $this->mergeParameter('blast', $container, $this->dir . $this->prefix);
        }

        return $this;
    }

    /**
     * @param ContainerBuilder $container
     *
     * @return self
     */
    public function loadParameters(ContainerBuilder $container, FileLoader $loader)

    {
        // parameters.yml
        if (file_exists($this->dir . $this->prefix . 'parameters' . $this->suffix)) {
            $loader->load('parameters' . $this->suffix);
        }

        return $this;
    }

    /**
     * This method is called at the end of the self::load() process, to add security related logic.
     *
     * @param ContainerBuilder $container
     *
     * @return self
     */
    public function loadSecurity(ContainerBuilder $container)

    {
        return $this;
    }

    /**
     * This method is called at the end of the self::load() process, to add the logic related to SonataAdmin.
     *
     * @param ContainerBuilder $container
     * @param FileLoader       $loader
     *
     * @return self
     */
    public function loadSonataAdmin(ContainerBuilder $container, FileLoader $loader)

    {
        if (file_exists($path = $this->dir . $this->bundlesPrefix . 'sonata_admin' . $this->suffix)) {

            $configSonataAdmin = Yaml::parse(
                file_get_contents($path)
            );

            DefaultParameters::getInstance($container)->defineDefaultConfiguration($configSonataAdmin['default']);
        }

        return $this;
    }

    /**
     * This method is called during the self::load() process, to add the logic related to SonataAdmin.
     *
     * @param ContainerBuilder $container
     * @param array            $config
     *
     * @return self
     */
    public function loadListeners(ContainerBuilder $container, array $config)

    {
        return $this;
    }

    /**
     * This method is called at the end of the self::load() process, to add any logic needed.
     *
     * @param ContainerBuilder $container
     * @param FileLoader       $loader
     * @param array            $config
     *
     * @return self
     */
    public function doLoad(ContainerBuilder $container, FileLoader $loader, array $config)

    {
        return $this;
    }

    /**
     * @param string           $var       the parameter name
     * @param ContainerBuilder $container
     * @param string           $dir
     * @param string           $file_name
     *
     * @return self
     */
    protected function mergeParameter($var, $container, $dir, $file_name = 'blast.yml')
    {
        $loader = new YamlFileLoader($newContainer = new ContainerBuilder(), new FileLocator($dir));
        $loader->load($file_name);

        if (!$container->hasParameter($var) || !is_array($container->getParameter($var))) {
            $container->setParameter($var, []);
        }

        if (!$newContainer->hasParameter($var) || !is_array($newContainer->getParameter($var))) {
            return $this;
        }

        $container->setParameter($var, array_replace_recursive(
            $container->getParameter($var),
            $newContainer->getParameter($var)
        ));

        return $this;
    }
}


1			<?php
2
3			/*
4			*
5			* Copyright (C) 2015-2017 Libre Informatique
6			*
7			* This file is licenced under the GNU LGPL v3.
8			* For the full copyright and license information, please view the LICENSE.md
9			* file that was distributed with this source code.
10			*/
11
12			namespace Blast\Bundle\CoreBundle\DependencyInjection;
13
14			use Symfony\Component\DependencyInjection\ContainerBuilder;
15			use Symfony\Component\Config\FileLocator;
16			use Symfony\Component\HttpKernel\DependencyInjection\Extension;
17			use Symfony\Component\DependencyInjection\Loader\FileLoader;
18			use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
19			use Symfony\Component\Yaml\Yaml;
20
21			/**
22			* This is the class that loads and manages your bundle configuration.
23			*
24			* To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html}
25			*/
26			class BlastCoreExtension extends Extension
27			{
28			/**
29			* {@inheritdoc}
30			*/
31			public function load(array $configs, ContainerBuilder $container)
32			{
33			$config = $this->processConfiguration($this->getConfiguration([], $container), $configs);
			0 ignored issues – show Documentation introduced 2017-07-25 12:36 UTC by Report Bug Copy Issue Report `$this->getConfiguration(array(), $container)` is of type `object\|null`, but the function expects a `object<Symfony\Component...ConfigurationInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34			$this->initialize();
35			$loader = $this->buildLoader($container);
36
37			// $this->loadParameters($container, $loader);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-11-29 07:38 UTC by Report Bug Copy Issue Report `73%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
38			$this->loadServices($loader);

blast-project / CoreBundle

Push — wip-platform ( 53fa26...cf78ce )

BlastCoreExtension A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

13 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like