SimpleUPS\Track\SmallPackage\Response

Complexity

Total Complexity

5

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	addShipment()	0	9	2
A	getShipments()	0	4	1
A	fromXml()	0	8	2

<?php namespace SimpleUPS\Track\SmallPackage;

/**
 * @internal
 */
class Response extends \SimpleUPS\Track\Response
{

    private
        /* @var Shipment $shipments */
        $shipments;

Consider using a different property name as you override a private property of the parent class.

    /**
     * @param Shipment $shipment
     *
     * @return Response
     */
    public function addShipment(Shipment $shipment)
    {
        if ($this->shipments === null) {
            $this->shipments = array();
        }

        $this->shipments[] = $shipment;
        return $this;
    }

    /**
     * @return Shipment[]|null
     */
    public function getShipments()
    {
        return $this->shipments;
    }

    /**
     * @param \SimpleXMLElement $xml
     *
     * @return Response
     */
    public function fromXml(\SimpleXMLElement $xml)
    {
        foreach ($xml->Shipment as $xml) {
            $this->addShipment(Shipment::fromXml($xml));
        }

        return $this;
    }

}