bjorn-87 / anax-weathermodule

src/Curl/Curl.php

<?php

namespace Bjos\Curl;

/**
 * A class that manages curl requests.
 * @SuppressWarnings(PHPMD.ShortVariable)
 */
class Curl
{

    /**
     * Curl method.
     *
     * @return array|void $res
     */
    public function curlApi(string $url = null)
    {
        $res = null;

        if ($url) {
            $curl = curl_init();
            curl_setopt($curl, CURLOPT_URL, $url);

It seems like $curl can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

            curl_setopt($curl, CURLOPT_HEADER, 0);
            curl_setopt($curl, CURLOPT_RETURNTRANSFER, 1);
            $output = curl_exec($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

            curl_close($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

            $res = json_decode($output, true);
        }

        return $res;
    }

    /**
     * multicurl method
     *
     * @return array
     */
    public function multiCurlApi(array $urls) : array
    {
        $response = [];

        if (count($urls) !== 0) {
            $options = [
                CURLOPT_RETURNTRANSFER => true,
            ];

            // Add all curl handlers and remember them
            // Initiate the multi curl handler
            $mh = curl_multi_init();
            $chAll = [];
            foreach ($urls as $url) {
                $ch = curl_init("$url");
                curl_setopt_array($ch, $options);

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt_array() does only seem to accept resource, maybe add an additional type check?

                curl_multi_add_handle($mh, $ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_multi_add_handle() does only seem to accept resource, maybe add an additional type check?

                $chAll[] = $ch;
            }

            // Execute all queries simultaneously,
            // and continue when all are complete
            $running = null;
            do {
                curl_multi_exec($mh, $running);
            } while ($running);

            // Close the handles
            foreach ($chAll as $ch) {
                curl_multi_remove_handle($mh, $ch);
            }
            curl_multi_close($mh);

            // All of our requests are done, we can now access the results
            foreach ($chAll as $ch) {
                $data = curl_multi_getcontent($ch);
                $response[] = json_decode($data, true);
            }
        }

        return $response;
    }
}