Biurad\UI\Exceptions\ParserException::forTagWithParent()

Complexity

Conditions	9
Paths	64

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	90

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function forTagWithParent(string $tagName, ?string $attrName = null, ?string $parent = null, bool $first = false, bool $void = false, bool $voidAttr = false): self
    {
        $errorMessage = 'Tag "%s" ' . (!empty($parent) ? ('must be inside a tag with attribute "%s"' . ($first ? ' as the first' : '')) : ('' === $parent ? $parent : 'is unexpected here'));

The condition '' === $parent is always false.

        $errorArgs = [$tagName];

        if (null !== $attrName) {
            $errorMessage = \substr_replace($errorMessage, ' with attribute "%s"' . ($voidAttr ? ' expected no value' . (!empty($parent) ? ', and ' : ' ') : ' '), 8, 1);
            $errorArgs[] = $attrName;
        }

        if ($void) {
            $errorMessage .= ' and must be self closed.';
        }

        if (null !== $parent) {
            $errorArgs[] = $parent;
        }

        return new self(\vsprintf($errorMessage, $errorArgs));

It seems like $errorMessage can also be of type array; however, parameter $format of vsprintf() does only seem to accept string, maybe add an additional type check?

    }