Biurad\Monorepo\Config::__construct()

Complexity

Conditions	11
Paths	2

Size

Total Lines	60
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php declare(strict_types=1);
    public function __construct(string $rootPath, string $cachePath = null, bool $reclone)
    {
        if (!\file_exists($configFile = ($this->config['path'] = $rootPath).'/.monorepo')) {
            throw new \RuntimeException(\sprintf('Config file "%s" does not exist.', $configFile));
        }

        $workers = [];
        $this->config['reclone'] = $reclone;
        $options = new OptionsResolver();
        $options
            ->define('base_url')->default(null)->allowedTypes('string', 'null')
            ->define('branch_filter')->default(null)->allowedTypes('string', 'null')
            ->define('extra')->default([])->allowedTypes('array')
            ->define('workers')->default([])->allowedTypes('array')
            ->normalize(function (Options $options, array $value): array {
                if (\array_is_list($value)) {

The function array_is_list was not found. Maybe you did not declare it correctly or list all dependencies?

                    return ['main' => $value];
                }

                foreach ($value as $k => $v) {
                    $v = \is_string($v) ? [$v] : $v;

                    if (!\is_string($k)) {
                        throw new InvalidOptionsException('Expected workers config to begin with a string key.');
                    }

                    if (!\is_array($v) || !\array_is_list($v)) {
                        throw new InvalidOptionsException('Expected workers config\'s key value be a list of workers classes.');
                    }
                }

                return $value;
            })
            ->define('repositories')
            ->default(function (OptionsResolver $options, Options $parent) use (&$workers): void {
                $workers = \array_keys($parent['workers']);
                $options->setPrototype(true)
                    ->define('url')->default(null)->allowedTypes('string', 'null')->required()
                    ->define('merge')->default(false)->allowedTypes('bool')
                    ->define('path')
                    ->allowedTypes('string')
                    ->default(\Closure::bind(fn (Options $options): string => $options->prototypeIndex, null, $options))

Accessing prototypeIndex on the interface Symfony\Component\OptionsResolver\Options suggest that you code against a concrete implementation. How about adding an instanceof check?

                    ->normalize(fn (Options $options, string $value): string => \trim($value, '/'))
                    ->define('workers')->default($workers)->allowedTypes('array')
                    ->normalize(function (Options $options, array $value) use ($workers): array {
                        foreach ($value as $worker) {
                            if (!\in_array($worker, $workers, true)) {
                                throw new InvalidOptionsException(\sprintf('The worker "%s" for monorepo\'s path "%s" does not exist.', $worker, $options['path']));
                            }
                        }

                        return $value;
                    })
                ;
            })->allowedTypes('array')
        ;

        $options->setRequired(['base_url', 'branch_filter', 'workers', 'repositories']);
        $this->config += $options->resolve(\function_exists('yaml_parse_file') ? yaml_parse_file($configFile) : Yaml::parseFile($configFile));
        $this->config['cache'] = $cachePath ?? $this->config['path'].'/.monorepo-cache';
    }