Passed
Pull Request — main (#93)
by Peter
01:13
created

pyclean.modern   F

Complexity

Total Complexity 61

Size/Duplication

Total Lines 348
Duplicated Lines 0 %

Importance

Changes 0
Metric Value
wmc 61
eloc 202
dl 0
loc 348
rs 3.52
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A CleanupRunner.configure() 0 9 3
A CleanupRunner.__init__() 0 9 1

13 Functions

Rating   Name   Duplication   Size   Complexity  
A remove_directory() 0 9 2
A print_filename() 0 4 1
A remove_file() 0 9 2
A print_dirname() 0 4 1
C should_ignore() 0 42 10
A confirm() 0 8 2
C delete_filesystem_objects() 0 34 11
A detect_debris_in_directory() 0 18 5
B descend_and_clean() 0 19 7
A remove_freeform_targets() 0 19 2
A remove_debris_for() 0 8 2
B pyclean() 0 33 8
A suggest_debris_option() 0 24 4

How to fix   Complexity   

Complexity

Complex classes like pyclean.modern often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

1
# SPDX-FileCopyrightText: 2020 Peter Bittner <[email protected]>
2
#
3
# SPDX-License-Identifier: GPL-3.0-or-later
4
5
"""
6
Modern, cross-platform, pure-Python pyclean implementation.
7
"""
8
9
import logging
10
import os
11
from pathlib import Path
12
13
BYTECODE_FILES = ['.pyc', '.pyo']
14
BYTECODE_DIRS = ['__pycache__']
15
DEBRIS_TOPICS = {
16
    'cache': [
17
        '.cache/**/*',
18
        '.cache/',
19
    ],
20
    'coverage': [
21
        '.coverage',
22
        'coverage.json',
23
        'coverage.lcov',
24
        'coverage.xml',
25
        'htmlcov/**/*',
26
        'htmlcov/',
27
    ],
28
    'jupyter': [
29
        '.ipynb_checkpoints/**/*',
30
        '.ipynb_checkpoints/',
31
    ],
32
    'mypy': [
33
        '.mypy_cache/**/*',
34
        '.mypy_cache/',
35
    ],
36
    'package': [
37
        'build/bdist.*/**/*',
38
        'build/bdist.*/',
39
        'build/lib/**/*',
40
        'build/lib/',
41
        'build/',
42
        'dist/**/*',
43
        'dist/',
44
        'sdist/**/*',
45
        'sdist/',
46
        '*.egg-info/**/*',
47
        '*.egg-info/',
48
    ],
49
    'pytest': [
50
        '.pytest_cache/**/*',
51
        '.pytest_cache/',
52
        'pytestdebug.log',
53
    ],
54
    'ruff': [
55
        '.ruff_cache/**/*',
56
        '.ruff_cache/',
57
    ],
58
    'tox': [
59
        '.tox/**/*',
60
        '.tox/',
61
    ],
62
}
63
64
65
class CleanupRunner:
66
    """Module-level configuration and value store."""
67
68
    def __init__(self):
69
        """Cleanup runner with optional dry-run behavior."""
70
        self.unlink = None
71
        self.rmdir = None
72
        self.ignore = None
73
        self.unlink_count = None
74
        self.unlink_failed = None
75
        self.rmdir_count = None
76
        self.rmdir_failed = None
77
78
    def configure(self, args):
79
        """Set up runner according to command line options."""
80
        self.unlink = print_filename if args.dry_run else remove_file
81
        self.rmdir = print_dirname if args.dry_run else remove_directory
82
        self.ignore = args.ignore
83
        self.unlink_count = 0
84
        self.unlink_failed = 0
85
        self.rmdir_count = 0
86
        self.rmdir_failed = 0
87
88
89
log = logging.getLogger(__name__)
90
Runner = CleanupRunner()
91
92
93
def should_ignore(path, ignore_patterns):
94
    """
95
    Check if a path should be ignored based on ignore patterns.
96
97
    Patterns can be:
98
    - Simple names like 'bar': matches any directory with that name
99
    - Paths like 'foo/bar': matches 'bar' directory inside 'foo' directory
100
      and also ignores everything inside that directory
101
102
    Args:
103
        path: Path object to check
104
        ignore_patterns: List of ignore patterns
105
106
    Returns:
107
        True if the path should be ignored, False otherwise
108
    """
109
    if ignore_patterns is None:
110
        return False
111
    if not ignore_patterns:
112
        return False
113
114
    for pattern in ignore_patterns:
115
        if '/' in pattern:
116
            # Pattern contains path separator - match relative path
117
            # Check if the pattern matches anywhere in the path hierarchy
118
            try:
119
                # Get parts from the pattern
120
                pattern_parts = Path(pattern).parts
121
                # Path must have at least as many parts as the pattern
122
                if len(path.parts) < len(pattern_parts):
123
                    continue
124
                # Check if pattern matches at any position in the path
125
                for i in range(len(path.parts) - len(pattern_parts) + 1):
126
                    path_slice = path.parts[i : i + len(pattern_parts)]
127
                    if path_slice == pattern_parts:
128
                        return True
129
            except (ValueError, IndexError):
130
                continue
131
        # Simple name - match the directory name anywhere
132
        elif path.name == pattern:
133
            return True
134
    return False
135
136
137
def remove_file(fileobj):
138
    """Attempt to delete a file object for real."""
139
    log.debug('Deleting file: %s', fileobj)
140
    try:
141
        fileobj.unlink()
142
        Runner.unlink_count += 1
143
    except OSError as err:
144
        log.debug('File not deleted. %s', err)
145
        Runner.unlink_failed += 1
146
147
148
def remove_directory(dirobj):
149
    """Attempt to remove a directory object for real."""
150
    log.debug('Removing directory: %s', dirobj)
151
    try:
152
        dirobj.rmdir()
153
        Runner.rmdir_count += 1
154
    except OSError as err:
155
        log.debug('Directory not removed. %s', err)
156
        Runner.rmdir_failed += 1
157
158
159
def print_filename(fileobj):
160
    """Only display the file name, used with --dry-run."""
161
    log.debug('Would delete file: %s', fileobj)
162
    Runner.unlink_count += 1
163
164
165
def print_dirname(dirobj):
166
    """Only display the directory name, used with --dry-run."""
167
    log.debug('Would delete directory: %s', dirobj)
168
    Runner.rmdir_count += 1
169
170
171
def pyclean(args):
172
    """Cross-platform cleaning of Python bytecode."""
173
    Runner.configure(args)
174
175
    for dir_name in args.directory:
176
        dir_path = Path(dir_name)
177
178
        log.info('Cleaning directory %s', dir_path)
179
        descend_and_clean(dir_path, BYTECODE_FILES, BYTECODE_DIRS)
180
181
        for topic in args.debris:
182
            remove_debris_for(topic, dir_path)
183
184
        remove_freeform_targets(args.erase, args.yes, dir_path)
185
186
    log.info(
187
        'Total %d files, %d directories %s.',
188
        Runner.unlink_count,
189
        Runner.rmdir_count,
190
        'would be removed' if args.dry_run else 'removed',
191
    )
192
193
    if Runner.unlink_failed or Runner.rmdir_failed:
194
        log.debug(
195
            '%d files, %d directories %s not be removed.',
196
            Runner.unlink_failed,
197
            Runner.rmdir_failed,
198
            'would' if args.dry_run else 'could',
199
        )
200
201
    # Suggest --debris option if it wasn't used
202
    if not args.debris:
203
        suggest_debris_option(args)
204
205
206
def descend_and_clean(directory, file_types, dir_names):
207
    """
208
    Walk and descend a directory tree, cleaning up files of a certain type
209
    along the way. Only delete directories if they are empty, in the end.
210
    """
211
    for child in sorted(directory.iterdir()):
212
        if child.is_file():
213
            if child.suffix in file_types:
214
                Runner.unlink(child)
215
        elif child.is_dir():
216
            if should_ignore(child, Runner.ignore):
217
                log.debug('Skipping %s', child)
218
            else:
219
                descend_and_clean(child, file_types, dir_names)
220
221
            if child.name in dir_names:
222
                Runner.rmdir(child)
223
        else:
224
            log.debug('Ignoring %s (neither a file nor a folder)', child)
225
226
227
def remove_debris_for(topic, directory):
228
    """
229
    Clean up debris for a specific topic.
230
    """
231
    log.debug('Scanning for debris of %s ...', topic.title())
232
233
    for path_glob in DEBRIS_TOPICS[topic]:
234
        delete_filesystem_objects(directory, path_glob, recursive=True)
235
236
237
def remove_freeform_targets(glob_patterns, yes, directory):
238
    """
239
    Remove free-form targets using globbing.
240
241
    This is **potentially dangerous** since users can delete everything
242
    anywhere in their file system, including the entire project they're
243
    working on. For this reason, the implementation imposes the following
244
    (user experience-related) restrictions:
245
246
    - Deleting (directories) is not recursive, directory contents must be
247
      explicitly specified using globbing (e.g. ``dirname/**/*``).
248
    - The user is responsible for the deletion order, so that a directory
249
      is empty when it is attempted to be deleted.
250
    - A confirmation prompt for the deletion of every single file system
251
      object is shown (unless the ``--yes`` option is used, in addition).
252
    """
253
    for path_glob in glob_patterns:
254
        log.debug('Erase file system objects matching: %s', path_glob)
255
        delete_filesystem_objects(directory, path_glob, prompt=not yes)
256
257
258
def delete_filesystem_objects(directory, path_glob, prompt=False, recursive=False):
259
    """
260
    Identifies all pathnames matching a specific glob pattern, and attempts
261
    to delete them in the proper order, optionally asking for confirmation.
262
263
    Implementation Note: We sort the file system objects in *reverse order*
264
    and first delete *all files* before removing directories. This way we
265
    make sure that the directories that are deepest down in the hierarchy
266
    are empty (for both files & directories) when we attempt to remove them.
267
    """
268
    all_names = sorted(directory.glob(path_glob), reverse=True)
269
    dirs = (name for name in all_names if name.is_dir() and not name.is_symlink())
0 ignored issues
show
Comprehensibility Best Practice introduced by
The variable name does not seem to be defined.
Loading history...
270
    files = (name for name in all_names if not name.is_dir() or name.is_symlink())
271
272
    for file_object in files:
273
        file_type = 'symlink' if file_object.is_symlink() else 'file'
274
        if prompt and not confirm('Delete %s %s' % (file_type, file_object)):
275
            Runner.unlink_failed += 1
276
            continue
277
        Runner.unlink(file_object)
278
279
    for dir_object in dirs:
280
        if prompt and not confirm('Remove empty directory %s' % dir_object):
281
            Runner.rmdir_failed += 1
282
            continue
283
        Runner.rmdir(dir_object)
284
285
    if recursive:
286
        subdirs = (Path(name.path) for name in os.scandir(directory) if name.is_dir())
287
        for subdir in subdirs:
288
            if should_ignore(subdir, Runner.ignore):
289
                log.debug('Skipping %s', subdir)
290
            else:
291
                delete_filesystem_objects(subdir, path_glob, prompt, recursive)
292
293
294
def confirm(message):
295
    """An interactive confirmation prompt."""
296
    try:
297
        answer = input('%s? ' % message)
298
        return answer.strip().lower() in ['y', 'yes']
299
    except KeyboardInterrupt:
300
        msg = 'Aborted by user.'
301
        raise SystemExit(msg)
302
303
304
def detect_debris_in_directory(directory):
305
    """
306
    Scan a directory for debris artifacts and return a list of detected topics.
307
    """
308
    detected_topics = []
309
310
    for topic, patterns in DEBRIS_TOPICS.items():
311
        for pattern in patterns:
312
            # Skip patterns that are for recursive cleanup (contain **)
313
            if '**' in pattern:
314
                continue
315
            # Check if the pattern matches anything in the directory
316
            matches = list(directory.glob(pattern))
317
            if matches:
318
                detected_topics.append(topic)
319
                break  # Found at least one match for this topic, move to next
320
321
    return detected_topics
322
323
324
def suggest_debris_option(args):
325
    """
326
    Suggest using the --debris option when it wasn't used.
327
    Optionally provide targeted suggestions based on detected artifacts.
328
    """
329
    # Collect all detected debris topics across all directories
330
    all_detected = set()
331
    for dir_name in args.directory:
332
        dir_path = Path(dir_name)
333
        if dir_path.exists():
334
            detected = detect_debris_in_directory(dir_path)
335
            all_detected.update(detected)
336
337
    if all_detected:
338
        # Provide targeted suggestion
339
        topics_str = ' '.join(sorted(all_detected))
340
        log.info(
341
            'Hint: Use --debris to also clean up build artifacts. Detected: %s',
342
            topics_str,
343
        )
344
    else:
345
        # Provide general suggestion
346
        log.info(
347
            'Hint: Use --debris to also clean up build artifacts '
348
            'from common Python development tools.',
349
        )
350