biscolab / google-maps-php-sdk

src/Http/GoogleMapsClient.php

<?php
/**
 * Copyright (c) 2018 - present
 * Google Maps PHP - GoogleMapsClient.php
 * author: Roberto Belotti - roby.belotti@gmail.com
 * web : robertobelotti.com, github.com/biscolab
 * Initial version created on: 5/9/2018
 * MIT license: https://github.com/biscolab/google-maps-php/blob/master/LICENSE
 */

namespace Biscolab\GoogleMaps\Http;

use Biscolab\GoogleMaps\Values\GoogleMapsRequestMethodValues;
use GuzzleHttp\Client;
use GuzzleHttp\Psr7\Response;

class GoogleMapsClient
{

	/**
	 * @var Client
	 */
	protected $client = null;

	/**
	 * GeocoderClient constructor.
	 */
	public function __construct()
	{

		$this->setClient(new Client());
	}

	/**
	 * @param null $client

Are you sure the doc-type for parameter $client is correct as it would always require null to be passed?

	 *
	 * @return GoogleMapsClient
	 */
	public function setClient($client)
	{

		$this->client = $client;

		return $this;
	}

	/**
	 * @param string      $url
	 * @param null|string $query
	 *
	 * @return \Biscolab\GoogleMaps\Http\GoogleMapsResponse
	 */
	public function get(string $url, ?string $query = null): GoogleMapsResponse
	{

		$client_params = $query ? [
			'query' => $query
		] : null;

		/** @var Response $res */
		$res = $this->client->request(GoogleMapsRequestMethodValues::GET, $url, $client_params);

It seems like $client_params can also be of type null; however, parameter $options of GuzzleHttp\Client::request() does only seem to accept array, maybe add an additional type check?

		return new GoogleMapsResponse($res);
	}
}