Bip70\Test\Client\GuzzleClient\ClientHeadersTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	testMissingContentType()	0	33	1
B	testInvalidContentType()	0	37	1

<?php

declare(strict_types=1);

namespace Bip70\Test\Client\GuzzleClient;

use PHPUnit\Framework\TestCase;

use Bip70\Client\GuzzleHttpClient;
use Bip70\X509\RequestValidation;
use Bip70\X509\TrustStoreLoader;
use GuzzleHttp\Handler\MockHandler;
use GuzzleHttp\HandlerStack;
use GuzzleHttp\Middleware;
use GuzzleHttp\Psr7\Response;
use X509\CertificationPath\PathValidation\PathValidationConfig;

class ClientHeadersTest extends TestCase
{
    public function testMissingContentType()
    {
        $container = [];
        $history = Middleware::history($container);

        $handler = new MockHandler([
            // response to our GET PAYMENTREQUEST request
            new Response(200, [], '{"result":true}')
        ]);

        $stack = HandlerStack::create($handler);
        $stack->push($history);

        $mockClient = new \GuzzleHttp\Client([
            'handler' => $stack,
        ]);

        $client = new GuzzleHttpClient($mockClient);

        $requestUrl = "https://development.bip70.local/invoice/1";

        // 10/12/2017 ish
        $now = new \DateTimeImmutable();
        $now = $now->setTimestamp(1509692666);

        $validationConfig = new PathValidationConfig($now, 10);

It seems like $now defined by $now->setTimestamp(1509692666) on line 43 can also be of type false; however, X509\CertificationPath\PathValidation\PathValidationConfig::__construct() does only seem to accept object<DateTimeImmutable>, did you maybe forget to handle an error condition?

        $validator = new RequestValidation($validationConfig, TrustStoreLoader::fromSystem());

        $this->expectException(\RuntimeException::class);
        $this->expectExceptionMessage("Missing content-type header");

        $client->getRequest($requestUrl, $validator);
    }

    public function testInvalidContentType()
    {
        $container = [];
        $history = Middleware::history($container);

        $handler = new MockHandler([
            // response to our GET PAYMENTREQUEST request
            new Response(200, [
                'Content-Type' => [
                    'application/json',
                ]
            ], '{"result":true}')
        ]);

        $stack = HandlerStack::create($handler);
        $stack->push($history);

        $mockClient = new \GuzzleHttp\Client([
            'handler' => $stack,
        ]);

        $client = new GuzzleHttpClient($mockClient);

        $requestUrl = "https://development.bip70.local/invoice/1";

        // 10/12/2017 ish
        $now = new \DateTimeImmutable();
        $now = $now->setTimestamp(1509692666);

        $validationConfig = new PathValidationConfig($now, 10);

It seems like $now defined by $now->setTimestamp(1509692666) on line 81 can also be of type false; however, X509\CertificationPath\PathValidation\PathValidationConfig::__construct() does only seem to accept object<DateTimeImmutable>, did you maybe forget to handle an error condition?

        $validator = new RequestValidation($validationConfig, TrustStoreLoader::fromSystem());

        $this->expectException(\RuntimeException::class);
        $this->expectExceptionMessage("Content-type was not application/bitcoin-paymentrequest");

        $client->getRequest($requestUrl, $validator);
    }
}