| Conditions | 6 |
| Total Lines | 63 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | #!/usr/bin/env python |
||
| 55 | def test_time_queue(self): |
||
| 56 | |||
| 57 | six.print_('Test time queue order by time only') |
||
| 58 | |||
| 59 | tq = TaskQueue(rate=300, burst=1000) |
||
| 60 | |||
| 61 | fifo_queue = Queue.Queue() |
||
| 62 | |||
| 63 | interval = 5.0 / 1000 |
||
| 64 | |||
| 65 | for i in range(0, 20): |
||
| 66 | it = InQueueTask(str(i), priority=int(i // 10), exetime=time.time() + (i + 1) * interval) |
||
| 67 | tq.put(it.taskid, it.priority, it.exetime) |
||
| 68 | fifo_queue.put(it) |
||
| 69 | six.print_('put, taskid=', it.taskid, 'priority=', it.priority, 'exetime=', it.exetime) |
||
| 70 | |||
| 71 | self.assertEqual(tq.priority_queue.qsize(), 0) |
||
| 72 | self.assertEqual(tq.processing.qsize(), 0) |
||
| 73 | self.assertEqual(tq.time_queue.qsize(), 20) |
||
| 74 | |||
| 75 | for i in range(0, 20): |
||
| 76 | t1 = fifo_queue.get() |
||
| 77 | t2 = tq.time_queue.get() |
||
| 78 | self.assertEqual(t1.taskid, t2.taskid) |
||
| 79 | six.print_('get, taskid=', t2.taskid, 'priority=', t2.priority, 'exetime=', t2.exetime) |
||
| 80 | self.assertEqual(tq.priority_queue.qsize(), 0) |
||
| 81 | self.assertEqual(tq.processing.qsize(), 0) |
||
| 82 | self.assertEqual(tq.time_queue.qsize(), 0) |
||
| 83 | |||
| 84 | queues = dict() |
||
| 85 | tasks = dict() |
||
| 86 | for i in range(0, 20): |
||
| 87 | priority = int(i // 10) |
||
| 88 | it = InQueueTask(str(i), priority=priority, exetime=time.time() + (i + 1) * interval) |
||
| 89 | tq.put(it.taskid, it.priority, it.exetime) |
||
| 90 | tasks[it.taskid] = it |
||
| 91 | |||
| 92 | if priority not in queues: |
||
| 93 | queues[priority] = Queue.Queue() |
||
| 94 | q = queues[priority] |
||
| 95 | q.put(it) |
||
| 96 | pass |
||
| 97 | |||
| 98 | self.assertEqual(tq.priority_queue.qsize(), 0) |
||
| 99 | self.assertEqual(tq.processing.qsize(), 0) |
||
| 100 | self.assertEqual(tq.time_queue.qsize(), 20) |
||
| 101 | |||
| 102 | time.sleep(20 * interval) |
||
| 103 | tq.check_update() |
||
| 104 | self.assertEqual(tq.priority_queue.qsize(), 20) |
||
| 105 | self.assertEqual(tq.processing.qsize(), 0) |
||
| 106 | self.assertEqual(tq.time_queue.qsize(), 0) |
||
| 107 | for i in range(0, 20): |
||
| 108 | taskid = tq.get() |
||
| 109 | t1 = tasks[taskid] |
||
| 110 | t2 = queues[t1.priority].get() |
||
| 111 | self.assertEqual(t1.taskid, t2.taskid) |
||
| 112 | |||
| 113 | self.assertEqual(tq.priority_queue.qsize(), 0) |
||
| 114 | self.assertEqual(tq.processing.qsize(), 20) |
||
| 115 | self.assertEqual(tq.time_queue.qsize(), 0) |
||
| 116 | |||
| 117 | pass |
||
| 118 | |||
| 124 |