Xml\Impl\Type\Reference\AttributeReferenceBuilderImpl

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	performModelBuild()	0	15	2
A	__construct()	0	5	1
A	build()	0	4	1

<?php

namespace Xml\Impl\Type\Reference;

use Xml\ModelInterface;
use Xml\Exception\ModelException;
use Xml\Impl\ModelBuildOperationInterface;
use Xml\Impl\Type\Attribute\AttributeImpl;
use Xml\Type\Reference\{
    AttributeReferenceBuilderInterface,
    AttributeReferenceInterface
};

class AttributeReferenceBuilderImpl implements AttributeReferenceBuilderInterface, ModelBuildOperationInterface
{
    private $referenceSourceAttribute;
    protected $attributeReferenceImpl;
    private $referenceTargetElement;

    public function __construct(AttributeImpl $referenceSourceAttribute, string $referenceTargetElement)
    {
        $this->referenceSourceAttribute = $referenceSourceAttribute;
        $this->referenceTargetElement = $referenceTargetElement;
        $this->attributeReferenceImpl = new AttributeReferenceImpl($referenceSourceAttribute);
    }

    public function build(): AttributeReferenceInterface
    {
        $this->referenceSourceAttribute->registerOutgoingReference($this->attributeReferenceImpl);
        return $this->attributeReferenceImpl;
    }

    public function performModelBuild(ModelInterface $model): void
    {
        $referenceTargetType = $model->getType($this->referenceTargetElement);
        $this->attributeReferenceImpl->setReferenceTargetElementType($referenceTargetType);

It seems like $referenceTargetType can also be of type null; however, parameter $referenceTargetElementType of Xml\Impl\Type\Reference\ReferenceImpl::setReferenceTargetElementType() does only seem to accept Xml\Impl\Type\ModelElementTypeImpl, maybe add an additional type check?

        $idAttribute = $referenceTargetType->getAttribute("id");
        if ($idAttribute !== null) {
            $idAttribute->registerIncoming($this->attributeReferenceImpl);

The method registerIncoming() does not exist on Xml\Type\Attribute\AttributeInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Xml\Type\Attribute\AttributeInterface.

            $this->attributeReferenceImpl->setReferenceTargetAttribute($idAttribute);
        } else {
            throw new ModelException(
                sprintf(
                    "Element type %s:%s has no id attribute",
                    $referenceTargetType->getTypeNamespace(),
                    $referenceTargetType->getTypeName()
                )
            );
        }
    }
}