bingo-soft / jabe

src/Repository/DiagramElement.php

<?php

namespace Jabe\Repository;

abstract class DiagramElement implements \Serializable
{
    protected $id = null;

    public function __construct(?string $id = null)
    {
        $this->id = $id;
    }

    /**
     * Id of the diagram element.
     */
    public function getId(): string
    {
        return $this->id;

The expression return $this->id could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    public function setId(string $id): void
    {
        $this->id = $id;
    }

    public function __toString()
    {
        return "id=" . $this->getId();
    }

    public function serialize()
    {
        return json_encode([
            'id' => $this->id
        ]);
    }

    public function unserialize($data)
    {
        $json = json_decode($data);
        $this->id = $json->id;
    }

    abstract public function isNode(): bool;
    abstract public function isEdge(): bool;
}