Issues (2551)

src/Repository/DeploymentHandlerInterface.php (1 issue)

Labels
Severity
1
<?php
2
3
namespace Jabe\Repository;
4
5
use Jabe\Authorization\ResourceInterface;
0 ignored issues
show
This use statement conflicts with another class in this namespace, Jabe\Repository\ResourceInterface. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
6
7
interface DeploymentHandlerInterface
8
{
9
    public function shouldDeployResource(ResourceInterface $newResource, ResourceInterface $existingResource): bool;
10
11
    public function determineDuplicateDeployment(CandidateDeploymentInterface $candidateDeployment): string;
12
13
    public function determineDeploymentsToResumeByProcessDefinitionKey(array $processDefinitionKeys): array;
14
15
    public function determineDeploymentsToResumeByDeploymentName(
16
        CandidateDeploymentInterface $candidateDeployment
17
    ): array;
18
}
19