bingo-soft / jabe

src/Impl/Context/ExecutionContext.php

<?php

namespace Jabe\Impl\Context;

use Jabe\Impl\Persistence\Entity\{
    ExecutionEntity,
    ProcessDefinitionEntity
};

class ExecutionContext extends CoreExecutionContext
{
    public function __construct(ExecutionEntity $execution)
    {
        parent::__construct($execution);
    }

    public function getProcessInstance(): ExecutionEntity
    {
        return $this->execution->getProcessInstance();
    }

    public function getProcessDefinition(): ProcessDefinitionEntity
    {
        return $this->execution->getProcessDefinition();
    }

    protected function getDeploymentId(): string
    {
        return $this->getProcessDefinition()->getDeploymentId();

The expression return $this->getProcessDefinition()->getDeploymentId() could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}